OFBiz › OFBiz - Dev

[jira] [Created] (OFBIZ-4724) Shopping Cart - One Page Checkout - not continuing

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

10 messages Options

Nicolas Malin (Jira)

[jira] [Created] (OFBIZ-4724) Shopping Cart - One Page Checkout - not continuing

Shopping Cart - One Page Checkout - not continuing
--------------------------------------------------

Key: OFBIZ-4724
URL: https://issues.apache.org/jira/browse/OFBIZ-4724
Project: OFBiz
Issue Type: Bug
Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
Environment: Any Browser
Reporter: K Sharad Bhushan
Attachments: ecommerce-shopping-cart-script.patch

While testing with latest trunk - revision at 1297039(March 5 2011), i have observed issues in one page checkout due to javascript. I have identified that the script was not in place to handle response. I happened to modify the script checkoutprocess.js to fix this. i have testing in chrome, mozilla and is working fine. I am attaching the patch for this fix

Please do review and let me know of of issues.

Found there cannot be a patch while creating issue

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4724) Shopping Cart - One Page Checkout - not continuing

> Shopping Cart - One Page Checkout - not continuing
> --------------------------------------------------
>
> Key: OFBIZ-4724
> URL: https://issues.apache.org/jira/browse/OFBIZ-4724
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Environment: Any Browser
> Reporter: K Sharad Bhushan
> Labels: ofbiz, patch
> Attachments: ecommerce-shopping-cart-script.patch
>
>
> While testing with latest trunk - revision at 1297039(March 5 2011), i have observed issues in one page checkout due to javascript. I have identified that the script was not in place to handle response. I happened to modify the script checkoutprocess.js to fix this. i have testing in chrome, mozilla and is working fine. I am attaching the patch for this fix
> Please do review and let me know of of issues.
> Found there cannot be a patch while creating issue

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4724) Shopping Cart - One Page Checkout - not continuing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236369#comment-13236369 ]

Jacques Le Roux commented on OFBIZ-4724:
----------------------------------------

Hi K Sharad,

2 minor points:
* dont' use tabs in you patches but 4 spaces
* remove the 2 console.log()

I just reviewed, could you explain a bit more what you expected and what happened (for quicker test)?

Thanks

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4724) Shopping Cart - One Page Checkout - not continuing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

K Sharad Bhushan updated OFBIZ-4724:
------------------------------------

Attachment: ecommerce-shopping-cart-script.patch

Hi Jacques,

Here is explanation

Expected: Shopping cart one page checkout should work and let me place an order. I expected every section(i.e shipping address, payment, shipping method) to report the errors if any and let the user continue with filling next section to place order.

Problem : I found that the process was breaking on errors i.e if i make an error in shipping address it was not displaying errors, and the "continue to step 3" button was failing to display next section on success as well.

Changes Made: while i observed the script as issues in handling response, i have done corrections to display errors and show next sections on successful submission.

Sharad

> Shopping Cart - One Page Checkout - not continuing
> --------------------------------------------------
>
> Key: OFBIZ-4724
> URL: https://issues.apache.org/jira/browse/OFBIZ-4724
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Environment: Any Browser
> Reporter: K Sharad Bhushan
> Labels: ofbiz, patch
> Attachments: ecommerce-shopping-cart-script.patch, ecommerce-shopping-cart-script.patch
>
>
> While testing with latest trunk - revision at 1297039(March 5 2011), i have observed issues in one page checkout due to javascript. I have identified that the script was not in place to handle response. I happened to modify the script checkoutprocess.js to fix this. i have testing in chrome, mozilla and is working fine. I am attaching the patch for this fix
> Please do review and let me know of of issues.
> Found there cannot be a patch while creating issue

Nicolas Malin (Jira)

[jira] [Issue Comment Edited] (OFBIZ-4724) Shopping Cart - One Page Checkout - not continuing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237451#comment-13237451 ]

K Sharad Bhushan edited comment on OFBIZ-4724 at 3/24/12 6:05 AM:
------------------------------------------------------------------

Hi Jacques,

Here is explanation

Expected: Shopping cart one page checkout should work and let me place an order. I expected every section(i.e shipping address, payment, shipping method) to report the errors if any and let the user continue with filling next section to place order.

Problem : I found that the process was breaking on errors i.e if i make an error in shipping address it was not displaying errors, and the "continue to step 3" button was failing to display next section on success as well.

Changes Made: while i observed the script as issues in handling response, i have done the corrections to display errors and show next sections on successful submission.

I have also attached the patch by replacing tabs with 4 spaces.

Sharad

was (Author: sharadbhushank):
Hi Jacques,

Here is explanation

Expected: Shopping cart one page checkout should work and let me place an order. I expected every section(i.e shipping address, payment, shipping method) to report the errors if any and let the user continue with filling next section to place order.

Problem : I found that the process was breaking on errors i.e if i make an error in shipping address it was not displaying errors, and the "continue to step 3" button was failing to display next section on success as well.

Changes Made: while i observed the script as issues in handling response, i have done corrections to display errors and show next sections on successful submission.

Sharad

> Shopping Cart - One Page Checkout - not continuing
> --------------------------------------------------
>
> Key: OFBIZ-4724
> URL: https://issues.apache.org/jira/browse/OFBIZ-4724
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Environment: Any Browser
> Reporter: K Sharad Bhushan
> Labels: ofbiz, patch
> Attachments: ecommerce-shopping-cart-script.patch, ecommerce-shopping-cart-script.patch
>
>
> While testing with latest trunk - revision at 1297039(March 5 2011), i have observed issues in one page checkout due to javascript. I have identified that the script was not in place to handle response. I happened to modify the script checkoutprocess.js to fix this. i have testing in chrome, mozilla and is working fine. I am attaching the patch for this fix
> Please do review and let me know of of issues.
> Found there cannot be a patch while creating issue

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4724) Shopping Cart - One Page Checkout - not continuing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237480#comment-13237480 ]

Jacques Le Roux commented on OFBIZ-4724:
----------------------------------------

Sorry K Sharad, but your patch does not apply on trunk HEAD

patching file specialpurpose/ecommerce/webapp/ecommerce/images/checkoutProcess.js
Hunk #1 FAILED at 144.
Hunk #2 FAILED at 261.
Hunk #3 FAILED at 299.
Hunk #4 FAILED at 344.
Hunk #5 FAILED at 396.
Hunk #6 succeeded at 411 (offset 5 lines).
Hunk #7 FAILED at 463.
Hunk #8 FAILED at 491.
Hunk #9 FAILED at 535.
8 out of 9 hunks FAILED -- saving rejects to file specialpurpose/ecommerce/webapp/ecommerce/images/checkoutProcess.js.rej

Please update to trunk HEAD before creating your patch

> Shopping Cart - One Page Checkout - not continuing
> --------------------------------------------------
>
> Key: OFBIZ-4724
> URL: https://issues.apache.org/jira/browse/OFBIZ-4724
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Environment: Any Browser
> Reporter: K Sharad Bhushan
> Labels: ofbiz, patch
> Attachments: ecommerce-shopping-cart-script.patch, ecommerce-shopping-cart-script.patch
>
>
> While testing with latest trunk - revision at 1297039(March 5 2011), i have observed issues in one page checkout due to javascript. I have identified that the script was not in place to handle response. I happened to modify the script checkoutprocess.js to fix this. i have testing in chrome, mozilla and is working fine. I am attaching the patch for this fix
> Please do review and let me know of of issues.
> Found there cannot be a patch while creating issue

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4724) Shopping Cart - One Page Checkout - not continuing

In reply to this post by Nicolas Malin (Jira)

> Shopping Cart - One Page Checkout - not continuing
> --------------------------------------------------
>
> Key: OFBIZ-4724
> URL: https://issues.apache.org/jira/browse/OFBIZ-4724
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Environment: Any Browser
> Reporter: K Sharad Bhushan
> Labels: ofbiz, patch
> Attachments: ecommerce-shopping-cart-script.patch, ecommerce-shopping-cart-script.patch, ecommerce-shopping-cart-script.patch
>
>
> While testing with latest trunk - revision at 1297039(March 5 2011), i have observed issues in one page checkout due to javascript. I have identified that the script was not in place to handle response. I happened to modify the script checkoutprocess.js to fix this. i have testing in chrome, mozilla and is working fine. I am attaching the patch for this fix
> Please do review and let me know of of issues.
> Found there cannot be a patch while creating issue

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4724) Shopping Cart - One Page Checkout - not continuing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237882#comment-13237882 ]

Jacques Le Roux commented on OFBIZ-4724:
----------------------------------------

They have been addressed at http://svn.apache.org/viewvc?view=revision&revision=1302219

> Shopping Cart - One Page Checkout - not continuing
> --------------------------------------------------
>
> Key: OFBIZ-4724
> URL: https://issues.apache.org/jira/browse/OFBIZ-4724
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Environment: Any Browser
> Reporter: K Sharad Bhushan
> Labels: ofbiz, patch
> Attachments: ecommerce-shopping-cart-script.patch, ecommerce-shopping-cart-script.patch, ecommerce-shopping-cart-script.patch
>
>
> While testing with latest trunk - revision at 1297039(March 5 2011), i have observed issues in one page checkout due to javascript. I have identified that the script was not in place to handle response. I happened to modify the script checkoutprocess.js to fix this. i have testing in chrome, mozilla and is working fine. I am attaching the patch for this fix
> Please do review and let me know of of issues.
> Found there cannot be a patch while creating issue

Nicolas Malin (Jira)

[jira] [Closed] (OFBIZ-4724) Shopping Cart - One Page Checkout - not continuing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4724.
----------------------------------

Resolution: Fixed
Fix Version/s: SVN trunk
Assignee: Jacques Le Roux

Thaks K Sharad,

Your patch is trunk at revision: 1305053

> Shopping Cart - One Page Checkout - not continuing
> --------------------------------------------------
>
> Key: OFBIZ-4724
> URL: https://issues.apache.org/jira/browse/OFBIZ-4724
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Environment: Any Browser
> Reporter: K Sharad Bhushan
> Assignee: Jacques Le Roux
> Labels: ofbiz, patch
> Fix For: SVN trunk
>
> Attachments: ecommerce-shopping-cart-script.patch, ecommerce-shopping-cart-script.patch, ecommerce-shopping-cart-script.patch
>
>
> While testing with latest trunk - revision at 1297039(March 5 2011), i have observed issues in one page checkout due to javascript. I have identified that the script was not in place to handle response. I happened to modify the script checkoutprocess.js to fix this. i have testing in chrome, mozilla and is working fine. I am attaching the patch for this fix
> Please do review and let me know of of issues.
> Found there cannot be a patch while creating issue

Nicolas Malin (Jira)

[jira] [Issue Comment Edited] (OFBIZ-4724) Shopping Cart - One Page Checkout - not continuing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237888#comment-13237888 ]

Jacques Le Roux edited comment on OFBIZ-4724 at 3/25/12 3:23 PM:
-----------------------------------------------------------------

Thanks K Sharad,

Your patch is in trunk at revision: 1305053

was (Author: jacques.le.roux):
Thaks K Sharad,

Your patch is trunk at revision: 1305053

> Shopping Cart - One Page Checkout - not continuing
> --------------------------------------------------
>
> Key: OFBIZ-4724
> URL: https://issues.apache.org/jira/browse/OFBIZ-4724
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Environment: Any Browser
> Reporter: K Sharad Bhushan
> Assignee: Jacques Le Roux
> Labels: ofbiz, patch
> Fix For: SVN trunk
>
> Attachments: ecommerce-shopping-cart-script.patch, ecommerce-shopping-cart-script.patch, ecommerce-shopping-cart-script.patch
>
>
> While testing with latest trunk - revision at 1297039(March 5 2011), i have observed issues in one page checkout due to javascript. I have identified that the script was not in place to handle response. I happened to modify the script checkoutprocess.js to fix this. i have testing in chrome, mozilla and is working fine. I am attaching the patch for this fix
> Please do review and let me know of of issues.
> Found there cannot be a patch while creating issue