make <property-to-field/> in widget firstly lookup up the SystemProperty entity and then the properties file
------------------------------------------------------------------------------------------------------------ Key: OFBIZ-4730 URL: https://issues.apache.org/jira/browse/OFBIZ-4730 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Leon Priority: Minor Entity "SystemProperty" has been introduced to framework, and <property-to-field/> in minilang has been update to lookup properties in that entity firstly, but the <property-to-field/> in widgets does not. Is there any particular concern about not to change the behaviour of <property-to-field/> in widgets, such as performance impact? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[ https://issues.apache.org/jira/browse/OFBIZ-4730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231923#comment-13231923 ] Leon commented on OFBIZ-4730: ----------------------------- Make some modification to ModelXxxAction classes just as that to <property-to-field/> in minilang. See attached for details. > make <property-to-field/> in widget firstly lookup up the SystemProperty entity and then the properties file > ------------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4730 > URL: https://issues.apache.org/jira/browse/OFBIZ-4730 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Priority: Minor > Attachments: OFBIZ-4730.patch > > > Entity "SystemProperty" has been introduced to framework, and <property-to-field/> in minilang has been update to lookup properties in that entity firstly, but the <property-to-field/> in widgets does not. > Is there any particular concern about not to change the behaviour of <property-to-field/> in widgets, such as performance impact? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4730: ------------------------ Attachment: OFBIZ-4730.patch > make <property-to-field/> in widget firstly lookup up the SystemProperty entity and then the properties file > ------------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4730 > URL: https://issues.apache.org/jira/browse/OFBIZ-4730 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Priority: Minor > Attachments: OFBIZ-4730.patch > > > Entity "SystemProperty" has been introduced to framework, and <property-to-field/> in minilang has been update to lookup properties in that entity firstly, but the <property-to-field/> in widgets does not. > Is there any particular concern about not to change the behaviour of <property-to-field/> in widgets, such as performance impact? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232348#comment-13232348 ] Jacques Le Roux commented on OFBIZ-4730: ---------------------------------------- THis would be more consistent, I prefer to let Hans, who originally worked on this new feature, to handle it though > make <property-to-field/> in widget firstly lookup up the SystemProperty entity and then the properties file > ------------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4730 > URL: https://issues.apache.org/jira/browse/OFBIZ-4730 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Priority: Minor > Attachments: OFBIZ-4730.patch > > > Entity "SystemProperty" has been introduced to framework, and <property-to-field/> in minilang has been update to lookup properties in that entity firstly, but the <property-to-field/> in widgets does not. > Is there any particular concern about not to change the behaviour of <property-to-field/> in widgets, such as performance impact? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker reassigned OFBIZ-4730: ---------------------------------- Assignee: Hans Bakker > make <property-to-field/> in widget firstly lookup up the SystemProperty entity and then the properties file > ------------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4730 > URL: https://issues.apache.org/jira/browse/OFBIZ-4730 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Assignee: Hans Bakker > Priority: Minor > Attachments: OFBIZ-4730.patch > > > Entity "SystemProperty" has been introduced to framework, and <property-to-field/> in minilang has been update to lookup properties in that entity firstly, but the <property-to-field/> in widgets does not. > Is there any particular concern about not to change the behaviour of <property-to-field/> in widgets, such as performance impact? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232404#comment-13232404 ] Hans Bakker commented on OFBIZ-4730: ------------------------------------ please remember this is a big job to change most (no need to do all) places where properties are retrieved...we will convert when we see a need in a tenant based system. This contribution is well appreciated....we will have a look at it..... > make <property-to-field/> in widget firstly lookup up the SystemProperty entity and then the properties file > ------------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4730 > URL: https://issues.apache.org/jira/browse/OFBIZ-4730 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Assignee: Hans Bakker > Priority: Minor > Attachments: OFBIZ-4730.patch > > > Entity "SystemProperty" has been introduced to framework, and <property-to-field/> in minilang has been update to lookup properties in that entity firstly, but the <property-to-field/> in widgets does not. > Is there any particular concern about not to change the behaviour of <property-to-field/> in widgets, such as performance impact? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker closed OFBIZ-4730. ------------------------------ Resolution: Fixed New Revision: 1302320, thank you Leon for the contribution. > make <property-to-field/> in widget firstly lookup up the SystemProperty entity and then the properties file > ------------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4730 > URL: https://issues.apache.org/jira/browse/OFBIZ-4730 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Assignee: Hans Bakker > Priority: Minor > Attachments: OFBIZ-4730.patch > > > Entity "SystemProperty" has been introduced to framework, and <property-to-field/> in minilang has been update to lookup properties in that entity firstly, but the <property-to-field/> in widgets does not. > Is there any particular concern about not to change the behaviour of <property-to-field/> in widgets, such as performance impact? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
Free forum by Nabble | Edit this page |