OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-475) Create View-Entity Reference in Webtools

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

6 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-475) Create View-Entity Reference in Webtools

Create View-Entity Reference in Webtools
----------------------------------------

Key: OFBIZ-475
URL: http://issues.apache.org/jira/browse/OFBIZ-475
Project: OFBiz (The Open for Business Project)
Issue Type: New Feature
Components: framework
Reporter: Chris Howe
Priority: Minor

Add reference in webtools similar to entity Entity Data Maintenance that shows only view-entities.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-475) Create View-Entity Reference in Webtools

[ http://issues.apache.org/jira/browse/OFBIZ-475?page=all ]

Chris Howe updated OFBIZ-475:
-----------------------------

Attachment: viewEntity.patch

The purpose of this is to make view entities more visible, thus encouraging the use of of view-entities to leverage a normalized data model instead of denormalizing the data model to fit a specific need.

viewEntity.patch
License is granted for inclusion, however this patch is not necessarily meant to be included as is. Screen formating isn't the best as packages don't line up well. Beanshell script was changed to simple-method as a test case for conversion - simple method performs marginally better on the large amount of data in the entityMaint screen.

> Create View-Entity Reference in Webtools
> ----------------------------------------
>
> Key: OFBIZ-475
> URL: http://issues.apache.org/jira/browse/OFBIZ-475
> Project: OFBiz (The Open for Business Project)
> Issue Type: New Feature
> Components: framework
> Reporter: Chris Howe
> Priority: Minor
> Attachments: viewEntity.patch
>
>
> Add reference in webtools similar to entity Entity Data Maintenance that shows only view-entities.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-475) Create View-Entity Reference in Webtools

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-475?page=comments#action_12451589 ]

Jacopo Cappellato commented on OFBIZ-475:
-----------------------------------------

I really don't see how this should encourage the use of view-entities... having the view entities 'near' the real ones as is now I think it is good enough, but I could be wrong.
Also the logic in the two new minilang methods is very specific for the data setup of the "entity maintenance" screen and so and don't see big advantages in wrapping it into two new services.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-475) Create View-Entity Reference in Webtools

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-475?page=comments#action_12451659 ]

Chris Howe commented on OFBIZ-475:
----------------------------------

IMO Having them near the real real ones still encourages use of the real ones as they get lost. In many situations reads are being done on an <entity/> and then a get-related is done on that returned list. It would have been better both performance (this admitidly may be negligible with cache) and programming clarity wise to have done that initial read on a view entity that joined the two. So, to have a screen that lists just the view-entities I think would encourage that. Whether the placement of the link in the patch encourages it, is a different story.

As far as wrapping the simple method in a service, is it possible to to call a simple method directly from a screen? If so, I couldn't find any examples.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-475) Create View-Entity Reference in Webtools

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-475?page=comments#action_12451662 ]

Jacopo Cappellato commented on OFBIZ-475:
-----------------------------------------

> IMO Having them near the real real ones still encourages
> use of the real ones as they get lost.

IMO this is irrelevant, but it's just my opinion...

> As far as wrapping the simple method in a service, is it possible to to call
> a simple method directly from a screen? If so, I couldn't find any examples.

I would have probably implemented them using a bsh script... or, if the decision is to implement as services, probably just one service (with a more informative name and a few more input parameters).

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-475) Create View-Entity Reference in Webtools

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-475?page=comments#action_12451669 ]

Chris Howe commented on OFBIZ-475:
----------------------------------

>I would have probably implemented them using a bsh script... or, if the decision is to implement as services,
>probably just one service (with a more informative name and a few more input parameters).

I guess I'm turning into a bit of a fan boy in regards to simple methods over bsh. In my custom applications I'm finding that I reuse a lot more often with simple methods. Those reusable methods just aren't available in the community code.

There are two services implemented because one of them replaces entityMaint.bsh for the entity maintainance screen. Only one of the services is used for the viewEntity screen. The entityMaint service actually performed about 15% better than the bsh script did (and the simple method still calls bsh several times, so that could probably be even better). But you're right, the enttiyMaint service could simply create and return a view-entity list as well.

As I mentioned, this patch isn't meant to be applied as is, just a bit of conceptualization to push for more visibility of view entities.