OFBiz › OFBiz - Dev

[jira] [Created] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

21 messages Options

Nicolas Malin (Jira)

[jira] [Created] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

build.xml in hot-deploy folder is not called correctly in the main build.xml
----------------------------------------------------------------------------

Key: OFBIZ-4765
URL: https://issues.apache.org/jira/browse/OFBIZ-4765
Project: OFBiz
Issue Type: Bug
Affects Versions: SVN trunk
Reporter: Markus M. May
Priority: Minor
Fix For: SVN trunk

In the current build.xml in the ofbiz-Home-folder, the build target is executed for each subdirectory (framework, application, specialpurpose) with the fileset:

<filelist dir="." files="specialpurpose/build.xml"/>

Only for the hot-deploy folder the fileset is quite different:

<fileset dir="${basedir}/hot-deploy" casesensitive="no">
<exclude name="disabled/**"/>
<include name="*/build.xml"/>
</fileset>

This is calling the build.xml directly in the hot-deploy components, which is an error, if you do have several dependent components in there, which needs to get build in the right order. I propose to use the following filelist:

<filelist dir="." files="hot-deploy/build.xml"/>

Problem could be, that not every project do have an build.xml file in this folder (or is this already a requirement?). If it is not then we would need to check, if this build.xml is there, then execute this, and otherwise use the already existing one.

A patch will be applied for the first solution.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

> build.xml in hot-deploy folder is not called correctly in the main build.xml
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4765
> URL: https://issues.apache.org/jira/browse/OFBIZ-4765
> Project: OFBiz
> Issue Type: Bug
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4765-fix-buildxml.patch
>
>
> In the current build.xml in the ofbiz-Home-folder, the build target is executed for each subdirectory (framework, application, specialpurpose) with the fileset:
> <filelist dir="." files="specialpurpose/build.xml"/>
> Only for the hot-deploy folder the fileset is quite different:
> <fileset dir="${basedir}/hot-deploy" casesensitive="no">
> <exclude name="disabled/**"/>
> <include name="*/build.xml"/>
> </fileset>
> This is calling the build.xml directly in the hot-deploy components, which is an error, if you do have several dependent components in there, which needs to get build in the right order. I propose to use the following filelist:
> <filelist dir="." files="hot-deploy/build.xml"/>
> Problem could be, that not every project do have an build.xml file in this folder (or is this already a requirement?). If it is not then we would need to check, if this build.xml is there, then execute this, and otherwise use the already existing one.
> A patch will be applied for the first solution.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato updated OFBIZ-4765:
-------------------------------------

Issue Type: Wish (was: Bug)

This is not a bug but the intended behavior of the system; we can add support for the hot-deploy/build.xml file but this has to be optional.

> build.xml in hot-deploy folder is not called correctly in the main build.xml
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4765
> URL: https://issues.apache.org/jira/browse/OFBIZ-4765
> Project: OFBiz
> Issue Type: Wish
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4765-fix-buildxml.patch
>
>
> In the current build.xml in the ofbiz-Home-folder, the build target is executed for each subdirectory (framework, application, specialpurpose) with the fileset:
> <filelist dir="." files="specialpurpose/build.xml"/>
> Only for the hot-deploy folder the fileset is quite different:
> <fileset dir="${basedir}/hot-deploy" casesensitive="no">
> <exclude name="disabled/**"/>
> <include name="*/build.xml"/>
> </fileset>
> This is calling the build.xml directly in the hot-deploy components, which is an error, if you do have several dependent components in there, which needs to get build in the right order. I propose to use the following filelist:
> <filelist dir="." files="hot-deploy/build.xml"/>
> Problem could be, that not every project do have an build.xml file in this folder (or is this already a requirement?). If it is not then we would need to check, if this build.xml is there, then execute this, and otherwise use the already existing one.
> A patch will be applied for the first solution.

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Markus M. May updated OFBIZ-4765:
---------------------------------

Attachment: OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch

The attached patch just uses the build.xml in the hot-deploy-folder, if available. Hope that this solution could be used as a "standard".

> build.xml in hot-deploy folder is not called correctly in the main build.xml
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4765
> URL: https://issues.apache.org/jira/browse/OFBIZ-4765
> Project: OFBiz
> Issue Type: Wish
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4765-fix-buildxml.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch
>
>
> In the current build.xml in the ofbiz-Home-folder, the build target is executed for each subdirectory (framework, application, specialpurpose) with the fileset:
> <filelist dir="." files="specialpurpose/build.xml"/>
> Only for the hot-deploy folder the fileset is quite different:
> <fileset dir="${basedir}/hot-deploy" casesensitive="no">
> <exclude name="disabled/**"/>
> <include name="*/build.xml"/>
> </fileset>
> This is calling the build.xml directly in the hot-deploy components, which is an error, if you do have several dependent components in there, which needs to get build in the right order. I propose to use the following filelist:
> <filelist dir="." files="hot-deploy/build.xml"/>
> Problem could be, that not every project do have an build.xml file in this folder (or is this already a requirement?). If it is not then we would need to check, if this build.xml is there, then execute this, and otherwise use the already existing one.
> A patch will be applied for the first solution.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240302#comment-13240302 ]

Jacopo Cappellato commented on OFBIZ-4765:
------------------------------------------

Markus, the patch seems to contain a diff between two local versions; there are also unrelated changes.

> build.xml in hot-deploy folder is not called correctly in the main build.xml
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4765
> URL: https://issues.apache.org/jira/browse/OFBIZ-4765
> Project: OFBiz
> Issue Type: Wish
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4765-fix-buildxml.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch
>
>
> In the current build.xml in the ofbiz-Home-folder, the build target is executed for each subdirectory (framework, application, specialpurpose) with the fileset:
> <filelist dir="." files="specialpurpose/build.xml"/>
> Only for the hot-deploy folder the fileset is quite different:
> <fileset dir="${basedir}/hot-deploy" casesensitive="no">
> <exclude name="disabled/**"/>
> <include name="*/build.xml"/>
> </fileset>
> This is calling the build.xml directly in the hot-deploy components, which is an error, if you do have several dependent components in there, which needs to get build in the right order. I propose to use the following filelist:
> <filelist dir="." files="hot-deploy/build.xml"/>
> Problem could be, that not every project do have an build.xml file in this folder (or is this already a requirement?). If it is not then we would need to check, if this build.xml is there, then execute this, and otherwise use the already existing one.
> A patch will be applied for the first solution.

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

In reply to this post by Nicolas Malin (Jira)

> build.xml in hot-deploy folder is not called correctly in the main build.xml
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4765
> URL: https://issues.apache.org/jira/browse/OFBIZ-4765
> Project: OFBiz
> Issue Type: Wish
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4765-fix-buildxml.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch
>
>
> In the current build.xml in the ofbiz-Home-folder, the build target is executed for each subdirectory (framework, application, specialpurpose) with the fileset:
> <filelist dir="." files="specialpurpose/build.xml"/>
> Only for the hot-deploy folder the fileset is quite different:
> <fileset dir="${basedir}/hot-deploy" casesensitive="no">
> <exclude name="disabled/**"/>
> <include name="*/build.xml"/>
> </fileset>
> This is calling the build.xml directly in the hot-deploy components, which is an error, if you do have several dependent components in there, which needs to get build in the right order. I propose to use the following filelist:
> <filelist dir="." files="hot-deploy/build.xml"/>
> Problem could be, that not every project do have an build.xml file in this folder (or is this already a requirement?). If it is not then we would need to check, if this build.xml is there, then execute this, and otherwise use the already existing one.
> A patch will be applied for the first solution.

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

In reply to this post by Nicolas Malin (Jira)

> build.xml in hot-deploy folder is not called correctly in the main build.xml
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4765
> URL: https://issues.apache.org/jira/browse/OFBIZ-4765
> Project: OFBiz
> Issue Type: Wish
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4765-fix-buildxml.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch
>
>
> In the current build.xml in the ofbiz-Home-folder, the build target is executed for each subdirectory (framework, application, specialpurpose) with the fileset:
> <filelist dir="." files="specialpurpose/build.xml"/>
> Only for the hot-deploy folder the fileset is quite different:
> <fileset dir="${basedir}/hot-deploy" casesensitive="no">
> <exclude name="disabled/**"/>
> <include name="*/build.xml"/>
> </fileset>
> This is calling the build.xml directly in the hot-deploy components, which is an error, if you do have several dependent components in there, which needs to get build in the right order. I propose to use the following filelist:
> <filelist dir="." files="hot-deploy/build.xml"/>
> Problem could be, that not every project do have an build.xml file in this folder (or is this already a requirement?). If it is not then we would need to check, if this build.xml is there, then execute this, and otherwise use the already existing one.
> A patch will be applied for the first solution.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243705#comment-13243705 ]

Jacques Le Roux commented on OFBIZ-4765:
----------------------------------------

Francis, your 2d patch will not apply since it's based on your initial change. So you need to revert both and reapply your change.
Jacopo, I don't see any problem with the spirit of this patch. But we know some are using other strategies coupled with ant create-component. Is it ok for you to apply this patch? Same question for all persons interested, of course...

> build.xml in hot-deploy folder is not called correctly in the main build.xml
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4765
> URL: https://issues.apache.org/jira/browse/OFBIZ-4765
> Project: OFBiz
> Issue Type: Wish
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4765-fix-buildxml.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch
>
>
> In the current build.xml in the ofbiz-Home-folder, the build target is executed for each subdirectory (framework, application, specialpurpose) with the fileset:
> <filelist dir="." files="specialpurpose/build.xml"/>
> Only for the hot-deploy folder the fileset is quite different:
> <fileset dir="${basedir}/hot-deploy" casesensitive="no">
> <exclude name="disabled/**"/>
> <include name="*/build.xml"/>
> </fileset>
> This is calling the build.xml directly in the hot-deploy components, which is an error, if you do have several dependent components in there, which needs to get build in the right order. I propose to use the following filelist:
> <filelist dir="." files="hot-deploy/build.xml"/>
> Problem could be, that not every project do have an build.xml file in this folder (or is this already a requirement?). If it is not then we would need to check, if this build.xml is there, then execute this, and otherwise use the already existing one.
> A patch will be applied for the first solution.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243707#comment-13243707 ]

Hans Bakker commented on OFBIZ-4765:
------------------------------------

not every component has a build.xml, as least up to now there is no requirement for that....

> build.xml in hot-deploy folder is not called correctly in the main build.xml
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4765
> URL: https://issues.apache.org/jira/browse/OFBIZ-4765
> Project: OFBiz
> Issue Type: Wish
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4765-fix-buildxml.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch
>
>
> In the current build.xml in the ofbiz-Home-folder, the build target is executed for each subdirectory (framework, application, specialpurpose) with the fileset:
> <filelist dir="." files="specialpurpose/build.xml"/>
> Only for the hot-deploy folder the fileset is quite different:
> <fileset dir="${basedir}/hot-deploy" casesensitive="no">
> <exclude name="disabled/**"/>
> <include name="*/build.xml"/>
> </fileset>
> This is calling the build.xml directly in the hot-deploy components, which is an error, if you do have several dependent components in there, which needs to get build in the right order. I propose to use the following filelist:
> <filelist dir="." files="hot-deploy/build.xml"/>
> Problem could be, that not every project do have an build.xml file in this folder (or is this already a requirement?). If it is not then we would need to check, if this build.xml is there, then execute this, and otherwise use the already existing one.
> A patch will be applied for the first solution.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243709#comment-13243709 ]

Jacques Le Roux commented on OFBIZ-4765:
----------------------------------------

Thanks Hans,

So you agree with Francis's proposition to have a global one in hot-deploy from where to handle all created sub-component, right?

> build.xml in hot-deploy folder is not called correctly in the main build.xml
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4765
> URL: https://issues.apache.org/jira/browse/OFBIZ-4765
> Project: OFBiz
> Issue Type: Wish
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4765-fix-buildxml.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch
>
>
> In the current build.xml in the ofbiz-Home-folder, the build target is executed for each subdirectory (framework, application, specialpurpose) with the fileset:
> <filelist dir="." files="specialpurpose/build.xml"/>
> Only for the hot-deploy folder the fileset is quite different:
> <fileset dir="${basedir}/hot-deploy" casesensitive="no">
> <exclude name="disabled/**"/>
> <include name="*/build.xml"/>
> </fileset>
> This is calling the build.xml directly in the hot-deploy components, which is an error, if you do have several dependent components in there, which needs to get build in the right order. I propose to use the following filelist:
> <filelist dir="." files="hot-deploy/build.xml"/>
> Problem could be, that not every project do have an build.xml file in this folder (or is this already a requirement?). If it is not then we would need to check, if this build.xml is there, then execute this, and otherwise use the already existing one.
> A patch will be applied for the first solution.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243712#comment-13243712 ]

Hans Bakker commented on OFBIZ-4765:
------------------------------------

Is there any relation to a possible component-load.xml file in hot-deploy which also allows a certain sequence.....

as i mentioned before build.xml should be optional

Regards,
Hans

> build.xml in hot-deploy folder is not called correctly in the main build.xml
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4765
> URL: https://issues.apache.org/jira/browse/OFBIZ-4765
> Project: OFBiz
> Issue Type: Wish
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4765-fix-buildxml.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch
>
>
> In the current build.xml in the ofbiz-Home-folder, the build target is executed for each subdirectory (framework, application, specialpurpose) with the fileset:
> <filelist dir="." files="specialpurpose/build.xml"/>
> Only for the hot-deploy folder the fileset is quite different:
> <fileset dir="${basedir}/hot-deploy" casesensitive="no">
> <exclude name="disabled/**"/>
> <include name="*/build.xml"/>
> </fileset>
> This is calling the build.xml directly in the hot-deploy components, which is an error, if you do have several dependent components in there, which needs to get build in the right order. I propose to use the following filelist:
> <filelist dir="." files="hot-deploy/build.xml"/>
> Problem could be, that not every project do have an build.xml file in this folder (or is this already a requirement?). If it is not then we would need to check, if this build.xml is there, then execute this, and otherwise use the already existing one.
> A patch will be applied for the first solution.

Nicolas Malin (Jira)

[jira] [Issue Comment Edited] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243712#comment-13243712 ]

Hans Bakker edited comment on OFBIZ-4765 at 4/1/12 12:48 PM:
-------------------------------------------------------------

as i mentioned before build.xml should be optional both in the component as in the hot-deploy directory similar to component-load.xml

Regards,
Hans

was (Author: hansbak):
Is there any relation to a possible component-load.xml file in hot-deploy which also allows a certain sequence.....

as i mentioned before build.xml should be optional

Regards,
Hans

> build.xml in hot-deploy folder is not called correctly in the main build.xml
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4765
> URL: https://issues.apache.org/jira/browse/OFBIZ-4765
> Project: OFBiz
> Issue Type: Wish
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4765-fix-buildxml.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch
>
>
> In the current build.xml in the ofbiz-Home-folder, the build target is executed for each subdirectory (framework, application, specialpurpose) with the fileset:
> <filelist dir="." files="specialpurpose/build.xml"/>
> Only for the hot-deploy folder the fileset is quite different:
> <fileset dir="${basedir}/hot-deploy" casesensitive="no">
> <exclude name="disabled/**"/>
> <include name="*/build.xml"/>
> </fileset>
> This is calling the build.xml directly in the hot-deploy components, which is an error, if you do have several dependent components in there, which needs to get build in the right order. I propose to use the following filelist:
> <filelist dir="." files="hot-deploy/build.xml"/>
> Problem could be, that not every project do have an build.xml file in this folder (or is this already a requirement?). If it is not then we would need to check, if this build.xml is there, then execute this, and otherwise use the already existing one.
> A patch will be applied for the first solution.

Nicolas Malin (Jira)

[jira] [Issue Comment Edited] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243712#comment-13243712 ]

Hans Bakker edited comment on OFBIZ-4765 at 4/1/12 1:04 PM:
------------------------------------------------------------

as i mentioned before build.xml should be optional both in the component as in the hot-deploy directory similar to component-load.xml

also the current situation should still work, only have build.xml in the component dir but not in the hot-deploy dir

Regards,
Hans

was (Author: hansbak):
as i mentioned before build.xml should be optional both in the component as in the hot-deploy directory similar to component-load.xml

Regards,
Hans

> build.xml in hot-deploy folder is not called correctly in the main build.xml
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4765
> URL: https://issues.apache.org/jira/browse/OFBIZ-4765
> Project: OFBiz
> Issue Type: Wish
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4765-fix-buildxml.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch
>
>
> In the current build.xml in the ofbiz-Home-folder, the build target is executed for each subdirectory (framework, application, specialpurpose) with the fileset:
> <filelist dir="." files="specialpurpose/build.xml"/>
> Only for the hot-deploy folder the fileset is quite different:
> <fileset dir="${basedir}/hot-deploy" casesensitive="no">
> <exclude name="disabled/**"/>
> <include name="*/build.xml"/>
> </fileset>
> This is calling the build.xml directly in the hot-deploy components, which is an error, if you do have several dependent components in there, which needs to get build in the right order. I propose to use the following filelist:
> <filelist dir="." files="hot-deploy/build.xml"/>
> Problem could be, that not every project do have an build.xml file in this folder (or is this already a requirement?). If it is not then we would need to check, if this build.xml is there, then execute this, and otherwise use the already existing one.
> A patch will be applied for the first solution.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244009#comment-13244009 ]

Markus M. May commented on OFBIZ-4765:
--------------------------------------

The applied patch is pretty much the same solution as before. Only if a "hot-deploy/build.xml" is available, the main build.xml is using this one. In all other cases the solution is doing the same as before.

Could you please review the patch and apply it?

> build.xml in hot-deploy folder is not called correctly in the main build.xml
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4765
> URL: https://issues.apache.org/jira/browse/OFBIZ-4765
> Project: OFBiz
> Issue Type: Wish
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4765-fix-buildxml.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch
>
>
> In the current build.xml in the ofbiz-Home-folder, the build target is executed for each subdirectory (framework, application, specialpurpose) with the fileset:
> <filelist dir="." files="specialpurpose/build.xml"/>
> Only for the hot-deploy folder the fileset is quite different:
> <fileset dir="${basedir}/hot-deploy" casesensitive="no">
> <exclude name="disabled/**"/>
> <include name="*/build.xml"/>
> </fileset>
> This is calling the build.xml directly in the hot-deploy components, which is an error, if you do have several dependent components in there, which needs to get build in the right order. I propose to use the following filelist:
> <filelist dir="." files="hot-deploy/build.xml"/>
> Problem could be, that not every project do have an build.xml file in this folder (or is this already a requirement?). If it is not then we would need to check, if this build.xml is there, then execute this, and otherwise use the already existing one.
> A patch will be applied for the first solution.

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Markus M. May updated OFBIZ-4765:
---------------------------------

Attachment: OFBIZ-4765-use-hotdeploy-buildxml-if-available-2.patch

Make the patch "unique", so that it does not depend on the first patch.

> build.xml in hot-deploy folder is not called correctly in the main build.xml
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4765
> URL: https://issues.apache.org/jira/browse/OFBIZ-4765
> Project: OFBiz
> Issue Type: Wish
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4765-fix-buildxml.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available-2.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch
>
>
> In the current build.xml in the ofbiz-Home-folder, the build target is executed for each subdirectory (framework, application, specialpurpose) with the fileset:
> <filelist dir="." files="specialpurpose/build.xml"/>
> Only for the hot-deploy folder the fileset is quite different:
> <fileset dir="${basedir}/hot-deploy" casesensitive="no">
> <exclude name="disabled/**"/>
> <include name="*/build.xml"/>
> </fileset>
> This is calling the build.xml directly in the hot-deploy components, which is an error, if you do have several dependent components in there, which needs to get build in the right order. I propose to use the following filelist:
> <filelist dir="." files="hot-deploy/build.xml"/>
> Problem could be, that not every project do have an build.xml file in this folder (or is this already a requirement?). If it is not then we would need to check, if this build.xml is there, then execute this, and otherwise use the already existing one.
> A patch will be applied for the first solution.

Nicolas Malin (Jira)

[jira] [Issue Comment Edited] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244015#comment-13244015 ]

Markus M. May edited comment on OFBIZ-4765 at 4/2/12 7:18 AM:
--------------------------------------------------------------

Make the patch "unique", so that it does not depend on the first patch.

Sorry, Jacques, did not respond in a timely manner, because me is not Francis ;-)

was (Author: [hidden email]):
Make the patch "unique", so that it does not depend on the first patch.

> build.xml in hot-deploy folder is not called correctly in the main build.xml
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4765
> URL: https://issues.apache.org/jira/browse/OFBIZ-4765
> Project: OFBiz
> Issue Type: Wish
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4765-fix-buildxml.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available-2.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch
>
>
> In the current build.xml in the ofbiz-Home-folder, the build target is executed for each subdirectory (framework, application, specialpurpose) with the fileset:
> <filelist dir="." files="specialpurpose/build.xml"/>
> Only for the hot-deploy folder the fileset is quite different:
> <fileset dir="${basedir}/hot-deploy" casesensitive="no">
> <exclude name="disabled/**"/>
> <include name="*/build.xml"/>
> </fileset>
> This is calling the build.xml directly in the hot-deploy components, which is an error, if you do have several dependent components in there, which needs to get build in the right order. I propose to use the following filelist:
> <filelist dir="." files="hot-deploy/build.xml"/>
> Problem could be, that not every project do have an build.xml file in this folder (or is this already a requirement?). If it is not then we would need to check, if this build.xml is there, then execute this, and otherwise use the already existing one.
> A patch will be applied for the first solution.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244024#comment-13244024 ]

Jacques Le Roux commented on OFBIZ-4765:
----------------------------------------

Yes sorry Markus, I just realize it this morning. I mixed with another issue I was working on.

> build.xml in hot-deploy folder is not called correctly in the main build.xml
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4765
> URL: https://issues.apache.org/jira/browse/OFBIZ-4765
> Project: OFBiz
> Issue Type: Wish
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4765-fix-buildxml.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available-2.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch
>
>
> In the current build.xml in the ofbiz-Home-folder, the build target is executed for each subdirectory (framework, application, specialpurpose) with the fileset:
> <filelist dir="." files="specialpurpose/build.xml"/>
> Only for the hot-deploy folder the fileset is quite different:
> <fileset dir="${basedir}/hot-deploy" casesensitive="no">
> <exclude name="disabled/**"/>
> <include name="*/build.xml"/>
> </fileset>
> This is calling the build.xml directly in the hot-deploy components, which is an error, if you do have several dependent components in there, which needs to get build in the right order. I propose to use the following filelist:
> <filelist dir="." files="hot-deploy/build.xml"/>
> Problem could be, that not every project do have an build.xml file in this folder (or is this already a requirement?). If it is not then we would need to check, if this build.xml is there, then execute this, and otherwise use the already existing one.
> A patch will be applied for the first solution.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244099#comment-13244099 ]

Jacques Le Roux commented on OFBIZ-4765:
----------------------------------------

This seems OK with me, since the previous behaviour is kept (ie when there is no build.xml file in hot-deploy dir then the build.xml files - if present - in hot-deploy sub-dirs will be used)

Agreed, Jacopo, Hans ?

> build.xml in hot-deploy folder is not called correctly in the main build.xml
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4765
> URL: https://issues.apache.org/jira/browse/OFBIZ-4765
> Project: OFBiz
> Issue Type: Wish
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4765-fix-buildxml.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available-2.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch
>
>
> In the current build.xml in the ofbiz-Home-folder, the build target is executed for each subdirectory (framework, application, specialpurpose) with the fileset:
> <filelist dir="." files="specialpurpose/build.xml"/>
> Only for the hot-deploy folder the fileset is quite different:
> <fileset dir="${basedir}/hot-deploy" casesensitive="no">
> <exclude name="disabled/**"/>
> <include name="*/build.xml"/>
> </fileset>
> This is calling the build.xml directly in the hot-deploy components, which is an error, if you do have several dependent components in there, which needs to get build in the right order. I propose to use the following filelist:
> <filelist dir="." files="hot-deploy/build.xml"/>
> Problem could be, that not every project do have an build.xml file in this folder (or is this already a requirement?). If it is not then we would need to check, if this build.xml is there, then execute this, and otherwise use the already existing one.
> A patch will be applied for the first solution.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244104#comment-13244104 ]

Hans Bakker commented on OFBIZ-4765:
------------------------------------

sounds fine me,
Hans

> build.xml in hot-deploy folder is not called correctly in the main build.xml
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4765
> URL: https://issues.apache.org/jira/browse/OFBIZ-4765
> Project: OFBiz
> Issue Type: Wish
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4765-fix-buildxml.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available-2.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch
>
>
> In the current build.xml in the ofbiz-Home-folder, the build target is executed for each subdirectory (framework, application, specialpurpose) with the fileset:
> <filelist dir="." files="specialpurpose/build.xml"/>
> Only for the hot-deploy folder the fileset is quite different:
> <fileset dir="${basedir}/hot-deploy" casesensitive="no">
> <exclude name="disabled/**"/>
> <include name="*/build.xml"/>
> </fileset>
> This is calling the build.xml directly in the hot-deploy components, which is an error, if you do have several dependent components in there, which needs to get build in the right order. I propose to use the following filelist:
> <filelist dir="." files="hot-deploy/build.xml"/>
> Problem could be, that not every project do have an build.xml file in this folder (or is this already a requirement?). If it is not then we would need to check, if this build.xml is there, then execute this, and otherwise use the already existing one.
> A patch will be applied for the first solution.

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4765) Allows a build.xml file in hot-deploy folder to build components in a specific order

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-4765:
-----------------------------------

Assignee: Jacques Le Roux
Issue Type: Improvement (was: Wish)
Summary: Allows a build.xml file in hot-deploy folder to build components in a specific order (was: build.xml in hot-deploy folder is not called correctly in the main build.xml)

Changed the title to better reflect the improvment

> Allows a build.xml file in hot-deploy folder to build components in a specific order
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-4765
> URL: https://issues.apache.org/jira/browse/OFBIZ-4765
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4765-fix-buildxml.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available-2.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch
>
>
> In the current build.xml in the ofbiz-Home-folder, the build target is executed for each subdirectory (framework, application, specialpurpose) with the fileset:
> <filelist dir="." files="specialpurpose/build.xml"/>
> Only for the hot-deploy folder the fileset is quite different:
> <fileset dir="${basedir}/hot-deploy" casesensitive="no">
> <exclude name="disabled/**"/>
> <include name="*/build.xml"/>
> </fileset>
> This is calling the build.xml directly in the hot-deploy components, which is an error, if you do have several dependent components in there, which needs to get build in the right order. I propose to use the following filelist:
> <filelist dir="." files="hot-deploy/build.xml"/>
> Problem could be, that not every project do have an build.xml file in this folder (or is this already a requirement?). If it is not then we would need to check, if this build.xml is there, then execute this, and otherwise use the already existing one.
> A patch will be applied for the first solution.