[jira] [Created] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
21 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[jira] [Closed] (OFBIZ-4765) Allows a build.xml file in hot-deploy folder to build components in a specific order

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4765.
----------------------------------

    Resolution: Fixed

Thanks Markus,

Your patch is in trunk at r1308336  

I have added this comment above the new feature:
{quote}
A check is done, if no build.xml file is present in hot-deploy dir, then the build.xml files - if present - in hot-deploy sub-dirs will be used. So the previous, simpler, behaviour is kept as long as you don't need to build hot-deploy components in a specific order.
{quote}
               

> Allows a build.xml file in hot-deploy folder to build components in a specific order
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4765
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4765
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Markus M. May
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4765-fix-buildxml.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available-2.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch
>
>
> In the current build.xml in the ofbiz-Home-folder, the build target is executed for each subdirectory (framework, application, specialpurpose) with the fileset:
> <filelist dir="." files="specialpurpose/build.xml"/>
> Only for the hot-deploy folder the fileset is quite different:
> <fileset dir="${basedir}/hot-deploy" casesensitive="no">
>    <exclude name="disabled/**"/>
>    <include name="*/build.xml"/>
> </fileset>
> This is calling the build.xml directly in the hot-deploy components, which is an error, if you do have several dependent components in there, which needs to get build in the right order. I propose to use the following filelist:
> <filelist dir="." files="hot-deploy/build.xml"/>
> Problem could be, that not every project do have an build.xml file in this folder (or is this already a requirement?). If it is not then we would need to check, if this build.xml is there, then execute this, and otherwise use the already existing one.
> A patch will be applied for the first solution.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
12