storeIncomingEmail assumes variable is not null when it might be
---------------------------------------------------------------- Key: OFBIZ-4784 URL: https://issues.apache.org/jira/browse/OFBIZ-4784 Project: OFBiz Issue Type: Bug Components: party Affects Versions: SVN trunk Environment: r1309653 Reporter: Paul Foxworthy Priority: Minor In storeIncomingEmail in CommunicationEventServices.java, the code to assemble the aboutThisEmail debugging message assumes addressesFrom and addressesTo are not null. But the methods that return values for those variables might return null if they encounter an exception. I have also removed uses of UtilValidate.isEmpty, which should only be used for collections and sequences (see OFBIZ-4427). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[ https://issues.apache.org/jira/browse/OFBIZ-4784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Foxworthy updated OFBIZ-4784: ---------------------------------- Attachment: OFBIZ-4784_CommunicationEventServices.patch > storeIncomingEmail assumes variable is not null when it might be > ---------------------------------------------------------------- > > Key: OFBIZ-4784 > URL: https://issues.apache.org/jira/browse/OFBIZ-4784 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk > Environment: r1309653 > Reporter: Paul Foxworthy > Priority: Minor > Attachments: OFBIZ-4784_CommunicationEventServices.patch > > > In storeIncomingEmail in CommunicationEventServices.java, the code to assemble the aboutThisEmail debugging message assumes addressesFrom and addressesTo are not null. But the methods that return values for those variables might return null if they encounter an exception. > I have also removed uses of UtilValidate.isEmpty, which should only be used for collections and sequences (see OFBIZ-4427). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4784. ---------------------------------- Resolution: Fixed Fix Version/s: SVN trunk Release Branch 11.04 Release Branch 10.04 Assignee: Jacques Le Roux Thanks Paul, Your patch is in trunk r1309715 R11.04 r1309717 R10.04 r1309718 > storeIncomingEmail assumes variable is not null when it might be > ---------------------------------------------------------------- > > Key: OFBIZ-4784 > URL: https://issues.apache.org/jira/browse/OFBIZ-4784 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk > Environment: r1309653 > Reporter: Paul Foxworthy > Assignee: Jacques Le Roux > Priority: Minor > Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk > > Attachments: OFBIZ-4784_CommunicationEventServices.patch > > > In storeIncomingEmail in CommunicationEventServices.java, the code to assemble the aboutThisEmail debugging message assumes addressesFrom and addressesTo are not null. But the methods that return values for those variables might return null if they encounter an exception. > I have also removed uses of UtilValidate.isEmpty, which should only be used for collections and sequences (see OFBIZ-4427). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
Free forum by Nabble | Edit this page |