[jira] Created: (OFBIZ-480) Error in Ecommerce when we do emptycart

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-480) Error in Ecommerce when we do emptycart

Nicolas Malin (Jira)
Error in Ecommerce when we do emptycart
---------------------------------------

                 Key: OFBIZ-480
                 URL: http://issues.apache.org/jira/browse/OFBIZ-480
             Project: OFBiz (The Open for Business Project)
          Issue Type: Bug
          Components: ecommerce
    Affects Versions: SVN trunk
         Environment: CentOs(Linux)
            Reporter: Ashish Vijaywargiya
         Attachments: empty_cart.patch

Hi,

There were two errors in the ecommerce :

1) When we add any product and click on the EmptyCart then it throw's error of null pointer exception.
I have changed ShoppingCartEvents.java to  check null condition for userLogin.
2) When we checkout the sale as "anonymous" user then we click on the "EmptyCart" then it was showing error of shoppingCart not found.

(See the online demo of Ofbiz for above two errors.Although same errors are resulting from the latest SVN )
I am also submitting the patch for this.

Regards
Ashish Vijaywargiya

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-480) Error in Ecommerce when we do emptycart

Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-480?page=all ]

Ashish Vijaywargiya updated OFBIZ-480:
--------------------------------------

    Attachment: empty_cart.patch

> Error in Ecommerce when we do emptycart
> ---------------------------------------
>
>                 Key: OFBIZ-480
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-480
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: CentOs(Linux)
>            Reporter: Ashish Vijaywargiya
>         Attachments: empty_cart.patch
>
>
> Hi,
> There were two errors in the ecommerce :
> 1) When we add any product and click on the EmptyCart then it throw's error of null pointer exception.
> I have changed ShoppingCartEvents.java to  check null condition for userLogin.
> 2) When we checkout the sale as "anonymous" user then we click on the "EmptyCart" then it was showing error of shoppingCart not found.
> (See the online demo of Ofbiz for above two errors.Although same errors are resulting from the latest SVN )
> I am also submitting the patch for this.
> Regards
> Ashish Vijaywargiya

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-480) Error in Ecommerce when we do emptycart

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-480?page=all ]

David E. Jones closed OFBIZ-480.
--------------------------------

    Fix Version/s: SVN trunk
       Resolution: Fixed
         Assignee: David E. Jones

Thanks for reporting and working on this Ashish. Your change in the ShoppingCartEvents.java file looks fine.

The changes in the showcart.ftl page have some problems. A better way to fix the bug you found is to use the ShoppingCartEvents.getCartObject method to construct a cart object if one does not already exist. There was also a change in that file around line 490 that didn't just fix the bug but also changed functionality of the page, which isn't cool when the change in functionality is not intended. The change I made is in showcart.ftl and it has the better solution and avoids the unwanted change.

The changes are in SVN rev 477896.

> Error in Ecommerce when we do emptycart
> ---------------------------------------
>
>                 Key: OFBIZ-480
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-480
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: CentOs(Linux)
>            Reporter: Ashish Vijaywargiya
>         Assigned To: David E. Jones
>             Fix For: SVN trunk
>
>         Attachments: empty_cart.patch
>
>
> Hi,
> There were two errors in the ecommerce :
> 1) When we add any product and click on the EmptyCart then it throw's error of null pointer exception.
> I have changed ShoppingCartEvents.java to  check null condition for userLogin.
> 2) When we checkout the sale as "anonymous" user then we click on the "EmptyCart" then it was showing error of shoppingCart not found.
> (See the online demo of Ofbiz for above two errors.Although same errors are resulting from the latest SVN )
> I am also submitting the patch for this.
> Regards
> Ashish Vijaywargiya

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-480) Error in Ecommerce when we do emptycart

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-480?page=comments#action_12451793 ]
           
Ashish Vijaywargiya commented on OFBIZ-480:
-------------------------------------------

David,

Thx for the comments.

Regards
Ashish Vijaywargiya

> Error in Ecommerce when we do emptycart
> ---------------------------------------
>
>                 Key: OFBIZ-480
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-480
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: CentOs(Linux)
>            Reporter: Ashish Vijaywargiya
>         Assigned To: David E. Jones
>             Fix For: SVN trunk
>
>         Attachments: empty_cart.patch
>
>
> Hi,
> There were two errors in the ecommerce :
> 1) When we add any product and click on the EmptyCart then it throw's error of null pointer exception.
> I have changed ShoppingCartEvents.java to  check null condition for userLogin.
> 2) When we checkout the sale as "anonymous" user then we click on the "EmptyCart" then it was showing error of shoppingCart not found.
> (See the online demo of Ofbiz for above two errors.Although same errors are resulting from the latest SVN )
> I am also submitting the patch for this.
> Regards
> Ashish Vijaywargiya

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira