OFBiz › OFBiz - Dev

[jira] [Created] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

38 messages Options

Nicolas Malin (Jira)

[jira] [Created] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

ajax autocomplete and dialog during session timeout
---------------------------------------------------

Key: OFBIZ-4813
URL: https://issues.apache.org/jira/browse/OFBIZ-4813
Project: OFBiz
Issue Type: Bug
Components: framework
Reporter: Wai

1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user.
2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message.
3. All ajax dialogs are on the left of browser window.

A number of fixes have been implemented for this issue.

1. At session timeout, user enters a character into autocomplete input box results in a alert window popup.
2. At session timeout, clicking on ajax dialog button will cause alert window to popup.
3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner.
4. Now all ajax dialogs are centered.
5. Change session timeout message to something more detailed.
6. Server response to ajax request now contain html tags.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wai updated OFBIZ-4813:
-----------------------

Attachment: spinner.gif
ofbiz-4813.patch

Instruction(s):
1. Apply patch
2. /ofbiz/framework/images/webapp/images/spinner.gif with this new file.

> ajax autocomplete and dialog during session timeout
> ---------------------------------------------------
>
> Key: OFBIZ-4813
> URL: https://issues.apache.org/jira/browse/OFBIZ-4813
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Reporter: Wai
> Attachments: ofbiz-4813.patch, spinner.gif
>
>
> 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user.
> 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message.
> 3. All ajax dialogs are on the left of browser window.
> A number of fixes have been implemented for this issue.
> 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup.
> 2. At session timeout, clicking on ajax dialog button will cause alert window to popup.
> 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner.
> 4. Now all ajax dialogs are centered.
> 5. Change session timeout message to something more detailed.
> 6. Server response to ajax request now contain html tags.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Issue Comment Edited] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254922#comment-13254922 ]

Wai edited comment on OFBIZ-4813 at 4/16/12 7:01 PM:
-----------------------------------------------------

Instruction(s):
1. Apply patch
2. Replace /ofbiz/framework/images/webapp/images/spinner.gif with this new file.

was (Author: wt):
Instruction(s):
1. Apply patch
2. /ofbiz/framework/images/webapp/images/spinner.gif with this new file.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255311#comment-13255311 ]

Jacques Le Roux commented on OFBIZ-4813:
----------------------------------------

Wai,

About the point 4: I purposely decided to put the layered Ajax box at top left because it allows an easier "maximisation". When centered, if you want to increase the surface you have 1st to move it to top left, then increase. When in top left one dragging gesture et voilà.

I don't know what others think about that
{code}
<property key="CommonSessionTimeoutPleaseLogIn">
- <value xml:lang="de">Sie sind nicht mehr angemeldet. Bitte melden Sie sich erneut an.</value>
- <value xml:lang="en">You are not logged in. Please login again.</value>
- <value xml:lang="es">No estÃ¡ conectado. Por favor, vuelva a conectarse.</value>
- <value xml:lang="vi">Báº¡n chÆ°a Ä‘Äƒng nháºp. Vui lÃ²ng Ä‘Äƒng nháºp láº¡i.</value>
+ <value xml:lang="en">Your session has expired. A login is required. You can refresh the page or save your data to login.</value>
{code}

Why did you replace this (I don't say it's wrong, just to understand what was wrong)
{code}
- }
- requestUrl = getViewNameWithSeparator(requestUrl) + "presentation=" + presentation;
+ }
{code}

{code}
+ var queryArgs = "presentation=" + presentation;
if (typeof args == "object" && jQuery.isArray(args)) {
for (var i = 0; i < args.length; i++) {
- requestUrlAndArgs += "&parm" + i + "=" + jQuery(args[i]).val();
+ queryArgs += "&parm" + i + "=" + jQuery(args[i]).val();
{code}

If you introduce a timeout, it should be configurable (property)
{code}
+ jQuery.ajax({
+ type: "post",
+ url: requestUrl,
+ data: queryArgs,
+ timeout: 5000,
{code}

Thanks

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255663#comment-13255663 ]

Wai commented on OFBIZ-4813:
----------------------------

Regarding point#4(centering of dialog):

I centered it as it looked unusual. Usually dialogs are at the center of the screen. The modification was for esthetical reasons. I was not aware it was like that by design given your explanation. I can change it back.

Regarding the change to label CommonSessionTimeoutPleaseLogIn:

The modification was made for the situation where a user has spent time filling up a form and them through using the autocompleter realizes that a session timeout has occurred. This normally would cause a mild panic. Hence the message "Your session has expired. A login is required. You can refresh the page or save your data to login.", lets the user know that there are 2 ways to refresh the session. 1) refresh the page. Hence lose all changes. 2) save as usually and expect to encounter a login screen during the process.

Regarding removal of code ""requestUrl = getViewNameWithSeparator(requestUrl) + ...:

The original code uses jQuery(...).load(...) to initiate an ajax request. The new code uses jQuery.ajax(...). Hence, the code in question became unnecessary as jQuery.ajax() requires specification of path and querystring separately.

Regarding the hardcoded timeout:

I should have defined a global variable to specify the value. I can corrected it once all the points have been addressed.

Wai

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255912#comment-13255912 ]

Jacques Le Roux commented on OFBIZ-4813:
----------------------------------------

Hi Wai,

Agreed on CommonSessionTimeoutPleaseLogIn change. Better having it only in English than keeping confusing/worrying previous even if we lose some translation.

Agreed on removal of code ""requestUrl = getViewNameWithSeparator(requestUrl) + ...:

I let you provide a new patch to apply soon.

Thanks

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

In reply to this post by Nicolas Malin (Jira)

> ajax autocomplete and dialog during session timeout
> ---------------------------------------------------
>
> Key: OFBIZ-4813
> URL: https://issues.apache.org/jira/browse/OFBIZ-4813
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Reporter: Wai
> Attachments: ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif
>
>
> 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user.
> 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message.
> 3. All ajax dialogs are on the left of browser window.
> A number of fixes have been implemented for this issue.
> 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup.
> 2. At session timeout, clicking on ajax dialog button will cause alert window to popup.
> 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner.
> 4. Now all ajax dialogs are centered.
> 5. Change session timeout message to something more detailed.
> 6. Server response to ajax request now contain html tags.

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

In reply to this post by Nicolas Malin (Jira)

> ajax autocomplete and dialog during session timeout
> ---------------------------------------------------
>
> Key: OFBIZ-4813
> URL: https://issues.apache.org/jira/browse/OFBIZ-4813
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Reporter: Wai
> Attachments: ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif
>
>
> 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user.
> 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message.
> 3. All ajax dialogs are on the left of browser window.
> A number of fixes have been implemented for this issue.
> 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup.
> 2. At session timeout, clicking on ajax dialog button will cause alert window to popup.
> 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner.
> 4. Now all ajax dialogs are centered.
> 5. Change session timeout message to something more detailed.
> 6. Server response to ajax request now contain html tags.

Nicolas Malin (Jira)

[jira] [Assigned] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-4813:
--------------------------------------

Assignee: Jacques Le Roux

> ajax autocomplete and dialog during session timeout
> ---------------------------------------------------
>
> Key: OFBIZ-4813
> URL: https://issues.apache.org/jira/browse/OFBIZ-4813
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Reporter: Wai
> Assignee: Jacques Le Roux
> Attachments: ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif
>
>
> 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user.
> 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message.
> 3. All ajax dialogs are on the left of browser window.
> A number of fixes have been implemented for this issue.
> 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup.
> 2. At session timeout, clicking on ajax dialog button will cause alert window to popup.
> 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner.
> 4. Now all ajax dialogs are centered.
> 5. Change session timeout message to something more detailed.
> 6. Server response to ajax request now contain html tags.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256038#comment-13256038 ]

Jacques Le Roux commented on OFBIZ-4813:
----------------------------------------

Sounds good,I will wait a timeout to check before committing. I wonder if we should not also replace the Tomahawk spinner?

> ajax autocomplete and dialog during session timeout
> ---------------------------------------------------
>
> Key: OFBIZ-4813
> URL: https://issues.apache.org/jira/browse/OFBIZ-4813
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Reporter: Wai
> Assignee: Jacques Le Roux
> Attachments: ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif
>
>
> 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user.
> 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message.
> 3. All ajax dialogs are on the left of browser window.
> A number of fixes have been implemented for this issue.
> 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup.
> 2. At session timeout, clicking on ajax dialog button will cause alert window to popup.
> 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner.
> 4. Now all ajax dialogs are centered.
> 5. Change session timeout message to something more detailed.
> 6. Server response to ajax request now contain html tags.

Nicolas Malin (Jira)

[jira] [Closed] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4813.
----------------------------------

Resolution: Fixed
Fix Version/s: SVN trunk

Thanks Wai,

Your modified patch is in trunk r1327502

What I adapted:
* Added <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/> in htmlheader-for-ajax.ftl
* Replaced also spinner.gif in Tomahawk (better be consistent)
* Added a French label an kept those existing but English (improved now)
* Removed the ajaxErrorText style in ajaxNotLoggedIn screen

For ajaxErrorText, maybe you forgot to provide it?

I did not backport to release (would be only R11.04) because it's not really a bug but more an improvement.

> ajax autocomplete and dialog during session timeout
> ---------------------------------------------------
>
> Key: OFBIZ-4813
> URL: https://issues.apache.org/jira/browse/OFBIZ-4813
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Reporter: Wai
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif
>
>
> 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user.
> 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message.
> 3. All ajax dialogs are on the left of browser window.
> A number of fixes have been implemented for this issue.
> 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup.
> 2. At session timeout, clicking on ajax dialog button will cause alert window to popup.
> 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner.
> 4. Now all ajax dialogs are centered.
> 5. Change session timeout message to something more detailed.
> 6. Server response to ajax request now contain html tags.

Nicolas Malin (Jira)

[jira] [Reopened] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wai reopened OFBIZ-4813:
------------------------

Jacques,

I did a quick check of the commit for this issue and discovered the following problems:

1. When ajaxErrorText style was removed, it uncovered a flaw in the regex pattern AJAX_SERVER_REPLY_MSG_REGEXPATTERN in selectall.js. As a result, the proper alert was not showing. It is now fixed.
2. I noticed that changes in the relevant css files were not made. As a result the spinner is showing a horizontal repeat. This has been corrected.
3. Tomahawk themes/tomahawk/webapp/tomahawk/images/spinner.gif is now removed framework/images/webapp/images.spinner.gif will be used by all themes in order for the same consistent spinner image to be used.

The supplied patch fixes these problems.

Thanks,
Wai

> ajax autocomplete and dialog during session timeout
> ---------------------------------------------------
>
> Key: OFBIZ-4813
> URL: https://issues.apache.org/jira/browse/OFBIZ-4813
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Reporter: Wai
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif
>
>
> 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user.
> 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message.
> 3. All ajax dialogs are on the left of browser window.
> A number of fixes have been implemented for this issue.
> 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup.
> 2. At session timeout, clicking on ajax dialog button will cause alert window to popup.
> 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner.
> 4. Now all ajax dialogs are centered.
> 5. Change session timeout message to something more detailed.
> 6. Server response to ajax request now contain html tags.

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wai updated OFBIZ-4813:
-----------------------

Attachment: ofbiz-4813-additional.patch

This is a supplementary patch to be applied to the trunk to fix the issues observed after the commit.

Note: please delete themes/tomahawk/webapp/tomahawk/images/spinner.gif

Thanks,
Wai

> ajax autocomplete and dialog during session timeout
> ---------------------------------------------------
>
> Key: OFBIZ-4813
> URL: https://issues.apache.org/jira/browse/OFBIZ-4813
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Reporter: Wai
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif
>
>
> 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user.
> 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message.
> 3. All ajax dialogs are on the left of browser window.
> A number of fixes have been implemented for this issue.
> 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup.
> 2. At session timeout, clicking on ajax dialog button will cause alert window to popup.
> 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner.
> 4. Now all ajax dialogs are centered.
> 5. Change session timeout message to something more detailed.
> 6. Server response to ajax request now contain html tags.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257840#comment-13257840 ]

Jacques Le Roux commented on OFBIZ-4813:
----------------------------------------

Wai,

Are you sure that removing the spinner in Tomahawk works? Here it does not it seems...

Also I did not see any spinner repeated before. Is there a specific use case to reproduce?

> ajax autocomplete and dialog during session timeout
> ---------------------------------------------------
>
> Key: OFBIZ-4813
> URL: https://issues.apache.org/jira/browse/OFBIZ-4813
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Reporter: Wai
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif
>
>
> 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user.
> 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message.
> 3. All ajax dialogs are on the left of browser window.
> A number of fixes have been implemented for this issue.
> 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup.
> 2. At session timeout, clicking on ajax dialog button will cause alert window to popup.
> 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner.
> 4. Now all ajax dialogs are centered.
> 5. Change session timeout message to something more detailed.
> 6. Server response to ajax request now contain html tags.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258121#comment-13258121 ]

Jacques Le Roux commented on OFBIZ-4813:
----------------------------------------

I guess for the spinner in Tomahawk you need to check the Theme setting (path to images). But then it gets maybe more complicated and it's easier to keep the duplicated gif.

About AJAX_SERVER_REPLY_MSG_REGEXPATTERN. I'd prefer to keep the message in the layered popup instead of in an alert box, except if you want to resolve the i18n issue: just try with French to see what I mean...

> ajax autocomplete and dialog during session timeout
> ---------------------------------------------------
>
> Key: OFBIZ-4813
> URL: https://issues.apache.org/jira/browse/OFBIZ-4813
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Reporter: Wai
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif
>
>
> 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user.
> 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message.
> 3. All ajax dialogs are on the left of browser window.
> A number of fixes have been implemented for this issue.
> 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup.
> 2. At session timeout, clicking on ajax dialog button will cause alert window to popup.
> 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner.
> 4. Now all ajax dialogs are centered.
> 5. Change session timeout message to something more detailed.
> 6. Server response to ajax request now contain html tags.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258274#comment-13258274 ]

Wai commented on OFBIZ-4813:
----------------------------

Jacques,

Point#1:

Regarding Tomahawk spinner image. You need to modify themes/tomahawk/webapp/tomahawk/css/style.css with the following changes specified in the patch "ofbiz-4813-additional.patch". If not, the spinner.gif inside the themes subdirectory would be used. That's why the #wait-spinner-image style specifies /images/spinner.gif as the target image to use and not /tomahawk/images/spinner.gif. To be consistent, all themes use /images/spinner.gif as the spinner image.

#wait-spinner-image {
height:45px;
width:45px;
background-repeat: no-repeat;
background-image:url(/images/spinner.gif);
}

Note: The previous patch "ofbiz-4813patch" already contained the changes to the css files. I do not know why it was not committed with the rest of the code changes? "ofbiz-4813-additional.patch" was provided to address that.

Point#2:

Regarding i18n issue for the popup alert. The alert has no problem showing the french message. The problem is on the server side. It is sending english regardless of what the user's currently selected locale is. I can create a jira report on that and find some time to fix it. In my opinion, an alert is more appropriate as it is a session wide phenomena that needs to be handled immediately. Hence a modal alert, front and center, seem more appropriate. Nevertheless, whatever you decide is good.

Point#3:

Regarding the double spinner image, you can see it in https://demo-trunk.ofbiz.apache.org:8443/catalog/control/EditProduct?productId=GZ-1000 and click on the appropriate button to see the double spinner image.

Again, "ofbiz-4813patch" already contained this change but was not committed. "ofbiz-4813-additional.patch" was provided to address that.

Thanks,
Wai

> ajax autocomplete and dialog during session timeout
> ---------------------------------------------------
>
> Key: OFBIZ-4813
> URL: https://issues.apache.org/jira/browse/OFBIZ-4813
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Reporter: Wai
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif
>
>
> 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user.
> 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message.
> 3. All ajax dialogs are on the left of browser window.
> A number of fixes have been implemented for this issue.
> 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup.
> 2. At session timeout, clicking on ajax dialog button will cause alert window to popup.
> 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner.
> 4. Now all ajax dialogs are centered.
> 5. Change session timeout message to something more detailed.
> 6. Server response to ajax request now contain html tags.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258276#comment-13258276 ]

Wai commented on OFBIZ-4813:
----------------------------

One more thing. To see the double spinner image, you need to select any theme other than tomahawk. At least until the patch as been committed.
Thanks,
Wai

> ajax autocomplete and dialog during session timeout
> ---------------------------------------------------
>
> Key: OFBIZ-4813
> URL: https://issues.apache.org/jira/browse/OFBIZ-4813
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Reporter: Wai
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif
>
>
> 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user.
> 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message.
> 3. All ajax dialogs are on the left of browser window.
> A number of fixes have been implemented for this issue.
> 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup.
> 2. At session timeout, clicking on ajax dialog button will cause alert window to popup.
> 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner.
> 4. Now all ajax dialogs are centered.
> 5. Change session timeout message to something more detailed.
> 6. Server response to ajax request now contain html tags.

Nicolas Malin (Jira)

[jira] [Issue Comment Edited] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258274#comment-13258274 ]

Wai edited comment on OFBIZ-4813 at 4/20/12 2:33 PM:
-----------------------------------------------------

Jacques,

Point#1:

Regarding Tomahawk spinner image. You need to modify themes/tomahawk/webapp/tomahawk/css/style.css with the following changes specified in the patch "ofbiz-4813-additional.patch". If not, the spinner.gif inside the themes subdirectory would be used. That's why the #wait-spinner-image style specifies /images/spinner.gif as the target image to use and not /tomahawk/images/spinner.gif. To be consistent, all themes use /images/spinner.gif as the spinner image.

{code}
#wait-spinner-image {
height:45px;
width:45px;
background-repeat: no-repeat;
background-image:url(/images/spinner.gif);
}
{code}

Note: The previous patch "ofbiz-4813patch" already contained the changes to the css files. I do not know why it was not committed with the rest of the code changes? "ofbiz-4813-additional.patch" was provided to address that.

Point#2:

Regarding i18n issue for the popup alert. The alert has no problem showing the french message. The problem is on the server side. It is sending english regardless of what the user's currently selected locale is. I can create a jira report on that and find some time to fix it. In my opinion, an alert is more appropriate as it is a session wide phenomena that needs to be handled immediately. Hence a modal alert, front and center, seem more appropriate. Nevertheless, whatever you decide is good.

Point#3:

Regarding the double spinner image, you can see it in https://demo-trunk.ofbiz.apache.org:8443/catalog/control/EditProduct?productId=GZ-1000 and click on the appropriate button to see the double spinner image.

Again, "ofbiz-4813patch" already contained this change but was not committed. "ofbiz-4813-additional.patch" was provided to address that.

Thanks,
Wai

was (Author: wt):
Jacques,

Point#1:

Regarding Tomahawk spinner image. You need to modify themes/tomahawk/webapp/tomahawk/css/style.css with the following changes specified in the patch "ofbiz-4813-additional.patch". If not, the spinner.gif inside the themes subdirectory would be used. That's why the #wait-spinner-image style specifies /images/spinner.gif as the target image to use and not /tomahawk/images/spinner.gif. To be consistent, all themes use /images/spinner.gif as the spinner image.

#wait-spinner-image {
height:45px;
width:45px;
background-repeat: no-repeat;
background-image:url(/images/spinner.gif);
}

Note: The previous patch "ofbiz-4813patch" already contained the changes to the css files. I do not know why it was not committed with the rest of the code changes? "ofbiz-4813-additional.patch" was provided to address that.

Point#2:

Regarding i18n issue for the popup alert. The alert has no problem showing the french message. The problem is on the server side. It is sending english regardless of what the user's currently selected locale is. I can create a jira report on that and find some time to fix it. In my opinion, an alert is more appropriate as it is a session wide phenomena that needs to be handled immediately. Hence a modal alert, front and center, seem more appropriate. Nevertheless, whatever you decide is good.

Point#3:

Regarding the double spinner image, you can see it in https://demo-trunk.ofbiz.apache.org:8443/catalog/control/EditProduct?productId=GZ-1000 and click on the appropriate button to see the double spinner image.

Again, "ofbiz-4813patch" already contained this change but was not committed. "ofbiz-4813-additional.patch" was provided to address that.

Thanks,
Wai

> ajax autocomplete and dialog during session timeout
> ---------------------------------------------------
>
> Key: OFBIZ-4813
> URL: https://issues.apache.org/jira/browse/OFBIZ-4813
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Reporter: Wai
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif
>
>
> 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user.
> 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message.
> 3. All ajax dialogs are on the left of browser window.
> A number of fixes have been implemented for this issue.
> 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup.
> 2. At session timeout, clicking on ajax dialog button will cause alert window to popup.
> 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner.
> 4. Now all ajax dialogs are centered.
> 5. Change session timeout message to something more detailed.
> 6. Server response to ajax request now contain html tags.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258289#comment-13258289 ]

Jacques Le Roux commented on OFBIZ-4813:
----------------------------------------

Wai,

Of course this was after applying the additional patch

# So I have this change in the css, else I'd not speak about it as an issue
# It's clearly showing the French message and accents are not handled. I quickly tried some workaounds and gave up. Accents are handled when the message is shown in the layered popup, that's why I did not want to waste too much time on it. In the popup is ok with me, not need for an alert box
# Seems that it depends on theme, I did not see it with Tomahawk but yes with others it shows

> ajax autocomplete and dialog during session timeout
> ---------------------------------------------------
>
> Key: OFBIZ-4813
> URL: https://issues.apache.org/jira/browse/OFBIZ-4813
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Reporter: Wai
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif
>
>
> 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user.
> 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message.
> 3. All ajax dialogs are on the left of browser window.
> A number of fixes have been implemented for this issue.
> 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup.
> 2. At session timeout, clicking on ajax dialog button will cause alert window to popup.
> 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner.
> 4. Now all ajax dialogs are centered.
> 5. Change session timeout message to something more detailed.
> 6. Server response to ajax request now contain html tags.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258291#comment-13258291 ]

Jacques Le Roux commented on OFBIZ-4813:
----------------------------------------

Of course, for the point 1, I removed the spinner from Tomahawk and it does not show, at least here...

> ajax autocomplete and dialog during session timeout
> ---------------------------------------------------
>
> Key: OFBIZ-4813
> URL: https://issues.apache.org/jira/browse/OFBIZ-4813
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Reporter: Wai
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif
>
>
> 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user.
> 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message.
> 3. All ajax dialogs are on the left of browser window.
> A number of fixes have been implemented for this issue.
> 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup.
> 2. At session timeout, clicking on ajax dialog button will cause alert window to popup.
> 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner.
> 4. Now all ajax dialogs are centered.
> 5. Change session timeout message to something more detailed.
> 6. Server response to ajax request now contain html tags.