[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258302#comment-13258302 ] Jacques Le Roux commented on OFBIZ-4813: ---------------------------------------- Oops, sorry I checked you are right for the Tomahawk spinner. I got conflict with your additional patch (certainly some hunk where already in) somehow I did not spot I had still background-image:url(/tomahawk/images/spinner.gif); One worry less ;) > ajax autocomplete and dialog during session timeout > --------------------------------------------------- > > Key: OFBIZ-4813 > URL: https://issues.apache.org/jira/browse/OFBIZ-4813 > Project: OFBiz > Issue Type: Bug > Components: framework > Reporter: Wai > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif > > > 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user. > 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message. > 3. All ajax dialogs are on the left of browser window. > A number of fixes have been implemented for this issue. > 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup. > 2. At session timeout, clicking on ajax dialog button will cause alert window to popup. > 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner. > 4. Now all ajax dialogs are centered. > 5. Change session timeout message to something more detailed. > 6. Server response to ajax request now contain html tags. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4813. ---------------------------------- Resolution: Fixed Hi Wai, At r1328738, I have applied your patch in trunk but commented out the lines {code} //default ajax request timeout in milliseconds var AJAX_REQUEST_TIMEOUT = 5000; ... //search for <span style="message...> returned from server var matchFound = data.toString().match(AJAX_SERVER_REPLY_MSG_REGEXPATTERN); if (matchFound != null) { alert(matchFound[1].trim()); response(null); return; } {code} This because: # I don't see any reasons to show the error message in an alert box rather than in the layered popup # In the alert box the special characters (French accents for instance) were not handled > ajax autocomplete and dialog during session timeout > --------------------------------------------------- > > Key: OFBIZ-4813 > URL: https://issues.apache.org/jira/browse/OFBIZ-4813 > Project: OFBiz > Issue Type: Bug > Components: framework > Reporter: Wai > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif > > > 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user. > 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message. > 3. All ajax dialogs are on the left of browser window. > A number of fixes have been implemented for this issue. > 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup. > 2. At session timeout, clicking on ajax dialog button will cause alert window to popup. > 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner. > 4. Now all ajax dialogs are centered. > 5. Change session timeout message to something more detailed. > 6. Server response to ajax request now contain html tags. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258955#comment-13258955 ] Jacques Le Roux commented on OFBIZ-4813: ---------------------------------------- Missed a part in fieldlookup.js at r1328738, committed at r1328743 > ajax autocomplete and dialog during session timeout > --------------------------------------------------- > > Key: OFBIZ-4813 > URL: https://issues.apache.org/jira/browse/OFBIZ-4813 > Project: OFBiz > Issue Type: Bug > Components: framework > Reporter: Wai > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif > > > 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user. > 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message. > 3. All ajax dialogs are on the left of browser window. > A number of fixes have been implemented for this issue. > 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup. > 2. At session timeout, clicking on ajax dialog button will cause alert window to popup. > 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner. > 4. Now all ajax dialogs are centered. > 5. Change session timeout message to something more detailed. > 6. Server response to ajax request now contain html tags. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260849#comment-13260849 ] Wai commented on OFBIZ-4813: ---------------------------- Jacques, I did a quick check and discovered that even when I set the active locale to French ("fr") and waited for a session timeout, the error message was still in English. Could you kindly verify whether this is the case at your end? Thanks, Wai > ajax autocomplete and dialog during session timeout > --------------------------------------------------- > > Key: OFBIZ-4813 > URL: https://issues.apache.org/jira/browse/OFBIZ-4813 > Project: OFBiz > Issue Type: Bug > Components: framework > Reporter: Wai > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif > > > 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user. > 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message. > 3. All ajax dialogs are on the left of browser window. > A number of fixes have been implemented for this issue. > 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup. > 2. At session timeout, clicking on ajax dialog button will cause alert window to popup. > 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner. > 4. Now all ajax dialogs are centered. > 5. Change session timeout message to something more detailed. > 6. Server response to ajax request now contain html tags. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261021#comment-13261021 ] Jacques Le Roux commented on OFBIZ-4813: ---------------------------------------- Wai, It works correctly here, I mean I see the French message. I guess it's then not related for this message to the choice in OFBiz, but the default locale. Not sure why though, because it's done from a screen, so should behave like the rest... > ajax autocomplete and dialog during session timeout > --------------------------------------------------- > > Key: OFBIZ-4813 > URL: https://issues.apache.org/jira/browse/OFBIZ-4813 > Project: OFBiz > Issue Type: Bug > Components: framework > Reporter: Wai > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif > > > 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user. > 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message. > 3. All ajax dialogs are on the left of browser window. > A number of fixes have been implemented for this issue. > 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup. > 2. At session timeout, clicking on ajax dialog button will cause alert window to popup. > 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner. > 4. Now all ajax dialogs are centered. > 5. Change session timeout message to something more detailed. > 6. Server response to ajax request now contain html tags. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264863#comment-13264863 ] yashwant dhakad commented on OFBIZ-4813: ---------------------------------------- Jacques, I think this should be backported in Release 11.04 as it is a bug. > ajax autocomplete and dialog during session timeout > --------------------------------------------------- > > Key: OFBIZ-4813 > URL: https://issues.apache.org/jira/browse/OFBIZ-4813 > Project: OFBiz > Issue Type: Bug > Components: framework > Reporter: Wai > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif > > > 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user. > 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message. > 3. All ajax dialogs are on the left of browser window. > A number of fixes have been implemented for this issue. > 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup. > 2. At session timeout, clicking on ajax dialog button will cause alert window to popup. > 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner. > 4. Now all ajax dialogs are centered. > 5. Change session timeout message to something more detailed. > 6. Server response to ajax request now contain html tags. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264877#comment-13264877 ] Jacques Le Roux commented on OFBIZ-4813: ---------------------------------------- Hi Yashwant, See my comment above: {quote} I did not backport to release (would be only R11.04) because it's not really a bug but more an improvement. {quote} I will though retry, and see if I should... > ajax autocomplete and dialog during session timeout > --------------------------------------------------- > > Key: OFBIZ-4813 > URL: https://issues.apache.org/jira/browse/OFBIZ-4813 > Project: OFBiz > Issue Type: Bug > Components: framework > Reporter: Wai > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif > > > 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user. > 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message. > 3. All ajax dialogs are on the left of browser window. > A number of fixes have been implemented for this issue. > 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup. > 2. At session timeout, clicking on ajax dialog button will cause alert window to popup. > 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner. > 4. Now all ajax dialogs are centered. > 5. Change session timeout message to something more detailed. > 6. Server response to ajax request now contain html tags. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264878#comment-13264878 ] Deepak Dixit commented on OFBIZ-4813: ------------------------------------- Jqcques, This is related to [OFBIZ-4753|https://issues.apache.org/jira/browse/OFBIZ-4753], If we back-ported this then issue reported at OFBIZ-4753 should be resolved. > ajax autocomplete and dialog during session timeout > --------------------------------------------------- > > Key: OFBIZ-4813 > URL: https://issues.apache.org/jira/browse/OFBIZ-4813 > Project: OFBiz > Issue Type: Bug > Components: framework > Reporter: Wai > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif > > > 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user. > 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message. > 3. All ajax dialogs are on the left of browser window. > A number of fixes have been implemented for this issue. > 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup. > 2. At session timeout, clicking on ajax dialog button will cause alert window to popup. > 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner. > 4. Now all ajax dialogs are centered. > 5. Change session timeout message to something more detailed. > 6. Server response to ajax request now contain html tags. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264896#comment-13264896 ] Jacques Le Roux commented on OFBIZ-4813: ---------------------------------------- Thanks Deepak, I will have a closer look... > ajax autocomplete and dialog during session timeout > --------------------------------------------------- > > Key: OFBIZ-4813 > URL: https://issues.apache.org/jira/browse/OFBIZ-4813 > Project: OFBiz > Issue Type: Bug > Components: framework > Reporter: Wai > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif > > > 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user. > 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message. > 3. All ajax dialogs are on the left of browser window. > A number of fixes have been implemented for this issue. > 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup. > 2. At session timeout, clicking on ajax dialog button will cause alert window to popup. > 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner. > 4. Now all ajax dialogs are centered. > 5. Change session timeout message to something more detailed. > 6. Server response to ajax request now contain html tags. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yashwant dhakad updated OFBIZ-4813: ----------------------------------- Attachment: OFBIZ-4813-R11.04.patch Here is the path for release 11.04 branch, ofbiz-4813.patch was not applied on release branch. > ajax autocomplete and dialog during session timeout > --------------------------------------------------- > > Key: OFBIZ-4813 > URL: https://issues.apache.org/jira/browse/OFBIZ-4813 > Project: OFBiz > Issue Type: Bug > Components: framework > Reporter: Wai > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: OFBIZ-4813-R11.04.patch, ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif > > > 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user. > 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message. > 3. All ajax dialogs are on the left of browser window. > A number of fixes have been implemented for this issue. > 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup. > 2. At session timeout, clicking on ajax dialog button will cause alert window to popup. > 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner. > 4. Now all ajax dialogs are centered. > 5. Change session timeout message to something more detailed. > 6. Server response to ajax request now contain html tags. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-4813: ------------------------------------ Mmm, there are conflicts, will see later... > ajax autocomplete and dialog during session timeout > --------------------------------------------------- > > Key: OFBIZ-4813 > URL: https://issues.apache.org/jira/browse/OFBIZ-4813 > Project: OFBiz > Issue Type: Bug > Components: framework > Reporter: Wai > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: OFBIZ-4813-R11.04.patch, ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif > > > 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user. > 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message. > 3. All ajax dialogs are on the left of browser window. > A number of fixes have been implemented for this issue. > 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup. > 2. At session timeout, clicking on ajax dialog button will cause alert window to popup. > 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner. > 4. Now all ajax dialogs are centered. > 5. Change session timeout message to something more detailed. > 6. Server response to ajax request now contain html tags. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265122#comment-13265122 ] Jacques Le Roux commented on OFBIZ-4813: ---------------------------------------- Ha sorry Yashwant, missed your patch (actually I saw it 1st time and did not find it afterward so tried to backport) > ajax autocomplete and dialog during session timeout > --------------------------------------------------- > > Key: OFBIZ-4813 > URL: https://issues.apache.org/jira/browse/OFBIZ-4813 > Project: OFBiz > Issue Type: Bug > Components: framework > Reporter: Wai > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: OFBIZ-4813-R11.04.patch, ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif > > > 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user. > 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message. > 3. All ajax dialogs are on the left of browser window. > A number of fixes have been implemented for this issue. > 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup. > 2. At session timeout, clicking on ajax dialog button will cause alert window to popup. > 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner. > 4. Now all ajax dialogs are centered. > 5. Change session timeout message to something more detailed. > 6. Server response to ajax request now contain html tags. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4813. ---------------------------------- Resolution: Fixed Fix Version/s: Release Branch 11.04 Thanks Yashwant, Your A modified patch is in R11.04 at r What I changed: * Added <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/> in htmlheader-for-ajax.ftl * Added a French label an kept those existing but English (improved now) * Removed some added parts in patch of fieldlookup.js and selectall.js (like I did in trunk, those related to AJAX_SERVER_REPLY_MSG_REGEXPATTERN, because of not handled UTF8 chars in alert box) * Added the new spinner.gif and replaced /tomahawk/images/spinner.gif to /images/spinner.gif in tomahawk/css/style.css I just found another weird behaviour/bug (also in trunk) and I guess specifically related to these changes. If just after using the layered lookup you disconnect by opening another browser tab and change the languague on the tab you just clicked (it's still possible either on this tab or on the new one with the login screen), then you get a blank page with only the CommonSessionTimeoutPleaseLogIn on screen and you are stuck unless you use the browser back button. I guess since the back button allows you to get out of this dead end situation it's ok, but still weird... > ajax autocomplete and dialog during session timeout > --------------------------------------------------- > > Key: OFBIZ-4813 > URL: https://issues.apache.org/jira/browse/OFBIZ-4813 > Project: OFBiz > Issue Type: Bug > Components: framework > Reporter: Wai > Assignee: Jacques Le Roux > Fix For: Release Branch 11.04, SVN trunk > > Attachments: OFBIZ-4813-R11.04.patch, ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif > > > 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user. > 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message. > 3. All ajax dialogs are on the left of browser window. > A number of fixes have been implemented for this issue. > 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup. > 2. At session timeout, clicking on ajax dialog button will cause alert window to popup. > 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner. > 4. Now all ajax dialogs are centered. > 5. Change session timeout message to something more detailed. > 6. Server response to ajax request now contain html tags. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265152#comment-13265152 ] Jacques Le Roux edited comment on OFBIZ-4813 at 4/30/12 7:52 PM: ----------------------------------------------------------------- Thanks Yashwant, ==== EDIT : forgot the revision number =========== Your A modified patch is in R11.04 at r1332358 What I changed: * Added <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/> in htmlheader-for-ajax.ftl * Added a French label an kept those existing but English (improved now) * Removed some added parts in patch of fieldlookup.js and selectall.js (like I did in trunk, those related to AJAX_SERVER_REPLY_MSG_REGEXPATTERN, because of not handled UTF8 chars in alert box) * Added the new spinner.gif and replaced /tomahawk/images/spinner.gif to /images/spinner.gif in tomahawk/css/style.css I just found another weird behaviour/bug (also in trunk) and I guess specifically related to these changes. If just after using the layered lookup you disconnect by opening another browser tab and change the languague on the tab you just clicked (it's still possible either on this tab or on the new one with the login screen), then you get a blank page with only the CommonSessionTimeoutPleaseLogIn on screen and you are stuck unless you use the browser back button. I guess since the back button allows you to get out of this dead end situation it's ok, but still weird... was (Author: jacques.le.roux): Thanks Yashwant, Your A modified patch is in R11.04 at r What I changed: * Added <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/> in htmlheader-for-ajax.ftl * Added a French label an kept those existing but English (improved now) * Removed some added parts in patch of fieldlookup.js and selectall.js (like I did in trunk, those related to AJAX_SERVER_REPLY_MSG_REGEXPATTERN, because of not handled UTF8 chars in alert box) * Added the new spinner.gif and replaced /tomahawk/images/spinner.gif to /images/spinner.gif in tomahawk/css/style.css I just found another weird behaviour/bug (also in trunk) and I guess specifically related to these changes. If just after using the layered lookup you disconnect by opening another browser tab and change the languague on the tab you just clicked (it's still possible either on this tab or on the new one with the login screen), then you get a blank page with only the CommonSessionTimeoutPleaseLogIn on screen and you are stuck unless you use the browser back button. I guess since the back button allows you to get out of this dead end situation it's ok, but still weird... > ajax autocomplete and dialog during session timeout > --------------------------------------------------- > > Key: OFBIZ-4813 > URL: https://issues.apache.org/jira/browse/OFBIZ-4813 > Project: OFBiz > Issue Type: Bug > Components: framework > Reporter: Wai > Assignee: Jacques Le Roux > Fix For: Release Branch 11.04, SVN trunk > > Attachments: OFBIZ-4813-R11.04.patch, ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif > > > 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user. > 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message. > 3. All ajax dialogs are on the left of browser window. > A number of fixes have been implemented for this issue. > 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup. > 2. At session timeout, clicking on ajax dialog button will cause alert window to popup. > 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner. > 4. Now all ajax dialogs are centered. > 5. Change session timeout message to something more detailed. > 6. Server response to ajax request now contain html tags. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265625#comment-13265625 ] yashwant dhakad commented on OFBIZ-4813: ---------------------------------------- Thanks Jacques. > ajax autocomplete and dialog during session timeout > --------------------------------------------------- > > Key: OFBIZ-4813 > URL: https://issues.apache.org/jira/browse/OFBIZ-4813 > Project: OFBiz > Issue Type: Bug > Components: framework > Reporter: Wai > Assignee: Jacques Le Roux > Fix For: Release Branch 11.04, SVN trunk > > Attachments: OFBIZ-4813-R11.04.patch, ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif > > > 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user. > 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message. > 3. All ajax dialogs are on the left of browser window. > A number of fixes have been implemented for this issue. > 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup. > 2. At session timeout, clicking on ajax dialog button will cause alert window to popup. > 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner. > 4. Now all ajax dialogs are centered. > 5. Change session timeout message to something more detailed. > 6. Server response to ajax request now contain html tags. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274512#comment-13274512 ] Jacques Le Roux commented on OFBIZ-4813: ---------------------------------------- Thanks Amardeep, Your patch is in trunk r1338065 R12.04 r1338071 R11.04 r1338072 I actually created another Jira issue for that OFBIZ-4867, not a problem I will close it now. Also most of the time, especially with small bug fixes, no needs to provide a patch for each realease branches, the tools/mergefromtrunk scripts allow us to apply them automatically > ajax autocomplete and dialog during session timeout > --------------------------------------------------- > > Key: OFBIZ-4813 > URL: https://issues.apache.org/jira/browse/OFBIZ-4813 > Project: OFBiz > Issue Type: Bug > Components: framework > Reporter: Wai > Assignee: Jacques Le Roux > Fix For: Release Branch 11.04, SVN trunk > > Attachments: OFBIZ-4813-R11.04.patch, OFBIZ-4813-R11.04.patch, OFBIZ-4813-trunk.patch, ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif > > > 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user. > 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message. > 3. All ajax dialogs are on the left of browser window. > A number of fixes have been implemented for this issue. > 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup. > 2. At session timeout, clicking on ajax dialog button will cause alert window to popup. > 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner. > 4. Now all ajax dialogs are centered. > 5. Change session timeout message to something more detailed. > 6. Server response to ajax request now contain html tags. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274520#comment-13274520 ] Jacques Le Roux commented on OFBIZ-4813: ---------------------------------------- Amardeep's patch was completed in trunk r1338101 R12.04 r1338109 R11.04 r1338110 > ajax autocomplete and dialog during session timeout > --------------------------------------------------- > > Key: OFBIZ-4813 > URL: https://issues.apache.org/jira/browse/OFBIZ-4813 > Project: OFBiz > Issue Type: Bug > Components: framework > Reporter: Wai > Assignee: Jacques Le Roux > Fix For: Release Branch 11.04, SVN trunk > > Attachments: OFBIZ-4813-R11.04.patch, OFBIZ-4813-R11.04.patch, OFBIZ-4813-trunk.patch, ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif > > > 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user. > 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message. > 3. All ajax dialogs are on the left of browser window. > A number of fixes have been implemented for this issue. > 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup. > 2. At session timeout, clicking on ajax dialog button will cause alert window to popup. > 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner. > 4. Now all ajax dialogs are centered. > 5. Change session timeout message to something more detailed. > 6. Server response to ajax request now contain html tags. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274541#comment-13274541 ] Amardeep Singh Jhajj commented on OFBIZ-4813: --------------------------------------------- Thanks Jacques. > ajax autocomplete and dialog during session timeout > --------------------------------------------------- > > Key: OFBIZ-4813 > URL: https://issues.apache.org/jira/browse/OFBIZ-4813 > Project: OFBiz > Issue Type: Bug > Components: framework > Reporter: Wai > Assignee: Jacques Le Roux > Fix For: Release Branch 11.04, SVN trunk > > Attachments: OFBIZ-4813-R11.04.patch, OFBIZ-4813-R11.04.patch, OFBIZ-4813-trunk.patch, ofbiz-4813-additional.patch, ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif > > > 1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user. > 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message. > 3. All ajax dialogs are on the left of browser window. > A number of fixes have been implemented for this issue. > 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup. > 2. At session timeout, clicking on ajax dialog button will cause alert window to popup. > 3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner. > 4. Now all ajax dialogs are centered. > 5. Change session timeout message to something more detailed. > 6. Server response to ajax request now contain html tags. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
Free forum by Nabble | Edit this page |