OFBiz › OFBiz - Dev

[jira] [Created] (OFBIZ-4837) Separator Error in data file tools

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

7 messages Options

Nicolas Malin (Jira)

[jira] [Created] (OFBIZ-4837) Separator Error in data file tools

Gil Portenseigne created OFBIZ-4837:
---------------------------------------

Summary: Separator Error in data file tools
Key: OFBIZ-4837
URL: https://issues.apache.org/jira/browse/OFBIZ-4837
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Reporter: Gil Portenseigne
Priority: Minor

In https://demo-trunk.ofbiz.apache.org/webtools/control/viewdatafile

There is a bug when defining simple separator (for instance ",") in definition file, and when in data file a string data contains the separator. This one sould not be interpreted in data parsing.

To illustrate a bit more, i add small sample files to reproduce the problem.
And the patch which fix the bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4837) Separator Error in data file tools

[ https://issues.apache.org/jira/browse/OFBIZ-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gil Portenseigne updated OFBIZ-4837:
------------------------------------

Remaining Estimate: 0.5h (was: 5h)
Original Estimate: 0.5h (was: 5h)

> Separator Error in data file tools
> ----------------------------------
>
> Key: OFBIZ-4837
> URL: https://issues.apache.org/jira/browse/OFBIZ-4837
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Gil Portenseigne
> Priority: Minor
> Labels: data, parsing
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> In https://demo-trunk.ofbiz.apache.org/webtools/control/viewdatafile
> There is a bug when defining simple separator (for instance ",") in definition file, and when in data file a string data contains the separator. This one sould not be interpreted in data parsing.
> To illustrate a bit more, i add small sample files to reproduce the problem.
> And the patch which fix the bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4837) Separator Error in data file tools

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gil Portenseigne updated OFBIZ-4837:
------------------------------------

Attachment: result.xml
dataSample.csv
dataDefinition.xml
resultBefore.xml

definition and sample befor the fix give the resultBefore file.

With the fix, result.xml is obtained

> Separator Error in data file tools
> ----------------------------------
>
> Key: OFBIZ-4837
> URL: https://issues.apache.org/jira/browse/OFBIZ-4837
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Gil Portenseigne
> Priority: Minor
> Labels: data, parsing
> Attachments: dataDefinition.xml, dataSample.csv, result.xml, resultBefore.xml
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> In https://demo-trunk.ofbiz.apache.org/webtools/control/viewdatafile
> There is a bug when defining simple separator (for instance ",") in definition file, and when in data file a string data contains the separator. This one sould not be interpreted in data parsing.
> To illustrate a bit more, i add small sample files to reproduce the problem.
> And the patch which fix the bug.

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4837) Separator Error in data file tools

In reply to this post by Nicolas Malin (Jira)

> Separator Error in data file tools
> ----------------------------------
>
> Key: OFBIZ-4837
> URL: https://issues.apache.org/jira/browse/OFBIZ-4837
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Gil Portenseigne
> Priority: Minor
> Labels: data, parsing
> Attachments: OFBIZ-4837.patch, dataDefinition.xml, dataSample.csv, result.xml, resultBefore.xml
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> In https://demo-trunk.ofbiz.apache.org/webtools/control/viewdatafile
> There is a bug when defining simple separator (for instance ",") in definition file, and when in data file a string data contains the separator. This one sould not be interpreted in data parsing.
> To illustrate a bit more, i add small sample files to reproduce the problem.
> And the patch which fix the bug.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4837) Separator Error in data file tools

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259665#comment-13259665 ]

Gil Portenseigne commented on OFBIZ-4837:
-----------------------------------------

I didn't comment the code :
I add strVal != null, to avoid NPE
The while loop is here to concatene the string value until the ending string separator is found.

> Separator Error in data file tools
> ----------------------------------
>
> Key: OFBIZ-4837
> URL: https://issues.apache.org/jira/browse/OFBIZ-4837
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Gil Portenseigne
> Priority: Minor
> Labels: data, parsing
> Attachments: OFBIZ-4837.patch, dataDefinition.xml, dataSample.csv, result.xml, resultBefore.xml
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> In https://demo-trunk.ofbiz.apache.org/webtools/control/viewdatafile
> There is a bug when defining simple separator (for instance ",") in definition file, and when in data file a string data contains the separator. This one sould not be interpreted in data parsing.
> To illustrate a bit more, i add small sample files to reproduce the problem.
> And the patch which fix the bug.

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4837) Separator Error in data file tools

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gil Portenseigne updated OFBIZ-4837:
------------------------------------

Attachment: OFBIZ-4837_2.patch

Second version of patch taking care of specific case, when the separator is the first character after the string separator.

> Separator Error in data file tools
> ----------------------------------
>
> Key: OFBIZ-4837
> URL: https://issues.apache.org/jira/browse/OFBIZ-4837
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Gil Portenseigne
> Priority: Minor
> Labels: data, parsing
> Attachments: OFBIZ-4837.patch, OFBIZ-4837_2.patch, dataDefinition.xml, dataSample.csv, result.xml, resultBefore.xml
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> In https://demo-trunk.ofbiz.apache.org/webtools/control/viewdatafile
> There is a bug when defining simple separator (for instance ",") in definition file, and when in data file a string data contains the separator. This one sould not be interpreted in data parsing.
> To illustrate a bit more, i add small sample files to reproduce the problem.
> And the patch which fix the bug.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4837) Separator Error in data file tools

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259955#comment-13259955 ]

Erwan de FERRIERES commented on OFBIZ-4837:
-------------------------------------------

Hi Gil,

there is no need to rename your patches, Jira is directly deactivating the oldest one.
Also, maybe the best test to explain your work is to add unit tests.

thanks

> Separator Error in data file tools
> ----------------------------------
>
> Key: OFBIZ-4837
> URL: https://issues.apache.org/jira/browse/OFBIZ-4837
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Gil Portenseigne
> Priority: Minor
> Labels: data, parsing
> Attachments: OFBIZ-4837.patch, OFBIZ-4837_2.patch, dataDefinition.xml, dataSample.csv, result.xml, resultBefore.xml
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> In https://demo-trunk.ofbiz.apache.org/webtools/control/viewdatafile
> There is a bug when defining simple separator (for instance ",") in definition file, and when in data file a string data contains the separator. This one sould not be interpreted in data parsing.
> To illustrate a bit more, i add small sample files to reproduce the problem.
> And the patch which fix the bug.