[jira] [Created] (OFBIZ-4865) Exception there when trying to update order's "Shipping Destination Address"

[Nicolas Malin (Jira)]

Leon created OFBIZ-4865:
---------------------------

             Summary: Exception there when trying to update order's "Shipping Destination Address"
                 Key: OFBIZ-4865
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4865
             Project: OFBiz
          Issue Type: Bug
          Components: order
    Affects Versions: SVN trunk
            Reporter: Leon


If click the "update" button of "Shipping Destination Address" in order view page, an exception thrown out as:
{quote}
The Following Errors Occurred:

BeanShell execution caused an error: Sourced file: inline evaluation of: `` shipmentMethod = parameters.get("shipmentMethod"); if(s . . . ''
{quote}

I'm not familiar with beanshell and the mechanism of how ofbiz handling it, but I'm sure that there'no such error days ago.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271111#comment-13271111 ]

Jacopo Cappellato commented on OFBIZ-4865:
------------------------------------------

could you please try to replace "${bsh:" with "${groovy:" in the script let that is throwing the error?


               

> Exception there when trying to update order's "Shipping Destination Address"
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4865
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4865
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>
> If click the "update" button of "Shipping Destination Address" in order view page, an exception thrown out as:
> {quote}
> The Following Errors Occurred:
> BeanShell execution caused an error: Sourced file: inline evaluation of: `` shipmentMethod = parameters.get("shipmentMethod"); if(s . . . ''
> {quote}
> I'm not familiar with beanshell and the mechanism of how ofbiz handling it, but I'm sure that there'no such error days ago.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271142#comment-13271142 ]

Ankit Jain commented on OFBIZ-4865:
-----------------------------------

This is happening because of the below code in "updateOrderItemShipGroup" service.

        <call-bsh><![CDATA[
            shipmentMethod = parameters.get("shipmentMethod");
            if(shipmentMethod != null){
               arr = shipmentMethod.split( "@" );
               parameters.put("shipmentMethodTypeId", arr[0]);
               parameters.put("carrierPartyId", arr[1]);
               parameters.put("carrierRoleTypeId", arr[2]);
            }
        ]]></call-bsh>
               

> Exception there when trying to update order's "Shipping Destination Address"
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4865
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4865
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>
> If click the "update" button of "Shipping Destination Address" in order view page, an exception thrown out as:
> {quote}
> The Following Errors Occurred:
> BeanShell execution caused an error: Sourced file: inline evaluation of: `` shipmentMethod = parameters.get("shipmentMethod"); if(s . . . ''
> {quote}
> I'm not familiar with beanshell and the mechanism of how ofbiz handling it, but I'm sure that there'no such error days ago.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271909#comment-13271909 ]

Paul Foxworthy commented on OFBIZ-4865:
---------------------------------------

There was a change for OFBIZ-4389, trunk r1167116, to include the carrierRoleTypeId here. The carrierRoleTypeId should be present, because the ftl in r1167116 puts it there.

It's possible that the exception is due to a missing carrierRoleTypeId. If as you say the problem occurs in trunk, I suspect you are doing something slightly different to me when I tested my patch.

Can you confirm that carrierRoleTypeId is indeed missing, i.e. there are not two @ characters in the shipmentMethod parameter?

I believe it should be there, because

https://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl?hb=true#to255

puts it there.

If it's missing, do a View Source in the browser and check what's listed in the options within the shipmentMethod.

Can you reproduce the problem on the demo site?

Cheers

Paul Foxworthy
               

> Exception there when trying to update order's "Shipping Destination Address"
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4865
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4865
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>
> If click the "update" button of "Shipping Destination Address" in order view page, an exception thrown out as:
> {quote}
> The Following Errors Occurred:
> BeanShell execution caused an error: Sourced file: inline evaluation of: `` shipmentMethod = parameters.get("shipmentMethod"); if(s . . . ''
> {quote}
> I'm not familiar with beanshell and the mechanism of how ofbiz handling it, but I'm sure that there'no such error days ago.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276237#comment-13276237 ]

Jacques Le Roux commented on OFBIZ-4865:
----------------------------------------

Hi Leon,

Please try to reproduce on trunk demo as suggested by Paul

Thanks
               

> Exception there when trying to update order's "Shipping Destination Address"
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4865
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4865
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>
> If click the "update" button of "Shipping Destination Address" in order view page, an exception thrown out as:
> {quote}
> The Following Errors Occurred:
> BeanShell execution caused an error: Sourced file: inline evaluation of: `` shipmentMethod = parameters.get("shipmentMethod"); if(s . . . ''
> {quote}
> I'm not familiar with beanshell and the mechanism of how ofbiz handling it, but I'm sure that there'no such error days ago.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leon updated OFBIZ-4865:
------------------------

    Attachment: OFBIZ-4856.patch
   

> Exception there when trying to update order's "Shipping Destination Address"
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4865
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4865
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>         Attachments: OFBIZ-4856.patch
>
>
> If click the "update" button of "Shipping Destination Address" in order view page, an exception thrown out as:
> {quote}
> The Following Errors Occurred:
> BeanShell execution caused an error: Sourced file: inline evaluation of: `` shipmentMethod = parameters.get("shipmentMethod"); if(s . . . ''
> {quote}
> I'm not familiar with beanshell and the mechanism of how ofbiz handling it, but I'm sure that there'no such error days ago.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276739#comment-13276739 ]

Leon commented on OFBIZ-4865:
-----------------------------

I searched the log and find the root cause is "java.lang.ArrayIndexOutOfBoundsException" from bsh script. As Paul told, there should be at least two "@" chars in "shipmentmethod" value. So I guess maybe somewhere "@" is missing. I tried to lookup for codes which construct parameters map for calling, and fortunately, I found it.

See attached patch for detail.

Thanks you all.
               

> Exception there when trying to update order's "Shipping Destination Address"
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4865
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4865
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>         Attachments: OFBIZ-4856.patch
>
>
> If click the "update" button of "Shipping Destination Address" in order view page, an exception thrown out as:
> {quote}
> The Following Errors Occurred:
> BeanShell execution caused an error: Sourced file: inline evaluation of: `` shipmentMethod = parameters.get("shipmentMethod"); if(s . . . ''
> {quote}
> I'm not familiar with beanshell and the mechanism of how ofbiz handling it, but I'm sure that there'no such error days ago.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276744#comment-13276744 ]

Adrian Crum commented on OFBIZ-4865:
------------------------------------

Leon - I think you attached the wrong patch file.
               

> Exception there when trying to update order's "Shipping Destination Address"
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4865
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4865
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>         Attachments: OFBIZ-4856.patch
>
>
> If click the "update" button of "Shipping Destination Address" in order view page, an exception thrown out as:
> {quote}
> The Following Errors Occurred:
> BeanShell execution caused an error: Sourced file: inline evaluation of: `` shipmentMethod = parameters.get("shipmentMethod"); if(s . . . ''
> {quote}
> I'm not familiar with beanshell and the mechanism of how ofbiz handling it, but I'm sure that there'no such error days ago.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leon updated OFBIZ-4865:
------------------------

    Attachment:     (was: OFBIZ-4856.patch)
   

> Exception there when trying to update order's "Shipping Destination Address"
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4865
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4865
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>         Attachments: OFBIZ-4865.patch
>
>
> If click the "update" button of "Shipping Destination Address" in order view page, an exception thrown out as:
> {quote}
> The Following Errors Occurred:
> BeanShell execution caused an error: Sourced file: inline evaluation of: `` shipmentMethod = parameters.get("shipmentMethod"); if(s . . . ''
> {quote}
> I'm not familiar with beanshell and the mechanism of how ofbiz handling it, but I'm sure that there'no such error days ago.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leon updated OFBIZ-4865:
------------------------

    Attachment: OFBIZ-4865.patch
   

> Exception there when trying to update order's "Shipping Destination Address"
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4865
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4865
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>         Attachments: OFBIZ-4865.patch
>
>
> If click the "update" button of "Shipping Destination Address" in order view page, an exception thrown out as:
> {quote}
> The Following Errors Occurred:
> BeanShell execution caused an error: Sourced file: inline evaluation of: `` shipmentMethod = parameters.get("shipmentMethod"); if(s . . . ''
> {quote}
> I'm not familiar with beanshell and the mechanism of how ofbiz handling it, but I'm sure that there'no such error days ago.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276800#comment-13276800 ]

Leon commented on OFBIZ-4865:
-----------------------------

Adrian,  Sorry for that. This one is correct.
               

> Exception there when trying to update order's "Shipping Destination Address"
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4865
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4865
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>         Attachments: OFBIZ-4865.patch
>
>
> If click the "update" button of "Shipping Destination Address" in order view page, an exception thrown out as:
> {quote}
> The Following Errors Occurred:
> BeanShell execution caused an error: Sourced file: inline evaluation of: `` shipmentMethod = parameters.get("shipmentMethod"); if(s . . . ''
> {quote}
> I'm not familiar with beanshell and the mechanism of how ofbiz handling it, but I'm sure that there'no such error days ago.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277263#comment-13277263 ]

Paul Foxworthy commented on OFBIZ-4865:
---------------------------------------

Thanks Leon.

My apologies for missing the call to updateOrderItemShipGroup from the updateOrderContactMech service in my OFBIZ-4389 patch.
               

> Exception there when trying to update order's "Shipping Destination Address"
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4865
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4865
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>         Attachments: OFBIZ-4865.patch
>
>
> If click the "update" button of "Shipping Destination Address" in order view page, an exception thrown out as:
> {quote}
> The Following Errors Occurred:
> BeanShell execution caused an error: Sourced file: inline evaluation of: `` shipmentMethod = parameters.get("shipmentMethod"); if(s . . . ''
> {quote}
> I'm not familiar with beanshell and the mechanism of how ofbiz handling it, but I'm sure that there'no such error days ago.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277659#comment-13277659 ]

Ankit Jain commented on OFBIZ-4865:
-----------------------------------

Adrian,

I think it is because of Script changes, previously I found this type of issue in forms also.
               

> Exception there when trying to update order's "Shipping Destination Address"
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4865
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4865
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>         Attachments: OFBIZ-4865.patch
>
>
> If click the "update" button of "Shipping Destination Address" in order view page, an exception thrown out as:
> {quote}
> The Following Errors Occurred:
> BeanShell execution caused an error: Sourced file: inline evaluation of: `` shipmentMethod = parameters.get("shipmentMethod"); if(s . . . ''
> {quote}
> I'm not familiar with beanshell and the mechanism of how ofbiz handling it, but I'm sure that there'no such error days ago.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4865.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release 09.04
                   Release Branch 12.04
                   SVN trunk
                   Release Branch 11.04
                   Release Branch 10.04
         Assignee: Jacques Le Roux

Thanks Leon and Paul,

Leon your patch is in
trunk r1340352
R12.04 r1340355
R11.04 r1340354
R10.04 r1340356
R09.04 r1340353 (because of OFBIZ-4389)


               

> Exception there when trying to update order's "Shipping Destination Address"
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4865
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4865
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04, Release 09.04
>
>         Attachments: OFBIZ-4865.patch
>
>
> If click the "update" button of "Shipping Destination Address" in order view page, an exception thrown out as:
> {quote}
> The Following Errors Occurred:
> BeanShell execution caused an error: Sourced file: inline evaluation of: `` shipmentMethod = parameters.get("shipmentMethod"); if(s . . . ''
> {quote}
> I'm not familiar with beanshell and the mechanism of how ofbiz handling it, but I'm sure that there'no such error days ago.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279453#comment-13279453 ]

Jacques Le Roux commented on OFBIZ-4865:
----------------------------------------

Forgot Ankit and Adrian, thanks!
               

> Exception there when trying to update order's "Shipping Destination Address"
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4865
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4865
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>             Fix For: Release 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04
>
>         Attachments: OFBIZ-4865.patch
>
>
> If click the "update" button of "Shipping Destination Address" in order view page, an exception thrown out as:
> {quote}
> The Following Errors Occurred:
> BeanShell execution caused an error: Sourced file: inline evaluation of: `` shipmentMethod = parameters.get("shipmentMethod"); if(s . . . ''
> {quote}
> I'm not familiar with beanshell and the mechanism of how ofbiz handling it, but I'm sure that there'no such error days ago.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira