[jira] [Created] (OFBIZ-4883) getOrders() in OrderListState does not work

[Nicolas Malin (Jira)]

Chatree Srichart created OFBIZ-4883:
---------------------------------------

             Summary: getOrders() in OrderListState does not work
                 Key: OFBIZ-4883
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4883
             Project: OFBiz
          Issue Type: Bug
          Components: order
    Affects Versions: SVN trunk
         Environment: Ubuntu 10.04
            Reporter: Chatree Srichart


Hi all,

I see the status conditions in the OrderListState.getOrders() method is wrong because it should iterate statuses from orderStatusState instead of orderFilterState.

Regards,
Chatree Srichart

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chatree Srichart updated OFBIZ-4883:
------------------------------------

    Attachment: FixOrderStatus.diff
   

> getOrders() in OrderListState does not work
> -------------------------------------------
>
>                 Key: OFBIZ-4883
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4883
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Ubuntu 10.04
>            Reporter: Chatree Srichart
>         Attachments: FixOrderStatus.diff
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Hi all,
> I see the status conditions in the OrderListState.getOrders() method is wrong because it should iterate statuses from orderStatusState instead of orderFilterState.
> Regards,
> Chatree Srichart

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279736#comment-13279736 ]

Jacques Le Roux commented on OFBIZ-4883:
----------------------------------------

From quick review you seems right, but could you show an use case with a related problem?
               

> getOrders() in OrderListState does not work
> -------------------------------------------
>
>                 Key: OFBIZ-4883
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4883
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Ubuntu 10.04
>            Reporter: Chatree Srichart
>         Attachments: FixOrderStatus.diff
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Hi all,
> I see the status conditions in the OrderListState.getOrders() method is wrong because it should iterate statuses from orderStatusState instead of orderFilterState.
> Regards,
> Chatree Srichart

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280080#comment-13280080 ]

Chatree Srichart commented on OFBIZ-4883:
-----------------------------------------

In the order list screen, https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist , if I select only "Created" status and press "Find" button. The result list will also show orders which has other statuses. I think that is the problem.

Regards,
Chatree Srichart
               

> getOrders() in OrderListState does not work
> -------------------------------------------
>
>                 Key: OFBIZ-4883
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4883
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Ubuntu 10.04
>            Reporter: Chatree Srichart
>         Attachments: FixOrderStatus.diff
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Hi all,
> I see the status conditions in the OrderListState.getOrders() method is wrong because it should iterate statuses from orderStatusState instead of orderFilterState.
> Regards,
> Chatree Srichart

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280135#comment-13280135 ]

Jacques Le Roux commented on OFBIZ-4883:
----------------------------------------

Thanks Chatree,

It works, but there is more than that, the filters does not work. I will work on it before committing this.
               

> getOrders() in OrderListState does not work
> -------------------------------------------
>
>                 Key: OFBIZ-4883
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4883
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Ubuntu 10.04
>            Reporter: Chatree Srichart
>         Attachments: FixOrderStatus.diff
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Hi all,
> I see the status conditions in the OrderListState.getOrders() method is wrong because it should iterate statuses from orderStatusState instead of orderFilterState.
> Regards,
> Chatree Srichart

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4883.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 12.04
                   SVN trunk
         Assignee: Jacques Le Roux

Thanks Chatree,

Your patch is in
trunk r1342980
R12.04 r1342981

See comment there
               

> getOrders() in OrderListState does not work
> -------------------------------------------
>
>                 Key: OFBIZ-4883
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4883
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Ubuntu 10.04
>            Reporter: Chatree Srichart
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk, Release Branch 12.04
>
>         Attachments: FixOrderStatus.diff
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Hi all,
> I see the status conditions in the OrderListState.getOrders() method is wrong because it should iterate statuses from orderStatusState instead of orderFilterState.
> Regards,
> Chatree Srichart

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira