[jira] [Created] (OFBIZ-4911) very trivial update to fieldlookup.js in case of "null object" failure for wierd unknonw reason

[Nicolas Malin (Jira)]

Leon created OFBIZ-4911:
---------------------------

             Summary: very trivial update to fieldlookup.js in case of "null object" failure for wierd unknonw reason
                 Key: OFBIZ-4911
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4911
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Leon
            Priority: Trivial
             Fix For: SVN trunk


I cannot find the root cause and it's hard to reproduce, but it does happen sometimes. The web browser reports "null object" exception when it tries to evaluate following codes in fieldlookup.js:
{quote}
var obj_caller = (window.opener? window.opener.lookups[num_id]: null);
{quote}

window.opener is there but window.opener.lookups is null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leon updated OFBIZ-4911:
------------------------

    Attachment: OFBIZ-4911.patch
   

> very trivial update to fieldlookup.js in case of "null object" failure for wierd unknonw reason
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4911
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4911
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4911.patch
>
>
> I cannot find the root cause and it's hard to reproduce, but it does happen sometimes. The web browser reports "null object" exception when it tries to evaluate following codes in fieldlookup.js:
> {quote}
> var obj_caller = (window.opener? window.opener.lookups[num_id]: null);
> {quote}
> window.opener is there but window.opener.lookups is null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468514#comment-13468514 ]

Andreas Allacher commented on OFBIZ-4911:
-----------------------------------------

I had the same issue (actually I always have it when I get lookup windows) and from what I can see this issue still exists in the current trunk versions.
It is really a small update (attached here) which makes it working flawless.
I think it should be applied to the repository and backported before the next stable version is released.
Even if the cause might be somewhere else this should still be applied as a safety check.
               

> very trivial update to fieldlookup.js in case of "null object" failure for wierd unknonw reason
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4911
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4911
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4911.patch
>
>
> I cannot find the root cause and it's hard to reproduce, but it does happen sometimes. The web browser reports "null object" exception when it tries to evaluate following codes in fieldlookup.js:
> {quote}
> var obj_caller = (window.opener? window.opener.lookups[num_id]: null);
> {quote}
> window.opener is there but window.opener.lookups is null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468840#comment-13468840 ]

Jacques Le Roux commented on OFBIZ-4911:
----------------------------------------

This patch does not apply, I will change the line directly later...
               

> very trivial update to fieldlookup.js in case of "null object" failure for wierd unknonw reason
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4911
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4911
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4911.patch
>
>
> I cannot find the root cause and it's hard to reproduce, but it does happen sometimes. The web browser reports "null object" exception when it tries to evaluate following codes in fieldlookup.js:
> {quote}
> var obj_caller = (window.opener? window.opener.lookups[num_id]: null);
> {quote}
> window.opener is there but window.opener.lookups is null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-4911:
--------------------------------------

    Assignee: Jacques Le Roux
   

> very trivial update to fieldlookup.js in case of "null object" failure for wierd unknonw reason
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4911
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4911
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4911.patch
>
>
> I cannot find the root cause and it's hard to reproduce, but it does happen sometimes. The web browser reports "null object" exception when it tries to evaluate following codes in fieldlookup.js:
> {quote}
> var obj_caller = (window.opener? window.opener.lookups[num_id]: null);
> {quote}
> window.opener is there but window.opener.lookups is null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469186#comment-13469186 ]

Jacques Le Roux commented on OFBIZ-4911:
----------------------------------------

I slept on it, and before applying it: is there really any ways to reproduce the issue before hidding it?
               

> very trivial update to fieldlookup.js in case of "null object" failure for wierd unknonw reason
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4911
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4911
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4911.patch
>
>
> I cannot find the root cause and it's hard to reproduce, but it does happen sometimes. The web browser reports "null object" exception when it tries to evaluate following codes in fieldlookup.js:
> {quote}
> var obj_caller = (window.opener? window.opener.lookups[num_id]: null);
> {quote}
> window.opener is there but window.opener.lookups is null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469318#comment-13469318 ]

Andreas Allacher commented on OFBIZ-4911:
-----------------------------------------

Well, yesterday I got it all the time. No matter where I went without this patch.
Today I can't reproduce it. No matter if the patch is applied or not (kind of strange as I don't remember changing anything that could have fixed this).

However, it shouldn't really matter because if it works without it, it will still work correctly and if it doesn't work without it, this should fix it.
               

> very trivial update to fieldlookup.js in case of "null object" failure for wierd unknonw reason
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4911
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4911
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4911.patch
>
>
> I cannot find the root cause and it's hard to reproduce, but it does happen sometimes. The web browser reports "null object" exception when it tries to evaluate following codes in fieldlookup.js:
> {quote}
> var obj_caller = (window.opener? window.opener.lookups[num_id]: null);
> {quote}
> window.opener is there but window.opener.lookups is null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470714#comment-13470714 ]

Jacques Le Roux commented on OFBIZ-4911:
----------------------------------------

Which platform(s) are you both using? Did you try in many browsers?
               

> very trivial update to fieldlookup.js in case of "null object" failure for wierd unknonw reason
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4911
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4911
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4911.patch
>
>
> I cannot find the root cause and it's hard to reproduce, but it does happen sometimes. The web browser reports "null object" exception when it tries to evaluate following codes in fieldlookup.js:
> {quote}
> var obj_caller = (window.opener? window.opener.lookups[num_id]: null);
> {quote}
> window.opener is there but window.opener.lookups is null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471314#comment-13471314 ]

Andreas Allacher commented on OFBIZ-4911:
-----------------------------------------

I was using Ubuntu 12.04 (64Bit) with Firefox 15.0.1 when I ran into this problem.
As said I wasn't able to reproduce it the next day but maybe I will be again tomorrow (don't have access to the system currently).

In any case: I don't see why it is a problem to not only check window.opener but also for window.opener.lookups - it actually makes quite a lot of sense after all that is the property that script is going to access.
               

> very trivial update to fieldlookup.js in case of "null object" failure for wierd unknonw reason
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4911
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4911
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4911.patch
>
>
> I cannot find the root cause and it's hard to reproduce, but it does happen sometimes. The web browser reports "null object" exception when it tries to evaluate following codes in fieldlookup.js:
> {quote}
> var obj_caller = (window.opener? window.opener.lookups[num_id]: null);
> {quote}
> window.opener is there but window.opener.lookups is null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4911.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 12.04
                   Release Branch 11.04
                   Release Branch 10.04

Thanks Leon, Andreas,

Leon, your patch is in
trunk r1395460
R12.04 r1395463
R11.04 r1395471
R10.04 r1395488  





               

> very trivial update to fieldlookup.js in case of "null object" failure for wierd unknonw reason
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4911
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4911
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04
>
>         Attachments: OFBIZ-4911.patch
>
>
> I cannot find the root cause and it's hard to reproduce, but it does happen sometimes. The web browser reports "null object" exception when it tries to evaluate following codes in fieldlookup.js:
> {quote}
> var obj_caller = (window.opener? window.opener.lookups[num_id]: null);
> {quote}
> window.opener is there but window.opener.lookups is null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira