[jira] [Created] (OFBIZ-4916) Applying change of commit r1343156 to other ftls.

[Nicolas Malin (Jira)]

Ankit Jain created OFBIZ-4916:
---------------------------------

             Summary: Applying change of commit r1343156 to other ftls.
                 Key: OFBIZ-4916
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4916
             Project: OFBiz
          Issue Type: Improvement
          Components: ALL APPLICATIONS
    Affects Versions: SVN trunk
            Reporter: Ankit Jain
            Priority: Minor
             Fix For: SVN trunk


As discussed with Jacopo applying change of commit r1343156 to other ftls.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ankit Jain updated OFBIZ-4916:
------------------------------

    Attachment: OFBIZ-4916.patch

Attached patch for the issue.
               

> Applying change of commit r1343156 to other ftls.
> -------------------------------------------------
>
>                 Key: OFBIZ-4916
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4916
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk
>            Reporter: Ankit Jain
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4916.patch
>
>
> As discussed with Jacopo applying change of commit r1343156 to other ftls.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287291#comment-13287291 ]

Jacopo Cappellato commented on OFBIZ-4916:
------------------------------------------

Are you sure about:
{code}
<@loopSubContent contentId=contentIdx viewIndex=viewIdx viewSize=viewSz contentAssocTypeId="PUBLISH_LINK"
     pickWhen="purposes.contains(\"ARTICLE\") && \"CTNT_PUBLISHED\".equals(content.get(\"statusId\"))"
     returnAfterPickWhen="purposes.contains(\"ARTICLE\")"
-    followWhen="contentAssocTypeId != null && contentAssocTypeId.equals(\"never follow\")">
+    followWhen="contentAssocTypeId?? && contentAssocTypeId.equals(\"never follow\")">
{code}

and similar?
               

> Applying change of commit r1343156 to other ftls.
> -------------------------------------------------
>
>                 Key: OFBIZ-4916
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4916
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk
>            Reporter: Ankit Jain
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4916.patch
>
>
> As discussed with Jacopo applying change of commit r1343156 to other ftls.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287310#comment-13287310 ]

Ankit Jain commented on OFBIZ-4916:
-----------------------------------

Actually not Jacopo,

Because these files showblog.ftl and showforumresponse.ftl are not using anywhere and bloglib.ftl is included in some ftls and I back trace them and in controller(/ofbiz_trunk/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/controller.xml) I found all the requests to these are commented with a not "TO BE REMOVED".

So does it means these files are of no use ??

I will update the patch after removing these files.

Thanks
               

> Applying change of commit r1343156 to other ftls.
> -------------------------------------------------
>
>                 Key: OFBIZ-4916
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4916
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk
>            Reporter: Ankit Jain
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4916.patch
>
>
> As discussed with Jacopo applying change of commit r1343156 to other ftls.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ankit Jain updated OFBIZ-4916:
------------------------------

    Attachment: UPDATED-OFBIZ-4916.patch

Updated Patch.
               

> Applying change of commit r1343156 to other ftls.
> -------------------------------------------------
>
>                 Key: OFBIZ-4916
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4916
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk
>            Reporter: Ankit Jain
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4916.patch, UPDATED-OFBIZ-4916.patch
>
>
> As discussed with Jacopo applying change of commit r1343156 to other ftls.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Adam Heath-2]

On 06/01/2012 04:27 AM, Jacopo Cappellato (JIRA) wrote:

>
>      [ https://issues.apache.org/jira/browse/OFBIZ-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287291#comment-13287291 ]
>
> Jacopo Cappellato commented on OFBIZ-4916:
> ------------------------------------------
>
> Are you sure about:
> {code}
> <@loopSubContent contentId=contentIdx viewIndex=viewIdx viewSize=viewSz contentAssocTypeId="PUBLISH_LINK"
>       pickWhen="purposes.contains(\"ARTICLE\")&&  \"CTNT_PUBLISHED\".equals(content.get(\"statusId\"))"
>       returnAfterPickWhen="purposes.contains(\"ARTICLE\")"
> -    followWhen="contentAssocTypeId != null&&  contentAssocTypeId.equals(\"never follow\")">
> +    followWhen="contentAssocTypeId??&&  contentAssocTypeId.equals(\"never follow\")">
> {code}

Don't want this part of the jira issue, but...

Why can't freemarker do contentAssocTypeId?.equals(value)

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-4916:
--------------------------------------

    Assignee: Jacques Le Roux
   

> Applying change of commit r1343156 to other ftls.
> -------------------------------------------------
>
>                 Key: OFBIZ-4916
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4916
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4916.patch, UPDATED-OFBIZ-4916.patch
>
>
> As discussed with Jacopo applying change of commit r1343156 to other ftls.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-4916:
-----------------------------------

    Affects Version/s: Release Branch 12.04
   

> Applying change of commit r1343156 to other ftls.
> -------------------------------------------------
>
>                 Key: OFBIZ-4916
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4916
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk, Release Branch 12.04
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4916.patch, UPDATED-OFBIZ-4916.patch
>
>
> As discussed with Jacopo applying change of commit r1343156 to other ftls.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-4916:
-----------------------------------

    Issue Type: Bug  (was: Improvement)
   

> Applying change of commit r1343156 to other ftls.
> -------------------------------------------------
>
>                 Key: OFBIZ-4916
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4916
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk, Release Branch 12.04
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4916.patch, UPDATED-OFBIZ-4916.patch
>
>
> As discussed with Jacopo applying change of commit r1343156 to other ftls.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287924#comment-13287924 ]

Jacques Le Roux commented on OFBIZ-4916:
----------------------------------------

Tri, there seems to be a pb with your last patch, please check, for instance make a fresh checkout an try to apply it...
               

> Applying change of commit r1343156 to other ftls.
> -------------------------------------------------
>
>                 Key: OFBIZ-4916
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4916
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk, Release Branch 12.04
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4916.patch, UPDATED-OFBIZ-4916.patch
>
>
> As discussed with Jacopo applying change of commit r1343156 to other ftls.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287924#comment-13287924 ]

Jacques Le Roux edited comment on OFBIZ-4916 at 6/2/12 1:24 PM:
----------------------------------------------------------------

Sorry I put a comment here which was for another issue (tired as said already)
               
      was (Author: jacques.le.roux):
    Tri, there seems to be a pb with your last patch, please check, for instance make a fresh checkout an try to apply it...
                 

> Applying change of commit r1343156 to other ftls.
> -------------------------------------------------
>
>                 Key: OFBIZ-4916
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4916
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk, Release Branch 12.04
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4916.patch, UPDATED-OFBIZ-4916.patch
>
>
> As discussed with Jacopo applying change of commit r1343156 to other ftls.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-4916:
-----------------------------------

    Summary: Replaces "!= null" pattern in ftl file by "??" (which replaces deprecated ?if_exist)  (was: Applying change of commit r1343156 to other ftls.)
   

> Replaces "!= null" pattern in ftl file by "??" (which replaces deprecated ?if_exist)
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4916
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4916
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk, Release Branch 12.04
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4916.patch, UPDATED-OFBIZ-4916.patch
>
>
> As discussed with Jacopo applying change of commit r1343156 to other ftls.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288363#comment-13288363 ]

Ankit Jain commented on OFBIZ-4916:
-----------------------------------

Thanks Jacques :)
               

> Replaces "!= null" pattern in ftl file by "??" (which replaces deprecated ?if_exist)
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4916
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4916
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk, Release Branch 12.04
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk, Release Branch 12.04
>
>         Attachments: OFBIZ-4916.patch, UPDATED-OFBIZ-4916.patch
>
>
> As discussed with Jacopo applying change of commit r1343156 to other ftls.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira