OFBiz › OFBiz - Dev

[jira] [Created] (OFBIZ-4965) HR Public Holiday Accepts Blank in

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

5 messages Options

Nicolas Malin (Jira)

[jira] [Created] (OFBIZ-4965) HR Public Holiday Accepts Blank in

Tom Burns created OFBIZ-4965:
--------------------------------

Summary: HR Public Holiday Accepts Blank in
Key: OFBIZ-4965
URL: https://issues.apache.org/jira/browse/OFBIZ-4965
Project: OFBiz
Issue Type: Bug
Reporter: Tom Burns
Priority: Trivial

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4965) HR Public Holiday Accepts Blank in

[ https://issues.apache.org/jira/browse/OFBIZ-4965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413033#comment-13413033 ]

Tom Burns commented on OFBIZ-4965:
----------------------------------

Title should have read HR Public Holiday Accepts Blank in Required Field (hit enter before completing form)

Component: Humanres
Version: demo-trunk

To Reproduce:
1. Navigate to HR > Global HR Settings > Public Holiday
2. Enter a From Date
3. Click Submit
4. Expected: Alert like "Required field Holiday Name missing"
Actual: New record created without required Holiday Name

> HR Public Holiday Accepts Blank in
> -----------------------------------
>
> Key: OFBIZ-4965
> URL: https://issues.apache.org/jira/browse/OFBIZ-4965
> Project: OFBiz
> Issue Type: Bug
> Reporter: Tom Burns
> Priority: Trivial
>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4965) HR Public Holiday Accepts Blank in

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom Burns updated OFBIZ-4965:
-----------------------------

Attachment: OFBIZ-4965 PublicHoliday.patch

Note: The controller entry <response name="error" type="view-last"/> created an undesirable effect (navigated to a screen other then expected PublicHoliday view).
I could not reproduce this in demo-trunk but changed the line in the controller to <response name="error" type="view" value="PublicHoliday"/> anyway.

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4965) HR Public Holiday Accepts Blank in Required Field

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-4965:
-----------------------------------

Component/s: humanres
Description:
To Reproduce:
1. Navigate to HR > Global HR Settings > Public Holiday
2. Enter a From Date
3. Click Submit

Expected: Alert like "Required field Holiday Name missing"
Actual: New record created without required Holiday Name
Affects Version/s: SVN trunk
Summary: HR Public Holiday Accepts Blank in Required Field (was: HR Public Holiday Accepts Blank in )

Hi Tom, you can easily edit title and description and other fields (components, etc.), simply use the edit button

I did it for you ;)

> HR Public Holiday Accepts Blank in Required Field
> --------------------------------------------------
>
> Key: OFBIZ-4965
> URL: https://issues.apache.org/jira/browse/OFBIZ-4965
> Project: OFBiz
> Issue Type: Bug
> Components: humanres
> Affects Versions: SVN trunk
> Reporter: Tom Burns
> Priority: Trivial
> Attachments: OFBIZ-4965 PublicHoliday.patch
>
>
> To Reproduce:
> 1. Navigate to HR > Global HR Settings > Public Holiday
> 2. Enter a From Date
> 3. Click Submit
> Expected: Alert like "Required field Holiday Name missing"
> Actual: New record created without required Holiday Name

Nicolas Malin (Jira)

[jira] [Closed] (OFBIZ-4965) HR Public Holiday Accepts Blank in Required Field

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4965.
----------------------------------

Resolution: Fixed
Fix Version/s: Release Branch 12.04
SVN trunk
Assignee: Jacques Le Roux

Thanks Tom,

Your patch is in
trunk r1361056
R12.04 r1361057

> HR Public Holiday Accepts Blank in Required Field
> --------------------------------------------------
>
> Key: OFBIZ-4965
> URL: https://issues.apache.org/jira/browse/OFBIZ-4965
> Project: OFBiz
> Issue Type: Bug
> Components: humanres
> Affects Versions: SVN trunk
> Reporter: Tom Burns
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk, Release Branch 12.04
>
> Attachments: OFBIZ-4965 PublicHoliday.patch
>
>
> To Reproduce:
> 1. Navigate to HR > Global HR Settings > Public Holiday
> 2. Enter a From Date
> 3. Click Submit
> Expected: Alert like "Required field Holiday Name missing"
> Actual: New record created without required Holiday Name