[jira] [Created] (OFBIZ-4982) js issue causes error when invalid dates are entered

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (OFBIZ-4982) js issue causes error when invalid dates are entered

Nicolas Malin (Jira)
Christoph Neuroth created OFBIZ-4982:
----------------------------------------

             Summary: js issue causes error when invalid dates are entered
                 Key: OFBIZ-4982
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4982
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Christoph Neuroth
            Priority: Minor
         Attachments: ofbiz-i18n_dateinput_null_fix.patch

Reproduce: Enter "123" in a DateField. This will trigger a JS exception and the invalid value will be sent to the server on form submission, probably causing server-side exceptions in badly written backend code, resulting in really bad error messages for the user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-4982) js issue causes error when invalid dates are entered

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christoph Neuroth updated OFBIZ-4982:
-------------------------------------

    Attachment: ofbiz-i18n_dateinput_null_fix.patch
   

> js issue causes error when invalid dates are entered
> ----------------------------------------------------
>
>                 Key: OFBIZ-4982
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4982
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Christoph Neuroth
>            Priority: Minor
>         Attachments: ofbiz-i18n_dateinput_null_fix.patch
>
>
> Reproduce: Enter "123" in a DateField. This will trigger a JS exception and the invalid value will be sent to the server on form submission, probably causing server-side exceptions in badly written backend code, resulting in really bad error messages for the user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Assigned] (OFBIZ-4982) js issue causes error when invalid dates are entered

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp reassigned OFBIZ-4982:
--------------------------------------

    Assignee: Sascha Rodekamp
   

> js issue causes error when invalid dates are entered
> ----------------------------------------------------
>
>                 Key: OFBIZ-4982
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4982
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Christoph Neuroth
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>         Attachments: ofbiz-i18n_dateinput_null_fix.patch
>
>
> Reproduce: Enter "123" in a DateField. This will trigger a JS exception and the invalid value will be sent to the server on form submission, probably causing server-side exceptions in badly written backend code, resulting in really bad error messages for the user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-4982) js issue causes error when invalid dates are entered

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429114#comment-13429114 ]

Sascha Rodekamp commented on OFBIZ-4982:
----------------------------------------

Hi Christoph,
thanks for the patch.
One thought that comes in my mind: Is it a good idea to remove wrong date inputs? It's obvious when you type "123" in the Date/Time field. But what if the user accidentally switched day and month which could also result in an exception. If we remove the wrong input field this wouldn't be noticed at all.
Is it possible to use a "custom validation" to highlight the field on a wrong input?

Many thanks
Sascha
               

> js issue causes error when invalid dates are entered
> ----------------------------------------------------
>
>                 Key: OFBIZ-4982
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4982
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Christoph Neuroth
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>         Attachments: ofbiz-i18n_dateinput_null_fix.patch
>
>
> Reproduce: Enter "123" in a DateField. This will trigger a JS exception and the invalid value will be sent to the server on form submission, probably causing server-side exceptions in badly written backend code, resulting in really bad error messages for the user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-4982) js issue causes error when invalid dates are entered

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429187#comment-13429187 ]

Christoph Neuroth commented on OFBIZ-4982:
------------------------------------------

Of course, proper client-side validation for the date format would be the way to go. This patch merely prevents unhandled exceptions popping up in log files and screen rendering error texts presented to the user.
               

> js issue causes error when invalid dates are entered
> ----------------------------------------------------
>
>                 Key: OFBIZ-4982
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4982
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Christoph Neuroth
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>         Attachments: ofbiz-i18n_dateinput_null_fix.patch
>
>
> Reproduce: Enter "123" in a DateField. This will trigger a JS exception and the invalid value will be sent to the server on form submission, probably causing server-side exceptions in badly written backend code, resulting in really bad error messages for the user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Closed] (OFBIZ-4982) js issue causes error when invalid dates are entered

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp closed OFBIZ-4982.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Hi Christoph,

you're patch is in trunk @Rev 1370123

Many thanks
Sascha
               

> js issue causes error when invalid dates are entered
> ----------------------------------------------------
>
>                 Key: OFBIZ-4982
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4982
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Christoph Neuroth
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ofbiz-i18n_dateinput_null_fix.patch
>
>
> Reproduce: Enter "123" in a DateField. This will trigger a JS exception and the invalid value will be sent to the server on form submission, probably causing server-side exceptions in badly written backend code, resulting in really bad error messages for the user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira