[jira] [Created] (OFBIZ-5013) Pagination Fails in Form ListAgreementTerms

[Nicolas Malin (Jira)]

Tom Burns created OFBIZ-5013:
--------------------------------

             Summary: Pagination Fails in Form ListAgreementTerms
                 Key: OFBIZ-5013
                 URL: https://issues.apache.org/jira/browse/OFBIZ-5013
             Project: OFBiz
          Issue Type: Bug
          Components: accounting
    Affects Versions: Release 10.04, Release 09.04.01, SVN trunk
         Environment: Demo Sites
            Reporter: Tom Burns
            Priority: Trivial


To reproduce:
Navigate to Accounting Manager > Agreements
Click Find
Click Edit (any agreement)
Click Agreement Terms
Click Submit and repeat Submit until pagination navagation is displayed
Navigate to second page
Expect: display records
Actual: org.ofbiz.webapp.control.RequestHandlerException: Unknown request [ListAgreementTerms]; this request does not exist or cannot be called directly.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-5013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom Burns updated OFBIZ-5013:
-----------------------------

    Attachment: OFBIZ-5013 ListAgreementTermsPaginationFail.patch
   

> Pagination Fails in Form ListAgreementTerms
> -------------------------------------------
>
>                 Key: OFBIZ-5013
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5013
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Release 09.04.01, Release 10.04, SVN trunk
>         Environment: Demo Sites
>            Reporter: Tom Burns
>            Priority: Trivial
>         Attachments: OFBIZ-5013 ListAgreementTermsPaginationFail.patch
>
>
> To reproduce:
> Navigate to Accounting Manager > Agreements
> Click Find
> Click Edit (any agreement)
> Click Agreement Terms
> Click Submit and repeat Submit until pagination navagation is displayed
> Navigate to second page
> Expect: display records
> Actual: org.ofbiz.webapp.control.RequestHandlerException: Unknown request [ListAgreementTerms]; this request does not exist or cannot be called directly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-5013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom Burns updated OFBIZ-5013:
-----------------------------

    Description:
To reproduce:
Navigate to Accounting Manager > Agreements
Click Find
Click Edit (any agreement)
Click Agreement Terms
Click Submit and repeat Submit until pagination navigation is displayed
Navigate to second page
Expect: display records
Actual: org.ofbiz.webapp.control.RequestHandlerException: Unknown request [ListAgreementTerms]; this request does not exist or cannot be called directly.

ListAgreementRoles pagination not tested but will likely also fail. paginate-target FindAgreementRoles does not exist.


  was:
To reproduce:
Navigate to Accounting Manager > Agreements
Click Find
Click Edit (any agreement)
Click Agreement Terms
Click Submit and repeat Submit until pagination navagation is displayed
Navigate to second page
Expect: display records
Actual: org.ofbiz.webapp.control.RequestHandlerException: Unknown request [ListAgreementTerms]; this request does not exist or cannot be called directly.


   

> Pagination Fails in Form ListAgreementTerms
> -------------------------------------------
>
>                 Key: OFBIZ-5013
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5013
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Release 09.04.01, Release 10.04, SVN trunk
>         Environment: Demo Sites
>            Reporter: Tom Burns
>            Priority: Trivial
>         Attachments: OFBIZ-5013 ListAgreementTermsPaginationFail.patch
>
>
> To reproduce:
> Navigate to Accounting Manager > Agreements
> Click Find
> Click Edit (any agreement)
> Click Agreement Terms
> Click Submit and repeat Submit until pagination navigation is displayed
> Navigate to second page
> Expect: display records
> Actual: org.ofbiz.webapp.control.RequestHandlerException: Unknown request [ListAgreementTerms]; this request does not exist or cannot be called directly.
> ListAgreementRoles pagination not tested but will likely also fail. paginate-target FindAgreementRoles does not exist.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-5013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-5013.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 12.04
                   SVN trunk
                   Release Branch 11.04
                   Release Branch 10.04
         Assignee: Jacques Le Roux

Thanks Tom,

Your patch is in
trunk r1388832
R12.04 r1388834
R11.04 r1388835
R10.04 r1388836

We no longer support R09.04 and R4

I also fixed roles.

Note: when, for testing, you want a quicker way to get pagination you can change widget.form.defaultViewSize in widget.properties
I use widget.form.defaultViewSize=2 ;)




               

> Pagination Fails in Form ListAgreementTerms
> -------------------------------------------
>
>                 Key: OFBIZ-5013
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5013
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Release 09.04.01, Release 10.04, SVN trunk
>         Environment: Demo Sites
>            Reporter: Tom Burns
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04
>
>         Attachments: OFBIZ-5013 ListAgreementTermsPaginationFail.patch
>
>
> To reproduce:
> Navigate to Accounting Manager > Agreements
> Click Find
> Click Edit (any agreement)
> Click Agreement Terms
> Click Submit and repeat Submit until pagination navigation is displayed
> Navigate to second page
> Expect: display records
> Actual: org.ofbiz.webapp.control.RequestHandlerException: Unknown request [ListAgreementTerms]; this request does not exist or cannot be called directly.
> ListAgreementRoles pagination not tested but will likely also fail. paginate-target FindAgreementRoles does not exist.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-5013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465035#comment-13465035 ]

Tom Burns commented on OFBIZ-5013:
----------------------------------

Jacques,

Thanks for the tip.

This is a off topic but on the subject of pagination, and list display in general, OFBiz (IMHO) should take some inspiration Big Fish.

The list in their Admin Modules are more user friendly then the list in OFBiz trunk. The navigation elements are CONSISTENT from list to list, they support reporting to PDF (also supported here and there in OFBiz) and some support sorting (all list should support sorting).

Do you think it would be worth wild (given the limited resources of committers) to open an improvement issue in Jira to set standards for, and upgrade current implementations of, an improved implementation of list forms in the OFBiz trunk?

On pagination in particular the default should be a user configurable (not hidden in the properties file) file. OFBiz should preserve the pagination preference for a list across sessions after a user changes the setting.

Tom

               

> Pagination Fails in Form ListAgreementTerms
> -------------------------------------------
>
>                 Key: OFBIZ-5013
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5013
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Release 09.04.01, Release 10.04, SVN trunk
>         Environment: Demo Sites
>            Reporter: Tom Burns
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04
>
>         Attachments: OFBIZ-5013 ListAgreementTermsPaginationFail.patch
>
>
> To reproduce:
> Navigate to Accounting Manager > Agreements
> Click Find
> Click Edit (any agreement)
> Click Agreement Terms
> Click Submit and repeat Submit until pagination navigation is displayed
> Navigate to second page
> Expect: display records
> Actual: org.ofbiz.webapp.control.RequestHandlerException: Unknown request [ListAgreementTerms]; this request does not exist or cannot be called directly.
> ListAgreementRoles pagination not tested but will likely also fail. paginate-target FindAgreementRoles does not exist.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-5013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470481#comment-13470481 ]

Jacques Le Roux commented on OFBIZ-5013:
----------------------------------------

Hi Tom,

There have been already a notable effort on this aspect. You can set the number of items per page, but yes the default is still set in properties. I think we discussed about your propositions. If you think you will be able to implement them, then yes feel free to create a Jira for that. Else don't expect much efforts from others. Could be done but unlikely at the moment, if I refer to the recent level of activity. Also we (committers) are at the moment more in a slim-down/fix bugs mode trend.
               

> Pagination Fails in Form ListAgreementTerms
> -------------------------------------------
>
>                 Key: OFBIZ-5013
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5013
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Release 09.04.01, Release 10.04, SVN trunk
>         Environment: Demo Sites
>            Reporter: Tom Burns
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04
>
>         Attachments: OFBIZ-5013 ListAgreementTermsPaginationFail.patch
>
>
> To reproduce:
> Navigate to Accounting Manager > Agreements
> Click Find
> Click Edit (any agreement)
> Click Agreement Terms
> Click Submit and repeat Submit until pagination navigation is displayed
> Navigate to second page
> Expect: display records
> Actual: org.ofbiz.webapp.control.RequestHandlerException: Unknown request [ListAgreementTerms]; this request does not exist or cannot be called directly.
> ListAgreementRoles pagination not tested but will likely also fail. paginate-target FindAgreementRoles does not exist.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira