|
Leon created OFBIZ-5025:
--------------------------- Summary: jquery validator localization looks for "messages_cn.js" for locale zh_CN and "_tw" for zh_TW Key: OFBIZ-5025 URL: https://issues.apache.org/jira/browse/OFBIZ-5025 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-5025.patch it's weird that jquery validator localization does not treat "zh_CN" as zhcn or zh-cn but "cn", neither does zh_TW. Trivial update to JsLanguageFileMappingCreator.java to make it generate correct file url for zh_CN and zh_TW. Besides, a uptodate JsLanguageFilesMapping.java created by service createJsLanguageFileMapping is also packaged into patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
[ https://issues.apache.org/jira/browse/OFBIZ-5025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-5025: ------------------------ Attachment: OFBIZ-5025.patch > jquery validator localization looks for "messages_cn.js" for locale zh_CN and "_tw" for zh_TW > --------------------------------------------------------------------------------------------- > > Key: OFBIZ-5025 > URL: https://issues.apache.org/jira/browse/OFBIZ-5025 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-5025.patch > > > it's weird that jquery validator localization does not treat "zh_CN" as zhcn or zh-cn but "cn", neither does zh_TW. > Trivial update to JsLanguageFileMappingCreator.java to make it generate correct file url for zh_CN and zh_TW. Besides, a uptodate JsLanguageFilesMapping.java created by service createJsLanguageFileMapping is also packaged into patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-5025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES reassigned OFBIZ-5025: ----------------------------------------- Assignee: Erwan de FERRIERES > jquery validator localization looks for "messages_cn.js" for locale zh_CN and "_tw" for zh_TW > --------------------------------------------------------------------------------------------- > > Key: OFBIZ-5025 > URL: https://issues.apache.org/jira/browse/OFBIZ-5025 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Assignee: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-5025.patch > > > it's weird that jquery validator localization does not treat "zh_CN" as zhcn or zh-cn but "cn", neither does zh_TW. > Trivial update to JsLanguageFileMappingCreator.java to make it generate correct file url for zh_CN and zh_TW. Besides, a uptodate JsLanguageFilesMapping.java created by service createJsLanguageFileMapping is also packaged into patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-5025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447396#comment-13447396 ] Erwan de FERRIERES commented on OFBIZ-5025: ------------------------------------------- Hi Leon, your patch doesn't apply on latest trunk. Could you please recreate it ? [erwan@thinkpad:~/workspace/ofbiz]$ patch -p0 < OFBIZ-5025.patch (Stripping trailing CRs from patch.) patching file framework/common/src/org/ofbiz/common/JsLanguageFileMappingCreator.java Hunk #1 FAILED at 72. Hunk #2 FAILED at 115. 2 out of 2 hunks FAILED -- saving rejects to file framework/common/src/org/ofbiz/common/JsLanguageFileMappingCreator.java.rej (Stripping trailing CRs from patch.) patching file framework/common/src/org/ofbiz/common/JsLanguageFilesMapping.java Hunk #1 FAILED at 399. Hunk #2 FAILED at 490. Hunk #3 FAILED at 514. Hunk #4 FAILED at 563. Hunk #5 FAILED at 593. Hunk #6 FAILED at 623. Hunk #7 FAILED at 638. Hunk #8 FAILED at 655. Hunk #9 FAILED at 680. 9 out of 9 hunks FAILED -- saving rejects to file framework/common/src/org/ofbiz/common/JsLanguageFilesMapping.java.rej Thanks > jquery validator localization looks for "messages_cn.js" for locale zh_CN and "_tw" for zh_TW > --------------------------------------------------------------------------------------------- > > Key: OFBIZ-5025 > URL: https://issues.apache.org/jira/browse/OFBIZ-5025 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Assignee: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-5025.patch > > > it's weird that jquery validator localization does not treat "zh_CN" as zhcn or zh-cn but "cn", neither does zh_TW. > Trivial update to JsLanguageFileMappingCreator.java to make it generate correct file url for zh_CN and zh_TW. Besides, a uptodate JsLanguageFilesMapping.java created by service createJsLanguageFileMapping is also packaged into patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-5025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-5025: ------------------------ Attachment: (was: OFBIZ-5025.patch) > jquery validator localization looks for "messages_cn.js" for locale zh_CN and "_tw" for zh_TW > --------------------------------------------------------------------------------------------- > > Key: OFBIZ-5025 > URL: https://issues.apache.org/jira/browse/OFBIZ-5025 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Assignee: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-5025.patch > > > it's weird that jquery validator localization does not treat "zh_CN" as zhcn or zh-cn but "cn", neither does zh_TW. > Trivial update to JsLanguageFileMappingCreator.java to make it generate correct file url for zh_CN and zh_TW. Besides, a uptodate JsLanguageFilesMapping.java created by service createJsLanguageFileMapping is also packaged into patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-5025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-5025: ------------------------ Attachment: OFBIZ-5025.patch > jquery validator localization looks for "messages_cn.js" for locale zh_CN and "_tw" for zh_TW > --------------------------------------------------------------------------------------------- > > Key: OFBIZ-5025 > URL: https://issues.apache.org/jira/browse/OFBIZ-5025 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Assignee: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-5025.patch > > > it's weird that jquery validator localization does not treat "zh_CN" as zhcn or zh-cn but "cn", neither does zh_TW. > Trivial update to JsLanguageFileMappingCreator.java to make it generate correct file url for zh_CN and zh_TW. Besides, a uptodate JsLanguageFilesMapping.java created by service createJsLanguageFileMapping is also packaged into patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-5025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447457#comment-13447457 ] Leon commented on OFBIZ-5025: ----------------------------- hi, Erwan, please try the new patch. Since these two files is in DOS format, the patch file generated from windows cannot be recognized correctly in unix. I re-diff them from unix and test it through. > jquery validator localization looks for "messages_cn.js" for locale zh_CN and "_tw" for zh_TW > --------------------------------------------------------------------------------------------- > > Key: OFBIZ-5025 > URL: https://issues.apache.org/jira/browse/OFBIZ-5025 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Assignee: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-5025.patch > > > it's weird that jquery validator localization does not treat "zh_CN" as zhcn or zh-cn but "cn", neither does zh_TW. > Trivial update to JsLanguageFileMappingCreator.java to make it generate correct file url for zh_CN and zh_TW. Besides, a uptodate JsLanguageFilesMapping.java created by service createJsLanguageFileMapping is also packaged into patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-5025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES closed OFBIZ-5025. ------------------------------------- Resolution: Fixed done at rev 1381146 Thanks Leon > jquery validator localization looks for "messages_cn.js" for locale zh_CN and "_tw" for zh_TW > --------------------------------------------------------------------------------------------- > > Key: OFBIZ-5025 > URL: https://issues.apache.org/jira/browse/OFBIZ-5025 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Assignee: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-5025.patch > > > it's weird that jquery validator localization does not treat "zh_CN" as zhcn or zh-cn but "cn", neither does zh_TW. > Trivial update to JsLanguageFileMappingCreator.java to make it generate correct file url for zh_CN and zh_TW. Besides, a uptodate JsLanguageFilesMapping.java created by service createJsLanguageFileMapping is also packaged into patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira |
| Free forum by Nabble | Edit this page |
