[jira] Created: (OFBIZ-515) Replace string comparison with != or == by .equals

[Nicolas Malin (Jira)]

Replace string comparison with != or == by .equals
--------------------------------------------------

                 Key: OFBIZ-515
                 URL: http://issues.apache.org/jira/browse/OFBIZ-515
             Project: OFBiz (The Open for Business Project)
          Issue Type: Bug
    Affects Versions: SVN trunk
            Reporter: Stefan Huehner


Attached patch converts several string comparisons to use the standard .equals form as it is not clear in the code
that the special check if both string point to exactly same object is applicable there.


--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-515?page=all ]

Stefan Huehner updated OFBIZ-515:
---------------------------------

    Attachment: ofbiz_string_compare.diff

> Replace string comparison with != or == by .equals
> --------------------------------------------------
>
>                 Key: OFBIZ-515
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-515
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>         Attachments: ofbiz_string_compare.diff
>
>
> Attached patch converts several string comparisons to use the standard .equals form as it is not clear in the code
> that the special check if both string point to exactly same object is applicable there.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-515?page=all ]

Jacopo Cappellato reassigned OFBIZ-515:
---------------------------------------

    Assignee: Jacopo Cappellato

> Replace string comparison with != or == by .equals
> --------------------------------------------------
>
>                 Key: OFBIZ-515
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-515
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>         Assigned To: Jacopo Cappellato
>         Attachments: ofbiz_string_compare.diff
>
>
> Attached patch converts several string comparisons to use the standard .equals form as it is not clear in the code
> that the special check if both string point to exactly same object is applicable there.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-515?page=all ]

Jacopo Cappellato closed OFBIZ-515.
-----------------------------------

    Resolution: Fixed

Thanks Stefan,

your patch is in rev. 482264

> Replace string comparison with != or == by .equals
> --------------------------------------------------
>
>                 Key: OFBIZ-515
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-515
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>         Assigned To: Jacopo Cappellato
>         Attachments: ofbiz_string_compare.diff
>
>
> Attached patch converts several string comparisons to use the standard .equals form as it is not clear in the code
> that the special check if both string point to exactly same object is applicable there.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira