[jira] Created: (OFBIZ-514) Remove some more unneeded casts

[Nicolas Malin (Jira)]

Remove some more unneeded casts
-------------------------------

                 Key: OFBIZ-514
                 URL: http://issues.apache.org/jira/browse/OFBIZ-514
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
    Affects Versions: SVN trunk
            Reporter: Stefan Huehner
            Priority: Trivial
         Attachments: ofbiz_cast2.diff

This patch removes some more unneeded casts (similar to OFBIZ-511). On change in there deserves to be noted:
framework/minilang/src/org/ofbiz/minilang/method/eventops/WebappPropertyToField.java
Here extra code was used to check if 'fieldVal instanceof String'. As fieldVal is declared as String this code has been simplified alot.


--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-514?page=all ]

Stefan Huehner updated OFBIZ-514:
---------------------------------

    Attachment: ofbiz_cast2.diff

> Remove some more unneeded casts
> -------------------------------
>
>                 Key: OFBIZ-514
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-514
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>            Priority: Trivial
>         Attachments: ofbiz_cast2.diff
>
>
> This patch removes some more unneeded casts (similar to OFBIZ-511). On change in there deserves to be noted:
> framework/minilang/src/org/ofbiz/minilang/method/eventops/WebappPropertyToField.java
> Here extra code was used to check if 'fieldVal instanceof String'. As fieldVal is declared as String this code has been simplified alot.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-514?page=all ]

Jacopo Cappellato reassigned OFBIZ-514:
---------------------------------------

    Assignee: Jacopo Cappellato

> Remove some more unneeded casts
> -------------------------------
>
>                 Key: OFBIZ-514
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-514
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>         Assigned To: Jacopo Cappellato
>            Priority: Trivial
>         Attachments: ofbiz_cast2.diff
>
>
> This patch removes some more unneeded casts (similar to OFBIZ-511). On change in there deserves to be noted:
> framework/minilang/src/org/ofbiz/minilang/method/eventops/WebappPropertyToField.java
> Here extra code was used to check if 'fieldVal instanceof String'. As fieldVal is declared as String this code has been simplified alot.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-514?page=all ]

Jacopo Cappellato closed OFBIZ-514.
-----------------------------------

    Resolution: Fixed

Thanks Stefan,

your patch is in rev. 482260

> Remove some more unneeded casts
> -------------------------------
>
>                 Key: OFBIZ-514
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-514
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>         Assigned To: Jacopo Cappellato
>            Priority: Trivial
>         Attachments: ofbiz_cast2.diff
>
>
> This patch removes some more unneeded casts (similar to OFBIZ-511). On change in there deserves to be noted:
> framework/minilang/src/org/ofbiz/minilang/method/eventops/WebappPropertyToField.java
> Here extra code was used to check if 'fieldVal instanceof String'. As fieldVal is declared as String this code has been simplified alot.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira