[jira] Created: (OFBIZ-516) virtual products sharing variants can cause inconsistest shopping cart

[Nicolas Malin (Jira)]

virtual products sharing variants can cause inconsistest shopping cart
----------------------------------------------------------------------

                 Key: OFBIZ-516
                 URL: http://issues.apache.org/jira/browse/OFBIZ-516
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: ecommerce
    Affects Versions: SVN trunk
         Environment: linux
            Reporter: Fred Forester
            Priority: Minor


If Virtual products are set up to share a group of variants the shopping cart may show a different virtual product than the one the customer actually selected.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-516?page=all ]

Fred Forester updated OFBIZ-516:
--------------------------------

    Attachment: variant_patch.log

Starting at ShoppingCartEvents addToCart method, allow the parent product to be passed down thru to the ShoppingCartItem.

This patch also corrects the selection of surveys for an add to cart survey.

> virtual products sharing variants can cause inconsistest shopping cart
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-516
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-516
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: linux
>            Reporter: Fred Forester
>            Priority: Minor
>         Attachments: variant_patch.log
>
>
> If Virtual products are set up to share a group of variants the shopping cart may show a different virtual product than the one the customer actually selected.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-516?page=comments#action_12458967 ]
           
Jacques Le Roux commented on OFBIZ-516:
---------------------------------------

Fred,

I tried your patch but did not find an use case to reproduce the problem. I tried by cloning Giant Widget to have another product with the same group of variants. What I"m missing here please ?

BTW it's easier for commiters to have a patch for each issue being patched (here variants and cart survey). Don't worry it will be ok for this one.

Thanks

> virtual products sharing variants can cause inconsistest shopping cart
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-516
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-516
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: linux
>            Reporter: Fred Forester
>            Priority: Minor
>         Attachments: variant_patch.log
>
>
> If Virtual products are set up to share a group of variants the shopping cart may show a different virtual product than the one the customer actually selected.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-516?page=comments#action_12459026 ]
           
Fred Forester commented on OFBIZ-516:
-------------------------------------

Hi

the situation is when one or all of the variants have Associations to more than one virtual.
I look up one of the virtuals in the catalog mgr then click variants then click one of the variants then click
associations. the variant has more than one associated virtual.

Thanx
Fred


.

> virtual products sharing variants can cause inconsistest shopping cart
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-516
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-516
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: linux
>            Reporter: Fred Forester
>            Priority: Minor
>         Attachments: variant_patch.log
>
>
> If Virtual products are set up to share a group of variants the shopping cart may show a different virtual product than the one the customer actually selected.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-516?page=all ]

Jacques Le Roux updated OFBIZ-516:
----------------------------------

    Attachment: Sans titre.PNG

A copy screen (in french sorry) of a variant using multi virtuals

> virtual products sharing variants can cause inconsistest shopping cart
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-516
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-516
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: linux
>            Reporter: Fred Forester
>            Priority: Minor
>         Attachments: Sans titre.PNG, variant_patch.log
>
>
> If Virtual products are set up to share a group of variants the shopping cart may show a different virtual product than the one the customer actually selected.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-516?page=comments#action_12459040 ]
           
Jacques Le Roux commented on OFBIZ-516:
---------------------------------------

Fred,

Sorry I'm not sure I understand you clearly. I uploaded a copy screen showing what I understand from your last comment. Actually that's what I meaned in my last comment.
But using eCommerce UI I never find in the shopping cart  "a different virtual product than the one the customer actually selected." Besides what does that mean exactly ?
Because in the shopping cart you never see the virtual product but the variant(s). Am'I wrong ? Do I miss something here ?

Thanks

> virtual products sharing variants can cause inconsistest shopping cart
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-516
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-516
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: linux
>            Reporter: Fred Forester
>            Priority: Minor
>         Attachments: Sans titre.PNG, variant_patch.log
>
>
> If Virtual products are set up to share a group of variants the shopping cart may show a different virtual product than the one the customer actually selected.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-516?page=comments#action_12459041 ]
           
Jacques Le Roux commented on OFBIZ-516:
---------------------------------------

Maybe 2 copy-screens (1 for back, the other for eCommerce) will convince me ... If you have problems with Jira copy screen, upload a file.

Thanks

> virtual products sharing variants can cause inconsistest shopping cart
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-516
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-516
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: linux
>            Reporter: Fred Forester
>            Priority: Minor
>         Attachments: Sans titre.PNG, variant_patch.log
>
>
> If Virtual products are set up to share a group of variants the shopping cart may show a different virtual product than the one the customer actually selected.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-516?page=comments#action_12459043 ]
           
Fred Forester commented on OFBIZ-516:
-------------------------------------

to make the screens I'll have to pull down a stock ofbiz. I can do that later this afternoon.


what I am seeing is. If I add a WG-9943 to the cart then click the item in the cart the product page may display
a WG-9943 or a Giant Widget Clone or a Giant Widget Clone2 depending on which ProductAssoc entiry is the first in the list rather than the actual virtual ID originally selected.

Thanx
Fred

> virtual products sharing variants can cause inconsistest shopping cart
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-516
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-516
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: linux
>            Reporter: Fred Forester
>            Priority: Minor
>         Attachments: Sans titre.PNG, variant_patch.log
>
>
> If Virtual products are set up to share a group of variants the shopping cart may show a different virtual product than the one the customer actually selected.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-516?page=comments#action_12459046 ]
           
Jacques Le Roux commented on OFBIZ-516:
---------------------------------------

Ok Thanks Fred, this should be enough, trying...

> virtual products sharing variants can cause inconsistest shopping cart
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-516
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-516
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: linux
>            Reporter: Fred Forester
>            Priority: Minor
>         Attachments: Sans titre.PNG, variant_patch.log
>
>
> If Virtual products are set up to share a group of variants the shopping cart may show a different virtual product than the one the customer actually selected.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-516?page=comments#action_12459082 ]
           
Jacques Le Roux commented on OFBIZ-516:
---------------------------------------

Fred,

Yes I understand the problem now. Unfortunatly your patch seems not to resolve the problem. My use case (after having applied the patch of course):
Searching "clone" in eCommerce, "giant widget clone2" is found. Selecting the 2 options (says Black, 3 wheels). If I click on the link to the variant shown at right in Cart Sumary I see the right virtual ("giant widget clone2" contained in product infos). If if open the cart view and click on the link to the variant I don't see the right virtual ("giant widget clone2" is not showing but WG-9943).

I miss something ?

Thanks

Jacques

> virtual products sharing variants can cause inconsistest shopping cart
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-516
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-516
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: linux
>            Reporter: Fred Forester
>            Priority: Minor
>         Attachments: Sans titre.PNG, variant_patch.log
>
>
> If Virtual products are set up to share a group of variants the shopping cart may show a different virtual product than the one the customer actually selected.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-516?page=comments#action_12459087 ]
           
Fred Forester commented on OFBIZ-516:
-------------------------------------

Hi  Jacques

it seems cart view slipped my mind. the problem appears in a few other places also. the ecommerce link in the orderview order items. and the recenlty ordered items box on the bottom left. the last 2 problems may require the parent product id to be stored the orderitem entity.

thanx
Fred

> virtual products sharing variants can cause inconsistest shopping cart
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-516
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-516
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: linux
>            Reporter: Fred Forester
>            Priority: Minor
>         Attachments: Sans titre.PNG, variant_patch.log
>
>
> If Virtual products are set up to share a group of variants the shopping cart may show a different virtual product than the one the customer actually selected.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-516?page=all ]

Fred Forester updated OFBIZ-516:
--------------------------------

    Attachment: showcart_patch.txt

Jacques


here's a patch for showcart.ftl.

Fred

> virtual products sharing variants can cause inconsistest shopping cart
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-516
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-516
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: linux
>            Reporter: Fred Forester
>            Priority: Minor
>         Attachments: Sans titre.PNG, showcart_patch.txt, variant_patch.log
>
>
> If Virtual products are set up to share a group of variants the shopping cart may show a different virtual product than the one the customer actually selected.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-516:
-------------------------------------

    Assignee: Jacques Le Roux

> virtual products sharing variants can cause inconsistest shopping cart
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-516
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-516
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: linux
>            Reporter: Fred Forester
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>         Attachments: Sans titre.PNG, showcart_patch.txt, variant_patch.log
>
>
> If Virtual products are set up to share a group of variants the shopping cart may show a different virtual product than the one the customer actually selected.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira