OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-517) createPartyPostalAddress should set contactMechTypeId

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

7 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-517) createPartyPostalAddress should set contactMechTypeId

createPartyPostalAddress should set contactMechTypeId
-----------------------------------------------------

Key: OFBIZ-517
URL: http://issues.apache.org/jira/browse/OFBIZ-517
Project: OFBiz (The Open for Business Project)
Issue Type: Bug
Components: party
Affects Versions: SVN trunk
Reporter: Al Byers

In PartyContactMechServices, createPartyPostalAddress calls createPartyContactMech without setting contactMechTypeId. It is not required in createPartyContactmech, but it is required in createContactMech and throws an execption.

Same thing with createPartyTelecom

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-517) createPartyPostalAddress should set contactMechTypeId

[ http://issues.apache.org/jira/browse/OFBIZ-517?page=all ]

Al Byers updated OFBIZ-517:
---------------------------

Attachment: PartyContactMechServices.patch

> createPartyPostalAddress should set contactMechTypeId
> -----------------------------------------------------
>
> Key: OFBIZ-517
> URL: http://issues.apache.org/jira/browse/OFBIZ-517
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: party
> Affects Versions: SVN trunk
> Reporter: Al Byers
> Attachments: PartyContactMechServices.patch
>
>
> In PartyContactMechServices, createPartyPostalAddress calls createPartyContactMech without setting contactMechTypeId. It is not required in createPartyContactmech, but it is required in createContactMech and throws an execption.
> Same thing with createPartyTelecom

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-517) createPartyPostalAddress should set contactMechTypeId

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-517?page=all ]

Al Byers updated OFBIZ-517:
---------------------------

Attachment: PartyContactMechServices.patch

the previous upload would not fix the problem correctly.
this patch moves the order of setting the contactMechId in createPartyPostalAddress to after the auto setting of parameters.

> createPartyPostalAddress should set contactMechTypeId
> -----------------------------------------------------
>
> Key: OFBIZ-517
> URL: http://issues.apache.org/jira/browse/OFBIZ-517
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: party
> Affects Versions: SVN trunk
> Reporter: Al Byers
> Attachments: PartyContactMechServices.patch, PartyContactMechServices.patch
>
>
> In PartyContactMechServices, createPartyPostalAddress calls createPartyContactMech without setting contactMechTypeId. It is not required in createPartyContactmech, but it is required in createContactMech and throws an execption.
> Same thing with createPartyTelecom

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-517) createPartyPostalAddress should set contactMechTypeId

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-517?page=comments#action_12455669 ]

Al Byers commented on OFBIZ-517:
--------------------------------

The previous fix for this problem was incorrect.
It looks like these lines needed to be swapped in PartyContactMechServices.createPartyPostalAddrss:
<set-service-fields service-name="createPartyContactMech" map-name="parameters" to-map-name="createPartyContactMechMap"/>
<set field="createPartyContactMechMap.contactMechId" from-field="newPartyContactMech.contactMechId"/>
(that is correct as is)

> createPartyPostalAddress should set contactMechTypeId
> -----------------------------------------------------
>
> Key: OFBIZ-517
> URL: http://issues.apache.org/jira/browse/OFBIZ-517
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: party
> Affects Versions: SVN trunk
> Reporter: Al Byers
> Attachments: PartyContactMechServices.patch, PartyContactMechServices.patch
>
>
> In PartyContactMechServices, createPartyPostalAddress calls createPartyContactMech without setting contactMechTypeId. It is not required in createPartyContactmech, but it is required in createContactMech and throws an execption.
> Same thing with createPartyTelecom

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-517) createPartyPostalAddress should set contactMechTypeId

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-517?page=comments#action_12456767 ]

Jacopo Cappellato commented on OFBIZ-517:
-----------------------------------------

Al,

I think you are right and your second patch should be committed: you should have the commit rights of doing it and close this issue, but if you have any issue with it I can do it for you.

> createPartyPostalAddress should set contactMechTypeId
> -----------------------------------------------------
>
> Key: OFBIZ-517
> URL: http://issues.apache.org/jira/browse/OFBIZ-517
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: party
> Affects Versions: SVN trunk
> Reporter: Al Byers
> Attachments: PartyContactMechServices.patch, PartyContactMechServices.patch
>
>
> In PartyContactMechServices, createPartyPostalAddress calls createPartyContactMech without setting contactMechTypeId. It is not required in createPartyContactmech, but it is required in createContactMech and throws an execption.
> Same thing with createPartyTelecom

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-517) createPartyPostalAddress should set contactMechTypeId

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-517?page=all ]

Jacques Le Roux updated OFBIZ-517:
----------------------------------

Attachment: (was: PartyContactMechServices.patch)

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-517) createPartyPostalAddress should set contactMechTypeId

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-517?page=all ]

Jacques Le Roux closed OFBIZ-517.
---------------------------------

Fix Version/s: SVN trunk
Resolution: Fixed
Assignee: Jacques Le Roux

I applied the patch but please next time Al don't forget to make the patch from root. It's uneasy to apply patches without relative pathes from root.
ie
good : applications/party/script/org/ofbiz/party/contact/PartyContactMechServices.xml
not good : PartyContactMechServices.xml

BTW like explained Jacopo as a member of PMC and commiter you should be able to commit yourself.

Completed: At revision: 484977

Thanks ;o)

> createPartyPostalAddress should set contactMechTypeId
> -----------------------------------------------------
>
> Key: OFBIZ-517
> URL: http://issues.apache.org/jira/browse/OFBIZ-517
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: party
> Affects Versions: SVN trunk
> Reporter: Al Byers
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: PartyContactMechServices.patch
>
>
> In PartyContactMechServices, createPartyPostalAddress calls createPartyContactMech without setting contactMechTypeId. It is not required in createPartyContactmech, but it is required in createContactMech and throws an execption.
> Same thing with createPartyTelecom