[jira] Created: (OFBIZ-530) Code-Cleanup: new Boolean(true) -> Boolean.TRUE

[Nicolas Malin (Jira)]

Code-Cleanup: new Boolean(true) -> Boolean.TRUE
-----------------------------------------------

                 Key: OFBIZ-530
                 URL: http://issues.apache.org/jira/browse/OFBIZ-530
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
            Reporter: Stefan Huehner
            Priority: Trivial
         Attachments: ofbiz_Boolean_static_1.diff

Hi attached patch tries to reduce the number of created objects. In a lot of Places Boolean objects to hold the true/false values are created. Each of them creates a new object to hold these 2 final states. The patch converts all of these to using the final static Boolean.TRUE / Boolean.FALSE values.


--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-530?page=all ]

Stefan Huehner updated OFBIZ-530:
---------------------------------

    Attachment: ofbiz_Boolean_static_1.diff

> Code-Cleanup: new Boolean(true) -> Boolean.TRUE
> -----------------------------------------------
>
>                 Key: OFBIZ-530
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-530
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Stefan Huehner
>            Priority: Trivial
>         Attachments: ofbiz_Boolean_static_1.diff
>
>
> Hi attached patch tries to reduce the number of created objects. In a lot of Places Boolean objects to hold the true/false values are created. Each of them creates a new object to hold these 2 final states. The patch converts all of these to using the final static Boolean.TRUE / Boolean.FALSE values.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-530?page=all ]

Stefan Huehner updated OFBIZ-530:
---------------------------------

    Attachment: ofbiz_Boolean_static_1a.diff

One more file is included in this patch. Rest ist the same as in version 1.diff

> Code-Cleanup: new Boolean(true) -> Boolean.TRUE
> -----------------------------------------------
>
>                 Key: OFBIZ-530
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-530
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Stefan Huehner
>            Priority: Trivial
>         Attachments: ofbiz_Boolean_static_1.diff, ofbiz_Boolean_static_1a.diff
>
>
> Hi attached patch tries to reduce the number of created objects. In a lot of Places Boolean objects to hold the true/false values are created. Each of them creates a new object to hold these 2 final states. The patch converts all of these to using the final static Boolean.TRUE / Boolean.FALSE values.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-530?page=all ]

Jacopo Cappellato updated OFBIZ-530:
------------------------------------

    Attachment:     (was: ofbiz_Boolean_static_1.diff)

> Code-Cleanup: new Boolean(true) -> Boolean.TRUE
> -----------------------------------------------
>
>                 Key: OFBIZ-530
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-530
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Stefan Huehner
>            Priority: Trivial
>         Attachments: ofbiz_Boolean_static_1a.diff
>
>
> Hi attached patch tries to reduce the number of created objects. In a lot of Places Boolean objects to hold the true/false values are created. Each of them creates a new object to hold these 2 final states. The patch converts all of these to using the final static Boolean.TRUE / Boolean.FALSE values.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-530?page=all ]

Jacopo Cappellato reassigned OFBIZ-530:
---------------------------------------

    Assignee: Jacopo Cappellato

> Code-Cleanup: new Boolean(true) -> Boolean.TRUE
> -----------------------------------------------
>
>                 Key: OFBIZ-530
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-530
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Stefan Huehner
>         Assigned To: Jacopo Cappellato
>            Priority: Trivial
>         Attachments: ofbiz_Boolean_static_1a.diff
>
>
> Hi attached patch tries to reduce the number of created objects. In a lot of Places Boolean objects to hold the true/false values are created. Each of them creates a new object to hold these 2 final states. The patch converts all of these to using the final static Boolean.TRUE / Boolean.FALSE values.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-530?page=comments#action_12457061 ]
           
Jacopo Cappellato commented on OFBIZ-530:
-----------------------------------------

Hi Stefan,

could you please create your patches without the -u options please? I'm having problems applying them...

See:

http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices

Thanks

> Code-Cleanup: new Boolean(true) -> Boolean.TRUE
> -----------------------------------------------
>
>                 Key: OFBIZ-530
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-530
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Stefan Huehner
>         Assigned To: Jacopo Cappellato
>            Priority: Trivial
>         Attachments: ofbiz_Boolean_static_1a.diff
>
>
> Hi attached patch tries to reduce the number of created objects. In a lot of Places Boolean objects to hold the true/false values are created. Each of them creates a new object to hold these 2 final states. The patch converts all of these to using the final static Boolean.TRUE / Boolean.FALSE values.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-530?page=all ]

Jacques Le Roux closed OFBIZ-530.
---------------------------------

    Fix Version/s: SVN trunk
       Resolution: Fixed
         Assignee: Jacques Le Roux  (was: Jacopo Cappellato)

Stefan, Jacopo,

On Windows I was able to apply and commit the file in rev. 484976. Of course i snot a reason to use -u option ;o)

Thanks

> Code-Cleanup: new Boolean(true) -> Boolean.TRUE
> -----------------------------------------------
>
>                 Key: OFBIZ-530
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-530
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Stefan Huehner
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ofbiz_Boolean_static_1a.diff
>
>
> Hi attached patch tries to reduce the number of created objects. In a lot of Places Boolean objects to hold the true/false values are created. Each of them creates a new object to hold these 2 final states. The patch converts all of these to using the final static Boolean.TRUE / Boolean.FALSE values.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-530?page=comments#action_12457073 ]
           
Jacopo Cappellato commented on OFBIZ-530:
-----------------------------------------

Thanks Jacques!

> Code-Cleanup: new Boolean(true) -> Boolean.TRUE
> -----------------------------------------------
>
>                 Key: OFBIZ-530
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-530
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Stefan Huehner
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ofbiz_Boolean_static_1a.diff
>
>
> Hi attached patch tries to reduce the number of created objects. In a lot of Places Boolean objects to hold the true/false values are created. Each of them creates a new object to hold these 2 final states. The patch converts all of these to using the final static Boolean.TRUE / Boolean.FALSE values.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira