[jira] Created: (OFBIZ-533) Code-Cleanup: remove superflous new String and .toString() calls

[Nicolas Malin (Jira)]

Code-Cleanup: remove superflous new String and .toString() calls
----------------------------------------------------------------

                 Key: OFBIZ-533
                 URL: http://issues.apache.org/jira/browse/OFBIZ-533
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
    Affects Versions: SVN trunk
            Reporter: Stefan Huehner
            Priority: Trivial
         Attachments: ofbiz_string_toString_1.diff

Hi attached patch removes some "new String" calls where the contructor argument is already a string. In adddition a lot to ".toString" calls have been removed where the argument was already a String.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-533?page=all ]

Stefan Huehner updated OFBIZ-533:
---------------------------------

    Attachment: ofbiz_string_toString_1.diff

> Code-Cleanup: remove superflous new String and .toString() calls
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-533
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-533
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>            Priority: Trivial
>         Attachments: ofbiz_string_toString_1.diff
>
>
> Hi attached patch removes some "new String" calls where the contructor argument is already a string. In adddition a lot to ".toString" calls have been removed where the argument was already a String.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-533?page=all ]

Jacopo Cappellato reassigned OFBIZ-533:
---------------------------------------

    Assignee: Jacopo Cappellato

> Code-Cleanup: remove superflous new String and .toString() calls
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-533
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-533
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>         Assigned To: Jacopo Cappellato
>            Priority: Trivial
>         Attachments: ofbiz_string_toString_1.diff
>
>
> Hi attached patch removes some "new String" calls where the contructor argument is already a string. In adddition a lot to ".toString" calls have been removed where the argument was already a String.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-533?page=comments#action_12457060 ]
           
Jacopo Cappellato commented on OFBIZ-533:
-----------------------------------------

Hi Stefan,

could you please create your patches without the -u options please? I'm having problems applying them...

See:

http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices

Thanks

> Code-Cleanup: remove superflous new String and .toString() calls
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-533
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-533
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>         Assigned To: Jacopo Cappellato
>            Priority: Trivial
>         Attachments: ofbiz_string_toString_1.diff
>
>
> Hi attached patch removes some "new String" calls where the contructor argument is already a string. In adddition a lot to ".toString" calls have been removed where the argument was already a String.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-533?page=all ]

Jacques Le Roux closed OFBIZ-533.
---------------------------------

    Fix Version/s: SVN trunk
       Resolution: Fixed
         Assignee: Jacques Le Roux  (was: Jacopo Cappellato)

Stefan, Jacopo,

On WIndows I was able to apply and commit the file in rev. 484972. But definitely yes, -u option is not to use.

Thanks

> Code-Cleanup: remove superflous new String and .toString() calls
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-533
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-533
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ofbiz_string_toString_1.diff
>
>
> Hi attached patch removes some "new String" calls where the contructor argument is already a string. In adddition a lot to ".toString" calls have been removed where the argument was already a String.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-533?page=comments#action_12457066 ]
           
Jacques Le Roux commented on OFBIZ-533:
---------------------------------------

Sorry for rev# : completed in revisions 484973 and 484974  

> Code-Cleanup: remove superflous new String and .toString() calls
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-533
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-533
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ofbiz_string_toString_1.diff
>
>
> Hi attached patch removes some "new String" calls where the contructor argument is already a string. In adddition a lot to ".toString" calls have been removed where the argument was already a String.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira