[jira] Created: (OFBIZ-534) Special characters such as double quote in Form Widget

[Nicolas Malin (Jira)]

Special characters such as double quote in Form Widget
------------------------------------------------------

                 Key: OFBIZ-534
                 URL: http://issues.apache.org/jira/browse/OFBIZ-534
             Project: OFBiz (The Open for Business Project)
          Issue Type: Bug
          Components: framework
            Reporter: Ismail Cansiz
            Priority: Critical


I have entered "Ofbiz Test" <[hidden email]> to fromEmailAddress field in updateProductStoreEmail form and saved the data.
Then i have recalled this form. But form doesn't shown properly. Because double quote character didn't convert to &quot;;

The form field datas must be convert to html string in ModelFormField.java.
I want to make a patch for this bug.

Does anybody has thought this?

Regards,
Ismail

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-534?page=comments#action_12456469 ]
           
Ismail Cansiz commented on OFBIZ-534:
-------------------------------------

There is same problem in HtmlFormRenderer.java too. Field values should be convert to html syntax in renderTextField and renderHiddenField methods.

> Special characters such as double quote in Form Widget
> ------------------------------------------------------
>
>                 Key: OFBIZ-534
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-534
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: framework
>            Reporter: Ismail Cansiz
>            Priority: Critical
>
> I have entered "Ofbiz Test" <[hidden email]> to fromEmailAddress field in updateProductStoreEmail form and saved the data.
> Then i have recalled this form. But form doesn't shown properly. Because double quote character didn't convert to &quot;;
> The form field datas must be convert to html string in ModelFormField.java.
> I want to make a patch for this bug.
> Does anybody has thought this?
> Regards,
> Ismail

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-534?page=all ]

Ismail Cansiz updated OFBIZ-534:
--------------------------------

    Attachment: HtmlFormRenderer.patch

I have a patch file to solution for this bug. I have tested and problem is solved for input text fields..
The file is containing only one modification for renderTextField method.
In the other methods such as renderTextAreaField may be require some modifications.

Any thoughts?

Thanks,
Ismail

> Special characters such as double quote in Form Widget
> ------------------------------------------------------
>
>                 Key: OFBIZ-534
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-534
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: framework
>            Reporter: Ismail Cansiz
>            Priority: Critical
>         Attachments: HtmlFormRenderer.patch
>
>
> I have entered "Ofbiz Test" <[hidden email]> to fromEmailAddress field in updateProductStoreEmail form and saved the data.
> Then i have recalled this form. But form doesn't shown properly. Because double quote character didn't convert to &quot;;
> The form field datas must be convert to html string in ModelFormField.java.
> I want to make a patch for this bug.
> Does anybody has thought this?
> Regards,
> Ismail

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-534?page=comments#action_12456761 ]
           
Jacopo Cappellato commented on OFBIZ-534:
-----------------------------------------

I think this is a good solution, can we commit this patch? Or are there any issues this could cause?

> Special characters such as double quote in Form Widget
> ------------------------------------------------------
>
>                 Key: OFBIZ-534
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-534
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: framework
>            Reporter: Ismail Cansiz
>            Priority: Critical
>         Attachments: HtmlFormRenderer.patch
>
>
> I have entered "Ofbiz Test" <[hidden email]> to fromEmailAddress field in updateProductStoreEmail form and saved the data.
> Then i have recalled this form. But form doesn't shown properly. Because double quote character didn't convert to &quot;;
> The form field datas must be convert to html string in ModelFormField.java.
> I want to make a patch for this bug.
> Does anybody has thought this?
> Regards,
> Ismail

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira