OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-547) Duplicate Id error on Create New FixedAsset

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

25 messages Options

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-547) Duplicate Id error on Create New FixedAsset

[ https://issues.apache.org/jira/browse/OFBIZ-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-547.
---------------------------------

Resolution: Fixed
Fix Version/s: SVN trunk

Anil,

Your patch is in OFBiz revision: 492411

Thanks

> Duplicate Id error on Create New FixedAsset
> -------------------------------------------
>
> Key: OFBIZ-547
> URL: https://issues.apache.org/jira/browse/OFBIZ-547
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Anil K Patel
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: FixedAssedIdDuplicateMessage_Update1.patch
>
>
> While creating a New FixedAsset, if user enters FixedAssetId that already exists in system, Unfriendly message is returned and existing fixedAsset is opened in Edit mode.
> 1) The error message should be easier to understand by user.
> 2) Existing fixedAsset should not be opened in edit mode, this confuses user with Idea that fixedAsset was created.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-547) Duplicate Id error on Create New FixedAsset

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462133 ]

Anil K Patel commented on OFBIZ-547:
------------------------------------

Jacques,
Thanks for your time and help.
Regards

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-547) Duplicate Id error on Create New FixedAsset

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462155 ]

David E. Jones commented on OFBIZ-547:
--------------------------------------

Yes, I guess a commit is a good way to get someone, especially someone like me, to review it!

Anyway, this all looks pretty safe, and more closely follow the pattern used with the createProduct service.

BTW, in general the use of "entity-one" is far more effective and less error prone than the use of "find-by-primary-key". The main reason for this is that the field mappings are done with sub-elements, not with a Map that must be created and worried about.

Anil Patel

Re: [jira] Commented: (OFBIZ-547) Duplicate Id error on Create New FixedAsset

David,
thanks for your comments. In fact I noticed pattern recently and used it in
patch applied to following issue.
https://issues.apache.org/jira/browse/OFBIZ-585

Regards
Anil Patel

On 1/3/07, David E. Jones (JIRA) <[hidden email]> wrote:

>
>
> [
> https://issues.apache.org/jira/browse/OFBIZ-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462155]
>
> David E. Jones commented on OFBIZ-547:
> --------------------------------------
>
> Yes, I guess a commit is a good way to get someone, especially someone
> like me, to review it!
>
> Anyway, this all looks pretty safe, and more closely follow the pattern
> used with the createProduct service.
>
> BTW, in general the use of "entity-one" is far more effective and less
> error prone than the use of "find-by-primary-key". The main reason for this
> is that the field mappings are done with sub-elements, not with a Map that
> must be created and worried about.
>
> > Duplicate Id error on Create New FixedAsset
> > -------------------------------------------
> >
> > Key: OFBIZ-547
> > URL: https://issues.apache.org/jira/browse/OFBIZ-547
> > Project: Apache OFBiz (The Open for Business Project)
> > Issue Type: Improvement
> > Components: accounting
> > Reporter: Anil K Patel
> > Assigned To: Jacques Le Roux
> > Fix For: SVN trunk
> >
> > Attachments: FixedAssedIdDuplicateMessage_Update1.patch
> >
> >
> > While creating a New FixedAsset, if user enters FixedAssetId that
> already exists in system, Unfriendly message is returned and existing
> fixedAsset is opened in Edit mode.
> > 1) The error message should be easier to understand by user.
> > 2) Existing fixedAsset should not be opened in edit mode, this confuses
> user with Idea that fixedAsset was created.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> https://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-547) Duplicate Id error on Create New FixedAsset

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462192 ]

Jacques Le Roux commented on OFBIZ-547:
---------------------------------------

Thanks for the comment David, this is this kind of little notes that helps to better handle MiniLang.