False message in receive return
------------------------------- Key: OFBIZ-550 URL: http://issues.apache.org/jira/browse/OFBIZ-550 Project: OFBiz (The Open for Business Project) Issue Type: Bug Components: product Affects Versions: SVN trunk Reporter: Jacques Le Roux Assigned To: Jacques Le Roux Fix For: SVN trunk I think I found a bug in receive return but I prefer this patch been reviewed because I maybe overlooked something If you apply a receive return you get a false message when returning correctly (hence in state RETURN_REQUESTED) from application. This message comes from receiveReturn.bsh where there is a test for status of the return header to be "RETURN_ACCEPTED". I think this message is superfluous in case of RETURN_REQUESTED. I propose to add a specific message in this case. Please see patch. Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[ http://issues.apache.org/jira/browse/OFBIZ-550?page=all ]
Jacques Le Roux updated OFBIZ-550: ---------------------------------- Attachment: receiveReturn.bsh.patch > False message in receive return > ------------------------------- > > Key: OFBIZ-550 > URL: http://issues.apache.org/jira/browse/OFBIZ-550 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assigned To: Jacques Le Roux > Fix For: SVN trunk > > Attachments: receiveReturn.bsh.patch > > > I think I found a bug in receive return but I prefer this patch been reviewed because I maybe overlooked something > If you apply a receive return you get a false message when returning correctly (hence in state RETURN_REQUESTED) from application. This message comes from receiveReturn.bsh where there is a test for status of the return header to be "RETURN_ACCEPTED". I think this message is superfluous in case of RETURN_REQUESTED. I propose to add a specific message in this case. Please see patch. > Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-550?page=all ]
Jacques Le Roux updated OFBIZ-550: ---------------------------------- Attachment: (was: receiveReturn.bsh.patch) > False message in receive return > ------------------------------- > > Key: OFBIZ-550 > URL: http://issues.apache.org/jira/browse/OFBIZ-550 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assigned To: Jacques Le Roux > Fix For: SVN trunk > > Attachments: receiveReturn.bsh.patch > > > I think I found a bug in receive return but I prefer this patch been reviewed because I maybe overlooked something > If you apply a receive return you get a false message when returning correctly (hence in state RETURN_REQUESTED) from application. This message comes from receiveReturn.bsh where there is a test for status of the return header to be "RETURN_ACCEPTED". I think this message is superfluous in case of RETURN_REQUESTED. I propose to add a specific message in this case. Please see patch. > Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-550?page=all ]
Jacques Le Roux updated OFBIZ-550: ---------------------------------- Attachment: receiveReturn.bsh.patch > False message in receive return > ------------------------------- > > Key: OFBIZ-550 > URL: http://issues.apache.org/jira/browse/OFBIZ-550 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assigned To: Jacques Le Roux > Fix For: SVN trunk > > Attachments: receiveReturn.bsh.patch > > > I think I found a bug in receive return but I prefer this patch been reviewed because I maybe overlooked something > If you apply a receive return you get a false message when returning correctly (hence in state RETURN_REQUESTED) from application. This message comes from receiveReturn.bsh where there is a test for status of the return header to be "RETURN_ACCEPTED". I think this message is superfluous in case of RETURN_REQUESTED. I propose to add a specific message in this case. Please see patch. > Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-550?page=all ]
Jacques Le Roux updated OFBIZ-550: ---------------------------------- Attachment: (was: receiveReturn.bsh.patch) > False message in receive return > ------------------------------- > > Key: OFBIZ-550 > URL: http://issues.apache.org/jira/browse/OFBIZ-550 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assigned To: Jacques Le Roux > Fix For: SVN trunk > > > I think I found a bug in receive return but I prefer this patch been reviewed because I maybe overlooked something > If you apply a receive return you get a false message when returning correctly (hence in state RETURN_REQUESTED) from application. This message comes from receiveReturn.bsh where there is a test for status of the return header to be "RETURN_ACCEPTED". I think this message is superfluous in case of RETURN_REQUESTED. I propose to add a specific message in this case. Please see patch. > Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-550?page=all ]
Jacques Le Roux updated OFBIZ-550: ---------------------------------- Attachment: receiveReturn.bsh.patch I also removed superfluous <li> > False message in receive return > ------------------------------- > > Key: OFBIZ-550 > URL: http://issues.apache.org/jira/browse/OFBIZ-550 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assigned To: Jacques Le Roux > Fix For: SVN trunk > > Attachments: receiveReturn.bsh.patch > > > I think I found a bug in receive return but I prefer this patch been reviewed because I maybe overlooked something > If you apply a receive return you get a false message when returning correctly (hence in state RETURN_REQUESTED) from application. This message comes from receiveReturn.bsh where there is a test for status of the return header to be "RETURN_ACCEPTED". I think this message is superfluous in case of RETURN_REQUESTED. I propose to add a specific message in this case. Please see patch. > Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-550?page=all ]
Jacques Le Roux updated OFBIZ-550: ---------------------------------- Attachment: (was: receiveReturn.bsh.patch) > False message in receive return > ------------------------------- > > Key: OFBIZ-550 > URL: http://issues.apache.org/jira/browse/OFBIZ-550 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assigned To: Jacques Le Roux > Fix For: SVN trunk > > > I think I found a bug in receive return but I prefer this patch been reviewed because I maybe overlooked something > If you apply a receive return you get a false message when returning correctly (hence in state RETURN_REQUESTED) from application. This message comes from receiveReturn.bsh where there is a test for status of the return header to be "RETURN_ACCEPTED". I think this message is superfluous in case of RETURN_REQUESTED. I propose to add a specific message in this case. Please see patch. > Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-550?page=all ]
Jacques Le Roux updated OFBIZ-550: ---------------------------------- Attachment: receiveReturn.bsh.patch Finally added i18n and i10n (french only) > False message in receive return > ------------------------------- > > Key: OFBIZ-550 > URL: http://issues.apache.org/jira/browse/OFBIZ-550 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assigned To: Jacques Le Roux > Fix For: SVN trunk > > Attachments: receiveReturn.bsh.patch > > > I think I found a bug in receive return but I prefer this patch been reviewed because I maybe overlooked something > If you apply a receive return you get a false message when returning correctly (hence in state RETURN_REQUESTED) from application. This message comes from receiveReturn.bsh where there is a test for status of the return header to be "RETURN_ACCEPTED". I think this message is superfluous in case of RETURN_REQUESTED. I propose to add a specific message in this case. Please see patch. > Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-550?page=all ]
Jacques Le Roux updated OFBIZ-550: ---------------------------------- Attachment: (was: receiveReturn.bsh.patch) > False message in receive return > ------------------------------- > > Key: OFBIZ-550 > URL: http://issues.apache.org/jira/browse/OFBIZ-550 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assigned To: Jacques Le Roux > Fix For: SVN trunk > > > I think I found a bug in receive return but I prefer this patch been reviewed because I maybe overlooked something > If you apply a receive return you get a false message when returning correctly (hence in state RETURN_REQUESTED) from application. This message comes from receiveReturn.bsh where there is a test for status of the return header to be "RETURN_ACCEPTED". I think this message is superfluous in case of RETURN_REQUESTED. I propose to add a specific message in this case. Please see patch. > Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-550?page=all ]
Jacques Le Roux updated OFBIZ-550: ---------------------------------- Attachment: receiveReturn.bsh.patch Better i18n/110n with all stuffes > False message in receive return > ------------------------------- > > Key: OFBIZ-550 > URL: http://issues.apache.org/jira/browse/OFBIZ-550 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assigned To: Jacques Le Roux > Fix For: SVN trunk > > Attachments: receiveReturn.bsh.patch > > > I think I found a bug in receive return but I prefer this patch been reviewed because I maybe overlooked something > If you apply a receive return you get a false message when returning correctly (hence in state RETURN_REQUESTED) from application. This message comes from receiveReturn.bsh where there is a test for status of the return header to be "RETURN_ACCEPTED". I think this message is superfluous in case of RETURN_REQUESTED. I propose to add a specific message in this case. Please see patch. > Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-550?page=all ]
Jacques Le Roux updated OFBIZ-550: ---------------------------------- Attachment: (was: receiveReturn.bsh.patch) > False message in receive return > ------------------------------- > > Key: OFBIZ-550 > URL: http://issues.apache.org/jira/browse/OFBIZ-550 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assigned To: Jacques Le Roux > Fix For: SVN trunk > > > I think I found a bug in receive return but I prefer this patch been reviewed because I maybe overlooked something > If you apply a receive return you get a false message when returning correctly (hence in state RETURN_REQUESTED) from application. This message comes from receiveReturn.bsh where there is a test for status of the return header to be "RETURN_ACCEPTED". I think this message is superfluous in case of RETURN_REQUESTED. I propose to add a specific message in this case. Please see patch. > Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-550?page=all ]
Jacques Le Roux updated OFBIZ-550: ---------------------------------- Attachment: receiveReturn.bsh.patch Arghh :( One more time caught by Cut/Paste : _ERROR_MESSAGE_ is not _EVENT_MESSAGE_ > False message in receive return > ------------------------------- > > Key: OFBIZ-550 > URL: http://issues.apache.org/jira/browse/OFBIZ-550 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assigned To: Jacques Le Roux > Fix For: SVN trunk > > Attachments: receiveReturn.bsh.patch > > > I think I found a bug in receive return but I prefer this patch been reviewed because I maybe overlooked something > If you apply a receive return you get a false message when returning correctly (hence in state RETURN_REQUESTED) from application. This message comes from receiveReturn.bsh where there is a test for status of the return header to be "RETURN_ACCEPTED". I think this message is superfluous in case of RETURN_REQUESTED. I propose to add a specific message in this case. Please see patch. > Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-550?page=comments#action_12459201 ]
Jacques Le Roux commented on OFBIZ-550: --------------------------------------- This fairly simple and harmless, waiting for comments else will use old CTR strategy (see Geronimo experience http://cwiki.apache.org/GMOxPMGT/commit-then-review-ctr-comeback-policy.html ;o) > False message in receive return > ------------------------------- > > Key: OFBIZ-550 > URL: http://issues.apache.org/jira/browse/OFBIZ-550 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assigned To: Jacques Le Roux > Fix For: SVN trunk > > Attachments: receiveReturn.bsh.patch > > > I think I found a bug in receive return but I prefer this patch been reviewed because I maybe overlooked something > If you apply a receive return you get a false message when returning correctly (hence in state RETURN_REQUESTED) from application. This message comes from receiveReturn.bsh where there is a test for status of the return header to be "RETURN_ACCEPTED". I think this message is superfluous in case of RETURN_REQUESTED. I propose to add a specific message in this case. Please see patch. > Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-550?page=all ]
Jacques Le Roux closed OFBIZ-550. --------------------------------- Resolution: Fixed Completed: At revision: 489476 > False message in receive return > ------------------------------- > > Key: OFBIZ-550 > URL: http://issues.apache.org/jira/browse/OFBIZ-550 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assigned To: Jacques Le Roux > Fix For: SVN trunk > > Attachments: receiveReturn.bsh.patch > > > I think I found a bug in receive return but I prefer this patch been reviewed because I maybe overlooked something > If you apply a receive return you get a false message when returning correctly (hence in state RETURN_REQUESTED) from application. This message comes from receiveReturn.bsh where there is a test for status of the return header to be "RETURN_ACCEPTED". I think this message is superfluous in case of RETURN_REQUESTED. I propose to add a specific message in this case. Please see patch. > Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
Free forum by Nabble | Edit this page |