OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-56) incoming email attachments buggy

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

28 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-56) incoming email attachments buggy

incoming email attachments buggy
--------------------------------

Key: OFBIZ-56
URL: http://issues.apache.org/jira/browse/OFBIZ-56
Project: The Open For Business Project
Type: Bug

Components: content
Versions: SVN trunk
Reporter: Si Chen
Fix For: SVN trunk

storeIncomingEmail has problems with attachments. If you send two images, the same image ends up being stored twice. Some types of content are not stored correctly (such as word docs with images embedded). Other times the /ViewSimpleContent request has problems retrieving content correctly.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-56) incoming email attachments buggy

[ http://issues.apache.org/jira/browse/OFBIZ-56?page=comments#action_12418355 ]

BJ Freeman commented on OFBIZ-56:
---------------------------------

I notice the code to only enter the email once is not working, under this case.
and email comes in where either the to or from or both the parties are marked unkown.

So the the addresses get stored in comments.

so when the mail is downloaded again. the status to and from will not match and new comm event is created.

> incoming email attachments buggy
> --------------------------------
>
> Key: OFBIZ-56
> URL: http://issues.apache.org/jira/browse/OFBIZ-56
> Project: The Open For Business Project
> Type: Bug

> Components: content
> Versions: SVN trunk
> Reporter: Si Chen
> Fix For: SVN trunk

>
> storeIncomingEmail has problems with attachments. If you send two images, the same image ends up being stored twice. Some types of content are not stored correctly (such as word docs with images embedded). Other times the /ViewSimpleContent request has problems retrieving content correctly.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-56) incoming email attachments buggy

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-56?page=comments#action_12418361 ]

BJ Freeman commented on OFBIZ-56:
---------------------------------

under comment
// store a note when the to/from emails are not associated with any parties in the system

the Party to does not set the status if unknown as does the partyFrom.

> incoming email attachments buggy
> --------------------------------
>
> Key: OFBIZ-56
> URL: http://issues.apache.org/jira/browse/OFBIZ-56
> Project: The Open For Business Project
> Type: Bug

> Components: content
> Versions: SVN trunk
> Reporter: Si Chen
> Fix For: SVN trunk

>
> storeIncomingEmail has problems with attachments. If you send two images, the same image ends up being stored twice. Some types of content are not stored correctly (such as word docs with images embedded). Other times the /ViewSimpleContent request has problems retrieving content correctly.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-56) incoming email attachments buggy

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-56?page=comments#action_12418363 ]

BJ Freeman commented on OFBIZ-56:
---------------------------------

Does not store the Header info.

Not sure my header processing code, that checks for things like does the domain and IP match.
if the email has been relayed.

if you think is of interest wll attach it here.

> incoming email attachments buggy
> --------------------------------
>
> Key: OFBIZ-56
> URL: http://issues.apache.org/jira/browse/OFBIZ-56
> Project: The Open For Business Project
> Type: Bug

> Components: content
> Versions: SVN trunk
> Reporter: Si Chen
> Fix For: SVN trunk

>
> storeIncomingEmail has problems with attachments. If you send two images, the same image ends up being stored twice. Some types of content are not stored correctly (such as word docs with images embedded). Other times the /ViewSimpleContent request has problems retrieving content correctly.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-56) incoming email attachments buggy

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-56?page=comments#action_12418370 ]

BJ Freeman commented on OFBIZ-56:
---------------------------------

possible code change
after
//Set sent and received dates

where it is gettting the content type.
how about a try catch to check if we have that mime type in our list.
if not then add it as a task or just add it to the list.

> incoming email attachments buggy
> --------------------------------
>
> Key: OFBIZ-56
> URL: http://issues.apache.org/jira/browse/OFBIZ-56
> Project: The Open For Business Project
> Type: Bug

> Components: content
> Versions: SVN trunk
> Reporter: Si Chen
> Fix For: SVN trunk

>
> storeIncomingEmail has problems with attachments. If you send two images, the same image ends up being stored twice. Some types of content are not stored correctly (such as word docs with images embedded). Other times the /ViewSimpleContent request has problems retrieving content correctly.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-56) incoming email attachments buggy

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-56?page=comments#action_12418371 ]

BJ Freeman commented on OFBIZ-56:
---------------------------------

emailworker.java

addAttachmentsToCommEvent
it sets the mime to
commEventMap.put("mimeTypeId", "text/html")
This may not be the case.
could be
text/plain
should get the content type from the passed in parms.
There should be a defualt in properties, that if null it is set to.

> incoming email attachments buggy
> --------------------------------
>
> Key: OFBIZ-56
> URL: http://issues.apache.org/jira/browse/OFBIZ-56
> Project: The Open For Business Project
> Type: Bug

> Components: content
> Versions: SVN trunk
> Reporter: Si Chen
> Fix For: SVN trunk

>
> storeIncomingEmail has problems with attachments. If you send two images, the same image ends up being stored twice. Some types of content are not stored correctly (such as word docs with images embedded). Other times the /ViewSimpleContent request has problems retrieving content correctly.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-56) incoming email attachments buggy

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-56?page=comments#action_12418379 ]

BJ Freeman commented on OFBIZ-56:
---------------------------------

expand
public String getContentType()
check for other formats that denote mime types.
should be internationlized.
would be the place to check if mime type is listed or not and insert it.

> incoming email attachments buggy
> --------------------------------
>
> Key: OFBIZ-56
> URL: http://issues.apache.org/jira/browse/OFBIZ-56
> Project: The Open For Business Project
> Type: Bug

> Components: content
> Versions: SVN trunk
> Reporter: Si Chen
> Fix For: SVN trunk

>
> storeIncomingEmail has problems with attachments. If you send two images, the same image ends up being stored twice. Some types of content are not stored correctly (such as word docs with images embedded). Other times the /ViewSimpleContent request has problems retrieving content correctly.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira

PhantomsHorridC

unsubscribe

In reply to this post by Nicolas Malin (Jira)

Remove me fromt this list

___________________________________________________________
Inbox full of spam? Get leading spam protection and 1GB storage with All New Yahoo! Mail. http://uk.docs.yahoo.com/nowyoucan.html

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-56) incoming email attachments buggy

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-56?page=comments#action_12418498 ]

BJ Freeman commented on OFBIZ-56:
---------------------------------

here is a small change to storeIncomingEmail()

// store a note when the to/from emails are not associated with any
// parties in the system
String commNote = "";
if (partyIdFrom != null) {
commEventMap.put("partyIdFrom", partyIdFrom);
commEventMap.put("contactMechIdFrom", contactMechIdFrom);
// commEventMap.put("contactMechIdTo", contactMechIdTo);
commEventMap.put("statusId", "COM_ENTERED");
} else {
// create a task to find party for email
commEventMap.put("statusId", "COM_UNKNOWN_PARTY");
commNote = "Sent from: " + UtilMisc.toListArray(addressesFrom);
}
// modifed 06/20/06 to match the partyIDfrom

if (partyIdTo != null) {
commEventMap.put("partyIdto", partyIdTo);
//moved from PartyIDfrom, since if PartyIDfrom is null won't get set.
commEventMap.put("contactMechIdTo", contactMechIdTo);
//no need to status here set in From
}else {
// create a task to find party for email
//this will override the status already set
commEventMap.put("statusId", "COM_UNKNOWN_PARTY");
commNote += "Sent to: " + UtilMisc.toListArray(addressesTo);
}

> incoming email attachments buggy
> --------------------------------
>
> Key: OFBIZ-56
> URL: http://issues.apache.org/jira/browse/OFBIZ-56
> Project: The Open For Business Project
> Type: Bug

> Components: content
> Versions: SVN trunk
> Reporter: Si Chen
> Fix For: SVN trunk

>
> storeIncomingEmail has problems with attachments. If you send two images, the same image ends up being stored twice. Some types of content are not stored correctly (such as word docs with images embedded). Other times the /ViewSimpleContent request has problems retrieving content correctly.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-56) incoming email attachments buggy

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-56?page=comments#action_12419016 ]

BJ Freeman commented on OFBIZ-56:
---------------------------------

Attachment doe not show

From the Header

Message-ID: <003401c69eb1$1a19b450$[hidden email]>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----=_NextPart_000_0035_01C69E8F.93081450"
X-Mailer: Microsoft CDO for Windows 2000
Content-Class: urn:content-classes:message
Importance: normal
Priority: normal
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.3790.504

the content Text is "Please see attached..".
This does not show up.

it is a text based attachment with Tab delimited text

I see one content box with nothing in it.

have a a screen that shows the entities that are linked for a particular Communications ID.
if this would help in trouble shooting let me know I will included.

.

> incoming email attachments buggy
> --------------------------------
>
> Key: OFBIZ-56
> URL: http://issues.apache.org/jira/browse/OFBIZ-56
> Project: The Open For Business Project
> Type: Bug

> Components: content
> Versions: SVN trunk
> Reporter: Si Chen
> Fix For: SVN trunk

>
> storeIncomingEmail has problems with attachments. If you send two images, the same image ends up being stored twice. Some types of content are not stored correctly (such as word docs with images embedded). Other times the /ViewSimpleContent request has problems retrieving content correctly.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-56) incoming email attachments buggy

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-56?page=comments#action_12424139 ]

Si Chen commented on OFBIZ-56:
------------------------------

BJ,

What is the change you pasted in above? What are you trying to fix? Please send a patch file instead of just pasting in code blocks. It is impossible to figure out what to do with just a block of code pasted in.

> incoming email attachments buggy
> --------------------------------
>
> Key: OFBIZ-56
> URL: http://issues.apache.org/jira/browse/OFBIZ-56
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: content
> Affects Versions: SVN trunk
> Reporter: Si Chen
> Fix For: SVN trunk
>
>
> storeIncomingEmail has problems with attachments. If you send two images, the same image ends up being stored twice. Some types of content are not stored correctly (such as word docs with images embedded). Other times the /ViewSimpleContent request has problems retrieving content correctly.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-56) incoming email attachments buggy

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-56?page=comments#action_12424171 ]

BJ Freeman commented on OFBIZ-56:
---------------------------------

this has two fixes in it
1) fixes the contenttype test for emails that don'e have more than one contentype.
2) is the fix above.

this is my first patch. Hope I did it correct.

IIndex: C:/projects/java/ofbiz_incubator_trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java
===================================================================
--- C:/projects/java/ofbiz_incubator_trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java (revision 426495)
+++ C:/projects/java/ofbiz_incubator_trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java (working copy)
@@ -686,9 +686,20 @@
Map result = null;
try {
String contentTypeRaw = message.getContentType();
- int idx = contentTypeRaw.indexOf(";");
- contentType = contentTypeRaw.substring(0, idx);
- Address [] addressesFrom = message.getFrom();
+ // int idx = contentTypeRaw.indexOf(";");
+ //some emails do not use ;. if you use the above commented out code, it may be null;
+ //so the code below will throw an exception.
+ // contentType = contentTypeRaw.substring(0, idx);
+ //following is the fix.
+ int idx = 0;
+ idx = contentTypeRaw.indexOf(";");
+ if (idx >= 1) {
+ contentType = contentTypeRaw.substring(0, idx);
+ } else {
+ contentType = contentTypeRaw;
+ }
+ //end of fix
+ Address [] addressesFrom = message.getFrom();
Address [] addressesTo = message.getRecipients(MimeMessage.RecipientType.TO);
Address [] addressesCC = message.getRecipients(MimeMessage.RecipientType.CC);
Address [] addressesBCC = message.getRecipients(MimeMessage.RecipientType.BCC);
@@ -763,16 +774,31 @@
if (partyIdFrom != null) {
commEventMap.put("partyIdFrom", partyIdFrom);
commEventMap.put("contactMechIdFrom", contactMechIdFrom);
- commEventMap.put("contactMechIdTo", contactMechIdTo);
+// commEventMap.put("contactMechIdTo", contactMechIdTo);
commEventMap.put("statusId", "COM_ENTERED");
} else {
// create a task to find party for email
commEventMap.put("statusId", "COM_UNKNOWN_PARTY");
commNote = "Sent from: " + UtilMisc.toListArray(addressesFrom);
}
+ /*
if (partyIdTo == null) {
commNote += "Sent to: " + UtilMisc.toListArray(addressesTo);
}
+ */
+ // modifed 06/20/06 to match the partyIDfrom
+
+ if (partyIdTo != null) {
+ commEventMap.put("partyIdto", partyIdTo);
+// moved from PartyIDfrom, since if PartyIDfrom is null won't get set.
+ commEventMap.put("contactMechIdTo", contactMechIdTo);
+ commEventMap.put("statusId", "COM_ENTERED");
+ }else {
+// create a task to find party for email
+// this will override the status already set
+ commEventMap.put("statusId", "COM_UNKNOWN_PARTY");
+ commNote += "Sent to: " + UtilMisc.toListArray(addressesTo);
+ }
if (!("".equals(commNote))) {
commEventMap.put("note", commNote);
}

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-56) incoming email attachments buggy

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-56?page=comments#action_12424174 ]

Si Chen commented on OFBIZ-56:
------------------------------

Bj,

Thanks but please add your patch as an an attachment not just pasted in. Cutting and pasting patch files don't work.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-56) incoming email attachments buggy

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-56?page=comments#action_12424178 ]

Jacques Le Roux commented on OFBIZ-56:
--------------------------------------

Hi Bj,

I did not take the time to review you patch (it's time to sleep here ;o). My comments here are only formals.

I think it would be better (ie easier for commiters) to attach your patch as file (see option above on left). Another point : please dont use absolute path in your path (for eg C:/projects/java/ofbiz_incubator_trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java ).
You should use something like applications/content/src/org/ofbiz/content/email/EmailServices.java). One more time less work for commiters.

You may find these interesting (hope you will find some time to read them ;o) http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices
http://docs.ofbiz.org/display/OFBADMIN/Coding+Conventions (notably this link inside this document : http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html)

Thanks

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-56) incoming email attachments buggy

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-56?page=comments#action_12424181 ]

BJ Freeman commented on OFBIZ-56:
---------------------------------

Thanks to both of you for holding my hand.
will follow the suggestions and attach the file.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-56) incoming email attachments buggy

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-56?page=comments#action_12424183 ]

Jacques Le Roux commented on OFBIZ-56:
--------------------------------------

One practical point :
If you are using Subclipse (I recognize its signature in the absolute path, am I wrong ?). There is no way to create relative paths (they should be always from OFBiz "root", or home as it sometimes said) with it.
SO there are 2 solutions :
. Using Subclipse to create patch but modify after the file by hand
. Use : svn di complete_file_name > name_of_patchfile
where complete_file_name = with path, from OFBiz root
di is the abrev. of diff. In you case something like

C:/projects/java/ofbiz_incubator_trunk/> svn di applications/content/src/org/ofbiz/content/email/EmailServices.java > EmailServices.java.patch

Thanks for your time !

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-56) incoming email attachments buggy

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-56?page=all ]

BJ Freeman updated OFBIZ-56:
----------------------------

Attachment: content_EmailServices_java.diff

hopefully I caught everything.
content EmailServices.java

> incoming email attachments buggy
> --------------------------------
>
> Key: OFBIZ-56
> URL: http://issues.apache.org/jira/browse/OFBIZ-56
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: content
> Affects Versions: SVN trunk
> Reporter: Si Chen
> Fix For: SVN trunk
>
> Attachments: content_EmailServices_java.diff
>
>
> storeIncomingEmail has problems with attachments. If you send two images, the same image ends up being stored twice. Some types of content are not stored correctly (such as word docs with images embedded). Other times the /ViewSimpleContent request has problems retrieving content correctly.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-56) incoming email attachments buggy

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-56?page=comments#action_12424188 ]

Jacques Le Roux commented on OFBIZ-56:
--------------------------------------

From a formal point of view it's good

Thanks BJ

> incoming email attachments buggy
> --------------------------------
>
> Key: OFBIZ-56
> URL: http://issues.apache.org/jira/browse/OFBIZ-56
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: content
> Affects Versions: SVN trunk
> Reporter: Si Chen
> Fix For: SVN trunk
>
> Attachments: content_EmailServices_java.diff
>
>
> storeIncomingEmail has problems with attachments. If you send two images, the same image ends up being stored twice. Some types of content are not stored correctly (such as word docs with images embedded). Other times the /ViewSimpleContent request has problems retrieving content correctly.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-56) incoming email attachments buggy

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-56?page=comments#action_12424189 ]

BJ Freeman commented on OFBIZ-56:
---------------------------------

Thanks for the idea.
I used my PFE to replace the tabs and remove the extra path info, from the file.. may try the other one when I feel more comfortable.
two quick operations.

> incoming email attachments buggy
> --------------------------------
>
> Key: OFBIZ-56
> URL: http://issues.apache.org/jira/browse/OFBIZ-56
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: content
> Affects Versions: SVN trunk
> Reporter: Si Chen
> Fix For: SVN trunk
>
> Attachments: content_EmailServices_java.diff
>
>
> storeIncomingEmail has problems with attachments. If you send two images, the same image ends up being stored twice. Some types of content are not stored correctly (such as word docs with images embedded). Other times the /ViewSimpleContent request has problems retrieving content correctly.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-56) incoming email attachments buggy

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-56?page=comments#action_12424198 ]

Si Chen commented on OFBIZ-56:
------------------------------

This does not patch. The second chunk is different than what is actually in EmailServices.java. Is your file up to date?

> incoming email attachments buggy
> --------------------------------
>
> Key: OFBIZ-56
> URL: http://issues.apache.org/jira/browse/OFBIZ-56
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: content
> Affects Versions: SVN trunk
> Reporter: Si Chen
> Fix For: SVN trunk
>
> Attachments: content_EmailServices_java.diff
>
>
> storeIncomingEmail has problems with attachments. If you send two images, the same image ends up being stored twice. Some types of content are not stored correctly (such as word docs with images embedded). Other times the /ViewSimpleContent request has problems retrieving content correctly.