[jira] Created: (OFBIZ-581) Tidy up imports in Java source

[Nicolas Malin (Jira)]

Tidy up imports in Java source
------------------------------

                 Key: OFBIZ-581
                 URL: http://issues.apache.org/jira/browse/OFBIZ-581
             Project: Apache OFBiz (The Open for Business Project)
          Issue Type: Improvement
    Affects Versions: SVN trunk
            Reporter: David Goodenough
            Priority: Trivial


The current ofbiz source code contains a number of unnecessary imports.  This patch tidy them all up.  While the effect of this is minor (it will speed compilation a little and reduces the possibility of incorrect source in the future) it makes it easier to see those errors/warning that really matter.  

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-581?page=all ]

David Goodenough updated OFBIZ-581:
-----------------------------------

    Attachment: clean-imports.patch

Patch as generated by Eclipse

> Tidy up imports in Java source
> ------------------------------
>
>                 Key: OFBIZ-581
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-581
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: David Goodenough
>            Priority: Trivial
>         Attachments: clean-imports.patch
>
>
> The current ofbiz source code contains a number of unnecessary imports.  This patch tidy them all up.  While the effect of this is minor (it will speed compilation a little and reduces the possibility of incorrect source in the future) it makes it easier to see those errors/warning that really matter.  

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-581?page=all ]

Jacques Le Roux updated OFBIZ-581:
----------------------------------

    Attachment: clean-imports.patch

David,

Your patch seems good but please don't use absolute pathes in it,
ie :
     /home/david/src/ofbiz/ofbiz/applications/accounting/src/org/ofbiz/accounting/payment/BillingAccountWorker.java
but
    applications/accounting/src/org/ofbiz/accounting/payment/BillingAccountWorker.java

Appling patches from OFBiz root facilitates commiter's work, please use relative pathes in future. I have updated the patch for you.

Thanks fo your work.

> Tidy up imports in Java source
> ------------------------------
>
>                 Key: OFBIZ-581
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-581
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: David Goodenough
>            Priority: Trivial
>         Attachments: clean-imports.patch, clean-imports.patch
>
>
> The current ofbiz source code contains a number of unnecessary imports.  This patch tidy them all up.  While the effect of this is minor (it will speed compilation a little and reduces the possibility of incorrect source in the future) it makes it easier to see those errors/warning that really matter.  

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-581?page=comments#action_12461590 ]
           
David Goodenough commented on OFBIZ-581:
----------------------------------------

I will try to find out how to configure Eclipse to use relative paths when it generates patches.  Alternatively I will edit the patches manually.  Thanks for fixing it.

> Tidy up imports in Java source
> ------------------------------
>
>                 Key: OFBIZ-581
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-581
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: David Goodenough
>            Priority: Trivial
>         Attachments: clean-imports.patch, clean-imports.patch
>
>
> The current ofbiz source code contains a number of unnecessary imports.  This patch tidy them all up.  While the effect of this is minor (it will speed compilation a little and reduces the possibility of incorrect source in the future) it makes it easier to see those errors/warning that really matter.  

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[cjhowe]

If you find out, could you please post?  I've been
manually editing mine and would like to stop doing
that :).  Thanks!
--- "David Goodenough (JIRA)" <[hidden email]> wrote:

>     [
>
http://issues.apache.org/jira/browse/OFBIZ-581?page=comments#action_12461590

> ]
>            
> David Goodenough commented on OFBIZ-581:
> ----------------------------------------
>
> I will try to find out how to configure Eclipse to
> use relative paths when it generates patches.
> Alternatively I will edit the patches manually.
> Thanks for fixing it.
>
> > Tidy up imports in Java source
> > ------------------------------
> >
> >                 Key: OFBIZ-581
> >                 URL:
> http://issues.apache.org/jira/browse/OFBIZ-581
> >             Project: Apache OFBiz (The Open for
> Business Project)
> >          Issue Type: Improvement
> >    Affects Versions: SVN trunk
> >            Reporter: David Goodenough
> >            Priority: Trivial
> >         Attachments: clean-imports.patch,
> clean-imports.patch
> >
> >
> > The current ofbiz source code contains a number of
> unnecessary imports.  This patch tidy them all up.
> While the effect of this is minor (it will speed
> compilation a little and reduces the possibility of
> incorrect source in the future) it makes it easier
> to see those errors/warning that really matter.  
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of
> the administrators:
>

http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
>        
>

[David E Jones-2]

This most likely won't help you, but I just do it from the command  
line with an "svn diff > mychanges.patch".

-David


On Dec 31, 2006, at 4:17 PM, Chris Howe wrote:

> If you find out, could you please post?  I've been
> manually editing mine and would like to stop doing
> that :).  Thanks!
> --- "David Goodenough (JIRA)" <[hidden email]> wrote:
>
>>     [
>>
> http://issues.apache.org/jira/browse/OFBIZ-581?
> page=comments#action_12461590
>> ]
>>
>> David Goodenough commented on OFBIZ-581:
>> ----------------------------------------
>>
>> I will try to find out how to configure Eclipse to
>> use relative paths when it generates patches.
>> Alternatively I will edit the patches manually.
>> Thanks for fixing it.
>>
>>> Tidy up imports in Java source
>>> ------------------------------
>>>
>>>                 Key: OFBIZ-581
>>>                 URL:
>> http://issues.apache.org/jira/browse/OFBIZ-581
>>>             Project: Apache OFBiz (The Open for
>> Business Project)
>>>          Issue Type: Improvement
>>>    Affects Versions: SVN trunk
>>>            Reporter: David Goodenough
>>>            Priority: Trivial
>>>         Attachments: clean-imports.patch,
>> clean-imports.patch
>>>
>>>
>>> The current ofbiz source code contains a number of
>> unnecessary imports.  This patch tidy them all up.
>> While the effect of this is minor (it will speed
>> compilation a little and reduces the possibility of
>> incorrect source in the future) it makes it easier
>> to see those errors/warning that really matter.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> If you think it was sent incorrectly contact one of
>> the administrators:
>>
> http://issues.apache.org/jira/secure/Administrators.jspa
>> -
>> For more information on JIRA, see:
>> http://www.atlassian.com/software/jira
>>
>>
>>
>

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-581?page=comments#action_12461591 ]
           
Jacques Le Roux commented on OFBIZ-581:
---------------------------------------

David,

Don't want to desesperate you but from my experience (I searched a bit). You may refer to this comments for instance :
http://issues.apache.org/jira/browse/OFBIZ-157#action_12434792
http://issues.apache.org/jira/browse/OFBIZ-46#action_12417609
http://issues.apache.org/jira/browse/OFBIZ-56#action_12424183

BTW please be sure to have a look at : http://docs.ofbiz.org/x/r

On Windows Tortoise is a wonderful tool to deal with svn.

Thanks for your attention.

> Tidy up imports in Java source
> ------------------------------
>
>                 Key: OFBIZ-581
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-581
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: David Goodenough
>            Priority: Trivial
>         Attachments: clean-imports.patch, clean-imports.patch
>
>
> The current ofbiz source code contains a number of unnecessary imports.  This patch tidy them all up.  While the effect of this is minor (it will speed compilation a little and reduces the possibility of incorrect source in the future) it makes it easier to see those errors/warning that really matter.  

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-581?page=comments#action_12461592 ]
           
Jacques Le Roux commented on OFBIZ-581:
---------------------------------------

There are links from the second link in the comment above that explain why there are no solutions (yet ?) to this problem :(

> Tidy up imports in Java source
> ------------------------------
>
>                 Key: OFBIZ-581
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-581
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: David Goodenough
>            Priority: Trivial
>         Attachments: clean-imports.patch, clean-imports.patch
>
>
> The current ofbiz source code contains a number of unnecessary imports.  This patch tidy them all up.  While the effect of this is minor (it will speed compilation a little and reduces the possibility of incorrect source in the future) it makes it easier to see those errors/warning that really matter.  

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Scott Gray]

I find it easy enough to just open the patch, highlight the first
instance of the path that i don't want, then ctrl + f and click replace all

Regards
Scott

David Goodenough (JIRA) wrote:

>     [ http://issues.apache.org/jira/browse/OFBIZ-581?page=comments#action_12461590 ]
>            
> David Goodenough commented on OFBIZ-581:
> ----------------------------------------
>
> I will try to find out how to configure Eclipse to use relative paths when it generates patches.  Alternatively I will edit the patches manually.  Thanks for fixing it.
>
>  
>> Tidy up imports in Java source
>> ------------------------------
>>
>>                 Key: OFBIZ-581
>>                 URL: http://issues.apache.org/jira/browse/OFBIZ-581
>>             Project: Apache OFBiz (The Open for Business Project)
>>          Issue Type: Improvement
>>    Affects Versions: SVN trunk
>>            Reporter: David Goodenough
>>            Priority: Trivial
>>         Attachments: clean-imports.patch, clean-imports.patch
>>
>>
>> The current ofbiz source code contains a number of unnecessary imports.  This patch tidy them all up.  While the effect of this is minor (it will speed compilation a little and reduces the possibility of incorrect source in the future) it makes it easier to see those errors/warning that really matter.  
>>    
>
>  

[Jacques Le Roux]

Thanks Scott,

I guess that's what we all do in this case

BTW Happy new year to all :o)

Jacques

From: "Scott Gray" <[hidden email]>

> I find it easy enough to just open the patch, highlight the first
> instance of the path that i don't want, then ctrl + f and click replace all
>
> Regards
> Scott
>
> David Goodenough (JIRA) wrote:
> >     [ http://issues.apache.org/jira/browse/OFBIZ-581?page=comments#action_12461590 ]
> >
> > David Goodenough commented on OFBIZ-581:
> > ----------------------------------------
> >
> > I will try to find out how to configure Eclipse to use relative paths when it generates patches.  Alternatively I will edit the

patches manually.  Thanks for fixing it.

> >
> >
> >> Tidy up imports in Java source
> >> ------------------------------
> >>
> >>                 Key: OFBIZ-581
> >>                 URL: http://issues.apache.org/jira/browse/OFBIZ-581
> >>             Project: Apache OFBiz (The Open for Business Project)
> >>          Issue Type: Improvement
> >>    Affects Versions: SVN trunk
> >>            Reporter: David Goodenough
> >>            Priority: Trivial
> >>         Attachments: clean-imports.patch, clean-imports.patch
> >>
> >>
> >> The current ofbiz source code contains a number of unnecessary imports.  This patch tidy them all up.  While the effect of this

is minor (it will speed compilation a little and reduces the possibility of incorrect source in the future) it makes it easier to
see those errors/warning that really matter.
> >>
> >
> >