[jira] Created: (OFBIZ-591) Shipping a serialized inventory item not handled correctly

[Nicolas Malin (Jira)]

Shipping a serialized inventory item not handled correctly
----------------------------------------------------------

                 Key: OFBIZ-591
                 URL: https://issues.apache.org/jira/browse/OFBIZ-591
             Project: Apache OFBiz (The Open for Business Project)
          Issue Type: Bug
          Components: product
            Reporter: Si Chen


When an order with serialized inventory items is shipped, the InventoryItem remains in the Promised status and hence is still counted in QOH.  It should be changed automatically to DELIVERED and no longer counted as inventory.

The statusvalidchange from DELIVERED back to AVAILABLE should be removed, as once the item has been shipped out, it should no longer be marked as AVAILABLE, just RETURNED if it is returned.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463119 ]

Jacopo Cappellato commented on OFBIZ-591:
-----------------------------------------

And what about refactoring the way the serialized inventory is implemented, instead?
I mean something like this:

* ignore the status of serialized inventory items; QOH and ATP will be considered instead:
QOH = 1 and ATP = 1 ---> AVAILABLE
QOH = 1 and ATP = 0 ---> PROMISED
QOH = 0 and ATP = 0 ---> DELIVERED

* add the following constraint: a serialized inventory item will never have QOH greater than 1

This will greatly simplify many processes (including inventory counting).

Does it make sense?

> Shipping a serialized inventory item not handled correctly
> ----------------------------------------------------------
>
>                 Key: OFBIZ-591
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-591
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>
> When an order with serialized inventory items is shipped, the InventoryItem remains in the Promised status and hence is still counted in QOH.  It should be changed automatically to DELIVERED and no longer counted as inventory.
> The statusvalidchange from DELIVERED back to AVAILABLE should be removed, as once the item has been shipped out, it should no longer be marked as AVAILABLE, just RETURNED if it is returned.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463120 ]

Si Chen commented on OFBIZ-591:
-------------------------------

I think it does make sense for me.  I guess David or Andy made the original version where the quantities were never filled in, so maybe it'd be nice to get their feedback?

> Shipping a serialized inventory item not handled correctly
> ----------------------------------------------------------
>
>                 Key: OFBIZ-591
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-591
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>         Assigned To: Si Chen
>
> When an order with serialized inventory items is shipped, the InventoryItem remains in the Promised status and hence is still counted in QOH.  It should be changed automatically to DELIVERED and no longer counted as inventory.
> The statusvalidchange from DELIVERED back to AVAILABLE should be removed, as once the item has been shipped out, it should no longer be marked as AVAILABLE, just RETURNED if it is returned.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Si Chen reassigned OFBIZ-591:
-----------------------------

    Assignee: Si Chen

> Shipping a serialized inventory item not handled correctly
> ----------------------------------------------------------
>
>                 Key: OFBIZ-591
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-591
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>         Assigned To: Si Chen
>
> When an order with serialized inventory items is shipped, the InventoryItem remains in the Promised status and hence is still counted in QOH.  It should be changed automatically to DELIVERED and no longer counted as inventory.
> The statusvalidchange from DELIVERED back to AVAILABLE should be removed, as once the item has been shipped out, it should no longer be marked as AVAILABLE, just RETURNED if it is returned.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463137 ]

Leon Torres commented on OFBIZ-591:
-----------------------------------

Jacopo, what if a particular item is defective?  Basing status off of the quantity on hand and ATP sounds very fishy, we lose the ability to describe the state of the item independently of the quantities.

> Shipping a serialized inventory item not handled correctly
> ----------------------------------------------------------
>
>                 Key: OFBIZ-591
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-591
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>         Assigned To: Si Chen
>
> When an order with serialized inventory items is shipped, the InventoryItem remains in the Promised status and hence is still counted in QOH.  It should be changed automatically to DELIVERED and no longer counted as inventory.
> The statusvalidchange from DELIVERED back to AVAILABLE should be removed, as once the item has been shipped out, it should no longer be marked as AVAILABLE, just RETURNED if it is returned.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463345 ]

Jacopo Cappellato commented on OFBIZ-591:
-----------------------------------------

I'd create an InventoryItemVariance (BROKEN) to decrement the QOH and ATP of -1.

> Shipping a serialized inventory item not handled correctly
> ----------------------------------------------------------
>
>                 Key: OFBIZ-591
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-591
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>         Assigned To: Si Chen
>
> When an order with serialized inventory items is shipped, the InventoryItem remains in the Promised status and hence is still counted in QOH.  It should be changed automatically to DELIVERED and no longer counted as inventory.
> The statusvalidchange from DELIVERED back to AVAILABLE should be removed, as once the item has been shipped out, it should no longer be marked as AVAILABLE, just RETURNED if it is returned.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463361 ]

Si Chen commented on OFBIZ-591:
-------------------------------

I think it might be a good idea to fill in the QOH and ATP based on the status codes, but not to ignore the status codes altogether and rely on ATP & QOH explicitly.  Unless you've seen differently, I think the status codes would be more intuitive to the user who works with serialized inventory.

One argument against filling in the QOH and ATP is that it may tempt the user to input QOH or ATP other than 1.0  I think this may be why originally they were intentionally left out.  It might be OK to have the system fill in the QOH and ATP based on status codes but not let the user modify them.

The issue originally brought up we've solved already, so may I close this issue and we continue the discussion about re-factoring on another one?

> Shipping a serialized inventory item not handled correctly
> ----------------------------------------------------------
>
>                 Key: OFBIZ-591
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-591
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>         Assigned To: Si Chen
>
> When an order with serialized inventory items is shipped, the InventoryItem remains in the Promised status and hence is still counted in QOH.  It should be changed automatically to DELIVERED and no longer counted as inventory.
> The statusvalidchange from DELIVERED back to AVAILABLE should be removed, as once the item has been shipped out, it should no longer be marked as AVAILABLE, just RETURNED if it is returned.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira