[jira] Created: (OFBIZ-596) improved find for existing FixedAsset based on David comments

[Nicolas Malin (Jira)]

improved find for existing FixedAsset based on David comments
-------------------------------------------------------------

                 Key: OFBIZ-596
                 URL: https://issues.apache.org/jira/browse/OFBIZ-596
             Project: Apache OFBiz (The Open for Business Project)
          Issue Type: Sub-task
          Components: accounting
            Reporter: Anil K Patel
         Attachments: improvedFindForExistingFixedAsset.patch

I did it, because most of time we copy existing code  when adding new functionality. This improvement will have cascading benefit if some body ever copied this code adding new functionality. One line patch.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel updated OFBIZ-596:
-------------------------------

    Attachment: improvedFindForExistingFixedAsset.patch

> improved find for existing FixedAsset based on David comments
> -------------------------------------------------------------
>
>                 Key: OFBIZ-596
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-596
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: improvedFindForExistingFixedAsset.patch
>
>
> I did it, because most of time we copy existing code  when adding new functionality. This improvement will have cascading benefit if some body ever copied this code adding new functionality. One line patch.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-596.
---------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Anil,

It should have been my duty and I'm a bit shameful. Anyway commited in revision: 492767  

Thanks for your consciousness !

> improved find for existing FixedAsset based on David comments
> -------------------------------------------------------------
>
>                 Key: OFBIZ-596
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-596
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Anil K Patel
>         Assigned To: Jacques Le Roux
>         Attachments: improvedFindForExistingFixedAsset.patch
>
>
> I did it, because most of time we copy existing code  when adding new functionality. This improvement will have cascading benefit if some body ever copied this code adding new functionality. One line patch.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462340 ]

Anil K Patel commented on OFBIZ-596:
------------------------------------

So nice you say that. As long as its done, its good for all of us.

> improved find for existing FixedAsset based on David comments
> -------------------------------------------------------------
>
>                 Key: OFBIZ-596
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-596
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Anil K Patel
>         Assigned To: Jacques Le Roux
>         Attachments: improvedFindForExistingFixedAsset.patch
>
>
> I did it, because most of time we copy existing code  when adding new functionality. This improvement will have cascading benefit if some body ever copied this code adding new functionality. One line patch.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira