[jira] Created: (OFBIZ-605) Consolidate backend css files

[Nicolas Malin (Jira)]

Consolidate backend css files
-----------------------------

                 Key: OFBIZ-605
                 URL: https://issues.apache.org/jira/browse/OFBIZ-605
             Project: Apache OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: framework
            Reporter: Adrian Crum
            Priority: Minor
         Attachments: framework.patch

Consolidate maincss.css and tabstyles.css files into one file - maincss.css.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-605:
------------------------------

    Attachment: framework.patch

> Consolidate backend css files
> -----------------------------
>
>                 Key: OFBIZ-605
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-605
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: framework.patch
>
>
> Consolidate maincss.css and tabstyles.css files into one file - maincss.css.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463127 ]

Adrian Crum commented on OFBIZ-605:
-----------------------------------

Apply the framework.patch file to the framework folder. Patch has been applied to latest svn. I quickly scanned through all app menus on all components plus a few data entry screens - everything still looks the same.

> Consolidate backend css files
> -----------------------------
>
>                 Key: OFBIZ-605
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-605
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: framework.patch
>
>
> Consolidate maincss.css and tabstyles.css files into one file - maincss.css.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463131 ]

Adrian Crum commented on OFBIZ-605:
-----------------------------------

Oops, I missed one decorator in CommonScreens.xml. Use the framework_v2.patch.

> Consolidate backend css files
> -----------------------------
>
>                 Key: OFBIZ-605
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-605
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: framework.patch, framework_v2.patch
>
>
> Consolidate maincss.css and tabstyles.css files into one file - maincss.css.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-605:
------------------------------

    Attachment: framework_v2.patch

> Consolidate backend css files
> -----------------------------
>
>                 Key: OFBIZ-605
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-605
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: framework.patch, framework_v2.patch
>
>
> Consolidate maincss.css and tabstyles.css files into one file - maincss.css.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato updated OFBIZ-605:
------------------------------------

    Attachment:     (was: framework.patch)

> Consolidate backend css files
> -----------------------------
>
>                 Key: OFBIZ-605
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-605
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: framework_v2.patch
>
>
> Consolidate maincss.css and tabstyles.css files into one file - maincss.css.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-605:
---------------------------------------

    Assignee: Jacopo Cappellato

> Consolidate backend css files
> -----------------------------
>
>                 Key: OFBIZ-605
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-605
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: framework_v2.patch
>
>
> Consolidate maincss.css and tabstyles.css files into one file - maincss.css.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463657 ]

Andrew Zeneski commented on OFBIZ-605:
--------------------------------------

Is this really what we want to do? Isn't having smaller CSS files for specific purposes easier to maintain? I'm not really sure about this one.

> Consolidate backend css files
> -----------------------------
>
>                 Key: OFBIZ-605
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-605
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: framework_v2.patch
>
>
> Consolidate maincss.css and tabstyles.css files into one file - maincss.css.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463660 ]

Adrian Crum commented on OFBIZ-605:
-----------------------------------

Andy,

It's a matter of perspective I guess. Some developers feel it's easier to maintain one file versus many files.

Another motivation behind this is to have one file that can be swapped out to change OFBiz's appearance. In other words, an assortment of selectable main css files would be akin to OFBiz "skins."

Once this is committed, I'll probably post another message on the boards to discuss reducing its size. It contains  a lot of redundant and unnecessary declarations.

> Consolidate backend css files
> -----------------------------
>
>                 Key: OFBIZ-605
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-605
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: framework_v2.patch
>
>
> Consolidate maincss.css and tabstyles.css files into one file - maincss.css.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463673 ]

Chris Howe commented on OFBIZ-605:
----------------------------------

For context:

http://www.nabble.com/CSS-Layout-and-Other-Cleanups-in-the-Manager-Applications-tf2915297.html#a8146629

> Consolidate backend css files
> -----------------------------
>
>                 Key: OFBIZ-605
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-605
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: framework_v2.patch
>
>
> Consolidate maincss.css and tabstyles.css files into one file - maincss.css.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato updated OFBIZ-605:
------------------------------------

    Assignee:     (was: Jacopo Cappellato)

There seem to be different opinions on this subject, at the moment.
For now, I'll just move this issue to the "Unassigned" status and after a consensus is found we'll take a decision about it.
In the meantime, thanks to Adrian for the patch.

> Consolidate backend css files
> -----------------------------
>
>                 Key: OFBIZ-605
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-605
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: framework_v2.patch
>
>
> Consolidate maincss.css and tabstyles.css files into one file - maincss.css.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira