[jira] Created: (OFBIZ-618) Customer must add a virtual product to the cart to get the price of that product.
Locked
[jira] Created: (OFBIZ-618) Customer must add a virtual product to the cart to get the price of that product.
 
|
Customer must add a virtual product to the cart to get the price of that product.
---------------------------------------------------------------------------------- Key: OFBIZ-618 URL: https://issues.apache.org/jira/browse/OFBIZ-618 Project: Apache OFBiz (The Open for Business Project) Issue Type: Improvement Components: ecommerce Affects Versions: SVN trunk Environment: All Reporter: Eric Crawford Priority: Minor Fix For: SVN trunk When a customer chooses a the required feature(s) for a virtual product, they are forced to add the item to the cart in order to know the price of that item. The product image is updated, but the price is not dynamically updated when the features are selected. The product description also remains that of the virtual product and is not updated with the variant's product information. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-618) Customer must add a virtual product to the cart to get the price of that product.
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467131 ] Fred Forester commented on OFBIZ-618: ------------------------------------- Hi, I have a patch for this but have a question. since the price is being embedded in a dynamic javascript I was kinda forced to hardcode the "$" for currency. if someone can tell me how to make that ofbiz friendly and format the Double according to the correct currency in bsh I would fix that before sending the patch. otherwise I can send it as is. Thanx Fred > Customer must add a virtual product to the cart to get the price of that product. > ---------------------------------------------------------------------------------- > > Key: OFBIZ-618 > URL: https://issues.apache.org/jira/browse/OFBIZ-618 > Project: Apache OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce > Affects Versions: SVN trunk > Environment: All > Reporter: Eric Crawford > Priority: Minor > Fix For: SVN trunk > > > When a customer chooses a the required feature(s) for a virtual product, they are forced to add the item to the cart in order to know the price of that item. The product image is updated, but the price is not dynamically updated when the features are selected. The product description also remains that of the virtual product and is not updated with the variant's product information. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-618) Customer must add a virtual product to the cart to get the price of that product.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fred Forester updated OFBIZ-618: -------------------------------- Attachment: diff.log this shows the base price of the variant in the select box but only if the virtual base price is not equal to the variants base price. there is a formatting issue with the amt maybe someone can come up with a better way to handle that. the patch is based on my local ofbiz but is pretty simple and should be easy enough to retrofit it. Fred > Customer must add a virtual product to the cart to get the price of that product. > ---------------------------------------------------------------------------------- > > Key: OFBIZ-618 > URL: https://issues.apache.org/jira/browse/OFBIZ-618 > Project: Apache OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce > Affects Versions: SVN trunk > Environment: All > Reporter: Eric Crawford > Priority: Minor > Fix For: SVN trunk > > Attachments: diff.log > > > When a customer chooses a the required feature(s) for a virtual product, they are forced to add the item to the cart in order to know the price of that item. The product image is updated, but the price is not dynamically updated when the features are selected. The product description also remains that of the virtual product and is not updated with the variant's product information. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-618) Customer must add a virtual product to the cart to get the price of that product.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-618: ------------------------------------- Assignee: Jacques Le Roux > Customer must add a virtual product to the cart to get the price of that product. > ---------------------------------------------------------------------------------- > > Key: OFBIZ-618 > URL: https://issues.apache.org/jira/browse/OFBIZ-618 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce > Affects Versions: SVN trunk > Environment: All > Reporter: Eric Crawford > Assigned To: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: diff.log > > > When a customer chooses a the required feature(s) for a virtual product, they are forced to add the item to the cart in order to know the price of that item. The product image is updated, but the price is not dynamically updated when the features are selected. The product description also remains that of the virtual product and is not updated with the variant's product information. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-618) Customer must add a virtual product to the cart to get the price of that product.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469149 ] Jacques Le Roux commented on OFBIZ-618: --------------------------------------- Fred, I just reviewed this patch. Few remarks . There are tabs in this patch please replace any tabs in your patch by 4 spaces, you shoumd also read http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices where there are some advices and tricks . I tried to apply the patch (after having changed tabs to spaces) but I got patching file applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productdetail.bsh Hunk #1 succeeded at 222 (offset 9 lines). Hunk #2 FAILED at 333. Hunk #3 succeeded at 385 (offset -9 lines). 1 out of 3 hunks FAILED -- saving rejects to file applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productdetail.bsh.rej . What version of OFBiz are you using ? I read Index: applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productdetail.bsh =================================================================== --- applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productdetail.bsh (revision 584) +++ applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productdetail.bsh (working copy) strange the current version is near 500 000 rather... So please, update your version (but check because weird anyway) and submit an actualised patch Thanks > Customer must add a virtual product to the cart to get the price of that product. > ---------------------------------------------------------------------------------- > > Key: OFBIZ-618 > URL: https://issues.apache.org/jira/browse/OFBIZ-618 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce > Affects Versions: SVN trunk > Environment: All > Reporter: Eric Crawford > Assigned To: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: diff.log > > > When a customer chooses a the required feature(s) for a virtual product, they are forced to add the item to the cart in order to know the price of that item. The product image is updated, but the price is not dynamically updated when the features are selected. The product description also remains that of the virtual product and is not updated with the variant's product information. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-618) Customer must add a virtual product to the cart to get the price of that product.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fred Forester updated OFBIZ-618: -------------------------------- Attachment: productdetail.patch Hi Jacques maybe this one will work better. > Customer must add a virtual product to the cart to get the price of that product. > ---------------------------------------------------------------------------------- > > Key: OFBIZ-618 > URL: https://issues.apache.org/jira/browse/OFBIZ-618 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce > Affects Versions: SVN trunk > Environment: All > Reporter: Eric Crawford > Assigned To: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: diff.log, productdetail.patch > > > When a customer chooses a the required feature(s) for a virtual product, they are forced to add the item to the cart in order to know the price of that item. The product image is updated, but the price is not dynamically updated when the features are selected. The product description also remains that of the virtual product and is not updated with the variant's product information. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-618) Customer must add a virtual product to the cart to get the price of that product.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fred Forester updated OFBIZ-618: -------------------------------- Attachment: productdetail.patch oops, forgot the asf button > Customer must add a virtual product to the cart to get the price of that product. > ---------------------------------------------------------------------------------- > > Key: OFBIZ-618 > URL: https://issues.apache.org/jira/browse/OFBIZ-618 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce > Affects Versions: SVN trunk > Environment: All > Reporter: Eric Crawford > Assigned To: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: diff.log, productdetail.patch, productdetail.patch > > > When a customer chooses a the required feature(s) for a virtual product, they are forced to add the item to the cart in order to know the price of that item. The product image is updated, but the price is not dynamically updated when the features are selected. The product description also remains that of the virtual product and is not updated with the variant's product information. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-618) Customer must add a virtual product to the cart to get the price of that product.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469595 ] Jacques Le Roux commented on OFBIZ-618: --------------------------------------- Fred, I reviewed and tested this patch, sorry but it does not work. First, why do you use opt in oneInList = EntityUtil.filterByAnd(variants,UtilMisc.toMap("productIdTo",opt)); ? Second, even if you have used the right value there (prodcutId of the variant) there would still be a problem. You put the price on the select box of the 1st feature, but this is not discriminant because following features may change this price. So I propose to create an array of prices (one for each variant) in productdetail.bsh and to use this array in productdetail.ftl. More precisely in function getList(name, index, src) by adding a new function in the spirit of function setAddProductId(name). Let me know if you have any question, thanks. > Customer must add a virtual product to the cart to get the price of that product. > ---------------------------------------------------------------------------------- > > Key: OFBIZ-618 > URL: https://issues.apache.org/jira/browse/OFBIZ-618 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce > Affects Versions: SVN trunk > Environment: All > Reporter: Eric Crawford > Assigned To: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: diff.log, productdetail.patch, productdetail.patch > > > When a customer chooses a the required feature(s) for a virtual product, they are forced to add the item to the cart in order to know the price of that item. The product image is updated, but the price is not dynamically updated when the features are selected. The product description also remains that of the virtual product and is not updated with the variant's product information. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-618) Customer must add a virtual product to the cart to get the price of that product.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469756 ] Fred Forester commented on OFBIZ-618: ------------------------------------- Jacques, "opt" seems to contain the productId of the variant. the "variants" list seems to have a list of ProductAssoc entities where they all have the same productId of the virtual and ProductIdTo matches the value of "opt" this is what I am seeing in the debug output anyway. I'll take at look at you suggestion over the weekend sometime. Thanx Fred > Customer must add a virtual product to the cart to get the price of that product. > ---------------------------------------------------------------------------------- > > Key: OFBIZ-618 > URL: https://issues.apache.org/jira/browse/OFBIZ-618 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce > Affects Versions: SVN trunk > Environment: All > Reporter: Eric Crawford > Assigned To: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: diff.log, productdetail.patch, productdetail.patch > > > When a customer chooses a the required feature(s) for a virtual product, they are forced to add the item to the cart in order to know the price of that item. The product image is updated, but the price is not dynamically updated when the features are selected. The product description also remains that of the virtual product and is not updated with the variant's product information. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-618) Customer must add a virtual product to the cart to get the price of that product.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469948 ] Jacques Le Roux commented on OFBIZ-618: --------------------------------------- Fred, Take a look at while (vti.hasNext()) { key = vti.next(); value = variantTree.get(key); opt = null; if (featureOrder.size() == 1) { opt = value.iterator().next(); } else { opt = "" + counter; } you see counter there ? Don't give up ! > Customer must add a virtual product to the cart to get the price of that product. > ---------------------------------------------------------------------------------- > > Key: OFBIZ-618 > URL: https://issues.apache.org/jira/browse/OFBIZ-618 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce > Affects Versions: SVN trunk > Environment: All > Reporter: Eric Crawford > Assigned To: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: diff.log, productdetail.patch, productdetail.patch > > > When a customer chooses a the required feature(s) for a virtual product, they are forced to add the item to the cart in order to know the price of that item. The product image is updated, but the price is not dynamically updated when the features are selected. The product description also remains that of the virtual product and is not updated with the variant's product information. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-618) Customer must add a virtual product to the cart to get the price of that product.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Crawford updated OFBIZ-618: -------------------------------- Attachment: productdetail-bsh.patch Display the virtual product price below the virtual product model number when all features are selected. > Customer must add a virtual product to the cart to get the price of that product. > ---------------------------------------------------------------------------------- > > Key: OFBIZ-618 > URL: https://issues.apache.org/jira/browse/OFBIZ-618 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce > Affects Versions: SVN trunk > Environment: All > Reporter: Eric Crawford > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: diff.log, productdetail-bsh.patch, productdetail.patch, productdetail.patch > > > When a customer chooses a the required feature(s) for a virtual product, they are forced to add the item to the cart in order to know the price of that item. The product image is updated, but the price is not dynamically updated when the features are selected. The product description also remains that of the virtual product and is not updated with the variant's product information. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-618) Customer must add a virtual product to the cart to get the price of that product.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Crawford updated OFBIZ-618: -------------------------------- Attachment: productdetail-ftl.patch Display the virtual product price below the virtual product ID when all features are selected. This is the patch file for productdetail.ftl. > Customer must add a virtual product to the cart to get the price of that product. > ---------------------------------------------------------------------------------- > > Key: OFBIZ-618 > URL: https://issues.apache.org/jira/browse/OFBIZ-618 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce > Affects Versions: SVN trunk > Environment: All > Reporter: Eric Crawford > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: diff.log, productdetail-bsh.patch, productdetail-ftl.patch, productdetail.patch, productdetail.patch > > > When a customer chooses a the required feature(s) for a virtual product, they are forced to add the item to the cart in order to know the price of that item. The product image is updated, but the price is not dynamically updated when the features are selected. The product description also remains that of the virtual product and is not updated with the variant's product information. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Issue Comment Edited: (OFBIZ-618) Customer must add a virtual product to the cart to get the price of that product.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533417 ] craws01 edited comment on OFBIZ-618 at 10/9/07 10:09 AM: --------------------------------------------------------------- Hello. I have attached 2 patch files that will add functionality to display the variant product price below the variant product ID when all features are selected. productdetail-bsh.patch is the patch file for productdetail.bsh and productdetail-ftl.patch is the patch file for productdetail.ftl. This patch file also fixes a problem with the variant product ID not displaying on IEwin 6, 7 when all features are selected. was (Author: craws01): Display the virtual product price below the virtual product model number when all features are selected. > Customer must add a virtual product to the cart to get the price of that product. > ---------------------------------------------------------------------------------- > > Key: OFBIZ-618 > URL: https://issues.apache.org/jira/browse/OFBIZ-618 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce > Affects Versions: SVN trunk > Environment: All > Reporter: Eric Crawford > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: diff.log, productdetail-bsh.patch, productdetail-ftl.patch, productdetail.patch, productdetail.patch > > > When a customer chooses a the required feature(s) for a virtual product, they are forced to add the item to the cart in order to know the price of that item. The product image is updated, but the price is not dynamically updated when the features are selected. The product description also remains that of the virtual product and is not updated with the variant's product information. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-618) Customer must add a virtual product to the cart to get the price of that product.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Crawford updated OFBIZ-618: -------------------------------- Comment: was deleted > Customer must add a virtual product to the cart to get the price of that product. > ---------------------------------------------------------------------------------- > > Key: OFBIZ-618 > URL: https://issues.apache.org/jira/browse/OFBIZ-618 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce > Affects Versions: SVN trunk > Environment: All > Reporter: Eric Crawford > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: diff.log, productdetail-bsh.patch, productdetail-ftl.patch, productdetail.patch, productdetail.patch > > > When a customer chooses a the required feature(s) for a virtual product, they are forced to add the item to the cart in order to know the price of that item. The product image is updated, but the price is not dynamically updated when the features are selected. The product description also remains that of the virtual product and is not updated with the variant's product information. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-618) Customer must add a virtual product to the cart to get the price of that product.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-618. --------------------------------- Resolution: Fixed Thanks Eric, I reviewed your patch, here are my remarks : Please don't use tabs but spaces for indentation (4 in any other than FTL files, 2 in FTL files). Take care with your indentations. Be sure to read this document before submitting a patch : http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices I agree that you patch fix the issue with IE 6/7 but there was a problem of localisation in it. You use numberFormat = NumberFormat.getCurrencyInstance(); but in FTL files we use the macro <@ofbizCurrency wich takes care of store parameters. For instance on my machine, with OFBiz OOTB, the variant price is given in EUROS (I lve in France) and should be in Dollar because it's how it's set in product store. I changed the line above to be String localeString = productStore.getString("defaultLocaleString"); if (UtilValidate.isNotEmpty(localeString)) { locale = UtilMisc.parseLocale(localeString); } numberFormat = NumberFormat.getCurrencyInstance(locale); It's not perfect (USD is missing) but it ok. I commited in trunk rev. 584531 > Customer must add a virtual product to the cart to get the price of that product. > ---------------------------------------------------------------------------------- > > Key: OFBIZ-618 > URL: https://issues.apache.org/jira/browse/OFBIZ-618 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce > Affects Versions: SVN trunk > Environment: All > Reporter: Eric Crawford > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: diff.log, productdetail-bsh.patch, productdetail-ftl.patch, productdetail.patch, productdetail.patch > > > When a customer chooses a the required feature(s) for a virtual product, they are forced to add the item to the cart in order to know the price of that item. The product image is updated, but the price is not dynamically updated when the features are selected. The product description also remains that of the virtual product and is not updated with the variant's product information. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-618) Customer must add a virtual product to the cart to get the price of that product.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534632 ] Eric Crawford commented on OFBIZ-618: ------------------------------------- Hi Jacques, Thanks for the comments. I had a funny feeling that the NumberFormat would need some changes, as I wasn't sure how to get the locale from the session. I will keep the tabs out next time. I think they made it in there from a copy/paste. I am almost done with another patch for a product image issue that I submitted a few months ago. Thanks, Eric > Customer must add a virtual product to the cart to get the price of that product. > ---------------------------------------------------------------------------------- > > Key: OFBIZ-618 > URL: https://issues.apache.org/jira/browse/OFBIZ-618 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce > Affects Versions: SVN trunk > Environment: All > Reporter: Eric Crawford > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: diff.log, productdetail-bsh.patch, productdetail-ftl.patch, productdetail.patch, productdetail.patch > > > When a customer chooses a the required feature(s) for a virtual product, they are forced to add the item to the cart in order to know the price of that item. The product image is updated, but the price is not dynamically updated when the features are selected. The product description also remains that of the virtual product and is not updated with the variant's product information. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |