[jira] Created: (OFBIZ-620) Prepend feature idCodes with '-'

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-620) Prepend feature idCodes with '-'

Nicolas Malin (Jira)
Prepend feature idCodes with '-'
--------------------------------

                 Key: OFBIZ-620
                 URL: https://issues.apache.org/jira/browse/OFBIZ-620
             Project: Apache OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: product
    Affects Versions: SVN trunk
         Environment: All.
            Reporter: Jonathon Wong
            Priority: Trivial
             Fix For: SVN trunk
         Attachments: ProductFeatureServices.java.patch

Currently, that function appends the ProductFeature idCode(s) immediately to the end of the Product ID. So, WG-9943 will have WG-9943B3 rather than WG-9943-B3.

Can I just add a '-' before the entire string of ProductFeature idCode(s)? Or should I do more work to store this prefix '-' in some entity linked to a Product? Or in config file? Or allow it to be specifiable by users on the QuickAddVariants screen?

I've included a suggested patch.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-620) Prepend feature idCodes with '-'

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathon Wong updated OFBIZ-620:
--------------------------------

    Attachment: ProductFeatureServices.java.patch

> Prepend feature idCodes with '-'
> --------------------------------
>
>                 Key: OFBIZ-620
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-620
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: All.
>            Reporter: Jonathon Wong
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ProductFeatureServices.java.patch
>
>
> Currently, that function appends the ProductFeature idCode(s) immediately to the end of the Product ID. So, WG-9943 will have WG-9943B3 rather than WG-9943-B3.
> Can I just add a '-' before the entire string of ProductFeature idCode(s)? Or should I do more work to store this prefix '-' in some entity linked to a Product? Or in config file? Or allow it to be specifiable by users on the QuickAddVariants screen?
> I've included a suggested patch.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-620) Prepend feature idCodes with '-'

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathon Wong updated OFBIZ-620:
--------------------------------

    Description:
Currently, that function ProductFeatureServices.getVariantCombinations( ) appends the ProductFeature idCode(s) immediately to the end of the Product ID. So, WG-9943 will have WG-9943B3 rather than WG-9943-B3.

Can I just add a '-' before the entire string of ProductFeature idCode(s)? Or should I do more work to store this prefix '-' in some entity linked to a Product? Or in config file? Or allow it to be specifiable by users on the QuickAddVariants screen?

I've included a suggested patch.

  was:
Currently, that function appends the ProductFeature idCode(s) immediately to the end of the Product ID. So, WG-9943 will have WG-9943B3 rather than WG-9943-B3.

Can I just add a '-' before the entire string of ProductFeature idCode(s)? Or should I do more work to store this prefix '-' in some entity linked to a Product? Or in config file? Or allow it to be specifiable by users on the QuickAddVariants screen?

I've included a suggested patch.


> Prepend feature idCodes with '-'
> --------------------------------
>
>                 Key: OFBIZ-620
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-620
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: All.
>            Reporter: Jonathon Wong
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ProductFeatureServices.java.patch
>
>
> Currently, that function ProductFeatureServices.getVariantCombinations( ) appends the ProductFeature idCode(s) immediately to the end of the Product ID. So, WG-9943 will have WG-9943B3 rather than WG-9943-B3.
> Can I just add a '-' before the entire string of ProductFeature idCode(s)? Or should I do more work to store this prefix '-' in some entity linked to a Product? Or in config file? Or allow it to be specifiable by users on the QuickAddVariants screen?
> I've included a suggested patch.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-620) Prepend feature idCodes with '-'

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-620.
---------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

> Prepend feature idCodes with '-'
> --------------------------------
>
>                 Key: OFBIZ-620
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-620
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: All.
>            Reporter: Jonathon Wong
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ProductFeatureServices.java.patch
>
>
> Currently, that function ProductFeatureServices.getVariantCombinations( ) appends the ProductFeature idCode(s) immediately to the end of the Product ID. So, WG-9943 will have WG-9943B3 rather than WG-9943-B3.
> Can I just add a '-' before the entire string of ProductFeature idCode(s)? Or should I do more work to store this prefix '-' in some entity linked to a Product? Or in config file? Or allow it to be specifiable by users on the QuickAddVariants screen?
> I've included a suggested patch.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-620) Prepend feature idCodes with '-'

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464451 ]

Jacques Le Roux commented on OFBIZ-620:
---------------------------------------

Jonathon,

You patch is in OFBiz rev. 495891

BTW please create your patch from root it easier for us to apply them. Worth to read : http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices

Thanks


> Prepend feature idCodes with '-'
> --------------------------------
>
>                 Key: OFBIZ-620
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-620
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: All.
>            Reporter: Jonathon Wong
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ProductFeatureServices.java.patch
>
>
> Currently, that function ProductFeatureServices.getVariantCombinations( ) appends the ProductFeature idCode(s) immediately to the end of the Product ID. So, WG-9943 will have WG-9943B3 rather than WG-9943-B3.
> Can I just add a '-' before the entire string of ProductFeature idCode(s)? Or should I do more work to store this prefix '-' in some entity linked to a Product? Or in config file? Or allow it to be specifiable by users on the QuickAddVariants screen?
> I've included a suggested patch.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira