[jira] Created: (OFBIZ-623) Product Menu looks bad

[Nicolas Malin (Jira)]

Product Menu looks bad
----------------------

                 Key: OFBIZ-623
                 URL: https://issues.apache.org/jira/browse/OFBIZ-623
             Project: Apache OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: product
         Environment: Windows XP
            Reporter: Jacques Le Roux
            Priority: Minor


Please see screen copy attached

I tried also on Opera 9.02 and IE 7 : same problem.

Surely a CSS change somewhere, any idea ?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-623:
----------------------------------

    Attachment: AScreenCopy.PNG

> Product Menu looks bad
> ----------------------
>
>                 Key: OFBIZ-623
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-623
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>         Environment: Windows XP
>            Reporter: Jacques Le Roux
>            Priority: Minor
>         Attachments: AScreenCopy.PNG
>
>
> Please see screen copy attached
> I tried also on Opera 9.02 and IE 7 : same problem.
> Surely a CSS change somewhere, any idea ?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guido Amarilla updated OFBIZ-623:
---------------------------------

    Attachment: maincssTabButton.patch

> Product Menu looks bad
> ----------------------
>
>                 Key: OFBIZ-623
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-623
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>         Environment: Windows XP
>            Reporter: Jacques Le Roux
>            Priority: Minor
>         Attachments: AScreenCopy.PNG, maincssTabButton.patch
>
>
> Please see screen copy attached
> I tried also on Opera 9.02 and IE 7 : same problem.
> Surely a CSS change somewhere, any idea ?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465588 ]

Guido Amarilla commented on OFBIZ-623:
--------------------------------------

This patch adds this line to the buttons style A.tabButton : line-height: 20px
to prevent overlapping.

I also noted the same problem in A.buttontext syle, so I added line-height: 18px.
Tested on Firefox and IE6 on Windows.

> Product Menu looks bad
> ----------------------
>
>                 Key: OFBIZ-623
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-623
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>         Environment: Windows XP
>            Reporter: Jacques Le Roux
>            Priority: Minor
>         Attachments: AScreenCopy.PNG, maincssTabButton.patch
>
>
> Please see screen copy attached
> I tried also on Opera 9.02 and IE 7 : same problem.
> Surely a CSS change somewhere, any idea ?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-623.
---------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
         Assignee: Jacques Le Roux

Guidom

Thanks your work is in OFBiz revision: 497218

Tested on Windows with Firefox 1.5.0.9, IE 7, and Opera 9.02

> Product Menu looks bad
> ----------------------
>
>                 Key: OFBIZ-623
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-623
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>         Environment: Windows XP
>            Reporter: Jacques Le Roux
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: AScreenCopy.PNG, maincssTabButton.patch
>
>
> Please see screen copy attached
> I tried also on Opera 9.02 and IE 7 : same problem.
> Surely a CSS change somewhere, any idea ?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465626 ]

Adrian Crum commented on OFBIZ-623:
-----------------------------------

While this is an effective "quick and dirty" patch, it would have been better to wrap the links in DIVs and applied padding to the DIVs.

> Product Menu looks bad
> ----------------------
>
>                 Key: OFBIZ-623
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-623
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>         Environment: Windows XP
>            Reporter: Jacques Le Roux
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: AScreenCopy.PNG, maincssTabButton.patch
>
>
> Please see screen copy attached
> I tried also on Opera 9.02 and IE 7 : same problem.
> Surely a CSS change somewhere, any idea ?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465628 ]

Chris Howe commented on OFBIZ-623:
----------------------------------

Adrian,

I agree.  I've been trying to replicate this issue since Guido posted the patch, but have been unsuccessful, though I remember seeing the issue in the past (maybe I saw it before upgrading to FF 2.0).  The "problem" with using line-height is that if you change the size of your text, you're going to maintain the size of the line, that's not likely the result you're looking for.  The line will grow in most cases (_some browsers do have quirks with this behavior if I remember) to accommodate larger text, but no browser will shrink the line height to accommodate smaller text or a more condensed font.

> Product Menu looks bad
> ----------------------
>
>                 Key: OFBIZ-623
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-623
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>         Environment: Windows XP
>            Reporter: Jacques Le Roux
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: AScreenCopy.PNG, maincssTabButton.patch
>
>
> Please see screen copy attached
> I tried also on Opera 9.02 and IE 7 : same problem.
> Surely a CSS change somewhere, any idea ?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465631 ]

Adrian Crum commented on OFBIZ-623:
-----------------------------------

The buttons overlap in my browser, just like the screen shot.

Yes, this has come up before. The button bars need to be refactored to wrap DIVs around links. That was one of the steps I was hoping to accomplish with the CSS effort.

> Product Menu looks bad
> ----------------------
>
>                 Key: OFBIZ-623
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-623
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>         Environment: Windows XP
>            Reporter: Jacques Le Roux
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: AScreenCopy.PNG, maincssTabButton.patch
>
>
> Please see screen copy attached
> I tried also on Opera 9.02 and IE 7 : same problem.
> Surely a CSS change somewhere, any idea ?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465692 ]

Adrian Crum commented on OFBIZ-623:
-----------------------------------

Okay, I played with this and I found an alternate "quick and dirty" patch that scales well:

line-height: 200%;

and

line-height: 180%;

(respectively).

> Product Menu looks bad
> ----------------------
>
>                 Key: OFBIZ-623
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-623
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>         Environment: Windows XP
>            Reporter: Jacques Le Roux
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: AScreenCopy.PNG, maincssTabButton.patch
>
>
> Please see screen copy attached
> I tried also on Opera 9.02 and IE 7 : same problem.
> Surely a CSS change somewhere, any idea ?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465693 ]

Adrian Crum commented on OFBIZ-623:
-----------------------------------

Ack. Ignore that last comment.

> Product Menu looks bad
> ----------------------
>
>                 Key: OFBIZ-623
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-623
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>         Environment: Windows XP
>            Reporter: Jacques Le Roux
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: AScreenCopy.PNG, maincssTabButton.patch
>
>
> Please see screen copy attached
> I tried also on Opera 9.02 and IE 7 : same problem.
> Surely a CSS change somewhere, any idea ?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465696 ]

Chris Howe commented on OFBIZ-623:
----------------------------------

I was about to say, that should fall victim to the same pitfalls as defining the line-height in px.  

1 em = 100%

In default english FF and IE 1 em = 16 px
So, when the body font-size was set to 62.5%,
16 x .625 = 10px
so
1 em = 10px
2 em = 20px
200%= 20px

The reason why the we choose 62.5% is for the decimal convention.  But it doesn't matter what someone else has their default font set at, as they will see the page in the same relation as we do.

So now if you change the font size of the text in that class, you're line height is still 2 em, even if your font-size is 0.8 em.

This needs to be set using margin

> Product Menu looks bad
> ----------------------
>
>                 Key: OFBIZ-623
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-623
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>         Environment: Windows XP
>            Reporter: Jacques Le Roux
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: AScreenCopy.PNG, maincssTabButton.patch
>
>
> Please see screen copy attached
> I tried also on Opera 9.02 and IE 7 : same problem.
> Surely a CSS change somewhere, any idea ?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira