[jira] Created: (OFBIZ-633) Remove redunant style decarations from maincss.css

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468797 ]

Jacques Le Roux commented on OFBIZ-633:
---------------------------------------

I hope so Adrian, I hope so...

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: experimental_1.patch, experimental_2.patch, maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-633:
------------------------------

    Attachment: experimental_3.patch

experimental_3.patch builds upon and improves the experimental_2.patch. (Let's just pretend experimental_1.patch never happened, okay?)

I refactored the party manager viewProfile page as a test for the new CSS classes. The existing viewProfile page looks terrible and the layout is easily broken when the browser window is resized. This patch makes the page look neat and organized regardless of window size.

I continued the CSS class decorator pattern with the button bars located at the top of the viewProfile page. Look for the line

<div class="buttonBar buttonStyle1">

in partyMenus.ftl and add the "toolBar" decorator to it. It's not fancy, but it demonstrates what can be done with the button bars.

View the page source (HTML markup) of the patched pages. The markup contains minimal styling information and it's well structured. Also notice the screenlet IDs. These can be used as named anchors. Try this link in a patched installation:

https://localhost:8443/partymgr/control/viewprofile?partyId=DemoCustomer#partyNotes

Now you can link directly to a screenlet!

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: experimental_1.patch, experimental_2.patch, experimental_3.patch, maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469351 ]

Jacques Le Roux commented on OFBIZ-633:
---------------------------------------

Adrian,

Finally took a look. Yes it's better. Notably for right buttons and menus when resized. Resizing is working well and better in the 3 browsers I tested.

I did not review the code just compared generated HTML. In general it seems better, less "sub-class" (like boxlink, boxhead, tableheadtext, tabletext ).
<div class="buttonBar buttonStyle1"> is clearer for sure. Screenlet link works weel too

So yes in general it's better and I can't see a regression either in Firefox 1.5.0.9, IE7 and Opeara 9.02

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: experimental_1.patch, experimental_2.patch, experimental_3.patch, maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469484 ]

Adrian Crum commented on OFBIZ-633:
-----------------------------------

Jacques,

Thank you very much for taking the time to try this out!

Did you notice that IE7 doesn't know how to float <td> elements? I found that quite funny.

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: experimental_1.patch, experimental_2.patch, experimental_3.patch, maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469529 ]

Jacques Le Roux commented on OFBIZ-633:
---------------------------------------

Adrian,

No I did not notice any bad effects, is that annoying ?

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: experimental_1.patch, experimental_2.patch, experimental_3.patch, maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469532 ]

Adrian Crum commented on OFBIZ-633:
-----------------------------------

Not annoying. The column of buttons on the right are not all the way to the right in IE7. It looks okay, but it doesn't do what you would expect it to do.

For some reason IE7 ignores positioning properties on <td> elements.

Bottom line is, the pages look best with Firefox. and they look okay with IE7. That's the goal I'm aiming for.

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: experimental_1.patch, experimental_2.patch, experimental_3.patch, maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-633:
------------------------------

    Attachment: experimental_4.patch

experimental_4.patch builds upon experimental_3.patch. This patch will require an ant build in the framework/widget component.

I refactored the UI for the Party Manager "create new" screens - which utilize form widgets. So, I had to make some modifications to HtmlFormRenderer.java to clean up the messy markup it output. In this patch, the form widget uses the default styles in the new maincss.css file - which causes a slight change in layout. I'm thinking about making a formWidget CSS class that the form widget can default to - which will make the form appearance match a little closer. I also added some HTML comments and indentation to help make the markup easier to read. Those can be taken back out after the refactoring.

The createparty.ftl file was added to demonstrate what I talked about on the dev mailing list. The ftl code is smaller than the corresponding widget code, but it requires a new file - which contains the license, etc. I would really like to see the widgets support HTML "snippets" so that little HTML code fragments like the one in createparty.ftl can be put right in the widget.

As with the previous experimental_x patches, it's best to spend time playing with the UI on the refactored pages and look at the markup. Change your browser's default font, resize the browser window, etc to see how well the UI behaves.

URLs of the refactored pages:

https://127.0.0.1:8443/partymgr/control/findparty
https://127.0.0.1:8443/partymgr/control/createnew
https://127.0.0.1:8443/partymgr/control/editpartygroup?create_new=Y
https://127.0.0.1:8443/partymgr/control/editperson?create_new=Y
https://127.0.0.1:8443/partymgr/control/NewCustomer
https://127.0.0.1:8443/partymgr/control/NewProspect
https://127.0.0.1:8443/partymgr/control/NewEmployee

This latest patch demonstrates the direction I'd like to see things go in. I probably won't submit any more experimental patches unless I come across something truly noteworthy.

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: experimental_1.patch, experimental_2.patch, experimental_3.patch, experimental_4.patch, maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-633:
------------------------------

    Attachment: createCustomer.jpg

I was playing around with form widget styles and I came up with some ideas. I have attached a screenshot of the create customer screen in Party Manager so you can take a look.

I made one small modification to HtmlFormRenderer.java's tooltip code to use this basic logic:

if tooltip style is specified
  use the specified tooltip style
else
  use the funky -[ ]- characters.

All of the styling in this screenshot was done purely with CSS.

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: createCustomer.jpg, experimental_1.patch, experimental_2.patch, experimental_3.patch, experimental_4.patch, maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-633:
------------------------------

    Attachment: profileBefore.jpg

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: createCustomer.jpg, experimental_1.patch, experimental_2.patch, experimental_3.patch, experimental_4.patch, findAfter.jpg, findBefore.jpg, maincss.css, profileBefore.jpg
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-633:
------------------------------

    Attachment: findAfter.jpg

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: createCustomer.jpg, experimental_1.patch, experimental_2.patch, experimental_3.patch, experimental_4.patch, findAfter.jpg, findBefore.jpg, maincss.css, profileBefore.jpg
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-633:
------------------------------

    Attachment: findBefore.jpg

I'm attaching some "before and after" screen shots, so those who don't have time to try out the patches can see the differences in the UI.

The "before" screen shots demonstrate how content doesn't scale well. The "after" screen shots demonstrate the new practices.

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: createCustomer.jpg, experimental_1.patch, experimental_2.patch, experimental_3.patch, experimental_4.patch, findAfter.jpg, findBefore.jpg, maincss.css, profileBefore.jpg
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-633:
------------------------------

    Attachment: profileAfter.jpg

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: createCustomer.jpg, experimental_1.patch, experimental_2.patch, experimental_3.patch, experimental_4.patch, findAfter.jpg, findBefore.jpg, maincss.css, profileAfter.jpg, profileBefore.jpg
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473342 ]

Jacopo Cappellato commented on OFBIZ-633:
-----------------------------------------

In my opinion, a natural next step in the direction of improving the css support in OFBiz, is that of changing the code in the HtmlFormRenderer class, so that instead of rendering the *single* form definitions by html tables, just use div/br etc... tags
On the other hand, using html tables for list based form is fine.

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: createCustomer.jpg, experimental_1.patch, experimental_2.patch, experimental_3.patch, experimental_4.patch, findAfter.jpg, findBefore.jpg, maincss.css, profileAfter.jpg, profileBefore.jpg
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-633:
------------------------------

    Attachment: HtmlFormRenderer.patch

Jacopo,

The Form Widget is one of those HTML "element collections" that works best with a table based layout. If you look at a typical data entry form it is, in essence, a table. The basicTable CSS class I created will style a form widget table and all of its contained elements, so there is very little markup needed.

Sure, we could replace the table with nested <div>s, but we wouldn't gain anything. The end result would be the same amount of HTML and less control of layout.

I started work on the HtmlFormRenderer class. I have attached a patch so you can take a look at it. Keep in mind that it isn't finished yet.

Btw, could you take a look at OFBIZ-685 please?

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: createCustomer.jpg, experimental_1.patch, experimental_2.patch, experimental_3.patch, experimental_4.patch, findAfter.jpg, findBefore.jpg, HtmlFormRenderer.patch, maincss.css, profileAfter.jpg, profileBefore.jpg
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-633:
------------------------------

    Attachment: experimental_6.patch

experimental_6.patch demonstrates two new features - component-level style sheets, and component-level java script files.

First apply the patch from OFBIZ-685, then apply this patch. Next, do an ant build in the framework/widget folder.

Browse to

https://localhost:8443/accounting/control/GlAccountNavigate

to see the demo of the new tree widget and the component-level style sheet.

Browse to

https://localhost:8443/partymgr/control/findparty

to see the demo of the component-level java script file. The java scripts that had been embedded in findparty.ftl are now in their own java script (.js) file.

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: createCustomer.jpg, experimental_1.patch, experimental_2.patch, experimental_3.patch, experimental_4.patch, experimental_6.patch, findAfter.jpg, findBefore.jpg, HtmlFormRenderer.patch, maincss.css, profileAfter.jpg, profileBefore.jpg
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474232 ]

Adrian Crum commented on OFBIZ-633:
-----------------------------------

One thing I could really use help with is the widget java files. I hard-coded the basic style to be used for each widget. I would prefer to have the style provided by the widget's xml file, but I'm not familiar enough with the widgets to do that. If anyone has expertise in this area and is willing to help, it would be greatly appreciated! Just apply the latest patch, fix up the code to make it more configurable, then repost the patch here.

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: createCustomer.jpg, experimental_1.patch, experimental_2.patch, experimental_3.patch, experimental_4.patch, experimental_6.patch, findAfter.jpg, findBefore.jpg, HtmlFormRenderer.patch, maincss.css, profileAfter.jpg, profileBefore.jpg
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-633:
------------------------------

    Attachment: experimental_6.patch

Better element nesting in the tree widget. Simplified navigation styles.

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: createCustomer.jpg, experimental_1.patch, experimental_2.patch, experimental_3.patch, experimental_4.patch, experimental_6.patch, experimental_6.patch, findAfter.jpg, findBefore.jpg, HtmlFormRenderer.patch, maincss.css, profileAfter.jpg, profileBefore.jpg
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-633:
------------------------------

    Attachment: experimental_7.patch

Menu widget refactor. No need to apply the patch from OFBIZ-685 - it's now a part of the project. Just apply this patch to the latest svn and do an ant build in the framework/widget folder.

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: createCustomer.jpg, experimental_1.patch, experimental_2.patch, experimental_3.patch, experimental_4.patch, experimental_6.patch, experimental_6.patch, experimental_7.patch, findAfter.jpg, findBefore.jpg, HtmlFormRenderer.patch, maincss.css, profileAfter.jpg, profileBefore.jpg
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478795 ]

Adrian Crum commented on OFBIZ-633:
-----------------------------------

This issue can be closed. The ideas explored here are now a part of the project.

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: createCustomer.jpg, experimental_1.patch, experimental_2.patch, experimental_3.patch, experimental_4.patch, experimental_6.patch, experimental_6.patch, experimental_7.patch, findAfter.jpg, findBefore.jpg, HtmlFormRenderer.patch, maincss.css, profileAfter.jpg, profileBefore.jpg
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-633.
---------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
         Assignee: Jacques Le Roux

Great,

Thanks all (specially Adrian and Chris) for the good work. You did not even let me the time to test it ;o)

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: createCustomer.jpg, experimental_1.patch, experimental_2.patch, experimental_3.patch, experimental_4.patch, experimental_6.patch, experimental_6.patch, experimental_7.patch, findAfter.jpg, findBefore.jpg, HtmlFormRenderer.patch, maincss.css, profileAfter.jpg, profileBefore.jpg
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.