[jira] Created: (OFBIZ-633) Remove redunant style decarations from maincss.css

[Nicolas Malin (Jira)]

Remove redunant style decarations from maincss.css
--------------------------------------------------

                 Key: OFBIZ-633
                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
             Project: Apache OFBiz (The Open for Business Project)
          Issue Type: Sub-task
            Reporter: Chris Howe
            Priority: Minor
         Attachments: maincss.css

This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Howe updated OFBIZ-633:
-----------------------------

    Attachment: maincss.css

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465522 ]

Chris Howe commented on OFBIZ-633:
----------------------------------

Replicated comment from OFBIZ-605 follows:

Despite the criticism about this from the ML, I think it is ready for JIRA. I may not agree with the idea of combining style sheets in general, but after reviewing tabstyles.css , it really hasn't been maintained in such a way to benefit from the separation and if that's the direction of the consensus, then "step in the right direction" is my preference rather than no action. I have not yet dropped this css into my deployment, but it should be a rather simple review. Since the backend stuff really hasn't seen too much risque css applications, this should at worst be a fairly harmless improvement and at best a great consolidation.

I will sometime this week drop it into a deployment and check it out more thoroughly and report back.

Aside from the em to px issue, if something is to be 0px or 0em, there should be no units. It should just be 0 (ie margin: 0; not margin: 0px;)

Both no units and px -> em modifications have been included

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Adrian Crum]

Chris,

Thank you very much for putting this in a separate issue, and for attaching your
file. I'll download it and try it out now.


Chris Howe (JIRA) wrote:

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                  Key: OFBIZ-633
>                  URL: https://issues.apache.org/jira/browse/OFBIZ-633
>              Project: Apache OFBiz (The Open for Business Project)
>           Issue Type: Sub-task
>             Reporter: Chris Howe
>             Priority: Minor
>          Attachments: maincss.css
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css
>

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465533 ]

Chris Howe commented on OFBIZ-633:
----------------------------------

Forgot to include the
font-size: 62.5%;
for the body tag

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: maincss.css, maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Howe updated OFBIZ-633:
-----------------------------

    Attachment: maincss.css

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: maincss.css, maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465543 ]

Adrian Crum commented on OFBIZ-633:
-----------------------------------

Yeah, I changed mine to 76%. The 62.5% looks much better.

The layout looks great with your changes, using Mozilla and IE.

Thanks Chris!

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: maincss.css, maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465548 ]

Adrian Crum commented on OFBIZ-633:
-----------------------------------

Okay, getting back to your original comments about separate style sheets. What if we worked on cleaning up the single large file, then work on finding good "break points' where it could be split back out?

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: maincss.css, maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465553 ]

Chris Howe commented on OFBIZ-633:
----------------------------------

That would be great.  

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: maincss.css, maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-633:
----------------------------------

    Attachment:     (was: maincss.css)

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-633:
------------------------------

    Attachment: experimental_1.patch

I attached experimental_1.patch to this issue for people to try out. Apply the patch to an installed and recent copy of OFBiz.

The patch continues to build upon the maincss.css file changes. The purpose of the patch is to try out some new CSS classes and HTML coding practices before the big UI refactor gets started. My hope is that several developers will try it out and post comments here.

The patch expands the maincss.css file with a set of new classes. I kept the old ones intact for backward compatibility. I put plenty of comments in the file to explain things. The end result is a huge maincss.css file. Keep in mind it is not intended to be put in the main project - it's just there to try out ideas.

I used the Party Manager component to try out the improved layout methods. I like it because it has a lot of content and a good assortment of HTML elements. Only two screens are used for the demo - findParty and viewProfile.

There are two things I need help with at this stage:

1. There is a bug with IE (any version) and how it handles ULs. I tried a popular hack to fix the bug, but it's not working. If any CSS gurus out there could take a look at it I would appreciate it very much. The bug is clearly commented in the maincss.css file.

2. I need some Mac users to try out this patch. I've tested it with Windows Mozilla, Firefox, and IE7. They all render well. I don't have access to a Mac, so I'm depending on someone with a Mac to spend a few minutes playing around with this patch.

I tried to keep the OFBiz look and feel the same, but there are a few HTML element collections that I took the liberty to restyle. It's not my intention to introduce the style changes into the main project, they are just there for demonstration purposes.

I've been too busy with this effort to install, configure, and learn how to use a new IDE, so the patch will contain unintentional formatting changes that are caused by my current IDE. Examining file differences line-by-line probably won't give you much insight anyway. I commented everything that was worth looking at.

Take some time to tinker with the UI. Shrink the browser window down, reverse the direction, try to break the layout. So far, it seems to work pretty well for me. Spend some time looking at the page source - it's much cleaner in the changed areas.

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: experimental_1.patch, maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-633:
------------------------------

    Attachment: experimental_2.patch

experimental_2.patch is a scaled down version of the previous patch. The only files modified are maincss.css and findParty.ftl.

I've been refining the new css classes and I have come up with a decorator pattern that I think is really cool. This patch can be used to demonstrate the decorator pattern.

If you want to style a table, just use the tag

<table class="basicTable">

This will give you a basic table with header and cell styling built in.

If you want to add a dark grid to the table, just use the tag

<table class="basicTable darkGrid">

or, for a light grid

<table class="basicTable lightGrid">

If you want the rows to highlight when the cursor moves over them, use the tag

<table class="basicTable hoverBar">

And you can combine decorators -

<table class="basicTable lightGrid hoverBar">

Try it out for yourself. Look for the line

<table class="basicTable" cellspacing="0">

in findParty.ftl and add the decorators.

Let me know what you think.

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: experimental_1.patch, experimental_2.patch, maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468187 ]

Chris Howe commented on OFBIZ-633:
----------------------------------

While I like the power of it.  It runs counter to Zen Gardenesqueianism. :-)

Your class names are describing the styling and not the content.

To follow the Zen, presumably, your table should have an id and then your desired styling would style the id.

In addition, I don't know if you plan on attempting it in the CSS, but multiple selectors is broken in IE6

In html: class="foo bar"
In css: .foo.bar{} or .bar.foo{}

However multiple classes does work

In html: class="foo bar"
In css: .foo{} or .bar{}

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: experimental_1.patch, experimental_2.patch, maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468189 ]

Adrian Crum commented on OFBIZ-633:
-----------------------------------

I don't think OFBiz will ever fit into the Zen Garden style 100%.  I mused about that on the dev mailing list.

The problem with IDs is they are supposed to be unique for each page. Many of the HTML "element collections" OFBiz uses appear more than once on a page. So, IDs are only good for things like the masthead, application navigation, etc.

Using the viewProfile page as an example - there are a dozen screenlets on that page. If we followed Zen to the "T" then there would be an ID and style for each screenlet. Does that seem reasonable to you? It doesn't to me.

One of my objectives is to come up with reusable classes that make it easier to style content, as well as move away from table-based layout. The findParty.ftl file in this patch is much better than the original in the sense that it doesn't attempt to style each individual HTML element. Does it qualify as Zen? No. Is it easier to code? Yes.

IE6 - I think we came to the conclusion on the mailing list that it would be a waste of time to get anything to work properly in that version. I'm just trying to get the back office apps refactored at this point.

Thanks for always offering your input Chris. I truly appreciate it! It's good to know at least one person is monitoring this issue. :p

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: experimental_1.patch, experimental_2.patch, maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468191 ]

Jonathon Wong commented on OFBIZ-633:
-------------------------------------

I'm watching this too. See my difficulties (excuses listed on dev ML) in fixing OFBIZ-622; I used hardcoded styles when I couldn't easily find appropriate css styles.

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: experimental_1.patch, experimental_2.patch, maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468192 ]

Chris Howe commented on OFBIZ-633:
----------------------------------

Since tables should only be used on tabular data, tables should be part of the etc that IDs are good for :-)

I know we haven't completely made the transition to eliminate tables completely for layout, but the IDs should work on the ones that should stick around.

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: experimental_1.patch, experimental_2.patch, maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468193 ]

Adrian Crum commented on OFBIZ-633:
-----------------------------------

Jonathon - thanks for letting me know that you're watching this. Please try out the patch and let me know what you think.

Chris - the cool thing about IDs is, they don't have to be tied to style. They can also be used as named anchors. I'd like to see all screenlets have IDs so that URLs can point directly to a particular section of an OFBiz page.

I've been examining to CSS/HTML of some of the busiest sites on the 'net and the approach I took in this patch seems to be pretty popular.

Would you like to submit a patch demonstrating your approach? I'd like to see it. I'm open to ideas.

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: experimental_1.patch, experimental_2.patch, maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468197 ]

Adrian Crum commented on OFBIZ-633:
-----------------------------------

Chris,

You got me to thinking.

Okay, if the OFBiz CSS/HTML guidelines state that tables should not be used for layout, then how do we layout the Find Party Parameters portion of that page? I kept the table layout in the patch, but i HAD thought about alternatives before submitting the patch.

Using nested DIVs would be a nightmare and there is no guarantee that they will line up as neatly as a table.

I considered using a UL, but that just traded one set of elements for another. It was just as complicated as a table layout.

So, I kept the table layout and attempted to make is simpler with some CSS styling. I don't know what the answer is to that one. Maybe someone else has a solution.

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: experimental_1.patch, experimental_2.patch, maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468217 ]

Jacques Le Roux commented on OFBIZ-633:
---------------------------------------

In his book (1st edition at least) Jeffrey Zeldman advocates to not be a bigot for table in XHTML.

Of course he recommends to <<use tables only for their original purpose: the presentation of tabular data such as that found in spreadsheets, address books, stock quotes, event listings, and so on.>>
But also :
<<To the kind of standards geek who spends hours each week arguing about the evils of presentational markup on W3C mailing lists, what we've done here is evil and harmful. For that matter, we've also sinned by using tables as anything other than containers of tabular data, by specifying widths and heights in our table cells and by setting image margins to zero in markup. In fact, in the eyes of some, this entire chapter is sinful. Some standards geeks might not think much of this book, quite frankly. In their view, we should be telling you how to write semantic markup instead of letting you think it's okay to sometimes use tables for layout.

But the thing is, it is okay. Maybe it won't be okay some years from now, when designers use and browsers support purely semantic future versions of XHTML and rich future versions of CSS and SVG. But this is a transitional book for a transitional time. "Web standards" is not a set of immutable laws, but a path filled with options and decisions. In our view, people who insist on absolute purity in today's browser and standards environment do as much harm to the mainstream adoption of web standards as those who have never heard of or are downright hostile toward structural markup and CSS.>>

I'm not sure what he is pushing for in his 2d edition however...

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: experimental_1.patch, experimental_2.patch, maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468311 ]

Adrian Crum commented on OFBIZ-633:
-----------------------------------

Thank you for the quote Jacques. Did you try the patch?

> Remove redunant style decarations from maincss.css
> --------------------------------------------------
>
>                 Key: OFBIZ-633
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-633
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: experimental_1.patch, experimental_2.patch, maincss.css
>
>
> This will be used to contain comments regarding the consolidated maincss.css file that are rather unrelated to the combining of maincss.css and tabstyles.css

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.