[jira] Created: (OFBIZ-660) Make user input change background colours of formulars

[Nicolas Malin (Jira)]

Make user input change background colours of formulars
------------------------------------------------------

                 Key: OFBIZ-660
                 URL: https://issues.apache.org/jira/browse/OFBIZ-660
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
    Affects Versions: SVN trunk
         Environment: all platforms
            Reporter: Daniel Martínez


Calendar and lookup improvements so they change background colour of formulars

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Martínez updated OFBIZ-660:
----------------------------------

    Priority: Minor  (was: Major)

> Make user input change background colours of formulars
> ------------------------------------------------------
>
>                 Key: OFBIZ-660
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-660
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>         Environment: all platforms
>            Reporter: Daniel Martínez
>            Priority: Minor
>
> Calendar and lookup improvements so they change background colour of formulars

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468008 ]

Jacques Le Roux commented on OFBIZ-660:
---------------------------------------

Daniel,

Did you forget the patch or is it not ready yet ?

> Make user input change background colours of formulars
> ------------------------------------------------------
>
>                 Key: OFBIZ-660
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-660
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>         Environment: all platforms
>            Reporter: Daniel Martínez
>            Priority: Minor
>
> Calendar and lookup improvements so they change background colour of formulars

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Martínez updated OFBIZ-660:
----------------------------------

    Attachment: patch_colors.diff

Here is the patch. It was not ready yet :-)

It is a demo patch and I don't mean it for inclusion as it only demonstrates the funcionality for lookup and calendar inputs. Do you like yellow?

I have to think about something for the other formular tags

> Make user input change background colours of formulars
> ------------------------------------------------------
>
>                 Key: OFBIZ-660
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-660
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>         Environment: all platforms
>            Reporter: Daniel Martínez
>            Priority: Minor
>         Attachments: patch_colors.diff
>
>
> Calendar and lookup improvements so they change background colour of formulars

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468019 ]

Jacques Le Roux commented on OFBIZ-660:
---------------------------------------

Daniel,

*Please* use relative pathes in your patches, I'm really tired to repeat that over and over :(.
Good to read : http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices

you used
    ofbiz/framework/common/webcommon/includes/lookup.ftl
a relative path
    framework/common/webcommon/includes/lookup.ftl

Anyway, your patch was made with version 499603 of the trunk, I get :
    patching file framework/common/webcommon/includes/lookup.ftl
    Hunk #2 FAILED at 39.
    Hunk #5 FAILED at 62.
    2 out of 5 hunks FAILED -- saving rejects to file framework/common/webcommon/includes/lookup.ftl.rej
    patching file framework/images/webapp/images/calendar.html
    Hunk #1 FAILED at 15.
    Hunk #2 FAILED at 40.
    Hunk #3 FAILED at 64.
    Hunk #4 FAILED at 70.
    Hunk #5 FAILED at 79.
    Hunk #6 FAILED at 120.
    Hunk #7 FAILED at 126.
    7 out of 7 hunks FAILED -- saving rejects to file framework/images/webapp/images/calendar.html.rej
please update before creating you patch.

Thanks

> Make user input change background colours of formulars
> ------------------------------------------------------
>
>                 Key: OFBIZ-660
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-660
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>         Environment: all platforms
>            Reporter: Daniel Martínez
>            Priority: Minor
>         Attachments: patch_colors.diff
>
>
> Calendar and lookup improvements so they change background colour of formulars

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Martínez updated OFBIZ-660:
----------------------------------

    Attachment: patch_colors2.diff

I hope this would be the good one

Regards

> Make user input change background colours of formulars
> ------------------------------------------------------
>
>                 Key: OFBIZ-660
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-660
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>         Environment: all platforms
>            Reporter: Daniel Martínez
>            Priority: Minor
>         Attachments: patch_colors.diff, patch_colors2.diff
>
>
> Calendar and lookup improvements so they change background colour of formulars

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-660:
----------------------------------

    Attachment:     (was: patch_colors.diff)

> Make user input change background colours of formulars
> ------------------------------------------------------
>
>                 Key: OFBIZ-660
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-660
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>         Environment: all platforms
>            Reporter: Daniel Martínez
>            Priority: Minor
>         Attachments: patch_colors2.diff
>
>
> Calendar and lookup improvements so they change background colour of formulars

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468052 ]

Jacques Le Roux commented on OFBIZ-660:
---------------------------------------

I'm sorry Daniel but I end up with exactly the same problem. I also tried to merge the patch but in this case iIget : "an unknown line type was found in line 18". I tried to understand why but did not find any clues.

I see that there are plenty of lines that seems changed but are not like for instance
    -        td {font-family: Arial, Helvetica, sans-serif; font-size: 10px;}
    -        A { text-decoration: none; }
    -        A:hover { color: red; }
    -        a.link { font-family: Arial, Helvetia, sans-serif; font-size: 10px; color: #000000; }
    -        a.link:hover { font-family: Arial, Helvetia, sans-serif; font-size: 10px; text-decoration: underline; color: red; }
    +        td {font-family: Arial, Helvetica, sans-serif; font-size: 10px;}
    +        A { text-decoration: none; }
    +        A:hover { color: red; }
    +        a.link { font-family: Arial, Helvetia, sans-serif; font-size: 10px; color: #000000; }
    +        a.link:hover { font-family: Arial, Helvetia, sans-serif; font-size: 10px; text-decoration: underline; color: red; }
I don't know if it's clue, I guess not :(

I looked at EOLs but they seem to have no problems. Have you touch the patch by hand or something ?

> Make user input change background colours of formulars
> ------------------------------------------------------
>
>                 Key: OFBIZ-660
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-660
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>         Environment: all platforms
>            Reporter: Daniel Martínez
>            Priority: Minor
>         Attachments: patch_colors2.diff
>
>
> Calendar and lookup improvements so they change background colour of formulars

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Martínez updated OFBIZ-660:
----------------------------------

    Attachment: patch_colors3.diff

Well, I guess this was getting pretty weird :-P

I am using eclipse and there is a tool to convert tabs to spaces. It did each time you save a file, but it seems it does not work well. I deactivated it. This patch has only the changes made as expected. Hope it works

regards,

> Make user input change background colours of formulars
> ------------------------------------------------------
>
>                 Key: OFBIZ-660
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-660
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>         Environment: all platforms
>            Reporter: Daniel Martínez
>            Priority: Minor
>         Attachments: patch_colors2.diff, patch_colors3.diff
>
>
> Calendar and lookup improvements so they change background colour of formulars

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-660:
----------------------------------

    Attachment:     (was: patch_colors2.diff)

> Make user input change background colours of formulars
> ------------------------------------------------------
>
>                 Key: OFBIZ-660
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-660
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>         Environment: all platforms
>            Reporter: Daniel Martínez
>            Priority: Minor
>         Attachments: patch_colors3.diff
>
>
> Calendar and lookup improvements so they change background colour of formulars

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468212 ]

Jacques Le Roux commented on OFBIZ-660:
---------------------------------------

Daniel,

I applied the patch locally but where I'm supposed to see yellow ?

> Make user input change background colours of formulars
> ------------------------------------------------------
>
>                 Key: OFBIZ-660
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-660
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>         Environment: all platforms
>            Reporter: Daniel Martínez
>            Priority: Minor
>         Attachments: patch_colors3.diff
>
>
> Calendar and lookup improvements so they change background colour of formulars

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468539 ]

Daniel Martínez commented on OFBIZ-660:
---------------------------------------

Jacques,

You should see the change to yellow when you use the calendar or the popup-lookup screens to select a date/reference

> Make user input change background colours of formulars
> ------------------------------------------------------
>
>                 Key: OFBIZ-660
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-660
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>         Environment: all platforms
>            Reporter: Daniel Martínez
>            Priority: Minor
>         Attachments: patch_colors3.diff
>
>
> Calendar and lookup improvements so they change background colour of formulars

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468549 ]

Jacques Le Roux commented on OFBIZ-660:
---------------------------------------

Daniel,

Can you be more explicit please. Because I see no yellow in field or around the image in both cases. This in Firefox 1.5.0.9, IE 7 and Opera 9.02. I'm missing something surely but what ?

Thanks

> Make user input change background colours of formulars
> ------------------------------------------------------
>
>                 Key: OFBIZ-660
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-660
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>         Environment: all platforms
>            Reporter: Daniel Martínez
>            Priority: Minor
>         Attachments: patch_colors3.diff
>
>
> Calendar and lookup improvements so they change background colour of formulars

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468582 ]

Daniel Martínez commented on OFBIZ-660:
---------------------------------------

Jacques,

You should see change the background of the date/references formular boxes to yellow when you change the field. I am using firefox 2.0 and IE 7. This should work for almost all browsers

> Make user input change background colours of formulars
> ------------------------------------------------------
>
>                 Key: OFBIZ-660
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-660
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>         Environment: all platforms
>            Reporter: Daniel Martínez
>            Priority: Minor
>         Attachments: patch_colors3.diff
>
>
> Calendar and lookup improvements so they change background colour of formulars

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468630 ]

Jacques Le Roux commented on OFBIZ-660:
---------------------------------------

Ha, OK !

I did not any changes, that was my mistake. I thought the field would change as soon as I would have clicked on the image (I did not take time to look into the code).

This looks fine to me. But I'm not sure everybody will like it. So I wait for others opinons before doing anything more.

Thanks

> Make user input change background colours of formulars
> ------------------------------------------------------
>
>                 Key: OFBIZ-660
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-660
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>         Environment: all platforms
>            Reporter: Daniel Martínez
>            Priority: Minor
>         Attachments: patch_colors3.diff
>
>
> Calendar and lookup improvements so they change background colour of formulars

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-660:
---------------------------------

      Component/s: framework
    Fix Version/s: SVN trunk

> Make user input change background colours of formulars
> ------------------------------------------------------
>
>                 Key: OFBIZ-660
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-660
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: all platforms
>            Reporter: Daniel Martínez
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: patch_colors3.diff
>
>
> Calendar and lookup improvements so they change background colour of formulars

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-660.
---------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Thanks Daniel,

Your patch is in trunk rev.  603893  

> Make user input change background colours of formulars
> ------------------------------------------------------
>
>                 Key: OFBIZ-660
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-660
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: all platforms
>            Reporter: Daniel Martínez
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: patch_colors3.diff
>
>
> Calendar and lookup improvements so they change background colour of formulars

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.