[jira] Created: (OFBIZ-667) Bug in displaying order items when using old style calcTax service

[Nicolas Malin (Jira)]

Bug in displaying order items when using old style calcTax service
------------------------------------------------------------------

                 Key: OFBIZ-667
                 URL: https://issues.apache.org/jira/browse/OFBIZ-667
             Project: OFBiz (The Open for Business Project)
          Issue Type: Bug
          Components: ecommerce, order
         Environment: Centos Linux 4.4, Java 1.5
            Reporter: Ismail Cansiz
            Priority: Minor


There is a bug in orderitems.ftl when using old style calcTax service.
I attached a patch file for this bug.

Ismail Cansiz

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ismail Cansiz updated OFBIZ-667:
--------------------------------

    Attachment: orderitems.patch

> Bug in displaying order items when using old style calcTax service
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-667
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-667
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: ecommerce, order
>         Environment: Centos Linux 4.4, Java 1.5
>            Reporter: Ismail Cansiz
>            Priority: Minor
>         Attachments: orderitems.patch
>
>
> There is a bug in orderitems.ftl when using old style calcTax service.
> I attached a patch file for this bug.
> Ismail Cansiz

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468226 ]

Jacques Le Roux commented on OFBIZ-667:
---------------------------------------

Ismail,

Could you please detail a bit more your use case ?

Thanks

> Bug in displaying order items when using old style calcTax service
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-667
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-667
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: ecommerce, order
>         Environment: Centos Linux 4.4, Java 1.5
>            Reporter: Ismail Cansiz
>            Priority: Minor
>         Attachments: orderitems.patch
>
>
> There is a bug in orderitems.ftl when using old style calcTax service.
> I attached a patch file for this bug.
> Ismail Cansiz

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468249 ]

Ismail Cansiz commented on OFBIZ-667:
-------------------------------------

Hi Jacques,

I have tested with ProductStore entity fields vatTaxAuthPartyId and vatTaxAuthGeoId equals to "_NA_".
In this stuation, errors occured while viewing the order item adjustments ("SALES_TAX"). Because primaryGeo.geoName is null and orderitems.ftl caused error.

Thanks,
Ismail

> Bug in displaying order items when using old style calcTax service
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-667
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-667
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: ecommerce, order
>         Environment: Centos Linux 4.4, Java 1.5
>            Reporter: Ismail Cansiz
>            Priority: Minor
>         Attachments: orderitems.patch
>
>
> There is a bug in orderitems.ftl when using old style calcTax service.
> I attached a patch file for this bug.
> Ismail Cansiz

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468287 ]

Jacques Le Roux commented on OFBIZ-667:
---------------------------------------

Ismail,

Sorry I have no problem with ProductStore vatTaxAuthPartyId and vatTaxAuthGeoId sets to "_NA_". using DemoCusomter. Can you elaborate a bit more please ?

Thanks

> Bug in displaying order items when using old style calcTax service
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-667
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-667
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: ecommerce, order
>         Environment: Centos Linux 4.4, Java 1.5
>            Reporter: Ismail Cansiz
>            Priority: Minor
>         Attachments: orderitems.patch
>
>
> There is a bug in orderitems.ftl when using old style calcTax service.
> I attached a patch file for this bug.
> Ismail Cansiz

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468526 ]

Ismail Cansiz commented on OFBIZ-667:
-------------------------------------

Jacques,

There is a line (line 188) in orderitems.ftl file.
<b>${uiLabelMap.OrderJurisdiction}:</b> ${primaryGeo.geoName} [${primaryGeo.abbreviation?if_exists}]

If vatTaxAuthGeoId is null, primaryGeo.geoName is null too in my test db. So erros occured.
Also in this situation, it's not important to display primaryGeo fields.

Another solution may be replace "${primaryGeo.geoName} " with "${primaryGeo.geoName?if_exists} ".
ie full line is
     <b>${uiLabelMap.OrderJurisdiction}:</b> ${primaryGeo.geoName?if_exists} [${primaryGeo.abbreviation?if_exists}]

Thanks,
Ismail

> Bug in displaying order items when using old style calcTax service
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-667
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-667
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: ecommerce, order
>         Environment: Centos Linux 4.4, Java 1.5
>            Reporter: Ismail Cansiz
>            Priority: Minor
>         Attachments: orderitems.patch
>
>
> There is a bug in orderitems.ftl when using old style calcTax service.
> I attached a patch file for this bug.
> Ismail Cansiz

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-667.
---------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Ismail,

Thanks for the pointers, I already looked at the files. My question was more from a functionnal point of view.
I looked for a more detailed use case. FInally I find one and it's ok.

I prefered another solution less specific and hidding uiLabelMap.OrderJurisdiction like your 1st :
    <#if primaryGeo.geoName?has_content>
        <b>${uiLabelMap.OrderJurisdiction}:</b> ${primaryGeo.geoName} [${primaryGeo.abbreviation?if_exists}]
    </#if>

The modification is in OFBiz rev. 501521

Thanks

> Bug in displaying order items when using old style calcTax service
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-667
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-667
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: ecommerce, order
>         Environment: Centos Linux 4.4, Java 1.5
>            Reporter: Ismail Cansiz
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>         Attachments: orderitems.patch
>
>
> There is a bug in orderitems.ftl when using old style calcTax service.
> I attached a patch file for this bug.
> Ismail Cansiz

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.