[jira] Created: (OFBIZ-671) Remove HTML styling code from widgets
Locked
12
12
[jira] Created: (OFBIZ-671) Remove HTML styling code from widgets
 
|
Remove HTML styling code from widgets
------------------------------------- Key: OFBIZ-671 URL: https://issues.apache.org/jira/browse/OFBIZ-671 Project: OFBiz (The Open for Business Project) Issue Type: Sub-task Components: framework Reporter: Adrian Crum Priority: Minor Widgets have embedded styling code in them. Styling should be left to the css files. A CSS class should be created called "alert" or something similar, and that class should be used instead of the hard-coded color="red" found in the widgets. Files affected (as far as I can tell): htmlMenuRenderer.java and htmlFormRenderer.java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-671) Remove HTML styling code from widgets
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-671: ------------------------------ Attachment: formwidget.patch Removed embedded styling from the form widget. Added id and style elements. Added ability to specify <input> element to focus on after form is rendered. Reduced some redundant code. NOTE: This patch depends on OFBIZ-754. > Remove HTML styling code from widgets > ------------------------------------- > > Key: OFBIZ-671 > URL: https://issues.apache.org/jira/browse/OFBIZ-671 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: formwidget.patch > > > Widgets have embedded styling code in them. Styling should be left to the css files. A CSS class should be created called "alert" or something similar, and that class should be used instead of the hard-coded color="red" found in the widgets. > Files affected (as far as I can tell): htmlMenuRenderer.java and htmlFormRenderer.java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-671) Remove HTML styling code from widgets
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-671: ------------------------------ Attachment: treewidget.patch Removed embedded styling from tree widget. Refactored rendering code to emit unordered lists instead of nested <div>s. NOTE: This patch depends on OFBIZ-754. > Remove HTML styling code from widgets > ------------------------------------- > > Key: OFBIZ-671 > URL: https://issues.apache.org/jira/browse/OFBIZ-671 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: formwidget.patch, treewidget.patch > > > Widgets have embedded styling code in them. Styling should be left to the css files. A CSS class should be created called "alert" or something similar, and that class should be used instead of the hard-coded color="red" found in the widgets. > Files affected (as far as I can tell): htmlMenuRenderer.java and htmlFormRenderer.java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-671) Remove HTML styling code from widgets
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-671: ------------------------------ Attachment: menuwidget.patch Removed embedded styling from the menu widget. Refactored rendering code to emit unordered lists instead of nested <div>s. NOTE: This patch depends on OFBIZ-754. NOTE: All files in this patch must be patched. Otherwise the app menus in Content Manager and Marketing Manager will break. > Remove HTML styling code from widgets > ------------------------------------- > > Key: OFBIZ-671 > URL: https://issues.apache.org/jira/browse/OFBIZ-671 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: formwidget.patch, menuwidget.patch, treewidget.patch > > > Widgets have embedded styling code in them. Styling should be left to the css files. A CSS class should be created called "alert" or something similar, and that class should be used instead of the hard-coded color="red" found in the widgets. > Files affected (as far as I can tell): htmlMenuRenderer.java and htmlFormRenderer.java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-671) Remove HTML styling code from widgets
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-671: ------------------------------ Attachment: menuwidget.patch Updated menu widget patch. Somehow I missed the Work Effort component. > Remove HTML styling code from widgets > ------------------------------------- > > Key: OFBIZ-671 > URL: https://issues.apache.org/jira/browse/OFBIZ-671 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: formwidget.patch, menuwidget.patch, menuwidget.patch, treewidget.patch > > > Widgets have embedded styling code in them. Styling should be left to the css files. A CSS class should be created called "alert" or something similar, and that class should be used instead of the hard-coded color="red" found in the widgets. > Files affected (as far as I can tell): htmlMenuRenderer.java and htmlFormRenderer.java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-671) Remove HTML styling code from widgets
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475610 ] Jacopo Cappellato commented on OFBIZ-671: ----------------------------------------- Adrian, I'm starting to review the formwidget.patch (thanks for your work!), I had actually a very cursory review for now, and here are my first comments: 1) would it be possible for you to pull out from the patch the three new attributes? I'm not saying that they are not worth of inclusion, but I'd like to discuss a bit more about them with others, and probably select better names for them; for example, "focus-widget" maybe should be named "focus-field-name" 2) please ignore this if you'll follow my suggestion in #1; I think that the lines: if (this.containerId == null || formElement.hasAttribute("id")) { this.containerId = formElement.getAttribute("container-id"); } should be instead: if (this.containerId == null || formElement.hasAttribute("id")) { this.containerId = formElement.getAttribute("id"); } 3) here and there you used "\r\n" for newlines, instead you should use the appendWhitespace(...) method 4) are the spaces that you added here and there really necessary? For example: - buffer.append("<td align=\"center\""); + buffer.append(" <td align=\"center\""); 5) why did you comment out many of the calls to the appendWhitespace(...)? - this.appendWhitespace(buffer); + //this.appendWhitespace(buffer Jacopo > Remove HTML styling code from widgets > ------------------------------------- > > Key: OFBIZ-671 > URL: https://issues.apache.org/jira/browse/OFBIZ-671 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: formwidget.patch, menuwidget.patch, menuwidget.patch, treewidget.patch > > > Widgets have embedded styling code in them. Styling should be left to the css files. A CSS class should be created called "alert" or something similar, and that class should be used instead of the hard-coded color="red" found in the widgets. > Files affected (as far as I can tell): htmlMenuRenderer.java and htmlFormRenderer.java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-671) Remove HTML styling code from widgets
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475612 ] Jacopo Cappellato commented on OFBIZ-671: ----------------------------------------- I would really like to get some comments from others committers as well (especially from David Jones, because he has a broader vision of the widgets than I have) because I think that the direction of this patch is good and I'd like to commit it as soon as it has been cleaned up. Jacopo > Remove HTML styling code from widgets > ------------------------------------- > > Key: OFBIZ-671 > URL: https://issues.apache.org/jira/browse/OFBIZ-671 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: formwidget.patch, menuwidget.patch, menuwidget.patch, treewidget.patch > > > Widgets have embedded styling code in them. Styling should be left to the css files. A CSS class should be created called "alert" or something similar, and that class should be used instead of the hard-coded color="red" found in the widgets. > Files affected (as far as I can tell): htmlMenuRenderer.java and htmlFormRenderer.java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-671) Remove HTML styling code from widgets
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475639 ] Adrian Crum commented on OFBIZ-671: ----------------------------------- Jacopo, Thank you for taking a look at this! I will work on using the appendWhitespace method. I was trying to keep things concise, but I understand your point. I added the spaces and commented out some of the appendWhitespace method calls so that the markup the widget generates is more readable. It was my plan to change those back after the refactor. I will take another look at the new attributes. It appeared to me that there was no way to assign an id or a style to the <form> element - that's why I included them. I will change the name of focus-widget, your suggestion sounds better. > Remove HTML styling code from widgets > ------------------------------------- > > Key: OFBIZ-671 > URL: https://issues.apache.org/jira/browse/OFBIZ-671 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: formwidget.patch, menuwidget.patch, menuwidget.patch, treewidget.patch > > > Widgets have embedded styling code in them. Styling should be left to the css files. A CSS class should be created called "alert" or something similar, and that class should be used instead of the hard-coded color="red" found in the widgets. > Files affected (as far as I can tell): htmlMenuRenderer.java and htmlFormRenderer.java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-671) Remove HTML styling code from widgets
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-671: ------------------------------ Attachment: formwidget.patch Improved form widget patch. Changed focus-widget to focus-field-name, changed /r/n to appendWhitespace method calls. I kept the markup formatting in the patch. This will be invaluable during the UI refactor. Just look at the markup this form widget outputs and see for yourself. If it becomes an issue, I promise I will remove it after the refactoring effort. I kept the new properties. Even David Jones will understand that the widgets are inconsistent when it come to id and style assignments. Some elements support it, others don't. My hope is that this patch will get committed so that the UI refactoring can get started. I strongly recommend taking another look at it afterwards because it can use some work. I found a lot of redundant code, and things that could be implemented better by using better OOP in the java files, plus Chris Howe has made a good suggestion about having a <styling> section. This patch is a step in the right direction, but there is so much more that can be done to improve the form widget. > Remove HTML styling code from widgets > ------------------------------------- > > Key: OFBIZ-671 > URL: https://issues.apache.org/jira/browse/OFBIZ-671 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: formwidget.patch, formwidget.patch, menuwidget.patch, menuwidget.patch, treewidget.patch > > > Widgets have embedded styling code in them. Styling should be left to the css files. A CSS class should be created called "alert" or something similar, and that class should be used instead of the hard-coded color="red" found in the widgets. > Files affected (as far as I can tell): htmlMenuRenderer.java and htmlFormRenderer.java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-671) Remove HTML styling code from widgets
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-671: ------------------------------ Attachment: treewidget.patch Improved tree widget patch. Replaced \r\n with appendWhitespace method calls. Kept markup formatting for reason stated above. > Remove HTML styling code from widgets > ------------------------------------- > > Key: OFBIZ-671 > URL: https://issues.apache.org/jira/browse/OFBIZ-671 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: formwidget.patch, formwidget.patch, menuwidget.patch, menuwidget.patch, treewidget.patch, treewidget.patch > > > Widgets have embedded styling code in them. Styling should be left to the css files. A CSS class should be created called "alert" or something similar, and that class should be used instead of the hard-coded color="red" found in the widgets. > Files affected (as far as I can tell): htmlMenuRenderer.java and htmlFormRenderer.java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-671) Remove HTML styling code from widgets
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-671: ------------------------------ Attachment: menuwidget.patch Improved menu widget patch. Replaced \r\n with appendWhitespace method calls. Kept markup formatting for reason stated above. > Remove HTML styling code from widgets > ------------------------------------- > > Key: OFBIZ-671 > URL: https://issues.apache.org/jira/browse/OFBIZ-671 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: formwidget.patch, formwidget.patch, menuwidget.patch, menuwidget.patch, menuwidget.patch, treewidget.patch, treewidget.patch > > > Widgets have embedded styling code in them. Styling should be left to the css files. A CSS class should be created called "alert" or something similar, and that class should be used instead of the hard-coded color="red" found in the widgets. > Files affected (as far as I can tell): htmlMenuRenderer.java and htmlFormRenderer.java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-671) Remove HTML styling code from widgets
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475735 ] Adrian Crum commented on OFBIZ-671: ----------------------------------- As I'm going through the Party Manager form widget xml files, I find myself adding the line default-tooltip-style="tooltip" to every form definition. Does anyone have any objections to the form widget java code defaulting to "tooltip" as the tooltip style? That would eliminate one more element from the form definitions. > Remove HTML styling code from widgets > ------------------------------------- > > Key: OFBIZ-671 > URL: https://issues.apache.org/jira/browse/OFBIZ-671 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: formwidget.patch, formwidget.patch, menuwidget.patch, menuwidget.patch, menuwidget.patch, treewidget.patch, treewidget.patch > > > Widgets have embedded styling code in them. Styling should be left to the css files. A CSS class should be created called "alert" or something similar, and that class should be used instead of the hard-coded color="red" found in the widgets. > Files affected (as far as I can tell): htmlMenuRenderer.java and htmlFormRenderer.java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-671) Remove HTML styling code from widgets
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475838 ] Jacopo Cappellato commented on OFBIZ-671: ----------------------------------------- I agree that, when needed, it is ok to 'hardcode' the name of the default style in the HtmlFormRenderer class: so, yes, I think it's the right way to handle the default style for tooltips. Hardcoding the name of the default style, will not prevent the user to change the default style by just changing the style definition attributes in the css; or just use the default-tooltip-style attribute to use a special style for one form. > Remove HTML styling code from widgets > ------------------------------------- > > Key: OFBIZ-671 > URL: https://issues.apache.org/jira/browse/OFBIZ-671 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: formwidget.patch, formwidget.patch, menuwidget.patch, menuwidget.patch, menuwidget.patch, treewidget.patch, treewidget.patch > > > Widgets have embedded styling code in them. Styling should be left to the css files. A CSS class should be created called "alert" or something similar, and that class should be used instead of the hard-coded color="red" found in the widgets. > Files affected (as far as I can tell): htmlMenuRenderer.java and htmlFormRenderer.java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-671) Remove HTML styling code from widgets
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-671: ------------------------------ Attachment: formwidget.patch Form widget now defaults to "tooltip" style if none is specified. > Remove HTML styling code from widgets > ------------------------------------- > > Key: OFBIZ-671 > URL: https://issues.apache.org/jira/browse/OFBIZ-671 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: formwidget.patch, formwidget.patch, formwidget.patch, menuwidget.patch, menuwidget.patch, menuwidget.patch, treewidget.patch, treewidget.patch > > > Widgets have embedded styling code in them. Styling should be left to the css files. A CSS class should be created called "alert" or something similar, and that class should be used instead of the hard-coded color="red" found in the widgets. > Files affected (as far as I can tell): htmlMenuRenderer.java and htmlFormRenderer.java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-671) Remove HTML styling code from widgets
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475950 ] Adrian Crum commented on OFBIZ-671: ----------------------------------- I just realized something about the change to the widgets - this could have an adverse impact on the eCommerce component. The main issue is browser compatibility. Some things off the top of my head that need to be addressed for eCommerce: 1. The new styles need to be copied to ecommain.css. 2. The list type form widget defaults to a table style of "basic-table dark-grid" - Chris Howe mentioned previously that older versions of IE don't handle multiple classes well. 3. The grid table decorators reveal a flaw in IE - it doesn't draw borders around empty table cells (<td> elements). So, those things need to be resolved before this gets committed. > Remove HTML styling code from widgets > ------------------------------------- > > Key: OFBIZ-671 > URL: https://issues.apache.org/jira/browse/OFBIZ-671 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: formwidget.patch, formwidget.patch, formwidget.patch, menuwidget.patch, menuwidget.patch, menuwidget.patch, treewidget.patch, treewidget.patch > > > Widgets have embedded styling code in them. Styling should be left to the css files. A CSS class should be created called "alert" or something similar, and that class should be used instead of the hard-coded color="red" found in the widgets. > Files affected (as far as I can tell): htmlMenuRenderer.java and htmlFormRenderer.java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-671) Remove HTML styling code from widgets
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475954 ] Chris Howe commented on OFBIZ-671: ---------------------------------- The issue with 2 is with having a style like so basic-table.dark-grid{ } the following should work fine basic-table{ } dark-grid{ } Meaning it should be able to inherit just fine. The problem is that you cannot specify styles that only affect the divs when they have both. > Remove HTML styling code from widgets > ------------------------------------- > > Key: OFBIZ-671 > URL: https://issues.apache.org/jira/browse/OFBIZ-671 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: formwidget.patch, formwidget.patch, formwidget.patch, menuwidget.patch, menuwidget.patch, menuwidget.patch, treewidget.patch, treewidget.patch > > > Widgets have embedded styling code in them. Styling should be left to the css files. A CSS class should be created called "alert" or something similar, and that class should be used instead of the hard-coded color="red" found in the widgets. > Files affected (as far as I can tell): htmlMenuRenderer.java and htmlFormRenderer.java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-671) Remove HTML styling code from widgets
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-671: ------------------------------ Attachment: menuwidget.patch Added default tooltip and selected styles to menu widget. > Remove HTML styling code from widgets > ------------------------------------- > > Key: OFBIZ-671 > URL: https://issues.apache.org/jira/browse/OFBIZ-671 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: formwidget.patch, formwidget.patch, formwidget.patch, menuwidget.patch, menuwidget.patch, menuwidget.patch, menuwidget.patch, treewidget.patch, treewidget.patch > > > Widgets have embedded styling code in them. Styling should be left to the css files. A CSS class should be created called "alert" or something similar, and that class should be used instead of the hard-coded color="red" found in the widgets. > Files affected (as far as I can tell): htmlMenuRenderer.java and htmlFormRenderer.java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-671) Remove HTML styling code from widgets
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-671: --------------------------------------- Assignee: Jacopo Cappellato > Remove HTML styling code from widgets > ------------------------------------- > > Key: OFBIZ-671 > URL: https://issues.apache.org/jira/browse/OFBIZ-671 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task > Components: framework > Reporter: Adrian Crum > Assigned To: Jacopo Cappellato > Priority: Minor > Attachments: formwidget.patch, formwidget.patch, formwidget.patch, menuwidget.patch, menuwidget.patch, menuwidget.patch, menuwidget.patch, treewidget.patch, treewidget.patch > > > Widgets have embedded styling code in them. Styling should be left to the css files. A CSS class should be created called "alert" or something similar, and that class should be used instead of the hard-coded color="red" found in the widgets. > Files affected (as far as I can tell): htmlMenuRenderer.java and htmlFormRenderer.java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-671) Remove HTML styling code from widgets
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-671. ----------------------------------- Resolution: Fixed Thanks Adrian, you did a lot of work! Your patches (with some minor formatting improvements) are in rev. 514099 > Remove HTML styling code from widgets > ------------------------------------- > > Key: OFBIZ-671 > URL: https://issues.apache.org/jira/browse/OFBIZ-671 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task > Components: framework > Reporter: Adrian Crum > Assigned To: Jacopo Cappellato > Priority: Minor > Attachments: formwidget.patch, formwidget.patch, formwidget.patch, menuwidget.patch, menuwidget.patch, menuwidget.patch, menuwidget.patch, treewidget.patch, treewidget.patch > > > Widgets have embedded styling code in them. Styling should be left to the css files. A CSS class should be created called "alert" or something similar, and that class should be used instead of the hard-coded color="red" found in the widgets. > Files affected (as far as I can tell): htmlMenuRenderer.java and htmlFormRenderer.java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-671) Remove HTML styling code from widgets
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477646 ] Adrian Crum commented on OFBIZ-671: ----------------------------------- Jacopo, The widget dtds have been updated in the trunk, but they still need to be updated on the ofbiz.org site. Example: http://ofbiz.apache.org/dtds/widget-form.xsd > Remove HTML styling code from widgets > ------------------------------------- > > Key: OFBIZ-671 > URL: https://issues.apache.org/jira/browse/OFBIZ-671 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task > Components: framework > Reporter: Adrian Crum > Assigned To: Jacopo Cappellato > Priority: Minor > Attachments: formwidget.patch, formwidget.patch, formwidget.patch, menuwidget.patch, menuwidget.patch, menuwidget.patch, menuwidget.patch, treewidget.patch, treewidget.patch > > > Widgets have embedded styling code in them. Styling should be left to the css files. A CSS class should be created called "alert" or something similar, and that class should be used instead of the hard-coded color="red" found in the widgets. > Files affected (as far as I can tell): htmlMenuRenderer.java and htmlFormRenderer.java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |