[jira] Created: (OFBIZ-68) Break up application templates with multiple screenlets
Locked
[jira] Created: (OFBIZ-68) Break up application templates with multiple screenlets
 
|
Break up application templates with multiple screenlets
------------------------------------------------------- Key: OFBIZ-68 URL: http://issues.apache.org/jira/browse/OFBIZ-68 Project: The Open For Business Project Type: Improvement Components: order Reporter: Chris Howe There are currently 7 freemarker files in the order applications that have multiple screenlets in the same template file. They are: entry/cart/showcart.ftl entry/cart/showPromotionDetails.ftl entry/order/orderheader.ftl entry/poheader.ftl (may not be used) order/orderheader.ftl quote/ViewQuoteInfo.ftl request/ViewRequestInfo.ftl I would like these to be split up. Screenlets, when defined make up a good chunk of reusable code. When multiple screenlets inhabit the same template file, you either have to reuse all of the code or none if it. By splitting these up, the parts are more likely to be reused than the whole. Because the order application is the base for so many custom applications in addition to ecomerce and wholesale and salesrep, making it reusable will lower the maintenance those applications require. Please vote on this and I will submit patches. Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
Re: [jira] Created: (OFBIZ-68) Break up application templates with multiple screenlets
|
|
always for modularity
+1 especially if I don't have to do it. ;) Chris Howe (JIRA) sent the following on 6/29/2006 6:24 PM: > Break up application templates with multiple screenlets > ------------------------------------------------------- > > Key: OFBIZ-68 > URL: http://issues.apache.org/jira/browse/OFBIZ-68 > Project: The Open For Business Project > Type: Improvement > > Components: order > Reporter: Chris Howe > > > There are currently 7 freemarker files in the order applications that have multiple screenlets in the same template file. They are: > > entry/cart/showcart.ftl > entry/cart/showPromotionDetails.ftl > entry/order/orderheader.ftl > entry/poheader.ftl (may not be used) > order/orderheader.ftl > quote/ViewQuoteInfo.ftl > request/ViewRequestInfo.ftl > > I would like these to be split up. Screenlets, when defined make up a good chunk of reusable code. When multiple screenlets inhabit the same template file, you either have to reuse all of the code or none if it. By splitting these up, the parts are more likely to be reused than the whole. > > Because the order application is the base for so many custom applications in addition to ecomerce and wholesale and salesrep, making it reusable will lower the maintenance those applications require. Please vote on this and I will submit patches. Thanks > |
[jira] Updated: (OFBIZ-68) Break up application templates with multiple screenlets
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-68?page=all ]
Chris Howe updated OFBIZ-68: ---------------------------- Attachment: ViewRequest.patch ViewRequest.patch splits up the ViewRequestInfo.ftl file into 3 freemarker templates also creates appropriate updates to RequestScreens.xml in the order application as well as the ecommerce application. Please review that this method is acceptable. > Break up application templates with multiple screenlets > ------------------------------------------------------- > > Key: OFBIZ-68 > URL: http://issues.apache.org/jira/browse/OFBIZ-68 > Project: The Open For Business Project > Type: Improvement > Components: order > Reporter: Chris Howe > Attachments: ViewRequest.patch > > There are currently 7 freemarker files in the order applications that have multiple screenlets in the same template file. They are: > entry/cart/showcart.ftl > entry/cart/showPromotionDetails.ftl > entry/order/orderheader.ftl > entry/poheader.ftl (may not be used) > order/orderheader.ftl > quote/ViewQuoteInfo.ftl > request/ViewRequestInfo.ftl > I would like these to be split up. Screenlets, when defined make up a good chunk of reusable code. When multiple screenlets inhabit the same template file, you either have to reuse all of the code or none if it. By splitting these up, the parts are more likely to be reused than the whole. > Because the order application is the base for so many custom applications in addition to ecomerce and wholesale and salesrep, making it reusable will lower the maintenance those applications require. Please vote on this and I will submit patches. Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Assigned: (OFBIZ-68) Break up application templates with multiple screenlets
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-68?page=all ]
Jacopo Cappellato reassigned OFBIZ-68: -------------------------------------- Assign To: Jacopo Cappellato > Break up application templates with multiple screenlets > ------------------------------------------------------- > > Key: OFBIZ-68 > URL: http://issues.apache.org/jira/browse/OFBIZ-68 > Project: The Open For Business Project > Type: Improvement > Components: order > Reporter: Chris Howe > Assignee: Jacopo Cappellato > Attachments: ViewRequest.patch > > There are currently 7 freemarker files in the order applications that have multiple screenlets in the same template file. They are: > entry/cart/showcart.ftl > entry/cart/showPromotionDetails.ftl > entry/order/orderheader.ftl > entry/poheader.ftl (may not be used) > order/orderheader.ftl > quote/ViewQuoteInfo.ftl > request/ViewRequestInfo.ftl > I would like these to be split up. Screenlets, when defined make up a good chunk of reusable code. When multiple screenlets inhabit the same template file, you either have to reuse all of the code or none if it. By splitting these up, the parts are more likely to be reused than the whole. > Because the order application is the base for so many custom applications in addition to ecomerce and wholesale and salesrep, making it reusable will lower the maintenance those applications require. Please vote on this and I will submit patches. Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-68) Break up application templates with multiple screenlets
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-68?page=comments#action_12418571 ]
Jacopo Cappellato commented on OFBIZ-68: ---------------------------------------- Chris, your work is very good and I've committed it, with some changes, in rev. 7906. Please, review it and see if everything is ok: I cleaned up a bit of the original code (following your suggestions in the comments in the screen) and I've also fixed two small errors inyour patch (in the ordermgr/RequestScreens.xml in chunk at line 107). Before working at the entry and order screens (rather messed up and frequently modified) you could refactor the quote screen as well. Also, consider that tomorrow David will move the OFBiz codebase to the ASF server: if you'll start working on this on monday, maybe it's better. Again thanks > Break up application templates with multiple screenlets > ------------------------------------------------------- > > Key: OFBIZ-68 > URL: http://issues.apache.org/jira/browse/OFBIZ-68 > Project: The Open For Business Project > Type: Improvement > Components: order > Reporter: Chris Howe > Assignee: Jacopo Cappellato > Attachments: ViewRequest.patch > > There are currently 7 freemarker files in the order applications that have multiple screenlets in the same template file. They are: > entry/cart/showcart.ftl > entry/cart/showPromotionDetails.ftl > entry/order/orderheader.ftl > entry/poheader.ftl (may not be used) > order/orderheader.ftl > quote/ViewQuoteInfo.ftl > request/ViewRequestInfo.ftl > I would like these to be split up. Screenlets, when defined make up a good chunk of reusable code. When multiple screenlets inhabit the same template file, you either have to reuse all of the code or none if it. By splitting these up, the parts are more likely to be reused than the whole. > Because the order application is the base for so many custom applications in addition to ecomerce and wholesale and salesrep, making it reusable will lower the maintenance those applications require. Please vote on this and I will submit patches. Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-68) Break up application templates with multiple screenlets
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-68?page=comments#action_12418692 ]
Chris Howe commented on OFBIZ-68: --------------------------------- Jacopo, For the component://order/widget/ordermgr/OrderRequestScreens.xml#ViewRequestInfo Screen, you didn't retain the container or add a css style that would maintain the left half, right half like the Order Header does using tables... ie some screenlets on the left half and some screenlets on the right half. it just requires something like <container style="lefthalf"> and then an addition to maincss.css and mainecom.css that defines the lefthalf and right half class in their respective proportions (50% with a bit of padding) > Break up application templates with multiple screenlets > ------------------------------------------------------- > > Key: OFBIZ-68 > URL: http://issues.apache.org/jira/browse/OFBIZ-68 > Project: The Open For Business Project > Type: Improvement > Components: order > Reporter: Chris Howe > Assignee: Jacopo Cappellato > Attachments: ViewRequest.patch > > There are currently 7 freemarker files in the order applications that have multiple screenlets in the same template file. They are: > entry/cart/showcart.ftl > entry/cart/showPromotionDetails.ftl > entry/order/orderheader.ftl > entry/poheader.ftl (may not be used) > order/orderheader.ftl > quote/ViewQuoteInfo.ftl > request/ViewRequestInfo.ftl > I would like these to be split up. Screenlets, when defined make up a good chunk of reusable code. When multiple screenlets inhabit the same template file, you either have to reuse all of the code or none if it. By splitting these up, the parts are more likely to be reused than the whole. > Because the order application is the base for so many custom applications in addition to ecomerce and wholesale and salesrep, making it reusable will lower the maintenance those applications require. Please vote on this and I will submit patches. Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-68) Break up application templates with multiple screenlets
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-68?page=comments#action_12418768 ]
Jacopo Cappellato commented on OFBIZ-68: ---------------------------------------- Hi Chris, could you please provide a patch for this? Thanks. > Break up application templates with multiple screenlets > ------------------------------------------------------- > > Key: OFBIZ-68 > URL: http://issues.apache.org/jira/browse/OFBIZ-68 > Project: The Open For Business Project > Type: Improvement > Components: order > Reporter: Chris Howe > Assignee: Jacopo Cappellato > Attachments: ViewRequest.patch > > There are currently 7 freemarker files in the order applications that have multiple screenlets in the same template file. They are: > entry/cart/showcart.ftl > entry/cart/showPromotionDetails.ftl > entry/order/orderheader.ftl > entry/poheader.ftl (may not be used) > order/orderheader.ftl > quote/ViewQuoteInfo.ftl > request/ViewRequestInfo.ftl > I would like these to be split up. Screenlets, when defined make up a good chunk of reusable code. When multiple screenlets inhabit the same template file, you either have to reuse all of the code or none if it. By splitting these up, the parts are more likely to be reused than the whole. > Because the order application is the base for so many custom applications in addition to ecomerce and wholesale and salesrep, making it reusable will lower the maintenance those applications require. Please vote on this and I will submit patches. Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-68) Break up application templates with multiple screenlets
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-68?page=all ]
Chris Howe updated OFBIZ-68: ---------------------------- Attachment: cssChange.patch cssChange.patch updates the ecomcss.css, maincss.css, and order/widget/RequestScreen to allow a left half, right half and contained footer this took much longer to do than I thought it would. I hope IE7 final gets released soon, IE people use it and it actually does things correctly.grrr > Break up application templates with multiple screenlets > ------------------------------------------------------- > > Key: OFBIZ-68 > URL: http://issues.apache.org/jira/browse/OFBIZ-68 > Project: The Open For Business Project > Type: Improvement > Components: order > Reporter: Chris Howe > Assignee: Jacopo Cappellato > Attachments: ViewRequest.patch, cssChange.patch > > There are currently 7 freemarker files in the order applications that have multiple screenlets in the same template file. They are: > entry/cart/showcart.ftl > entry/cart/showPromotionDetails.ftl > entry/order/orderheader.ftl > entry/poheader.ftl (may not be used) > order/orderheader.ftl > quote/ViewQuoteInfo.ftl > request/ViewRequestInfo.ftl > I would like these to be split up. Screenlets, when defined make up a good chunk of reusable code. When multiple screenlets inhabit the same template file, you either have to reuse all of the code or none if it. By splitting these up, the parts are more likely to be reused than the whole. > Because the order application is the base for so many custom applications in addition to ecomerce and wholesale and salesrep, making it reusable will lower the maintenance those applications require. Please vote on this and I will submit patches. Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-68) Break up application templates with multiple screenlets
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-68?page=comments#action_12418786 ]
Jacopo Cappellato commented on OFBIZ-68: ---------------------------------------- Chris, thanks so much. They work very well. I've committed the patch for the order component (rev. 7921) and I've asked David if he could add the new styles you have defined. > Break up application templates with multiple screenlets > ------------------------------------------------------- > > Key: OFBIZ-68 > URL: http://issues.apache.org/jira/browse/OFBIZ-68 > Project: The Open For Business Project > Type: Improvement > Components: order > Reporter: Chris Howe > Assignee: Jacopo Cappellato > Attachments: ViewRequest.patch, cssChange.patch > > There are currently 7 freemarker files in the order applications that have multiple screenlets in the same template file. They are: > entry/cart/showcart.ftl > entry/cart/showPromotionDetails.ftl > entry/order/orderheader.ftl > entry/poheader.ftl (may not be used) > order/orderheader.ftl > quote/ViewQuoteInfo.ftl > request/ViewRequestInfo.ftl > I would like these to be split up. Screenlets, when defined make up a good chunk of reusable code. When multiple screenlets inhabit the same template file, you either have to reuse all of the code or none if it. By splitting these up, the parts are more likely to be reused than the whole. > Because the order application is the base for so many custom applications in addition to ecomerce and wholesale and salesrep, making it reusable will lower the maintenance those applications require. Please vote on this and I will submit patches. Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-68) Break up application templates with multiple screenlets
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-68?page=all ]
Chris Howe updated OFBIZ-68: ---------------------------- Attachment: ViewQuote.patch ViewQuote.patch follows the same approach as ViewRequest.patch. Note: OrderErrorQuoteNotFound and OrderErrorRequestNotFound are not in any property files > Break up application templates with multiple screenlets > ------------------------------------------------------- > > Key: OFBIZ-68 > URL: http://issues.apache.org/jira/browse/OFBIZ-68 > Project: The Open For Business Project > Type: Improvement > Components: order > Reporter: Chris Howe > Assignee: Jacopo Cappellato > Attachments: ViewQuote.patch, ViewRequest.patch, cssChange.patch > > There are currently 7 freemarker files in the order applications that have multiple screenlets in the same template file. They are: > entry/cart/showcart.ftl > entry/cart/showPromotionDetails.ftl > entry/order/orderheader.ftl > entry/poheader.ftl (may not be used) > order/orderheader.ftl > quote/ViewQuoteInfo.ftl > request/ViewRequestInfo.ftl > I would like these to be split up. Screenlets, when defined make up a good chunk of reusable code. When multiple screenlets inhabit the same template file, you either have to reuse all of the code or none if it. By splitting these up, the parts are more likely to be reused than the whole. > Because the order application is the base for so many custom applications in addition to ecomerce and wholesale and salesrep, making it reusable will lower the maintenance those applications require. Please vote on this and I will submit patches. Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-68) Break up application templates with multiple screenlets
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-68?page=comments#action_12418828 ]
Jacopo Cappellato commented on OFBIZ-68: ---------------------------------------- Thanks Chris, your patch for quotes is in svn (with some small changes) with rev. 418557 > Break up application templates with multiple screenlets > ------------------------------------------------------- > > Key: OFBIZ-68 > URL: http://issues.apache.org/jira/browse/OFBIZ-68 > Project: The Open For Business Project > Type: Improvement > Components: order > Reporter: Chris Howe > Assignee: Jacopo Cappellato > Attachments: ViewQuote.patch, ViewRequest.patch, cssChange.patch > > There are currently 7 freemarker files in the order applications that have multiple screenlets in the same template file. They are: > entry/cart/showcart.ftl > entry/cart/showPromotionDetails.ftl > entry/order/orderheader.ftl > entry/poheader.ftl (may not be used) > order/orderheader.ftl > quote/ViewQuoteInfo.ftl > request/ViewRequestInfo.ftl > I would like these to be split up. Screenlets, when defined make up a good chunk of reusable code. When multiple screenlets inhabit the same template file, you either have to reuse all of the code or none if it. By splitting these up, the parts are more likely to be reused than the whole. > Because the order application is the base for so many custom applications in addition to ecomerce and wholesale and salesrep, making it reusable will lower the maintenance those applications require. Please vote on this and I will submit patches. Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-68) Break up application templates with multiple screenlets
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-68?page=all ]
Chris Howe updated OFBIZ-68: ---------------------------- Attachment: OrderOrderHeader.patch OrderOrderHeader.patch splits up order/webapp/ordermgr/order/orderheader.ftl and all screen definitions that call it I like this approach better concerning the orderitems and may want to go back and do it for the orderrequest and orderquote for both ecommerce and order > Break up application templates with multiple screenlets > ------------------------------------------------------- > > Key: OFBIZ-68 > URL: http://issues.apache.org/jira/browse/OFBIZ-68 > Project: The Open For Business Project > Type: Improvement > Components: order > Reporter: Chris Howe > Assignee: Jacopo Cappellato > Attachments: OrderOrderHeader.patch, ViewQuote.patch, ViewRequest.patch, cssChange.patch > > There are currently 7 freemarker files in the order applications that have multiple screenlets in the same template file. They are: > entry/cart/showcart.ftl > entry/cart/showPromotionDetails.ftl > entry/order/orderheader.ftl > entry/poheader.ftl (may not be used) > order/orderheader.ftl > quote/ViewQuoteInfo.ftl > request/ViewRequestInfo.ftl > I would like these to be split up. Screenlets, when defined make up a good chunk of reusable code. When multiple screenlets inhabit the same template file, you either have to reuse all of the code or none if it. By splitting these up, the parts are more likely to be reused than the whole. > Because the order application is the base for so many custom applications in addition to ecomerce and wholesale and salesrep, making it reusable will lower the maintenance those applications require. Please vote on this and I will submit patches. Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-68) Break up application templates with multiple screenlets
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-68?page=all ]
Chris Howe updated OFBIZ-68: ---------------------------- Attachment: OrderEntryOrderHeader.patch OrderEntryOrderHeader.patch splits up order/webapp/ordermgr/entry/order/orderheader.ftl and all screen definitions that call it > Break up application templates with multiple screenlets > ------------------------------------------------------- > > Key: OFBIZ-68 > URL: http://issues.apache.org/jira/browse/OFBIZ-68 > Project: The Open For Business Project > Type: Improvement > Components: order > Reporter: Chris Howe > Assignee: Jacopo Cappellato > Attachments: OrderEntryOrderHeader.patch, OrderOrderHeader.patch, ViewQuote.patch, ViewRequest.patch, cssChange.patch > > There are currently 7 freemarker files in the order applications that have multiple screenlets in the same template file. They are: > entry/cart/showcart.ftl > entry/cart/showPromotionDetails.ftl > entry/order/orderheader.ftl > entry/poheader.ftl (may not be used) > order/orderheader.ftl > quote/ViewQuoteInfo.ftl > request/ViewRequestInfo.ftl > I would like these to be split up. Screenlets, when defined make up a good chunk of reusable code. When multiple screenlets inhabit the same template file, you either have to reuse all of the code or none if it. By splitting these up, the parts are more likely to be reused than the whole. > Because the order application is the base for so many custom applications in addition to ecomerce and wholesale and salesrep, making it reusable will lower the maintenance those applications require. Please vote on this and I will submit patches. Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-68) Break up application templates with multiple screenlets
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-68?page=all ]
Chris Howe updated OFBIZ-68: ---------------------------- Attachment: showPromotionDetails.patch showPromotionDetails.patch splits up order/webapp/ordermgr/entry/cart/showPromotionDetails.ftl and all screen definitions that call it I'm not going to split up /entry/cart/showcart.ftl because it contains javascript functions at the begining that are not used in showcart.ftl. The functions are used in subsequent template files that are called after showcart.ftl. A consensus needs to be reached on how to best handle this as it is already kind of a mess. > Break up application templates with multiple screenlets > ------------------------------------------------------- > > Key: OFBIZ-68 > URL: http://issues.apache.org/jira/browse/OFBIZ-68 > Project: The Open For Business Project > Type: Improvement > Components: order > Reporter: Chris Howe > Assignee: Jacopo Cappellato > Attachments: OrderEntryOrderHeader.patch, OrderOrderHeader.patch, ViewQuote.patch, ViewRequest.patch, cssChange.patch, showPromotionDetails.patch > > There are currently 7 freemarker files in the order applications that have multiple screenlets in the same template file. They are: > entry/cart/showcart.ftl > entry/cart/showPromotionDetails.ftl > entry/order/orderheader.ftl > entry/poheader.ftl (may not be used) > order/orderheader.ftl > quote/ViewQuoteInfo.ftl > request/ViewRequestInfo.ftl > I would like these to be split up. Screenlets, when defined make up a good chunk of reusable code. When multiple screenlets inhabit the same template file, you either have to reuse all of the code or none if it. By splitting these up, the parts are more likely to be reused than the whole. > Because the order application is the base for so many custom applications in addition to ecomerce and wholesale and salesrep, making it reusable will lower the maintenance those applications require. Please vote on this and I will submit patches. Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-68) Break up application templates with multiple screenlets
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-68?page=comments#action_12418879 ]
David E. Jones commented on OFBIZ-68: ------------------------------------- Could I recommend closing this issue after the current patches are committed and moving to an easier model of one issue for each screen, or set of screens, that is split up? Ie, more or less one issue per patch so the status and commentary is easier to manage and understand. > Break up application templates with multiple screenlets > ------------------------------------------------------- > > Key: OFBIZ-68 > URL: http://issues.apache.org/jira/browse/OFBIZ-68 > Project: The Open For Business Project > Type: Improvement > Components: order > Reporter: Chris Howe > Assignee: Jacopo Cappellato > Attachments: OrderEntryOrderHeader.patch, OrderOrderHeader.patch, ViewQuote.patch, ViewRequest.patch, cssChange.patch, showPromotionDetails.patch > > There are currently 7 freemarker files in the order applications that have multiple screenlets in the same template file. They are: > entry/cart/showcart.ftl > entry/cart/showPromotionDetails.ftl > entry/order/orderheader.ftl > entry/poheader.ftl (may not be used) > order/orderheader.ftl > quote/ViewQuoteInfo.ftl > request/ViewRequestInfo.ftl > I would like these to be split up. Screenlets, when defined make up a good chunk of reusable code. When multiple screenlets inhabit the same template file, you either have to reuse all of the code or none if it. By splitting these up, the parts are more likely to be reused than the whole. > Because the order application is the base for so many custom applications in addition to ecomerce and wholesale and salesrep, making it reusable will lower the maintenance those applications require. Please vote on this and I will submit patches. Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-68) Break up application templates with multiple screenlets
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-68?page=comments#action_12418880 ]
Chris Howe commented on OFBIZ-68: --------------------------------- That should actually be the last patch for this issue anyway (provided it tests okay, which it should). In the future should I take advantage of the subtask feature? > Break up application templates with multiple screenlets > ------------------------------------------------------- > > Key: OFBIZ-68 > URL: http://issues.apache.org/jira/browse/OFBIZ-68 > Project: The Open For Business Project > Type: Improvement > Components: order > Reporter: Chris Howe > Assignee: Jacopo Cappellato > Attachments: OrderEntryOrderHeader.patch, OrderOrderHeader.patch, ViewQuote.patch, ViewRequest.patch, cssChange.patch, showPromotionDetails.patch > > There are currently 7 freemarker files in the order applications that have multiple screenlets in the same template file. They are: > entry/cart/showcart.ftl > entry/cart/showPromotionDetails.ftl > entry/order/orderheader.ftl > entry/poheader.ftl (may not be used) > order/orderheader.ftl > quote/ViewQuoteInfo.ftl > request/ViewRequestInfo.ftl > I would like these to be split up. Screenlets, when defined make up a good chunk of reusable code. When multiple screenlets inhabit the same template file, you either have to reuse all of the code or none if it. By splitting these up, the parts are more likely to be reused than the whole. > Because the order application is the base for so many custom applications in addition to ecomerce and wholesale and salesrep, making it reusable will lower the maintenance those applications require. Please vote on this and I will submit patches. Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-68) Break up application templates with multiple screenlets
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-68?page=comments#action_12438960 ]
Scott Gray commented on OFBIZ-68: --------------------------------- I think this issue can be closed? > Break up application templates with multiple screenlets > ------------------------------------------------------- > > Key: OFBIZ-68 > URL: http://issues.apache.org/jira/browse/OFBIZ-68 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Chris Howe > Assigned To: Jacopo Cappellato > Attachments: cssChange.patch, OrderEntryOrderHeader.patch, OrderOrderHeader.patch, showPromotionDetails.patch, ViewQuote.patch, ViewRequest.patch > > > There are currently 7 freemarker files in the order applications that have multiple screenlets in the same template file. They are: > entry/cart/showcart.ftl > entry/cart/showPromotionDetails.ftl > entry/order/orderheader.ftl > entry/poheader.ftl (may not be used) > order/orderheader.ftl > quote/ViewQuoteInfo.ftl > request/ViewRequestInfo.ftl > I would like these to be split up. Screenlets, when defined make up a good chunk of reusable code. When multiple screenlets inhabit the same template file, you either have to reuse all of the code or none if it. By splitting these up, the parts are more likely to be reused than the whole. > Because the order application is the base for so many custom applications in addition to ecomerce and wholesale and salesrep, making it reusable will lower the maintenance those applications require. Please vote on this and I will submit patches. Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Closed: (OFBIZ-68) Break up application templates with multiple screenlets
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-68?page=all ]
Jacopo Cappellato closed OFBIZ-68. ---------------------------------- Resolution: Fixed Chris, your last patches were no more applicable because some of the artifacts have been modified so I've manually applied them with some differences (because there were a few issues, such as some bad references to missing resources, probably custom templates); if you can, have a look at them to see if everything work as expected. Really thank for your work, Jacopo > Break up application templates with multiple screenlets > ------------------------------------------------------- > > Key: OFBIZ-68 > URL: http://issues.apache.org/jira/browse/OFBIZ-68 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Chris Howe > Assigned To: Jacopo Cappellato > Attachments: cssChange.patch, OrderEntryOrderHeader.patch, OrderOrderHeader.patch, showPromotionDetails.patch, ViewQuote.patch, ViewRequest.patch > > > There are currently 7 freemarker files in the order applications that have multiple screenlets in the same template file. They are: > entry/cart/showcart.ftl > entry/cart/showPromotionDetails.ftl > entry/order/orderheader.ftl > entry/poheader.ftl (may not be used) > order/orderheader.ftl > quote/ViewQuoteInfo.ftl > request/ViewRequestInfo.ftl > I would like these to be split up. Screenlets, when defined make up a good chunk of reusable code. When multiple screenlets inhabit the same template file, you either have to reuse all of the code or none if it. By splitting these up, the parts are more likely to be reused than the whole. > Because the order application is the base for so many custom applications in addition to ecomerce and wholesale and salesrep, making it reusable will lower the maintenance those applications require. Please vote on this and I will submit patches. Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |