[jira] Created: (OFBIZ-689) Highlight Selected Feature
Locked
[jira] Created: (OFBIZ-689) Highlight Selected Feature
 
|
Highlight Selected Feature
-------------------------- Key: OFBIZ-689 URL: https://issues.apache.org/jira/browse/OFBIZ-689 Project: OFBiz (The Open for Business Project) Issue Type: New Feature Components: product Reporter: Anil K Patel Attachments: HighlightSelectedRow.patch When we pick a category and we get a list of specific feature, since usually it is a long list and you might be clicking a box that is not on the same level than the feature you wanted to pick, to avoid mistakes, can you highlight the whole line once the box is checked to make sure that the box checked was the one of the option we wanted -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-689) Highlight Selected Feature
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anil K Patel updated OFBIZ-689: ------------------------------- Attachment: HighlightSelectedRow.patch > Highlight Selected Feature > -------------------------- > > Key: OFBIZ-689 > URL: https://issues.apache.org/jira/browse/OFBIZ-689 > Project: OFBiz (The Open for Business Project) > Issue Type: New Feature > Components: product > Reporter: Anil K Patel > Attachments: HighlightSelectedRow.patch > > > When we pick a category and we get a list of specific feature, since usually it is a long list and you might be clicking a box that is not on the same level than the feature you wanted to pick, to avoid mistakes, can you highlight the whole line once the box is checked to make sure that the box checked was the one of the option we wanted -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-689) Highlight Selected Feature
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470451 ] Scott Gray commented on OFBIZ-689: ---------------------------------- Hi Anil The patch doesn't take into account the effect of using the select all checkbox: 1. Check a couple of rows 2. Check and uncheck the select all box You will see the rows from step 1 remain highlighted but not checked But otherwise it looks fine, I can't commit this anyway as I don't have framework permissions > Highlight Selected Feature > -------------------------- > > Key: OFBIZ-689 > URL: https://issues.apache.org/jira/browse/OFBIZ-689 > Project: OFBiz (The Open for Business Project) > Issue Type: New Feature > Components: product > Reporter: Anil K Patel > Attachments: HighlightSelectedRow.patch > > > When we pick a category and we get a list of specific feature, since usually it is a long list and you might be clicking a box that is not on the same level than the feature you wanted to pick, to avoid mistakes, can you highlight the whole line once the box is checked to make sure that the box checked was the one of the option we wanted -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-689) Highlight Selected Feature
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527701 ] Jacopo Cappellato commented on OFBIZ-689: ----------------------------------------- Scott, now you have full access to the SVN repository :-) > Highlight Selected Feature > -------------------------- > > Key: OFBIZ-689 > URL: https://issues.apache.org/jira/browse/OFBIZ-689 > Project: OFBiz > Issue Type: New Feature > Components: product > Reporter: Anil K Patel > Attachments: HighlightSelectedRow.patch > > > When we pick a category and we get a list of specific feature, since usually it is a long list and you might be clicking a box that is not on the same level than the feature you wanted to pick, to avoid mistakes, can you highlight the whole line once the box is checked to make sure that the box checked was the one of the option we wanted -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-689) Highlight Selected Feature
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Gray reassigned OFBIZ-689: -------------------------------- Assignee: Scott Gray Thanks for the reminder Jacopo :-) I don't remember much about this issue but I'll certainly take a look when I get a chance. In the meantime if anyone wants to give it another review that would be great. > Highlight Selected Feature > -------------------------- > > Key: OFBIZ-689 > URL: https://issues.apache.org/jira/browse/OFBIZ-689 > Project: OFBiz > Issue Type: New Feature > Components: product > Reporter: Anil K Patel > Assignee: Scott Gray > Attachments: HighlightSelectedRow.patch > > > When we pick a category and we get a list of specific feature, since usually it is a long list and you might be clicking a box that is not on the same level than the feature you wanted to pick, to avoid mistakes, can you highlight the whole line once the box is checked to make sure that the box checked was the one of the option we wanted -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-689) Highlight Selected Feature
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528923 ] Bilgin Ibryam commented on OFBIZ-689: ------------------------------------- Hi guys, I just took a look at this patch and did some changes and comments: 1. Added another function that highlight all the fields when clicked on select all check box. 2. Removed viewOneTR2 class from highlightRow function. This class is not used in ofbiz at all and it makes some bugs (in some cases some of the rows are styled viewOneTR2 and some viewOneTR1, they are close but different color styles). In ofbiz there are also some other tables that can benefit from this checkbox highlight feature. Why not add these javascript functions to selectall.js insetead of concrete ftl files? An alternative way to go could be applying "hover-bar" style to the form table. I mean something like this: Index: applications/product/webapp/catalog/feature/EditFeatureCategoryFeatures.ftl =================================================================== --- applications/product/webapp/catalog/feature/EditFeatureCategoryFeatures.ftl (revision 577453) +++ applications/product/webapp/catalog/feature/EditFeatureCategoryFeatures.ftl (working copy) @@ -53,7 +53,7 @@ </tr> </table> </#if> -<table border="1" cellpadding='2' cellspacing='0'> +<table border="1" cellpadding='2' cellspacing='0' class="hover-bar"> <form method='POST' action='<@ofbizUrl>UpdateProductFeatureInCategory</@ofbizUrl>' name="selectAllForm"> <input type="hidden" name="_useRowSubmit" value="Y"> <input type="hidden" name="_checkGlobalScope" value="N"> Bilgin Ibryam > Highlight Selected Feature > -------------------------- > > Key: OFBIZ-689 > URL: https://issues.apache.org/jira/browse/OFBIZ-689 > Project: OFBiz > Issue Type: New Feature > Components: product > Reporter: Anil K Patel > Assignee: Scott Gray > Attachments: HighlightSelectedRow.patch > > > When we pick a category and we get a list of specific feature, since usually it is a long list and you might be clicking a box that is not on the same level than the feature you wanted to pick, to avoid mistakes, can you highlight the whole line once the box is checked to make sure that the box checked was the one of the option we wanted -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-689) Highlight Selected Feature
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-689: -------------------------------- Attachment: HighlightSelectedRow-bibryam.patch > Highlight Selected Feature > -------------------------- > > Key: OFBIZ-689 > URL: https://issues.apache.org/jira/browse/OFBIZ-689 > Project: OFBiz > Issue Type: New Feature > Components: product > Reporter: Anil K Patel > Assignee: Scott Gray > Attachments: HighlightSelectedRow-bibryam.patch, HighlightSelectedRow.patch > > > When we pick a category and we get a list of specific feature, since usually it is a long list and you might be clicking a box that is not on the same level than the feature you wanted to pick, to avoid mistakes, can you highlight the whole line once the box is checked to make sure that the box checked was the one of the option we wanted -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-689) Highlight Selected Feature
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562359#action_12562359 ] Jacques Le Roux commented on OFBIZ-689: --------------------------------------- No takers ? > Highlight Selected Feature > -------------------------- > > Key: OFBIZ-689 > URL: https://issues.apache.org/jira/browse/OFBIZ-689 > Project: OFBiz > Issue Type: New Feature > Components: product > Reporter: Anil K Patel > Assignee: Scott Gray > Attachments: HighlightSelectedRow-bibryam.patch, HighlightSelectedRow.patch > > > When we pick a category and we get a list of specific feature, since usually it is a long list and you might be clicking a box that is not on the same level than the feature you wanted to pick, to avoid mistakes, can you highlight the whole line once the box is checked to make sure that the box checked was the one of the option we wanted -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-689) Highlight Selected Feature
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Gray reassigned OFBIZ-689: -------------------------------- Assignee: (was: Scott Gray) Sorry I haven't got time right now, if someone wants to take it, by all means please do > Highlight Selected Feature > -------------------------- > > Key: OFBIZ-689 > URL: https://issues.apache.org/jira/browse/OFBIZ-689 > Project: OFBiz > Issue Type: New Feature > Components: product > Reporter: Anil K Patel > Attachments: HighlightSelectedRow-bibryam.patch, HighlightSelectedRow.patch > > > When we pick a category and we get a list of specific feature, since usually it is a long list and you might be clicking a box that is not on the same level than the feature you wanted to pick, to avoid mistakes, can you highlight the whole line once the box is checked to make sure that the box checked was the one of the option we wanted -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-689) Highlight Selected Feature
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-689: -------------------------------- Attachment: HighlightSelectedRow-bibryam.patch > Highlight Selected Feature > -------------------------- > > Key: OFBIZ-689 > URL: https://issues.apache.org/jira/browse/OFBIZ-689 > Project: OFBiz > Issue Type: New Feature > Components: product > Reporter: Anil K Patel > Attachments: HighlightSelectedRow-bibryam.patch, HighlightSelectedRow-bibryam.patch, HighlightSelectedRow.patch > > > When we pick a category and we get a list of specific feature, since usually it is a long list and you might be clicking a box that is not on the same level than the feature you wanted to pick, to avoid mistakes, can you highlight the whole line once the box is checked to make sure that the box checked was the one of the option we wanted -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-689) Highlight Selected Feature
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563748#action_12563748 ] Bilgin Ibryam commented on OFBIZ-689: ------------------------------------- Hi, i updated the patch according to the new style changes in ofbiz. Someone with framework commit access can commit it. Bilgin > Highlight Selected Feature > -------------------------- > > Key: OFBIZ-689 > URL: https://issues.apache.org/jira/browse/OFBIZ-689 > Project: OFBiz > Issue Type: New Feature > Components: product > Reporter: Anil K Patel > Attachments: HighlightSelectedRow-bibryam.patch, HighlightSelectedRow-bibryam.patch, HighlightSelectedRow.patch > > > When we pick a category and we get a list of specific feature, since usually it is a long list and you might be clicking a box that is not on the same level than the feature you wanted to pick, to avoid mistakes, can you highlight the whole line once the box is checked to make sure that the box checked was the one of the option we wanted -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-689) Highlight Selected Feature
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563753#action_12563753 ] Adrian Crum commented on OFBIZ-689: ----------------------------------- Bilgin, This looks pretty good, but it would be better to follow the current CSS patterns. Call the new style "selected" - so that it is consistent with other styles - and also make it a descendent of basic-table (.basic-table .selected {...). > Highlight Selected Feature > -------------------------- > > Key: OFBIZ-689 > URL: https://issues.apache.org/jira/browse/OFBIZ-689 > Project: OFBiz > Issue Type: New Feature > Components: product > Reporter: Anil K Patel > Attachments: HighlightSelectedRow-bibryam.patch, HighlightSelectedRow-bibryam.patch, HighlightSelectedRow.patch > > > When we pick a category and we get a list of specific feature, since usually it is a long list and you might be clicking a box that is not on the same level than the feature you wanted to pick, to avoid mistakes, can you highlight the whole line once the box is checked to make sure that the box checked was the one of the option we wanted -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-689) Highlight Selected Feature
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-689: ------------------------------------- Assignee: Jacques Le Roux > Highlight Selected Feature > -------------------------- > > Key: OFBIZ-689 > URL: https://issues.apache.org/jira/browse/OFBIZ-689 > Project: OFBiz > Issue Type: New Feature > Components: product > Reporter: Anil K Patel > Assignee: Jacques Le Roux > Attachments: HighlightSelectedRow-bibryam.patch, HighlightSelectedRow-bibryam.patch, HighlightSelectedRow.patch > > > When we pick a category and we get a list of specific feature, since usually it is a long list and you might be clicking a box that is not on the same level than the feature you wanted to pick, to avoid mistakes, can you highlight the whole line once the box is checked to make sure that the box checked was the one of the option we wanted -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-689) Highlight Selected Feature
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563881#action_12563881 ] Jacques Le Roux commented on OFBIZ-689: --------------------------------------- Bilgin, Ready to commit as soon as Adrian's advices are applied. Thanks > Highlight Selected Feature > -------------------------- > > Key: OFBIZ-689 > URL: https://issues.apache.org/jira/browse/OFBIZ-689 > Project: OFBiz > Issue Type: New Feature > Components: product > Reporter: Anil K Patel > Assignee: Jacques Le Roux > Attachments: HighlightSelectedRow-bibryam.patch, HighlightSelectedRow-bibryam.patch, HighlightSelectedRow.patch > > > When we pick a category and we get a list of specific feature, since usually it is a long list and you might be clicking a box that is not on the same level than the feature you wanted to pick, to avoid mistakes, can you highlight the whole line once the box is checked to make sure that the box checked was the one of the option we wanted -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-689) Highlight Selected Feature
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-689: -------------------------------- Attachment: HighlightSelectedRow-bibryam.patch Thanks for the tips Adrian. Updated the patch (but you can taka a look again ;) PS: These days i will update the other ftls with checkbox to use this style. > Highlight Selected Feature > -------------------------- > > Key: OFBIZ-689 > URL: https://issues.apache.org/jira/browse/OFBIZ-689 > Project: OFBiz > Issue Type: New Feature > Components: product > Reporter: Anil K Patel > Assignee: Jacques Le Roux > Attachments: HighlightSelectedRow-bibryam.patch, HighlightSelectedRow-bibryam.patch, HighlightSelectedRow-bibryam.patch, HighlightSelectedRow.patch > > > When we pick a category and we get a list of specific feature, since usually it is a long list and you might be clicking a box that is not on the same level than the feature you wanted to pick, to avoid mistakes, can you highlight the whole line once the box is checked to make sure that the box checked was the one of the option we wanted -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-689) Highlight Selected Feature
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563903#action_12563903 ] Adrian Crum commented on OFBIZ-689: ----------------------------------- Styles look good. > Highlight Selected Feature > -------------------------- > > Key: OFBIZ-689 > URL: https://issues.apache.org/jira/browse/OFBIZ-689 > Project: OFBiz > Issue Type: New Feature > Components: product > Reporter: Anil K Patel > Assignee: Jacques Le Roux > Attachments: HighlightSelectedRow-bibryam.patch, HighlightSelectedRow-bibryam.patch, HighlightSelectedRow-bibryam.patch, HighlightSelectedRow.patch > > > When we pick a category and we get a list of specific feature, since usually it is a long list and you might be clicking a box that is not on the same level than the feature you wanted to pick, to avoid mistakes, can you highlight the whole line once the box is checked to make sure that the box checked was the one of the option we wanted -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-689) Highlight Selected Feature
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-689. --------------------------------- Resolution: Fixed Fix Version/s: SVN trunk Thanks Bilgin, Your patch is in trunk revision: 616697 > Highlight Selected Feature > -------------------------- > > Key: OFBIZ-689 > URL: https://issues.apache.org/jira/browse/OFBIZ-689 > Project: OFBiz > Issue Type: New Feature > Components: product > Reporter: Anil K Patel > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: HighlightSelectedRow-bibryam.patch, HighlightSelectedRow-bibryam.patch, HighlightSelectedRow-bibryam.patch, HighlightSelectedRow.patch > > > When we pick a category and we get a list of specific feature, since usually it is a long list and you might be clicking a box that is not on the same level than the feature you wanted to pick, to avoid mistakes, can you highlight the whole line once the box is checked to make sure that the box checked was the one of the option we wanted -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |