[jira] Created: (OFBIZ-710) EditInventoryItem.bsh has HtmlFormWrapper rendering code. This be replaced with screens.render in ftl.

[Nicolas Malin (Jira)]

EditInventoryItem.bsh has HtmlFormWrapper rendering code. This be replaced with screens.render in ftl.
------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-710
                 URL: https://issues.apache.org/jira/browse/OFBIZ-710
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: product
            Reporter: Anil K Patel


EditInventory.bsh file uses HtmlFormWrapper for rendering  /inventory/InventoryForms.xml#CreatePhysicalInventoryAndVariance, ViewPhysicalInventoryAndVariance forms. Path to the forms file is relative to facility webapp. This causes limitation in using the EditInventory screen from other components.

The code for rendering should be moved to EditInventory.ftl file and should use screens.render.
 

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel updated OFBIZ-710:
-------------------------------

    Attachment: EditInventoryItemRefactored.patch

Implements better coding practice.

> EditInventoryItem.bsh has HtmlFormWrapper rendering code. This be replaced with screens.render in ftl.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-710
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-710
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>            Reporter: Anil K Patel
>         Attachments: EditInventoryItemRefactored.patch
>
>
> EditInventory.bsh file uses HtmlFormWrapper for rendering  /inventory/InventoryForms.xml#CreatePhysicalInventoryAndVariance, ViewPhysicalInventoryAndVariance forms. Path to the forms file is relative to facility webapp. This causes limitation in using the EditInventory screen from other components.
> The code for rendering should be moved to EditInventory.ftl file and should use screens.render.
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471947 ]

Chris Howe commented on OFBIZ-710:
----------------------------------

Hey Anil,

This is related to OFBIZ-278.  This reminded me of it and I think I've found a solution for OFBIZ-278 that would take care of this as well. I'm going to test my guess and report back later today.  

Looking over your patch, why do the screen.render at all?  Why not put
<screen name="EditInventoryItem">
<snip>
<html-template location="component://product/webapp/facility/inventory/EditInventoryItem.ftl"/>
<snip>
<include-screen name="nonSerialFormScreens"/>
<snip>
</screen>


<screen name="nonSerialFormScreens">
<section>
<conditional>
<if-compare field="inventoryItem.inventoryItemTypeId" value="NON_SERIAL_INV_ITEM"/>
</conditional>
<widgets>
<include-form name="ViewPhysicalInventoryAndVariance" location="component://product/webapp/facility/inventory/InventoryForms.xml"/>
<include-form name="CreatePhysicalInventoryAndVariance" location="component://product/webapp/facility/inventory/InventoryForms.xml"/>
</widgets>
</section>
</screen>

and remove the final conditional test from the end of EditInventoryItem.ftl

> EditInventoryItem.bsh has HtmlFormWrapper rendering code. This be replaced with screens.render in ftl.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-710
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-710
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>            Reporter: Anil K Patel
>         Attachments: EditInventoryItemRefactored.patch, EditInventoryItemRefactored.patch
>
>
> EditInventory.bsh file uses HtmlFormWrapper for rendering  /inventory/InventoryForms.xml#CreatePhysicalInventoryAndVariance, ViewPhysicalInventoryAndVariance forms. Path to the forms file is relative to facility webapp. This causes limitation in using the EditInventory screen from other components.
> The code for rendering should be moved to EditInventory.ftl file and should use screens.render.
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel updated OFBIZ-710:
-------------------------------

    Attachment: EditInventoryItemRefactored.patch

One more improvement. Moved the screen rendering in ftl file to include form tag in screen defination.

> EditInventoryItem.bsh has HtmlFormWrapper rendering code. This be replaced with screens.render in ftl.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-710
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-710
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>            Reporter: Anil K Patel
>         Attachments: EditInventoryItemRefactored.patch, EditInventoryItemRefactored.patch
>
>
> EditInventory.bsh file uses HtmlFormWrapper for rendering  /inventory/InventoryForms.xml#CreatePhysicalInventoryAndVariance, ViewPhysicalInventoryAndVariance forms. Path to the forms file is relative to facility webapp. This causes limitation in using the EditInventory screen from other components.
> The code for rendering should be moved to EditInventory.ftl file and should use screens.render.
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471948 ]

Chris Howe commented on OFBIZ-710:
----------------------------------

you're sly, posting that up while i'm typing up a comment :-)

> EditInventoryItem.bsh has HtmlFormWrapper rendering code. This be replaced with screens.render in ftl.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-710
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-710
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>            Reporter: Anil K Patel
>         Attachments: EditInventoryItemRefactored.patch, EditInventoryItemRefactored.patch
>
>
> EditInventory.bsh file uses HtmlFormWrapper for rendering  /inventory/InventoryForms.xml#CreatePhysicalInventoryAndVariance, ViewPhysicalInventoryAndVariance forms. Path to the forms file is relative to facility webapp. This causes limitation in using the EditInventory screen from other components.
> The code for rendering should be moved to EditInventory.ftl file and should use screens.render.
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471950 ]

Anil K Patel commented on OFBIZ-710:
------------------------------------

Looks like a good Idea, I will modify code and post the patch.

> EditInventoryItem.bsh has HtmlFormWrapper rendering code. This be replaced with screens.render in ftl.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-710
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-710
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>            Reporter: Anil K Patel
>         Attachments: EditInventoryItemRefactored.patch, EditInventoryItemRefactored.patch
>
>
> EditInventory.bsh file uses HtmlFormWrapper for rendering  /inventory/InventoryForms.xml#CreatePhysicalInventoryAndVariance, ViewPhysicalInventoryAndVariance forms. Path to the forms file is relative to facility webapp. This causes limitation in using the EditInventory screen from other components.
> The code for rendering should be moved to EditInventory.ftl file and should use screens.render.
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel updated OFBIZ-710:
-------------------------------

    Attachment: EditInventoryItemRefactored.patch

Code updated based on Chris comments.

> EditInventoryItem.bsh has HtmlFormWrapper rendering code. This be replaced with screens.render in ftl.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-710
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-710
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>            Reporter: Anil K Patel
>         Attachments: EditInventoryItemRefactored.patch, EditInventoryItemRefactored.patch, EditInventoryItemRefactored.patch
>
>
> EditInventory.bsh file uses HtmlFormWrapper for rendering  /inventory/InventoryForms.xml#CreatePhysicalInventoryAndVariance, ViewPhysicalInventoryAndVariance forms. Path to the forms file is relative to facility webapp. This causes limitation in using the EditInventory screen from other components.
> The code for rendering should be moved to EditInventory.ftl file and should use screens.render.
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-710:
---------------------------------------

    Assignee: Jacopo Cappellato

> EditInventoryItem.bsh has HtmlFormWrapper rendering code. This be replaced with screens.render in ftl.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-710
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-710
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>            Reporter: Anil K Patel
>         Assigned To: Jacopo Cappellato
>         Attachments: EditInventoryItemRefactored.patch, EditInventoryItemRefactored.patch, EditInventoryItemRefactored.patch
>
>
> EditInventory.bsh file uses HtmlFormWrapper for rendering  /inventory/InventoryForms.xml#CreatePhysicalInventoryAndVariance, ViewPhysicalInventoryAndVariance forms. Path to the forms file is relative to facility webapp. This causes limitation in using the EditInventory screen from other components.
> The code for rendering should be moved to EditInventory.ftl file and should use screens.render.
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-710.
-----------------------------------

    Resolution: Fixed

Anil, Chris,

in rev. 505649 I've committed a slightly modified patch based on the #2 one submitted by Anil.
Please let me know if you see something wrong.
Thanks to both of you,

Jacopo

> EditInventoryItem.bsh has HtmlFormWrapper rendering code. This be replaced with screens.render in ftl.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-710
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-710
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>            Reporter: Anil K Patel
>         Assigned To: Jacopo Cappellato
>         Attachments: EditInventoryItemRefactored.patch, EditInventoryItemRefactored.patch, EditInventoryItemRefactored.patch
>
>
> EditInventory.bsh file uses HtmlFormWrapper for rendering  /inventory/InventoryForms.xml#CreatePhysicalInventoryAndVariance, ViewPhysicalInventoryAndVariance forms. Path to the forms file is relative to facility webapp. This causes limitation in using the EditInventory screen from other components.
> The code for rendering should be moved to EditInventory.ftl file and should use screens.render.
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471990 ]

Chris Howe commented on OFBIZ-710:
----------------------------------

In 505649, you appear to have skipped over the removal of t the last if conditional check in EditInventoryItem.ftl

> EditInventoryItem.bsh has HtmlFormWrapper rendering code. This be replaced with screens.render in ftl.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-710
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-710
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>            Reporter: Anil K Patel
>         Assigned To: Jacopo Cappellato
>         Attachments: EditInventoryItemRefactored.patch, EditInventoryItemRefactored.patch, EditInventoryItemRefactored.patch
>
>
> EditInventory.bsh file uses HtmlFormWrapper for rendering  /inventory/InventoryForms.xml#CreatePhysicalInventoryAndVariance, ViewPhysicalInventoryAndVariance forms. Path to the forms file is relative to facility webapp. This causes limitation in using the EditInventory screen from other components.
> The code for rendering should be moved to EditInventory.ftl file and should use screens.render.
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471994 ]

Jacopo Cappellato commented on OFBIZ-710:
-----------------------------------------

Thanks Chris,

I had messed up the svn plugin of Netbeans...
I've committed it in rev. 505715

> EditInventoryItem.bsh has HtmlFormWrapper rendering code. This be replaced with screens.render in ftl.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-710
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-710
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>            Reporter: Anil K Patel
>         Assigned To: Jacopo Cappellato
>         Attachments: EditInventoryItemRefactored.patch, EditInventoryItemRefactored.patch, EditInventoryItemRefactored.patch
>
>
> EditInventory.bsh file uses HtmlFormWrapper for rendering  /inventory/InventoryForms.xml#CreatePhysicalInventoryAndVariance, ViewPhysicalInventoryAndVariance forms. Path to the forms file is relative to facility webapp. This causes limitation in using the EditInventory screen from other components.
> The code for rendering should be moved to EditInventory.ftl file and should use screens.render.
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.