[jira] Created: (OFBIZ-762) Move form stylings and pagination attributes to child elements

[Nicolas Malin (Jira)]

Move form stylings and pagination attributes to child elements
--------------------------------------------------------------

                 Key: OFBIZ-762
                 URL: https://issues.apache.org/jira/browse/OFBIZ-762
             Project: OFBiz (The Open for Business Project)
          Issue Type: Wish
            Reporter: Chris Howe


Pending the outcome of the discussion
http://www.nabble.com/forum/ViewPost.jtp?post=9129284&framed=y

This will hold the patches necessary to accomplish.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Howe updated OFBIZ-762:
-----------------------------

    Attachment: FormWidget.patch

FormWidget.patch

This should be all the code that is required to support <styling> and <paginate> child elements in the form widget.

This could have been done using if else statements when the variables are first defined in the form element, but if the attributes will be deprecated entirely from the form widget in the future, this will make it easier

> Move form stylings and pagination attributes to child elements
> --------------------------------------------------------------
>
>                 Key: OFBIZ-762
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-762
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Wish
>            Reporter: Chris Howe
>         Attachments: FormWidget.patch
>
>
> Pending the outcome of the discussion
> http://www.nabble.com/forum/ViewPost.jtp?post=9129284&framed=y
> This will hold the patches necessary to accomplish.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475696 ]

Chris Howe commented on OFBIZ-762:
----------------------------------

One more thing,

May wish to add a statement to the log if one of the attributes is used in the form element regarding possible deprecation, etc.

> Move form stylings and pagination attributes to child elements
> --------------------------------------------------------------
>
>                 Key: OFBIZ-762
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-762
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Wish
>            Reporter: Chris Howe
>         Attachments: FormWidget.patch
>
>
> Pending the outcome of the discussion
> http://www.nabble.com/forum/ViewPost.jtp?post=9129284&framed=y
> This will hold the patches necessary to accomplish.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475727 ]

Adrian Crum commented on OFBIZ-762:
-----------------------------------

Chris,

I don't think the attributes will or should be deprecated. If the form container is properly styled, then they simply aren't needed - but they should still remain available if someone needs them.

> Move form stylings and pagination attributes to child elements
> --------------------------------------------------------------
>
>                 Key: OFBIZ-762
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-762
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Wish
>            Reporter: Chris Howe
>         Attachments: FormWidget.patch
>
>
> Pending the outcome of the discussion
> http://www.nabble.com/forum/ViewPost.jtp?post=9129284&framed=y
> This will hold the patches necessary to accomplish.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475731 ]

Jacques Le Roux commented on OFBIZ-762:
---------------------------------------

Adrian,

I Agree and this is what Jacopo seemed to think too (he used the sentence "unless you need a non specific style for the single form").  But then Chris's concern (too much form attributes for code completion easy use) remains. Hence sub-elements...

> Move form stylings and pagination attributes to child elements
> --------------------------------------------------------------
>
>                 Key: OFBIZ-762
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-762
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Wish
>            Reporter: Chris Howe
>         Attachments: FormWidget.patch
>
>
> Pending the outcome of the discussion
> http://www.nabble.com/forum/ViewPost.jtp?post=9129284&framed=y
> This will hold the patches necessary to accomplish.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475734 ]

Chris Howe commented on OFBIZ-762:
----------------------------------

To clarify, the deprecation I'm talking about is deprecation from the form element

<form name="myForm" default-title-style="myStyle">
...
</form>

because it's moved to the child element <styling>

<form name="myForm>
  <styling default-title-style="myStyle"/>
...
</form>

The included patch deprecates from the xsd, but the java still supports both.  Because it is redundant, at some time the java code should stop looking for those attributes in the form element and only be looking for them in the styling element.

> Move form stylings and pagination attributes to child elements
> --------------------------------------------------------------
>
>                 Key: OFBIZ-762
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-762
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Wish
>            Reporter: Chris Howe
>         Attachments: FormWidget.patch
>
>
> Pending the outcome of the discussion
> http://www.nabble.com/forum/ViewPost.jtp?post=9129284&framed=y
> This will hold the patches necessary to accomplish.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475784 ]

Adrian Crum commented on OFBIZ-762:
-----------------------------------

Understood. Thank you for the clarification.

> Move form stylings and pagination attributes to child elements
> --------------------------------------------------------------
>
>                 Key: OFBIZ-762
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-762
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Wish
>            Reporter: Chris Howe
>         Attachments: FormWidget.patch
>
>
> Pending the outcome of the discussion
> http://www.nabble.com/forum/ViewPost.jtp?post=9129284&framed=y
> This will hold the patches necessary to accomplish.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-762.
-----------------------------------

    Resolution: Incomplete

If any work will be done in this area, it's better to discuss in the mailing list.

> Move form stylings and pagination attributes to child elements
> --------------------------------------------------------------
>
>                 Key: OFBIZ-762
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-762
>             Project: OFBiz
>          Issue Type: Wish
>            Reporter: Chris Howe
>         Attachments: FormWidget.patch
>
>
> Pending the outcome of the discussion
> http://www.nabble.com/forum/ViewPost.jtp?post=9129284&framed=y
> This will hold the patches necessary to accomplish.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.