[jira] Created: (OFBIZ-763) Refactor Party Manager UI

[Nicolas Malin (Jira)]

Refactor Party Manager UI
-------------------------

                 Key: OFBIZ-763
                 URL: https://issues.apache.org/jira/browse/OFBIZ-763
             Project: OFBiz (The Open for Business Project)
          Issue Type: Sub-task
          Components: party
            Reporter: Adrian Crum
            Priority: Minor


Refactor the Party Manager UI according to the new patterns.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-763:
------------------------------

    Attachment: partyforms.patch

Party Manager forms patch. Eliminated unnecessary styling assignments, formatted xml files so that each form is its own block of code, ordered form element assignments according to Chris Howe's suggestion.

NOTE: This patch depends upon OFBIZ-671.

> Refactor Party Manager UI
> -------------------------
>
>                 Key: OFBIZ-763
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-763
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>          Components: party
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: partyforms.patch
>
>
> Refactor the Party Manager UI according to the new patterns.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-763:
------------------------------

    Attachment: partyforms.patch

Eliminated all default-tooltip-style attributes from form definitions - now handled by form widget.

> Refactor Party Manager UI
> -------------------------
>
>                 Key: OFBIZ-763
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-763
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>          Components: party
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: partyforms.patch, partyforms.patch
>
>
> Refactor the Party Manager UI according to the new patterns.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475925 ]

Jacopo Cappellato commented on OFBIZ-763:
-----------------------------------------

Adrian,

I've applied to my local copy this patch, together with the new css in OFBIZ-754 and  formwidget.patch attached to OFBIZ-671.
I've noticed that the forms of the party application are now a bit ugly: for example, have a look at the ones under the security menu... the single form field labels are not bold, the font and size of drop downs seem different from the ones of other fields...
Could you have a look at this issues or am I missing something?

Thanks

> Refactor Party Manager UI
> -------------------------
>
>                 Key: OFBIZ-763
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-763
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>          Components: party
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: partyforms.patch, partyforms.patch
>
>
> Refactor the Party Manager UI according to the new patterns.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475927 ]

Adrian Crum commented on OFBIZ-763:
-----------------------------------

Jacopo,

Thank you for taking a look at this. It would be helpful if you could give me the URL where you see the ugly forms. I just clicked through most of the security pages and everything looks okay here. Are you sure you did an ant build in the framework/widget component?

By the way, there will be other Party Manager patches forthcoming. I'm breaking them up into pieces because a single patch for the whole component would be huge.

> Refactor Party Manager UI
> -------------------------
>
>                 Key: OFBIZ-763
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-763
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>          Components: party
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: partyforms.patch, partyforms.patch
>
>
> Refactor the Party Manager UI according to the new patterns.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-763:
------------------------------

    Attachment: PMSCTY.JPG

Screen shot of what you should see at

https://127.0.0.1:8443/partymgr/control/EditSecurityGroup?groupId=ORDERPROC

> Refactor Party Manager UI
> -------------------------
>
>                 Key: OFBIZ-763
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-763
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>          Components: party
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: partyforms.patch, partyforms.patch, PMSCTY.JPG
>
>
> Refactor the Party Manager UI according to the new patterns.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475940 ]

Jacopo Cappellato commented on OFBIZ-763:
-----------------------------------------

Adrian,

the screenshot looks great and it's pretty different from mine.
The main issue is that all the forms in the other components seem to have loosen thir styles.
I'm attaching you a diff patch of what I'm running.

> Refactor Party Manager UI
> -------------------------
>
>                 Key: OFBIZ-763
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-763
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>          Components: party
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: partyforms.patch, partyforms.patch, PMSCTY.JPG
>
>
> Refactor the Party Manager UI according to the new patterns.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475944 ]

Jacopo Cappellato commented on OFBIZ-763:
-----------------------------------------

Adrian,

I found what my problem was.
When I applied the main.css patch all the new styles at the bottom of the file were not applied (this is something that happens to me quite frequently with Netbeans)... I've added them and now everything looks much better.

Sorry for the invalid report.

> Refactor Party Manager UI
> -------------------------
>
>                 Key: OFBIZ-763
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-763
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>          Components: party
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: partyforms.patch, partyforms.patch, PMSCTY.JPG
>
>
> Refactor the Party Manager UI according to the new patterns.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475976 ]

Adrian Crum commented on OFBIZ-763:
-----------------------------------

Jacopo,

Take a look at the Create Customer page and notice how I grouped the long form into neat little sub-sections. Then view the page source and see how it was done with CSS alone. I like using that page as an example of how to use the power of CSS.

> Refactor Party Manager UI
> -------------------------
>
>                 Key: OFBIZ-763
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-763
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>          Components: party
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: partyforms.patch, partyforms.patch, PMSCTY.JPG
>
>
> Refactor the Party Manager UI according to the new patterns.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475980 ]

Jacopo Cappellato commented on OFBIZ-763:
-----------------------------------------

Adrian,

I've seen it... quite impressive!

Kudos

> Refactor Party Manager UI
> -------------------------
>
>                 Key: OFBIZ-763
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-763
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>          Components: party
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: partyforms.patch, partyforms.patch, PMSCTY.JPG
>
>
> Refactor the Party Manager UI according to the new patterns.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-763:
------------------------------

    Attachment: partymenus.patch

Refactored party manager menus.

> Refactor Party Manager UI
> -------------------------
>
>                 Key: OFBIZ-763
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-763
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>          Components: party
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: partyforms.patch, partyforms.patch, partymenus.patch, PMSCTY.JPG
>
>
> Refactor the Party Manager UI according to the new patterns.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-763:
---------------------------------------

    Assignee: Jacopo Cappellato

> Refactor Party Manager UI
> -------------------------
>
>                 Key: OFBIZ-763
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-763
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>          Components: party
>            Reporter: Adrian Crum
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: partyforms.patch, partyforms.patch, partymenus.patch, PMSCTY.JPG
>
>
> Refactor the Party Manager UI according to the new patterns.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476129 ]

Jacopo Cappellato commented on OFBIZ-763:
-----------------------------------------

Adrian,

I've noticed that the tabs of the party details screen are not highlighted when selected... could you please verify if you can reproduce it?

> Refactor Party Manager UI
> -------------------------
>
>                 Key: OFBIZ-763
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-763
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>          Components: party
>            Reporter: Adrian Crum
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: partyforms.patch, partyforms.patch, partymenus.patch, PMSCTY.JPG
>
>
> Refactor the Party Manager UI according to the new patterns.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-763:
------------------------------

    Attachment: partymenus.patch

Jacopo,

The attached patch corrects the party profile button bar problem.

FYI: I have the menu widget java file default to a selected style of "selected", but the menu widget xsd keeps supplying a style of "tabButtonSelected" - which overrides the default in the java code.

During the transition I'll have to specify default-selected-style="selected" in the menu widget xml files, even though that shouldn't be necessary. Once the ofbiz.org xsd files are updated, that line can be removed.

> Refactor Party Manager UI
> -------------------------
>
>                 Key: OFBIZ-763
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-763
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>          Components: party
>            Reporter: Adrian Crum
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: partyforms.patch, partyforms.patch, partymenus.patch, partymenus.patch, PMSCTY.JPG
>
>
> Refactor the Party Manager UI according to the new patterns.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-763:
------------------------------

    Attachment: partymgr.patch

The entire Party Manager component, refactored. This patch replaces all other patches in this issue.

I made a few subtle styling changes to make the component's pages more consistent. I fixed up the jumbled and confusing Party Relationships page.

> Refactor Party Manager UI
> -------------------------
>
>                 Key: OFBIZ-763
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-763
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>          Components: party
>            Reporter: Adrian Crum
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: partyforms.patch, partyforms.patch, partymenus.patch, partymenus.patch, partymgr.patch, PMSCTY.JPG
>
>
> Refactor the Party Manager UI according to the new patterns.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-763:
------------------------------

    Attachment: partymgr.patch

Same patch, but now includes files missing from first one.

> Refactor Party Manager UI
> -------------------------
>
>                 Key: OFBIZ-763
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-763
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>          Components: party
>            Reporter: Adrian Crum
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: partyforms.patch, partyforms.patch, partymenus.patch, partymenus.patch, partymgr.patch, partymgr.patch, PMSCTY.JPG
>
>
> Refactor the Party Manager UI according to the new patterns.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476857 ]

Adrian Crum commented on OFBIZ-763:
-----------------------------------

A few things to note on this effort:

listCommunications.ftl doesn't appear to be used, so I didn't work on it.

The menu CommFindTabBar in CommMenus.xml doesn't appear to be used.

I was able to style the entire component using only the new CSS classes, the legacy smallSubmit class, and the legacy screenlet classes. I created one component-specific class and I put it in a component style sheet. I did that mainly to demonstrate how it can be done.

This refactor also includes a component-specific java script file.

If you uncomment the nav-next and nav-previous CSS classes in the latest maincss.css style sheet, then browse to the Find Party -> Show All Records page, you'll see something cool.

> Refactor Party Manager UI
> -------------------------
>
>                 Key: OFBIZ-763
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-763
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>          Components: party
>            Reporter: Adrian Crum
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: partyforms.patch, partyforms.patch, partymenus.patch, partymenus.patch, partymgr.patch, partymgr.patch, PMSCTY.JPG
>
>
> Refactor the Party Manager UI according to the new patterns.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-763:
------------------------------

    Attachment: partymgr.patch

Latest patch. I found a few spots I missed earlier. This patch replaces all other patches.

> Refactor Party Manager UI
> -------------------------
>
>                 Key: OFBIZ-763
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-763
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>          Components: party
>            Reporter: Adrian Crum
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: partyforms.patch, partyforms.patch, partymenus.patch, partymenus.patch, partymgr.patch, partymgr.patch, partymgr.patch, PMSCTY.JPG
>
>
> Refactor the Party Manager UI according to the new patterns.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-763.
-----------------------------------

    Resolution: Fixed

Thanks Adrian,

committed in rev. 514106

> Refactor Party Manager UI
> -------------------------
>
>                 Key: OFBIZ-763
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-763
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>          Components: party
>            Reporter: Adrian Crum
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: partyforms.patch, partyforms.patch, partymenus.patch, partymenus.patch, partymgr.patch, partymgr.patch, partymgr.patch, PMSCTY.JPG
>
>
> Refactor the Party Manager UI according to the new patterns.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477643 ]

Adrian Crum commented on OFBIZ-763:
-----------------------------------

Jacopo,

Thank you very much for your help with this! I am glad you waited a few days to commit this - I feel more confident with the version you committed.

> Refactor Party Manager UI
> -------------------------
>
>                 Key: OFBIZ-763
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-763
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>          Components: party
>            Reporter: Adrian Crum
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: partyforms.patch, partyforms.patch, partymenus.patch, partymenus.patch, partymgr.patch, partymgr.patch, partymgr.patch, PMSCTY.JPG
>
>
> Refactor the Party Manager UI according to the new patterns.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.