[jira] Created: (OFBIZ-797) Better EmailServices.sendMail messaging

[Nicolas Malin (Jira)]

Better EmailServices.sendMail messaging
---------------------------------------

                 Key: OFBIZ-797
                 URL: https://issues.apache.org/jira/browse/OFBIZ-797
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
            Reporter: Chris Howe
            Priority: Minor


EmailServices.sendMail does a lot of stuff between lines 168 and 237.  I propose that this try/catch be broken up a bit or handle specific exceptions appropriately instead of handling just a generic exception.  The one that I'm personally running into is a ConnectException.  Everything gets rescheduled correctly and it tries again later and succeeds, but because sendMail runs sync during order processing it spits out an ugly error message to the customer.  If I could get some advice, I'll attach a patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-797:
---------------------------------

          Component/s: framework
        Fix Version/s: SVN trunk
    Affects Version/s: SVN trunk

> Better EmailServices.sendMail messaging
> ---------------------------------------
>
>                 Key: OFBIZ-797
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-797
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Chris Howe
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> EmailServices.sendMail does a lot of stuff between lines 168 and 237.  I propose that this try/catch be broken up a bit or handle specific exceptions appropriately instead of handling just a generic exception.  The one that I'm personally running into is a ConnectException.  Everything gets rescheduled correctly and it tries again later and succeeds, but because sendMail runs sync during order processing it spits out an ugly error message to the customer.  If I could get some advice, I'll attach a patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti closed OFBIZ-797.
--------------------------------

    Resolution: Fixed

Thanks to Andrew Zeneski it has been recently implemented into rev.765476.

> Better EmailServices.sendMail messaging
> ---------------------------------------
>
>                 Key: OFBIZ-797
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-797
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Chris Howe
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> EmailServices.sendMail does a lot of stuff between lines 168 and 237.  I propose that this try/catch be broken up a bit or handle specific exceptions appropriately instead of handling just a generic exception.  The one that I'm personally running into is a ConnectException.  Everything gets rescheduled correctly and it tries again later and succeeds, but because sendMail runs sync during order processing it spits out an ugly error message to the customer.  If I could get some advice, I'll attach a patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.