[jira] Created: (OFBIZ-826) Allow header and appbar locations to be overriden in GlobalDecorator

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-826) Allow header and appbar locations to be overriden in GlobalDecorator

Nicolas Malin (Jira)
Allow header and appbar locations to be overriden in GlobalDecorator
--------------------------------------------------------------------

                 Key: OFBIZ-826
                 URL: https://issues.apache.org/jira/browse/OFBIZ-826
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
            Reporter: Chris Howe
            Priority: Minor


With the experimentation being done with various javascript tools it is often necessary to append information in the <head> of  the html document.  Parameterizing the header location will help this.  While we're at it we might as well parameterize the appbar location as well.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-826) Allow header and appbar locations to be overriden in GlobalDecorator

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Howe updated OFBIZ-826:
-----------------------------

    Attachment: CommonHeader.patch

> Allow header and appbar locations to be overriden in GlobalDecorator
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-826
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-826
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: CommonHeader.patch
>
>
> With the experimentation being done with various javascript tools it is often necessary to append information in the <head> of  the html document.  Parameterizing the header location will help this.  While we're at it we might as well parameterize the appbar location as well.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-826) Allow header and appbar locations to be overriden in GlobalDecorator

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482108 ]

Adrian Crum commented on OFBIZ-826:
-----------------------------------

Chris,

I had suggested a few weeks ago a similar change - where the components are responsible for rendering their own app header. Did you take a look at that? Dev ml, subject "Another GlobalDecorator Suggestion"


> Allow header and appbar locations to be overriden in GlobalDecorator
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-826
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-826
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: CommonHeader.patch
>
>
> With the experimentation being done with various javascript tools it is often necessary to append information in the <head> of  the html document.  Parameterizing the header location will help this.  While we're at it we might as well parameterize the appbar location as well.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-826) Allow header and appbar locations to be overriden in GlobalDecorator

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482124 ]

Chris Howe commented on OFBIZ-826:
----------------------------------

I like that idea too... the only issue with it is that you can't have a default value, so custom deployments would break until they were corrected.

> Allow header and appbar locations to be overriden in GlobalDecorator
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-826
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-826
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: CommonHeader.patch
>
>
> With the experimentation being done with various javascript tools it is often necessary to append information in the <head> of  the html document.  Parameterizing the header location will help this.  While we're at it we might as well parameterize the appbar location as well.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-826) Allow header and appbar locations to be overriden in GlobalDecorator

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482581 ]

Adrian Crum commented on OFBIZ-826:
-----------------------------------

What kind of additional information needs to be appended?

Here's my concern: The nice thing about our current setup is there are only a few files that need to be modified if users want to change their layout. In other words, the basic layout code has been somewhat "centralized." The changes you're proposing would "de-centralize" things so that it would be possible to have multiple copies of the same file (header.ftl and appbar.ftl).

Maybe if you provide some examples of the problems you're facing, we can come up with an alternative solution.


> Allow header and appbar locations to be overriden in GlobalDecorator
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-826
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-826
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: CommonHeader.patch
>
>
> With the experimentation being done with various javascript tools it is often necessary to append information in the <head> of  the html document.  Parameterizing the header location will help this.  While we're at it we might as well parameterize the appbar location as well.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-826) Allow header and appbar locations to be overriden in GlobalDecorator

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482608 ]

Chris Howe commented on OFBIZ-826:
----------------------------------

The original Rico javascript stuff needs the <body> tag to be <body onload="bodyOnLoad()"/>  And there are naturally a million different configurations for similar sorts of javascript things as well as may need to load javascript in an explicit order for dependencies.  Dojo and the new Rico LiveGrid Plus stuff have different load module declarations that need to be loaded in the head tag.  Those are just the couple that I've come across already...and I'm still green in this area.

> Allow header and appbar locations to be overriden in GlobalDecorator
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-826
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-826
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: CommonHeader.patch
>
>
> With the experimentation being done with various javascript tools it is often necessary to append information in the <head> of  the html document.  Parameterizing the header location will help this.  While we're at it we might as well parameterize the appbar location as well.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-826) Allow header and appbar locations to be overriden in GlobalDecorator

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482825 ]

Adrian Crum commented on OFBIZ-826:
-----------------------------------

Chris,

Loading javascripts in a specific order can be accomodated with the existing layoutSettings.javaScripts[] mechanism.

As far as the stuff needed in the header, if we're at an experimentation stage, why not just pass a variable to the header template?

Header.ftl example:

<body <#if bodyAttributes?has_content>${bodyAttributes}</#if>>

I don't think anyone would have any objections to sprinkling the existing header template with a few conditionals while we try out some ideas.


> Allow header and appbar locations to be overriden in GlobalDecorator
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-826
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-826
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: CommonHeader.patch
>
>
> With the experimentation being done with various javascript tools it is often necessary to append information in the <head> of  the html document.  Parameterizing the header location will help this.  While we're at it we might as well parameterize the appbar location as well.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-826) Allow header and appbar locations to be overriden in GlobalDecorator

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482836 ]

Chris Howe commented on OFBIZ-826:
----------------------------------

The specific order cannot be accomodated with layoutSettings.javaScripts[] .  Adding to an array with the [] notation adds the new value to the end of the Array.  The called screen will add it's javascript to the Array before the decorator screen adds the parent javascript so those that require the initialization of objects in a certain order will fail (perhaps printing the array in reverse order will solve this?).


>I don't think anyone would have any objections to sprinkling the existing header template with a few conditionals >while we try out some ideas.

Why bother sprinkling the existing header template with conditionals while people are experimenting?  We don't know where things will end up. Just let the developer specify his own header while working on POC and when something seems worthwhile add the conditional then.  I understand your concern about having multiple header files with redundant code.  However, this minor improvement is to add flexibility for custom applications so would have no effect on decentralizing the community project.


> Allow header and appbar locations to be overriden in GlobalDecorator
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-826
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-826
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: CommonHeader.patch
>
>
> With the experimentation being done with various javascript tools it is often necessary to append information in the <head> of  the html document.  Parameterizing the header location will help this.  While we're at it we might as well parameterize the appbar location as well.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-826) Allow header and appbar locations to be overriden in GlobalDecorator

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482841 ]

Adrian Crum commented on OFBIZ-826:
-----------------------------------

layoutSettings.javaScripts[+0] puts the script at the front of the list.



> Allow header and appbar locations to be overriden in GlobalDecorator
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-826
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-826
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: CommonHeader.patch
>
>
> With the experimentation being done with various javascript tools it is often necessary to append information in the <head> of  the html document.  Parameterizing the header location will help this.  While we're at it we might as well parameterize the appbar location as well.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-826) Allow header and appbar locations to be overriden in GlobalDecorator

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482844 ]

Chris Howe commented on OFBIZ-826:
----------------------------------

Thanks.  That solves the first part.

> Allow header and appbar locations to be overriden in GlobalDecorator
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-826
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-826
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: CommonHeader.patch
>
>
> With the experimentation being done with various javascript tools it is often necessary to append information in the <head> of  the html document.  Parameterizing the header location will help this.  While we're at it we might as well parameterize the appbar location as well.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-826) Allow header and appbar locations to be overriden in GlobalDecorator

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482845 ]

Chris Howe commented on OFBIZ-826:
----------------------------------

I suppose the second part could then be solved by

1)breaking up the header to just before the body tag
2) adding a decorator-section-include="additionalHeader"
3)then the portion after the body tag

maybe

> Allow header and appbar locations to be overriden in GlobalDecorator
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-826
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-826
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: CommonHeader.patch
>
>
> With the experimentation being done with various javascript tools it is often necessary to append information in the <head> of  the html document.  Parameterizing the header location will help this.  While we're at it we might as well parameterize the appbar location as well.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-826) Allow header and appbar locations to be overriden in GlobalDecorator

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482848 ]

Adrian Crum commented on OFBIZ-826:
-----------------------------------

No, your patch should be okay. No need to make things any more complicated.


> Allow header and appbar locations to be overriden in GlobalDecorator
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-826
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-826
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: CommonHeader.patch
>
>
> With the experimentation being done with various javascript tools it is often necessary to append information in the <head> of  the html document.  Parameterizing the header location will help this.  While we're at it we might as well parameterize the appbar location as well.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-826) Allow header and appbar locations to be overriden in GlobalDecorator

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486129 ]

Chris Howe commented on OFBIZ-826:
----------------------------------

Since I've been playing with LiveGrid Plus I'm warming closer to Adrian's POV, perhaps simply adding an array for additional information to header.ftl may be better...
<#if additionalScreens?exists>
  <#list additionalScreens as newScreen>
    ${screen.render(''(newScreen)")}
  </#list>
</#if>


> Allow header and appbar locations to be overriden in GlobalDecorator
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-826
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-826
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: CommonHeader.patch
>
>
> With the experimentation being done with various javascript tools it is often necessary to append information in the <head> of  the html document.  Parameterizing the header location will help this.  While we're at it we might as well parameterize the appbar location as well.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-826) Allow header and appbar locations to be overriden in GlobalDecorator

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486147 ]

Adrian Crum commented on OFBIZ-826:
-----------------------------------

There's also this line in header.ftl:

${layoutSettings.extraHead?if_exists}


> Allow header and appbar locations to be overriden in GlobalDecorator
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-826
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-826
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: CommonHeader.patch
>
>
> With the experimentation being done with various javascript tools it is often necessary to append information in the <head> of  the html document.  Parameterizing the header location will help this.  While we're at it we might as well parameterize the appbar location as well.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-826) Allow header and appbar locations to be overriden in GlobalDecorator

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486155 ]

Chris Howe commented on OFBIZ-826:
----------------------------------

Would that benefit more by being an array?  I'm thinking most of the use would be additive and not overriding.

> Allow header and appbar locations to be overriden in GlobalDecorator
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-826
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-826
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: CommonHeader.patch
>
>
> With the experimentation being done with various javascript tools it is often necessary to append information in the <head> of  the html document.  Parameterizing the header location will help this.  While we're at it we might as well parameterize the appbar location as well.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-826) Allow header and appbar locations to be overriden in GlobalDecorator

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486159 ]

Adrian Crum commented on OFBIZ-826:
-----------------------------------

I was just pointing it out, not suggesting it as a replacement for your idea. Hence my "also."


> Allow header and appbar locations to be overriden in GlobalDecorator
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-826
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-826
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: CommonHeader.patch
>
>
> With the experimentation being done with various javascript tools it is often necessary to append information in the <head> of  the html document.  Parameterizing the header location will help this.  While we're at it we might as well parameterize the appbar location as well.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-826) Allow header and appbar locations to be overriden in GlobalDecorator

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-826:
---------------------------------

          Component/s: framework
        Fix Version/s: SVN trunk
    Affects Version/s: SVN trunk

> Allow header and appbar locations to be overriden in GlobalDecorator
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-826
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-826
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Chris Howe
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: CommonHeader.patch
>
>
> With the experimentation being done with various javascript tools it is often necessary to append information in the <head> of  the html document.  Parameterizing the header location will help this.  While we're at it we might as well parameterize the appbar location as well.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.