[jira] Created: (OFBIZ-875) Add ability to put HTML "snippets" in screen widget XML files
Locked
[jira] Created: (OFBIZ-875) Add ability to put HTML "snippets" in screen widget XML files
 
|
Add ability to put HTML "snippets" in screen widget XML files
------------------------------------------------------------- Key: OFBIZ-875 URL: https://issues.apache.org/jira/browse/OFBIZ-875 Project: OFBiz (The Open for Business Project) Issue Type: Improvement Components: framework Reporter: Adrian Crum Priority: Minor Sometimes there is a need to output a little HTML that the screen widget doesn't accomodate, but it's not enough code to justify a separate ftl file. This improvement adds an html-snippet element to the platform-specific->html element which allows HTML to be directly inserted in a widget XML file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-875) Add ability to put HTML "snippets" in screen widget XML files
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-875: ------------------------------ Attachment: html_snippet.patch The patch. Example widget code: <widgets> <platform-specific> <html> <html-snippet><![CDATA[<h1>Hello World!</h1><br/>]]></html-snippet> </html> <platform-specific> </widgets> This patch also fixes a bug and some quirky behavior in the <platform-specific> area. > Add ability to put HTML "snippets" in screen widget XML files > ------------------------------------------------------------- > > Key: OFBIZ-875 > URL: https://issues.apache.org/jira/browse/OFBIZ-875 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: html_snippet.patch > > > Sometimes there is a need to output a little HTML that the screen widget doesn't accomodate, but it's not enough code to justify a separate ftl file. This improvement adds an html-snippet element to the platform-specific->html element which allows HTML to be directly inserted in a widget XML file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-875) Add ability to put HTML "snippets" in screen widget XML files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-875: ------------------------------ Attachment: html_snippet.patch Same patch, removed unintentional formatting. > Add ability to put HTML "snippets" in screen widget XML files > ------------------------------------------------------------- > > Key: OFBIZ-875 > URL: https://issues.apache.org/jira/browse/OFBIZ-875 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: html_snippet.patch, html_snippet.patch > > > Sometimes there is a need to output a little HTML that the screen widget doesn't accomodate, but it's not enough code to justify a separate ftl file. This improvement adds an html-snippet element to the platform-specific->html element which allows HTML to be directly inserted in a widget XML file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-875) Add ability to put HTML "snippets" in screen widget XML files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487813 ] David E. Jones commented on OFBIZ-875: -------------------------------------- From a design perspective on the Screen Widget I have concerns about this change, so please no one commit it until there is time to discuss it. Adrian has expressed his opinion on it, which is great, and even in the form of a patch. Before we do it or decide not to do it we should get opinions from others, that means you! > Add ability to put HTML "snippets" in screen widget XML files > ------------------------------------------------------------- > > Key: OFBIZ-875 > URL: https://issues.apache.org/jira/browse/OFBIZ-875 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: html_snippet.patch, html_snippet.patch > > > Sometimes there is a need to output a little HTML that the screen widget doesn't accomodate, but it's not enough code to justify a separate ftl file. This improvement adds an html-snippet element to the platform-specific->html element which allows HTML to be directly inserted in a widget XML file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-875) Add ability to put HTML "snippets" in screen widget XML files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487818 ] Adrian Crum commented on OFBIZ-875: ----------------------------------- David, It would be helpful to know what your concern is, so it can be addressed. > Add ability to put HTML "snippets" in screen widget XML files > ------------------------------------------------------------- > > Key: OFBIZ-875 > URL: https://issues.apache.org/jira/browse/OFBIZ-875 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: html_snippet.patch, html_snippet.patch > > > Sometimes there is a need to output a little HTML that the screen widget doesn't accomodate, but it's not enough code to justify a separate ftl file. This improvement adds an html-snippet element to the platform-specific->html element which allows HTML to be directly inserted in a widget XML file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-875) Add ability to put HTML "snippets" in screen widget XML files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487831 ] Chris Howe commented on OFBIZ-875: ---------------------------------- I would have concerns on how it gets used in the community project (I have suspicions Adrian has designs for lists to be implemented this way throughout the OFBiz community project that I would be opposed to). That said, I think that it is very good to have this option available and consistent with the XML design and the element structure of the widget. I wish I had a better understanding of the intricacies of some of the OFBiz tools to implement more CDATA tags in places. > Add ability to put HTML "snippets" in screen widget XML files > ------------------------------------------------------------- > > Key: OFBIZ-875 > URL: https://issues.apache.org/jira/browse/OFBIZ-875 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: html_snippet.patch, html_snippet.patch > > > Sometimes there is a need to output a little HTML that the screen widget doesn't accomodate, but it's not enough code to justify a separate ftl file. This improvement adds an html-snippet element to the platform-specific->html element which allows HTML to be directly inserted in a widget XML file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-875) Add ability to put HTML "snippets" in screen widget XML files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487836 ] Adrian Crum commented on OFBIZ-875: ----------------------------------- Chris, I don't have any pre-conceived uses for this feature. If anything, it would answer a question Jacopo asked a while ago: How do you get around having to use <label style="head1">My Heading</label> and just use <h1>My Heading</h1> instead? > Add ability to put HTML "snippets" in screen widget XML files > ------------------------------------------------------------- > > Key: OFBIZ-875 > URL: https://issues.apache.org/jira/browse/OFBIZ-875 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: html_snippet.patch, html_snippet.patch > > > Sometimes there is a need to output a little HTML that the screen widget doesn't accomodate, but it's not enough code to justify a separate ftl file. This improvement adds an html-snippet element to the platform-specific->html element which allows HTML to be directly inserted in a widget XML file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-875) Add ability to put HTML "snippets" in screen widget XML files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487853 ] David Shere commented on OFBIZ-875: ----------------------------------- Is the question, "How much HTML is enough to justify a separate FTL file?" > Add ability to put HTML "snippets" in screen widget XML files > ------------------------------------------------------------- > > Key: OFBIZ-875 > URL: https://issues.apache.org/jira/browse/OFBIZ-875 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: html_snippet.patch, html_snippet.patch > > > Sometimes there is a need to output a little HTML that the screen widget doesn't accomodate, but it's not enough code to justify a separate ftl file. This improvement adds an html-snippet element to the platform-specific->html element which allows HTML to be directly inserted in a widget XML file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-875) Add ability to put HTML "snippets" in screen widget XML files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487864 ] Chris Howe commented on OFBIZ-875: ---------------------------------- Although not a perfect solution, having <label style="head1">My Heading</label> should still be the preferred practice over <[CDATA[<h1>My Heading</h1>]]/>. Moving to cdata in this instance makes your screen more medium specific instead of less. A more ideal solution would be for the html renderer to identify reserved words head1 = <h1>, head2 = <h2>, paragraph = <p>, etc. I understand there aren't many examples of non html interfaces floating around but utilizing cdata in this manner helps to ensure that we don't see any. The widgets are kept outside of the webapp to make sure that web applications are not the only focus for their development. > Add ability to put HTML "snippets" in screen widget XML files > ------------------------------------------------------------- > > Key: OFBIZ-875 > URL: https://issues.apache.org/jira/browse/OFBIZ-875 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: html_snippet.patch, html_snippet.patch > > > Sometimes there is a need to output a little HTML that the screen widget doesn't accomodate, but it's not enough code to justify a separate ftl file. This improvement adds an html-snippet element to the platform-specific->html element which allows HTML to be directly inserted in a widget XML file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-875) Add ability to put HTML "snippets" in screen widget XML files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487868 ] Jacopo Cappellato commented on OFBIZ-875: ----------------------------------------- Adrian, I'd like to clarify that my concern/question was about the usage of the "head1" style... and not on the <label style=""/> element. I think it is important to limit the usage of html code inside of widgets because avoiding this we will be able to implement new renderer in the future. Jacopo > Add ability to put HTML "snippets" in screen widget XML files > ------------------------------------------------------------- > > Key: OFBIZ-875 > URL: https://issues.apache.org/jira/browse/OFBIZ-875 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: html_snippet.patch, html_snippet.patch > > > Sometimes there is a need to output a little HTML that the screen widget doesn't accomodate, but it's not enough code to justify a separate ftl file. This improvement adds an html-snippet element to the platform-specific->html element which allows HTML to be directly inserted in a widget XML file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-875) Add ability to put HTML "snippets" in screen widget XML files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487869 ] Adrian Crum commented on OFBIZ-875: ----------------------------------- Chris, There is a good chance that the unused swing renderer - if it was used - would run into similar problems and it would have an equivalent workaround. > Add ability to put HTML "snippets" in screen widget XML files > ------------------------------------------------------------- > > Key: OFBIZ-875 > URL: https://issues.apache.org/jira/browse/OFBIZ-875 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: html_snippet.patch, html_snippet.patch > > > Sometimes there is a need to output a little HTML that the screen widget doesn't accomodate, but it's not enough code to justify a separate ftl file. This improvement adds an html-snippet element to the platform-specific->html element which allows HTML to be directly inserted in a widget XML file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-875) Add ability to put HTML "snippets" in screen widget XML files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487876 ] Adrian Crum commented on OFBIZ-875: ----------------------------------- Jacopo, So should we deprecate the <html> widget element? Using Chris's argument, even having that is squelching development of other interfaces. I'm truly puzzled by these objections. We already have a <platform-specific> element that narrows down platform-dependent code. Inside that we have an <html> element that - it's understood - will contain html-specific code. What difference does it make if the EXISTING <html> element contains a template or CDATA? It's still HTML. Arguing against one method or another is basically arguing against them both. > Add ability to put HTML "snippets" in screen widget XML files > ------------------------------------------------------------- > > Key: OFBIZ-875 > URL: https://issues.apache.org/jira/browse/OFBIZ-875 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: html_snippet.patch, html_snippet.patch > > > Sometimes there is a need to output a little HTML that the screen widget doesn't accomodate, but it's not enough code to justify a separate ftl file. This improvement adds an html-snippet element to the platform-specific->html element which allows HTML to be directly inserted in a widget XML file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-875) Add ability to put HTML "snippets" in screen widget XML files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487893 ] Chris Howe commented on OFBIZ-875: ---------------------------------- The best practice here is _where possible_ eliminate the usage of <platform-specific/>. So, the objection is moving data that is currently outside of the <platform-specific/> element into the <platform-specific/> element is not a good idea. Like I said, I agree with this feature being added as it certainly makes the html element more robust. However, I am likely to disagree with where you'll want to actually use this feature in the community project. 1) Unordered lists - likely have a better home in menu widgets or tree widget if they were to receive as much attention as is being given to screen widget improvement 2) labels shouldn't move into a less generic direction. Rather, reserved label styles should be handled more in line with the desired interface by the renderer. As I see it now, it's likely that the only place that the community project will benefit from this is when adding a small JavaScript snippets. At the same time, there's no harm for a custom application to worry about best practices when it's only envisioned usage is html. > Add ability to put HTML "snippets" in screen widget XML files > ------------------------------------------------------------- > > Key: OFBIZ-875 > URL: https://issues.apache.org/jira/browse/OFBIZ-875 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: html_snippet.patch, html_snippet.patch > > > Sometimes there is a need to output a little HTML that the screen widget doesn't accomodate, but it's not enough code to justify a separate ftl file. This improvement adds an html-snippet element to the platform-specific->html element which allows HTML to be directly inserted in a widget XML file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-875) Add ability to put HTML "snippets" in screen widget XML files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487894 ] Adrian Crum commented on OFBIZ-875: ----------------------------------- Chris, Thank you for the clarification. You seem to be reading a lot into my simple Hello World! example. Maybe the improper uses you're predicting should be addressed if/when they occur. > Add ability to put HTML "snippets" in screen widget XML files > ------------------------------------------------------------- > > Key: OFBIZ-875 > URL: https://issues.apache.org/jira/browse/OFBIZ-875 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: html_snippet.patch, html_snippet.patch > > > Sometimes there is a need to output a little HTML that the screen widget doesn't accomodate, but it's not enough code to justify a separate ftl file. This improvement adds an html-snippet element to the platform-specific->html element which allows HTML to be directly inserted in a widget XML file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-875) Add ability to put HTML "snippets" in screen widget XML files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487912 ] Chris Howe commented on OFBIZ-875: ---------------------------------- i thought that was what i was doing... would you prefer i simply say "+1 for this patch." if so, +1 for this patch :-) > Add ability to put HTML "snippets" in screen widget XML files > ------------------------------------------------------------- > > Key: OFBIZ-875 > URL: https://issues.apache.org/jira/browse/OFBIZ-875 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: html_snippet.patch, html_snippet.patch > > > Sometimes there is a need to output a little HTML that the screen widget doesn't accomodate, but it's not enough code to justify a separate ftl file. This improvement adds an html-snippet element to the platform-specific->html element which allows HTML to be directly inserted in a widget XML file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-875) Add ability to put HTML "snippets" in screen widget XML files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-875: --------------------------------------- Assignee: Jacopo Cappellato > Add ability to put HTML "snippets" in screen widget XML files > ------------------------------------------------------------- > > Key: OFBIZ-875 > URL: https://issues.apache.org/jira/browse/OFBIZ-875 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Jacopo Cappellato > Priority: Minor > Attachments: html_snippet.patch, html_snippet.patch > > > Sometimes there is a need to output a little HTML that the screen widget doesn't accomodate, but it's not enough code to justify a separate ftl file. This improvement adds an html-snippet element to the platform-specific->html element which allows HTML to be directly inserted in a widget XML file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-875) Add ability to put HTML "snippets" in screen widget XML files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534585 ] Jacopo Cappellato commented on OFBIZ-875: ----------------------------------------- Adrian, all, your patch and this discussion are both interesting, however I still have concerns about this new feature: I really think that we should not make it easier to add html code to screen widgets... instead we should improve the screen widget framework to be more flexible and rich. And, in the same time, we should convert the existing ftl templates to form/menu/screen widgets (and some of the bsh scripts to actions in widgets): I'm slowly doing this (in my free time), and it is amazing to see how much cleaner and smaller the refactored code is if compared to ftl+bsh. What if we close this as "Won't fix"? > Add ability to put HTML "snippets" in screen widget XML files > ------------------------------------------------------------- > > Key: OFBIZ-875 > URL: https://issues.apache.org/jira/browse/OFBIZ-875 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: html_snippet.patch, html_snippet.patch > > > Sometimes there is a need to output a little HTML that the screen widget doesn't accomodate, but it's not enough code to justify a separate ftl file. This improvement adds an html-snippet element to the platform-specific->html element which allows HTML to be directly inserted in a widget XML file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-875) Add ability to put HTML "snippets" in screen widget XML files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-875. ----------------------------------- Resolution: Won't Fix See my last comment. > Add ability to put HTML "snippets" in screen widget XML files > ------------------------------------------------------------- > > Key: OFBIZ-875 > URL: https://issues.apache.org/jira/browse/OFBIZ-875 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Jacopo Cappellato > Priority: Minor > Attachments: html_snippet.patch, html_snippet.patch > > > Sometimes there is a need to output a little HTML that the screen widget doesn't accomodate, but it's not enough code to justify a separate ftl file. This improvement adds an html-snippet element to the platform-specific->html element which allows HTML to be directly inserted in a widget XML file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |