[jira] Created: (OFBIZ-878) Extend UPS Shipping Estimate Service to add Package Dimension details to request if Product is inShippingBox

[Nicolas Malin (Jira)]

Extend UPS Shipping Estimate Service to add Package Dimension details to request if Product is inShippingBox
-------------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-878
                 URL: https://issues.apache.org/jira/browse/OFBIZ-878
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: product
            Reporter: Anil K Patel




--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel updated OFBIZ-878:
-------------------------------

    Attachment: DimensionAwareUpsServices.patch

Patch to add Dimension data to the request sent to UPS for shipping Estimate. A Indicator field "inShippingBox" has been added to Product Entity. If inShippingBox is set to Y then Shipping Package dimensions are expected in shippingDepth, shippingWidth, shippingHeight fields.

I'll appreciate help with code review.

> Extend UPS Shipping Estimate Service to add Package Dimension details to request if Product is inShippingBox
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-878
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-878
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>            Reporter: Anil K Patel
>         Attachments: DimensionAwareUpsServices.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ruppert reassigned OFBIZ-878:
---------------------------------

    Assignee: Tim Ruppert

> Extend UPS Shipping Estimate Service to add Package Dimension details to request if Product is inShippingBox
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-878
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-878
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>            Reporter: Anil K Patel
>         Assigned To: Tim Ruppert
>         Attachments: DimensionAwareUpsServices.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488457 ]

Tim Ruppert commented on OFBIZ-878:
-----------------------------------

Anil, in order to guard this a little more defensively, I would both check to see if inShippingBox is set to Y AND height, length and width are all populated - as it won't work if any of them are missing.

Also, you put the inShippingBox value into the itemInfo two times where one is sufficient.

> Extend UPS Shipping Estimate Service to add Package Dimension details to request if Product is inShippingBox
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-878
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-878
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>            Reporter: Anil K Patel
>         Assigned To: Tim Ruppert
>         Attachments: DimensionAwareUpsServices.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488464 ]

Anil K Patel commented on OFBIZ-878:
------------------------------------

Sorry saw one more thing.

> Extend UPS Shipping Estimate Service to add Package Dimension details to request if Product is inShippingBox
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-878
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-878
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>            Reporter: Anil K Patel
>         Assigned To: Tim Ruppert
>         Attachments: DimensionAwareUpsServices.patch, DimensionAwareUpsServices.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel updated OFBIZ-878:
-------------------------------

    Attachment: DimensionAwareUpsServices.patch

Thanks Tim, Here is modified patch.

> Extend UPS Shipping Estimate Service to add Package Dimension details to request if Product is inShippingBox
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-878
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-878
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>            Reporter: Anil K Patel
>         Assigned To: Tim Ruppert
>         Attachments: DimensionAwareUpsServices.patch, DimensionAwareUpsServices.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel updated OFBIZ-878:
-------------------------------

    Attachment: DimensionAwareUpsServices.patch

> Extend UPS Shipping Estimate Service to add Package Dimension details to request if Product is inShippingBox
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-878
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-878
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>            Reporter: Anil K Patel
>         Assigned To: Tim Ruppert
>         Attachments: DimensionAwareUpsServices.patch, DimensionAwareUpsServices.patch, DimensionAwareUpsServices.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel updated OFBIZ-878:
-------------------------------

    Attachment: DimensionAwareUpsServices.patch

Finally I think we can apply this patch.

> Extend UPS Shipping Estimate Service to add Package Dimension details to request if Product is inShippingBox
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-878
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-878
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>            Reporter: Anil K Patel
>         Assigned To: Tim Ruppert
>         Attachments: DimensionAwareUpsServices.patch, DimensionAwareUpsServices.patch, DimensionAwareUpsServices.patch, DimensionAwareUpsServices.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ruppert closed OFBIZ-878.
-----------------------------

    Resolution: Fixed

Thanks for this Anil.  This is in rev 529677

> Extend UPS Shipping Estimate Service to add Package Dimension details to request if Product is inShippingBox
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-878
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-878
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>            Reporter: Anil K Patel
>         Assigned To: Tim Ruppert
>         Attachments: DimensionAwareUpsServices.patch, DimensionAwareUpsServices.patch, DimensionAwareUpsServices.patch, DimensionAwareUpsServices.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.