[jira] Created: (OFBIZ-880) Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.
Locked
[jira] Created: (OFBIZ-880) Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.
 
|
Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.
----------------------------------------------------------------------------------------------- Key: OFBIZ-880 URL: https://issues.apache.org/jira/browse/OFBIZ-880 Project: OFBiz (The Open for Business Project) Issue Type: Improvement Components: order Reporter: Jacopo Cappellato Priority: Minor Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. It would be great to have this fixed before the upcoming release (volunteers?). Here is the list of the warnings: 13 warnings applications/order/src/org/ofbiz/order/order/OrderServices.java:1120: warning: [deprecation] getOrderGrandTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated double updatedTotal = orh.getOrderGrandTotal(); applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderReturnedTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderNonReturnedTaxAndShipping() in org.ofbiz.order.order.OrderReadHelper has been deprecated double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); applications/order/src/org/ofbiz/order/order/OrderServices.java:1278: warning: [deprecation] getOrderItemsSubTotal(java.util.List,java.util.List) in org.ofbiz.order.order.OrderReadHelper has been deprecated double orderSubTotal = OrderReadHelper.getOrderItemsSubTotal(validOrderItems, allAdjustments); applications/order/src/org/ofbiz/order/order/OrderServices.java:1281: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated BigDecimal orderShipping = new BigDecimal(OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true)); applications/order/src/org/ofbiz/order/order/OrderServices.java:1289: warning: [deprecation] getOrderItemSubTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated amounts.add(i, new BigDecimal(OrderReadHelper.getOrderItemSubTotal(orderItem, allAdjustments, true, false))); // get the item amount applications/order/src/org/ofbiz/order/order/OrderServices.java:1290: warning: [deprecation] getOrderItemAdjustmentsTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated shipAmts.add(i, new BigDecimal(OrderReadHelper.getOrderItemAdjustmentsTotal(orderItem, allAdjustments, false, false, true))); // get the shipping amount applications/order/src/org/ofbiz/order/order/OrderServices.java:1468: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated double currentShipping = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orh.getOrderItemAndShipGroupAssoc(shipGroupSeqId), orh.getAdjustments(), false, false, true); applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); applications/order/src/org/ofbiz/order/order/OrderServices.java:2355: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated double orderSubTotal = orh.getOrderItemsSubTotal(); applications/order/src/org/ofbiz/order/order/OrderServices.java:2357: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated double shippingAmount = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orderItems, orderAdjustments, false, false, true); applications/order/src/org/ofbiz/order/order/OrderServices.java:2358: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated shippingAmount += OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-880) Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488063 ] Jacques Le Roux commented on OFBIZ-880: --------------------------------------- I will try to help... Tomorrow... > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > ----------------------------------------------------------------------------------------------- > > Key: OFBIZ-880 > URL: https://issues.apache.org/jira/browse/OFBIZ-880 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Jacopo Cappellato > Priority: Minor > > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > It would be great to have this fixed before the upcoming release (volunteers?). > Here is the list of the warnings: > 13 warnings > applications/order/src/org/ofbiz/order/order/OrderServices.java:1120: warning: [deprecation] getOrderGrandTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double updatedTotal = orh.getOrderGrandTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderReturnedTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderNonReturnedTaxAndShipping() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1278: warning: [deprecation] getOrderItemsSubTotal(java.util.List,java.util.List) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = OrderReadHelper.getOrderItemsSubTotal(validOrderItems, allAdjustments); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1281: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > BigDecimal orderShipping = new BigDecimal(OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true)); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1289: warning: [deprecation] getOrderItemSubTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > amounts.add(i, new BigDecimal(OrderReadHelper.getOrderItemSubTotal(orderItem, allAdjustments, true, false))); // get the item amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1290: warning: [deprecation] getOrderItemAdjustmentsTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shipAmts.add(i, new BigDecimal(OrderReadHelper.getOrderItemAdjustmentsTotal(orderItem, allAdjustments, false, false, true))); // get the shipping amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1468: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double currentShipping = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orh.getOrderItemAndShipGroupAssoc(shipGroupSeqId), orh.getAdjustments(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2355: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = orh.getOrderItemsSubTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2357: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double shippingAmount = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orderItems, orderAdjustments, false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2358: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shippingAmount += OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-880) Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Gray reassigned OFBIZ-880: -------------------------------- Assignee: Scott Gray If anyone is working on this let me know, because I'm about to start... > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > ----------------------------------------------------------------------------------------------- > > Key: OFBIZ-880 > URL: https://issues.apache.org/jira/browse/OFBIZ-880 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Jacopo Cappellato > Assigned To: Scott Gray > Priority: Minor > > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > It would be great to have this fixed before the upcoming release (volunteers?). > Here is the list of the warnings: > 13 warnings > applications/order/src/org/ofbiz/order/order/OrderServices.java:1120: warning: [deprecation] getOrderGrandTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double updatedTotal = orh.getOrderGrandTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderReturnedTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderNonReturnedTaxAndShipping() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1278: warning: [deprecation] getOrderItemsSubTotal(java.util.List,java.util.List) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = OrderReadHelper.getOrderItemsSubTotal(validOrderItems, allAdjustments); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1281: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > BigDecimal orderShipping = new BigDecimal(OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true)); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1289: warning: [deprecation] getOrderItemSubTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > amounts.add(i, new BigDecimal(OrderReadHelper.getOrderItemSubTotal(orderItem, allAdjustments, true, false))); // get the item amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1290: warning: [deprecation] getOrderItemAdjustmentsTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shipAmts.add(i, new BigDecimal(OrderReadHelper.getOrderItemAdjustmentsTotal(orderItem, allAdjustments, false, false, true))); // get the shipping amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1468: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double currentShipping = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orh.getOrderItemAndShipGroupAssoc(shipGroupSeqId), orh.getAdjustments(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2355: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = orh.getOrderItemsSubTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2357: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double shippingAmount = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orderItems, orderAdjustments, false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2358: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shippingAmount += OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-880) Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489023 ] Scott Gray commented on OFBIZ-880: ---------------------------------- Is it ok to return a BigDecimal in a service when a Double is expected or will this throw an exception? Thanks > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > ----------------------------------------------------------------------------------------------- > > Key: OFBIZ-880 > URL: https://issues.apache.org/jira/browse/OFBIZ-880 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Jacopo Cappellato > Assigned To: Scott Gray > Priority: Minor > > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > It would be great to have this fixed before the upcoming release (volunteers?). > Here is the list of the warnings: > 13 warnings > applications/order/src/org/ofbiz/order/order/OrderServices.java:1120: warning: [deprecation] getOrderGrandTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double updatedTotal = orh.getOrderGrandTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderReturnedTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderNonReturnedTaxAndShipping() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1278: warning: [deprecation] getOrderItemsSubTotal(java.util.List,java.util.List) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = OrderReadHelper.getOrderItemsSubTotal(validOrderItems, allAdjustments); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1281: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > BigDecimal orderShipping = new BigDecimal(OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true)); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1289: warning: [deprecation] getOrderItemSubTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > amounts.add(i, new BigDecimal(OrderReadHelper.getOrderItemSubTotal(orderItem, allAdjustments, true, false))); // get the item amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1290: warning: [deprecation] getOrderItemAdjustmentsTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shipAmts.add(i, new BigDecimal(OrderReadHelper.getOrderItemAdjustmentsTotal(orderItem, allAdjustments, false, false, true))); // get the shipping amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1468: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double currentShipping = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orh.getOrderItemAndShipGroupAssoc(shipGroupSeqId), orh.getAdjustments(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2355: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = orh.getOrderItemsSubTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2357: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double shippingAmount = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orderItems, orderAdjustments, false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2358: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shippingAmount += OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-880) Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489028 ] Jacopo Cappellato commented on OFBIZ-880: ----------------------------------------- Scott, I think it will throw an exception. I guess that we have two options here: 1) change the service def for the out attribute from Double to BigDecimal, and fix all the service calls in OFBiz 2) change the service def to return also the BigDecimal attribute (this will be backward compatible) All in all I'd prefer the option #1 but maybe option #2 is a bit more prodent (and less work for you) Any other opinion? Jacopo > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > ----------------------------------------------------------------------------------------------- > > Key: OFBIZ-880 > URL: https://issues.apache.org/jira/browse/OFBIZ-880 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Jacopo Cappellato > Assigned To: Scott Gray > Priority: Minor > > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > It would be great to have this fixed before the upcoming release (volunteers?). > Here is the list of the warnings: > 13 warnings > applications/order/src/org/ofbiz/order/order/OrderServices.java:1120: warning: [deprecation] getOrderGrandTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double updatedTotal = orh.getOrderGrandTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderReturnedTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderNonReturnedTaxAndShipping() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1278: warning: [deprecation] getOrderItemsSubTotal(java.util.List,java.util.List) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = OrderReadHelper.getOrderItemsSubTotal(validOrderItems, allAdjustments); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1281: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > BigDecimal orderShipping = new BigDecimal(OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true)); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1289: warning: [deprecation] getOrderItemSubTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > amounts.add(i, new BigDecimal(OrderReadHelper.getOrderItemSubTotal(orderItem, allAdjustments, true, false))); // get the item amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1290: warning: [deprecation] getOrderItemAdjustmentsTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shipAmts.add(i, new BigDecimal(OrderReadHelper.getOrderItemAdjustmentsTotal(orderItem, allAdjustments, false, false, true))); // get the shipping amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1468: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double currentShipping = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orh.getOrderItemAndShipGroupAssoc(shipGroupSeqId), orh.getAdjustments(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2355: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = orh.getOrderItemsSubTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2357: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double shippingAmount = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orderItems, orderAdjustments, false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2358: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shippingAmount += OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-880) Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489033 ] Scott Gray commented on OFBIZ-880: ---------------------------------- No. 1 looks good to me, I'd prefer to get rid of the Doubles and be done with it. Is it ok to change service defs like this? > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > ----------------------------------------------------------------------------------------------- > > Key: OFBIZ-880 > URL: https://issues.apache.org/jira/browse/OFBIZ-880 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Jacopo Cappellato > Assigned To: Scott Gray > Priority: Minor > > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > It would be great to have this fixed before the upcoming release (volunteers?). > Here is the list of the warnings: > 13 warnings > applications/order/src/org/ofbiz/order/order/OrderServices.java:1120: warning: [deprecation] getOrderGrandTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double updatedTotal = orh.getOrderGrandTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderReturnedTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderNonReturnedTaxAndShipping() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1278: warning: [deprecation] getOrderItemsSubTotal(java.util.List,java.util.List) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = OrderReadHelper.getOrderItemsSubTotal(validOrderItems, allAdjustments); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1281: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > BigDecimal orderShipping = new BigDecimal(OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true)); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1289: warning: [deprecation] getOrderItemSubTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > amounts.add(i, new BigDecimal(OrderReadHelper.getOrderItemSubTotal(orderItem, allAdjustments, true, false))); // get the item amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1290: warning: [deprecation] getOrderItemAdjustmentsTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shipAmts.add(i, new BigDecimal(OrderReadHelper.getOrderItemAdjustmentsTotal(orderItem, allAdjustments, false, false, true))); // get the shipping amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1468: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double currentShipping = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orh.getOrderItemAndShipGroupAssoc(shipGroupSeqId), orh.getAdjustments(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2355: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = orh.getOrderItemsSubTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2357: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double shippingAmount = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orderItems, orderAdjustments, false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2358: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shippingAmount += OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-880) Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489058 ] Jacopo Cappellato commented on OFBIZ-880: ----------------------------------------- Scott, I think you should simply replace it with: orderHeader.set("grandTotal", updatedTotal); where updatedTotal is a BigDecimal Jacopo Scott Gray wrote: > Thanks David I'll go ahead with it. > > One question, how do I approach this line with updatedTotal being a > BigDecimal: > > orderHeader.set("grandTotal", UtilFormatOut.formatPriceNumber > (updatedTotal)); > > UtilFormatOut doesn't take BigDecimals in any of it methods > > Thanks > Scott > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > ----------------------------------------------------------------------------------------------- > > Key: OFBIZ-880 > URL: https://issues.apache.org/jira/browse/OFBIZ-880 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Jacopo Cappellato > Assigned To: Scott Gray > Priority: Minor > > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > It would be great to have this fixed before the upcoming release (volunteers?). > Here is the list of the warnings: > 13 warnings > applications/order/src/org/ofbiz/order/order/OrderServices.java:1120: warning: [deprecation] getOrderGrandTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double updatedTotal = orh.getOrderGrandTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderReturnedTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderNonReturnedTaxAndShipping() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1278: warning: [deprecation] getOrderItemsSubTotal(java.util.List,java.util.List) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = OrderReadHelper.getOrderItemsSubTotal(validOrderItems, allAdjustments); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1281: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > BigDecimal orderShipping = new BigDecimal(OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true)); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1289: warning: [deprecation] getOrderItemSubTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > amounts.add(i, new BigDecimal(OrderReadHelper.getOrderItemSubTotal(orderItem, allAdjustments, true, false))); // get the item amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1290: warning: [deprecation] getOrderItemAdjustmentsTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shipAmts.add(i, new BigDecimal(OrderReadHelper.getOrderItemAdjustmentsTotal(orderItem, allAdjustments, false, false, true))); // get the shipping amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1468: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double currentShipping = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orh.getOrderItemAndShipGroupAssoc(shipGroupSeqId), orh.getAdjustments(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2355: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = orh.getOrderItemsSubTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2357: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double shippingAmount = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orderItems, orderAdjustments, false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2358: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shippingAmount += OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-880) Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489063 ] Scott Gray commented on OFBIZ-880: ---------------------------------- Thanks Jacopo, one last question (I hope), is the intention to replace all currency related doubles/Doubles with BigDecimal? There's doubles all over and I'm not sure whether I should be changing them over or not > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > ----------------------------------------------------------------------------------------------- > > Key: OFBIZ-880 > URL: https://issues.apache.org/jira/browse/OFBIZ-880 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Jacopo Cappellato > Assigned To: Scott Gray > Priority: Minor > > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > It would be great to have this fixed before the upcoming release (volunteers?). > Here is the list of the warnings: > 13 warnings > applications/order/src/org/ofbiz/order/order/OrderServices.java:1120: warning: [deprecation] getOrderGrandTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double updatedTotal = orh.getOrderGrandTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderReturnedTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderNonReturnedTaxAndShipping() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1278: warning: [deprecation] getOrderItemsSubTotal(java.util.List,java.util.List) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = OrderReadHelper.getOrderItemsSubTotal(validOrderItems, allAdjustments); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1281: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > BigDecimal orderShipping = new BigDecimal(OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true)); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1289: warning: [deprecation] getOrderItemSubTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > amounts.add(i, new BigDecimal(OrderReadHelper.getOrderItemSubTotal(orderItem, allAdjustments, true, false))); // get the item amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1290: warning: [deprecation] getOrderItemAdjustmentsTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shipAmts.add(i, new BigDecimal(OrderReadHelper.getOrderItemAdjustmentsTotal(orderItem, allAdjustments, false, false, true))); // get the shipping amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1468: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double currentShipping = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orh.getOrderItemAndShipGroupAssoc(shipGroupSeqId), orh.getAdjustments(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2355: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = orh.getOrderItemsSubTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2357: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double shippingAmount = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orderItems, orderAdjustments, false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2358: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shippingAmount += OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-880) Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489067 ] Jacopo Cappellato commented on OFBIZ-880: ----------------------------------------- Scott, all your questions are welcome. I think that the long term goal is to replace all the doubles with BigDecimals, there are simply too many issues with double arithmetic in Java. For example, with the following code: double number = 132.23; double newNumber = number * 100; System.out.println("Number: " + number); System.out.println("Number * 100: " + newNumber); we get the following output: Number: 132.23 Number * 100: 13222.999999999998 a bit scary.... However, an incremental approach (small commits etc...) it is the best way to go. > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > ----------------------------------------------------------------------------------------------- > > Key: OFBIZ-880 > URL: https://issues.apache.org/jira/browse/OFBIZ-880 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Jacopo Cappellato > Assigned To: Scott Gray > Priority: Minor > > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > It would be great to have this fixed before the upcoming release (volunteers?). > Here is the list of the warnings: > 13 warnings > applications/order/src/org/ofbiz/order/order/OrderServices.java:1120: warning: [deprecation] getOrderGrandTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double updatedTotal = orh.getOrderGrandTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderReturnedTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderNonReturnedTaxAndShipping() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1278: warning: [deprecation] getOrderItemsSubTotal(java.util.List,java.util.List) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = OrderReadHelper.getOrderItemsSubTotal(validOrderItems, allAdjustments); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1281: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > BigDecimal orderShipping = new BigDecimal(OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true)); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1289: warning: [deprecation] getOrderItemSubTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > amounts.add(i, new BigDecimal(OrderReadHelper.getOrderItemSubTotal(orderItem, allAdjustments, true, false))); // get the item amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1290: warning: [deprecation] getOrderItemAdjustmentsTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shipAmts.add(i, new BigDecimal(OrderReadHelper.getOrderItemAdjustmentsTotal(orderItem, allAdjustments, false, false, true))); // get the shipping amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1468: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double currentShipping = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orh.getOrderItemAndShipGroupAssoc(shipGroupSeqId), orh.getAdjustments(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2355: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = orh.getOrderItemsSubTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2357: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double shippingAmount = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orderItems, orderAdjustments, false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2358: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shippingAmount += OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-880) Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489070 ] Jacopo Cappellato commented on OFBIZ-880: ----------------------------------------- Scott, this link will be useful: http://www.opensourcestrategies.com/ofbiz/ofbiz_bigdecimal_cookbook.txt > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > ----------------------------------------------------------------------------------------------- > > Key: OFBIZ-880 > URL: https://issues.apache.org/jira/browse/OFBIZ-880 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Jacopo Cappellato > Assigned To: Scott Gray > Priority: Minor > > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > It would be great to have this fixed before the upcoming release (volunteers?). > Here is the list of the warnings: > 13 warnings > applications/order/src/org/ofbiz/order/order/OrderServices.java:1120: warning: [deprecation] getOrderGrandTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double updatedTotal = orh.getOrderGrandTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderReturnedTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderNonReturnedTaxAndShipping() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1278: warning: [deprecation] getOrderItemsSubTotal(java.util.List,java.util.List) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = OrderReadHelper.getOrderItemsSubTotal(validOrderItems, allAdjustments); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1281: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > BigDecimal orderShipping = new BigDecimal(OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true)); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1289: warning: [deprecation] getOrderItemSubTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > amounts.add(i, new BigDecimal(OrderReadHelper.getOrderItemSubTotal(orderItem, allAdjustments, true, false))); // get the item amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1290: warning: [deprecation] getOrderItemAdjustmentsTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shipAmts.add(i, new BigDecimal(OrderReadHelper.getOrderItemAdjustmentsTotal(orderItem, allAdjustments, false, false, true))); // get the shipping amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1468: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double currentShipping = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orh.getOrderItemAndShipGroupAssoc(shipGroupSeqId), orh.getAdjustments(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2355: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = orh.getOrderItemsSubTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2357: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double shippingAmount = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orderItems, orderAdjustments, false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2358: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shippingAmount += OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-880) Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489071 ] Scott Gray commented on OFBIZ-880: ---------------------------------- Jacopo, Thanks for the info, I'll commit in stages so that they are easy to review. But it will have to start tomorrow now as I'm out of time tonight. > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > ----------------------------------------------------------------------------------------------- > > Key: OFBIZ-880 > URL: https://issues.apache.org/jira/browse/OFBIZ-880 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Jacopo Cappellato > Assigned To: Scott Gray > Priority: Minor > > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > It would be great to have this fixed before the upcoming release (volunteers?). > Here is the list of the warnings: > 13 warnings > applications/order/src/org/ofbiz/order/order/OrderServices.java:1120: warning: [deprecation] getOrderGrandTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double updatedTotal = orh.getOrderGrandTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderReturnedTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderNonReturnedTaxAndShipping() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1278: warning: [deprecation] getOrderItemsSubTotal(java.util.List,java.util.List) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = OrderReadHelper.getOrderItemsSubTotal(validOrderItems, allAdjustments); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1281: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > BigDecimal orderShipping = new BigDecimal(OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true)); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1289: warning: [deprecation] getOrderItemSubTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > amounts.add(i, new BigDecimal(OrderReadHelper.getOrderItemSubTotal(orderItem, allAdjustments, true, false))); // get the item amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1290: warning: [deprecation] getOrderItemAdjustmentsTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shipAmts.add(i, new BigDecimal(OrderReadHelper.getOrderItemAdjustmentsTotal(orderItem, allAdjustments, false, false, true))); // get the shipping amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1468: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double currentShipping = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orh.getOrderItemAndShipGroupAssoc(shipGroupSeqId), orh.getAdjustments(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2355: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = orh.getOrderItemsSubTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2357: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double shippingAmount = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orderItems, orderAdjustments, false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2358: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shippingAmount += OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-880) Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489954 ] Scott Gray commented on OFBIZ-880: ---------------------------------- I've finished with OrderServices.java but we'll leave this open while I finish off the other warnings: OrderReturnServices.java 2 warnings ShoppingCart.java 3 warnings ShippingEvents.java 3 warnings > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > ----------------------------------------------------------------------------------------------- > > Key: OFBIZ-880 > URL: https://issues.apache.org/jira/browse/OFBIZ-880 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Jacopo Cappellato > Assigned To: Scott Gray > Priority: Minor > > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > It would be great to have this fixed before the upcoming release (volunteers?). > Here is the list of the warnings: > 13 warnings > applications/order/src/org/ofbiz/order/order/OrderServices.java:1120: warning: [deprecation] getOrderGrandTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double updatedTotal = orh.getOrderGrandTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderReturnedTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderNonReturnedTaxAndShipping() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1278: warning: [deprecation] getOrderItemsSubTotal(java.util.List,java.util.List) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = OrderReadHelper.getOrderItemsSubTotal(validOrderItems, allAdjustments); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1281: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > BigDecimal orderShipping = new BigDecimal(OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true)); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1289: warning: [deprecation] getOrderItemSubTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > amounts.add(i, new BigDecimal(OrderReadHelper.getOrderItemSubTotal(orderItem, allAdjustments, true, false))); // get the item amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1290: warning: [deprecation] getOrderItemAdjustmentsTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shipAmts.add(i, new BigDecimal(OrderReadHelper.getOrderItemAdjustmentsTotal(orderItem, allAdjustments, false, false, true))); // get the shipping amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1468: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double currentShipping = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orh.getOrderItemAndShipGroupAssoc(shipGroupSeqId), orh.getAdjustments(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2355: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = orh.getOrderItemsSubTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2357: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double shippingAmount = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orderItems, orderAdjustments, false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2358: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shippingAmount += OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-880) Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489955 ] Jacopo Cappellato commented on OFBIZ-880: ----------------------------------------- That's great Scott. One more thing we could do after this task is done is: 1) remove all the existing deprecated methods 2) remove the *Bd suffix from the new methods Jacopo > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > ----------------------------------------------------------------------------------------------- > > Key: OFBIZ-880 > URL: https://issues.apache.org/jira/browse/OFBIZ-880 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Jacopo Cappellato > Assigned To: Scott Gray > Priority: Minor > > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > It would be great to have this fixed before the upcoming release (volunteers?). > Here is the list of the warnings: > 13 warnings > applications/order/src/org/ofbiz/order/order/OrderServices.java:1120: warning: [deprecation] getOrderGrandTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double updatedTotal = orh.getOrderGrandTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderReturnedTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderNonReturnedTaxAndShipping() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1278: warning: [deprecation] getOrderItemsSubTotal(java.util.List,java.util.List) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = OrderReadHelper.getOrderItemsSubTotal(validOrderItems, allAdjustments); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1281: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > BigDecimal orderShipping = new BigDecimal(OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true)); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1289: warning: [deprecation] getOrderItemSubTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > amounts.add(i, new BigDecimal(OrderReadHelper.getOrderItemSubTotal(orderItem, allAdjustments, true, false))); // get the item amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1290: warning: [deprecation] getOrderItemAdjustmentsTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shipAmts.add(i, new BigDecimal(OrderReadHelper.getOrderItemAdjustmentsTotal(orderItem, allAdjustments, false, false, true))); // get the shipping amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1468: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double currentShipping = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orh.getOrderItemAndShipGroupAssoc(shipGroupSeqId), orh.getAdjustments(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2355: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = orh.getOrderItemsSubTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2357: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double shippingAmount = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orderItems, orderAdjustments, false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2358: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shippingAmount += OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-880) Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489964 ] Scott Gray commented on OFBIZ-880: ---------------------------------- Hi Jacopo That sounds like a good way to go, but we need to run searches on all the bsh files first as I'm pretty sure some of the deprecated methods are still called from them. But anyway, I'll just keep plugging on a couple of hours a night until it's all finished. > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > ----------------------------------------------------------------------------------------------- > > Key: OFBIZ-880 > URL: https://issues.apache.org/jira/browse/OFBIZ-880 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Jacopo Cappellato > Assigned To: Scott Gray > Priority: Minor > > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > It would be great to have this fixed before the upcoming release (volunteers?). > Here is the list of the warnings: > 13 warnings > applications/order/src/org/ofbiz/order/order/OrderServices.java:1120: warning: [deprecation] getOrderGrandTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double updatedTotal = orh.getOrderGrandTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderReturnedTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderNonReturnedTaxAndShipping() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1278: warning: [deprecation] getOrderItemsSubTotal(java.util.List,java.util.List) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = OrderReadHelper.getOrderItemsSubTotal(validOrderItems, allAdjustments); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1281: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > BigDecimal orderShipping = new BigDecimal(OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true)); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1289: warning: [deprecation] getOrderItemSubTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > amounts.add(i, new BigDecimal(OrderReadHelper.getOrderItemSubTotal(orderItem, allAdjustments, true, false))); // get the item amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1290: warning: [deprecation] getOrderItemAdjustmentsTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shipAmts.add(i, new BigDecimal(OrderReadHelper.getOrderItemAdjustmentsTotal(orderItem, allAdjustments, false, false, true))); // get the shipping amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1468: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double currentShipping = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orh.getOrderItemAndShipGroupAssoc(shipGroupSeqId), orh.getAdjustments(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2355: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = orh.getOrderItemsSubTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2357: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double shippingAmount = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orderItems, orderAdjustments, false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2358: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shippingAmount += OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-880) Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516191 ] Scott Gray commented on OFBIZ-880: ---------------------------------- Ok this should be completed in revs. 560613, 560628, 560640, 560642, 560644 and 560649 I'll do a final run through to check the deprecated methods aren't being called in any bsh or ftl files and then if no one objects I'll begin removing the methods and renaming the BigDecimal versions. > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > ----------------------------------------------------------------------------------------------- > > Key: OFBIZ-880 > URL: https://issues.apache.org/jira/browse/OFBIZ-880 > Project: OFBiz > Issue Type: Improvement > Components: order > Reporter: Jacopo Cappellato > Assignee: Scott Gray > Priority: Minor > > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > It would be great to have this fixed before the upcoming release (volunteers?). > Here is the list of the warnings: > 13 warnings > applications/order/src/org/ofbiz/order/order/OrderServices.java:1120: warning: [deprecation] getOrderGrandTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double updatedTotal = orh.getOrderGrandTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderReturnedTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderNonReturnedTaxAndShipping() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1278: warning: [deprecation] getOrderItemsSubTotal(java.util.List,java.util.List) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = OrderReadHelper.getOrderItemsSubTotal(validOrderItems, allAdjustments); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1281: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > BigDecimal orderShipping = new BigDecimal(OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true)); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1289: warning: [deprecation] getOrderItemSubTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > amounts.add(i, new BigDecimal(OrderReadHelper.getOrderItemSubTotal(orderItem, allAdjustments, true, false))); // get the item amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1290: warning: [deprecation] getOrderItemAdjustmentsTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shipAmts.add(i, new BigDecimal(OrderReadHelper.getOrderItemAdjustmentsTotal(orderItem, allAdjustments, false, false, true))); // get the shipping amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1468: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double currentShipping = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orh.getOrderItemAndShipGroupAssoc(shipGroupSeqId), orh.getAdjustments(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2355: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = orh.getOrderItemsSubTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2357: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double shippingAmount = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orderItems, orderAdjustments, false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2358: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shippingAmount += OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-880) Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Gray reassigned OFBIZ-880: -------------------------------- Assignee: (was: Scott Gray) There's now only 2 deprecated methods left in OrderReadHelper.java: getShippingAddress() getBillingAddress() To be honest I really don't feel like dealing with those at the moment, so I'm going to unassign this issue for now. > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > ----------------------------------------------------------------------------------------------- > > Key: OFBIZ-880 > URL: https://issues.apache.org/jira/browse/OFBIZ-880 > Project: OFBiz > Issue Type: Improvement > Components: order > Reporter: Jacopo Cappellato > Priority: Minor > > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > It would be great to have this fixed before the upcoming release (volunteers?). > Here is the list of the warnings: > 13 warnings > applications/order/src/org/ofbiz/order/order/OrderServices.java:1120: warning: [deprecation] getOrderGrandTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double updatedTotal = orh.getOrderGrandTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderReturnedTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderNonReturnedTaxAndShipping() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1278: warning: [deprecation] getOrderItemsSubTotal(java.util.List,java.util.List) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = OrderReadHelper.getOrderItemsSubTotal(validOrderItems, allAdjustments); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1281: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > BigDecimal orderShipping = new BigDecimal(OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true)); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1289: warning: [deprecation] getOrderItemSubTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > amounts.add(i, new BigDecimal(OrderReadHelper.getOrderItemSubTotal(orderItem, allAdjustments, true, false))); // get the item amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1290: warning: [deprecation] getOrderItemAdjustmentsTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shipAmts.add(i, new BigDecimal(OrderReadHelper.getOrderItemAdjustmentsTotal(orderItem, allAdjustments, false, false, true))); // get the shipping amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1468: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double currentShipping = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orh.getOrderItemAndShipGroupAssoc(shipGroupSeqId), orh.getAdjustments(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2355: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = orh.getOrderItemsSubTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2357: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double shippingAmount = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orderItems, orderAdjustments, false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2358: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shippingAmount += OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-880) Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554361 ] Jacques Le Roux commented on OFBIZ-880: --------------------------------------- I had a quick look at these 2 methods. Why are they deprecated ? > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > ----------------------------------------------------------------------------------------------- > > Key: OFBIZ-880 > URL: https://issues.apache.org/jira/browse/OFBIZ-880 > Project: OFBiz > Issue Type: Improvement > Components: order > Reporter: Jacopo Cappellato > Priority: Minor > > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > It would be great to have this fixed before the upcoming release (volunteers?). > Here is the list of the warnings: > 13 warnings > applications/order/src/org/ofbiz/order/order/OrderServices.java:1120: warning: [deprecation] getOrderGrandTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double updatedTotal = orh.getOrderGrandTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderReturnedTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderNonReturnedTaxAndShipping() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1278: warning: [deprecation] getOrderItemsSubTotal(java.util.List,java.util.List) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = OrderReadHelper.getOrderItemsSubTotal(validOrderItems, allAdjustments); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1281: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > BigDecimal orderShipping = new BigDecimal(OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true)); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1289: warning: [deprecation] getOrderItemSubTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > amounts.add(i, new BigDecimal(OrderReadHelper.getOrderItemSubTotal(orderItem, allAdjustments, true, false))); // get the item amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1290: warning: [deprecation] getOrderItemAdjustmentsTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shipAmts.add(i, new BigDecimal(OrderReadHelper.getOrderItemAdjustmentsTotal(orderItem, allAdjustments, false, false, true))); // get the shipping amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1468: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double currentShipping = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orh.getOrderItemAndShipGroupAssoc(shipGroupSeqId), orh.getAdjustments(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2355: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = orh.getOrderItemsSubTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2357: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double shippingAmount = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orderItems, orderAdjustments, false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2358: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shippingAmount += OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-880) Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-880. --------------------------------- Resolution: Fixed Fix Version/s: SVN trunk > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > ----------------------------------------------------------------------------------------------- > > Key: OFBIZ-880 > URL: https://issues.apache.org/jira/browse/OFBIZ-880 > Project: OFBiz > Issue Type: Improvement > Components: order > Reporter: Jacopo Cappellato > Priority: Minor > Fix For: SVN trunk > > > Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. > It would be great to have this fixed before the upcoming release (volunteers?). > Here is the list of the warnings: > 13 warnings > applications/order/src/org/ofbiz/order/order/OrderServices.java:1120: warning: [deprecation] getOrderGrandTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double updatedTotal = orh.getOrderGrandTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderReturnedTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderNonReturnedTaxAndShipping() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1278: warning: [deprecation] getOrderItemsSubTotal(java.util.List,java.util.List) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = OrderReadHelper.getOrderItemsSubTotal(validOrderItems, allAdjustments); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1281: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > BigDecimal orderShipping = new BigDecimal(OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true)); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1289: warning: [deprecation] getOrderItemSubTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > amounts.add(i, new BigDecimal(OrderReadHelper.getOrderItemSubTotal(orderItem, allAdjustments, true, false))); // get the item amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1290: warning: [deprecation] getOrderItemAdjustmentsTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shipAmts.add(i, new BigDecimal(OrderReadHelper.getOrderItemAdjustmentsTotal(orderItem, allAdjustments, false, false, true))); // get the shipping amount > applications/order/src/org/ofbiz/order/order/OrderServices.java:1468: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double currentShipping = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orh.getOrderItemAndShipGroupAssoc(shipGroupSeqId), orh.getAdjustments(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2355: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated > double orderSubTotal = orh.getOrderItemsSubTotal(); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2357: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > double shippingAmount = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orderItems, orderAdjustments, false, false, true); > applications/order/src/org/ofbiz/order/order/OrderServices.java:2358: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated > shippingAmount += OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |